)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b85806b3118d6d82173dc01426de5398921706ca","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE: Since the agent API was changed server-agent communications will be"},{"line_number":26,"context_line":"completely broken untill both sides are upgraded so users will be unable to"},{"line_number":27,"context_line":"create new or update existing HAProxy loadbalancer instances during upgrade"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"AAAATn%2F%2BhB4%3D","line":25,"updated":"2013-11-25 09:09:43.000000000","message":"How about the following minor fixes:\n\n   Since the change in the agent \"RPC\" API was backward-incompatible\n   (major RPC version change), LBaaS server-agent ....","commit_id":"da4f2fdcd76eaca51671e0d8ae0457b82b86b920"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8bb50ff7cae926a70cadbe26524de45869f80a3a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE: Since the agent API was changed server-agent communications will be"},{"line_number":26,"context_line":"completely broken untill both sides are upgraded so users will be unable to"},{"line_number":27,"context_line":"create new or update existing HAProxy loadbalancer instances during upgrade"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"AAAATn%2F%2BhA4%3D","line":25,"in_reply_to":"AAAATn%2F%2BhB4%3D","updated":"2013-11-25 09:13:38.000000000","message":"Done","commit_id":"da4f2fdcd76eaca51671e0d8ae0457b82b86b920"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b85806b3118d6d82173dc01426de5398921706ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE: Since the agent API was changed server-agent communications will be"},{"line_number":26,"context_line":"completely broken untill both sides are upgraded so users will be unable to"},{"line_number":27,"context_line":"create new or update existing HAProxy loadbalancer instances during upgrade"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements blueprint lbaas-common-agent-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"AAAATn%2F%2BhEo%3D","line":26,"updated":"2013-11-25 09:09:43.000000000","message":"typo: untill -\u003e until","commit_id":"da4f2fdcd76eaca51671e0d8ae0457b82b86b920"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8bb50ff7cae926a70cadbe26524de45869f80a3a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE: Since the agent API was changed server-agent communications will be"},{"line_number":26,"context_line":"completely broken untill both sides are upgraded so users will be unable to"},{"line_number":27,"context_line":"create new or update existing HAProxy loadbalancer instances during upgrade"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements blueprint lbaas-common-agent-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"AAAATn%2F%2BhA0%3D","line":26,"in_reply_to":"AAAATn%2F%2BhEo%3D","updated":"2013-11-25 09:13:38.000000000","message":"Done","commit_id":"da4f2fdcd76eaca51671e0d8ae0457b82b86b920"}],"etc/lbaas_agent.ini":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c4b9edab088180b1c8e21ed615a43de34d3590c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# periodic_interval \u003d 10"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# The agent requires drivers to manage the loadbalancer.  HAProxy is the opensource version."},{"line_number":11,"context_line":"# Several device drivers reflecting different service providers could be specified"},{"line_number":12,"context_line":"# device_driver \u003d neutron.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[haproxy]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAQn%2F%2FJl0%3D","line":11,"updated":"2013-08-06 12:18:21.000000000","message":"Show example of how multiple drivers are specified, so users know that multiple entries are used, instead of one entry with comma separated values.","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"27e69c16a3e4ab9096d0f888556ca7f040602126","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# periodic_interval \u003d 10"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# The agent requires drivers to manage the loadbalancer.  HAProxy is the opensource version."},{"line_number":11,"context_line":"# Several device drivers reflecting different service providers could be specified"},{"line_number":12,"context_line":"# device_driver \u003d neutron.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[haproxy]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAQn%2F%2FJgc%3D","line":11,"in_reply_to":"AAAAQn%2F%2FJl0%3D","updated":"2013-08-06 12:37:21.000000000","message":"Good point, thanks","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Default is:"},{"line_number":15,"context_line":"# device_driver \u003d neutron.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[haproxy]"},{"line_number":18,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":19,"context_line":"# matches your plugin."},{"line_number":20,"context_line":"# interface_driver \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAARn%2F%2Fv5Q%3D","line":17,"updated":"2013-08-22 11:17:39.000000000","message":"That introduces backward-incompatible change.\nI think you need to handle backward compatibility somehow.\nExisting setups don\u0027t have this section in ini-files and parameters are not seen.\nOne of examples of how this is handled:\nhttps://review.openstack.org/#/c/20603/11/quantum/agent/common/config.py","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Default is:"},{"line_number":15,"context_line":"# device_driver \u003d neutron.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[haproxy]"},{"line_number":18,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":19,"context_line":"# matches your plugin."},{"line_number":20,"context_line":"# interface_driver \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAARn%2F%2FvTk%3D","line":17,"in_reply_to":"AAAARn%2F%2Fv5Q%3D","updated":"2013-08-22 14:32:08.000000000","message":"Yeah, thanks for pointing and for an example!","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# interface_driver \u003d neutron.agent.linux.interface.BridgeInterfaceDriver"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# The agent requires drivers to manage the loadbalancer.  HAProxy is the opensource version."},{"line_number":27,"context_line":"# Several device drivers reflecting different service providers could be specified:"},{"line_number":28,"context_line":"# device_driver \u003d path.to.provider1.driver.Driver"},{"line_number":29,"context_line":"# device_driver \u003d path.to.provider2.driver.Driver"},{"line_number":30,"context_line":"# Default is:"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAATn%2F%2B7Gc%3D","line":27,"updated":"2013-11-18 15:59:01.000000000","message":"Several device drivers -\u003e Multiple device drivers","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# interface_driver \u003d neutron.agent.linux.interface.BridgeInterfaceDriver"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# The agent requires drivers to manage the loadbalancer.  HAProxy is the opensource version."},{"line_number":27,"context_line":"# Several device drivers reflecting different service providers could be specified:"},{"line_number":28,"context_line":"# device_driver \u003d path.to.provider1.driver.Driver"},{"line_number":29,"context_line":"# device_driver \u003d path.to.provider2.driver.Driver"},{"line_number":30,"context_line":"# Default is:"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAATn%2F%2B2B0%3D","line":27,"in_reply_to":"AAAATn%2F%2B7Gc%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"}],"neutron/services/loadbalancer/agent_scheduler.py":[{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"197b98ddefbe434e53bff953ea94060e7f5b16b4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                LOG.warn(_(\u0027No active lbaas agents for pool %s\u0027) % pool[\u0027id\u0027])"},{"line_number":111,"context_line":"                return"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            candidates \u003d plugin.get_lbaas_agent_candidates(device_driver,"},{"line_number":114,"context_line":"                                                           active_agents)"},{"line_number":115,"context_line":"            if not candidates:"},{"line_number":116,"context_line":"                LOG.warn(_(\u0027No lbaas agent supporting device driver % s\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAASn%2F%2Fg1Q%3D","line":113,"updated":"2013-09-03 22:13:20.000000000","message":"How is it going to work with service type framework where devices are given in the config?","commit_id":"4a97ea19bd17194fa9f03ab593ef9259930da89a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5d64964fd2110bdab73bb631c96a68b26d7f9606","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                LOG.warn(_(\u0027No active lbaas agents for pool %s\u0027) % pool[\u0027id\u0027])"},{"line_number":111,"context_line":"                return"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            candidates \u003d plugin.get_lbaas_agent_candidates(device_driver,"},{"line_number":114,"context_line":"                                                           active_agents)"},{"line_number":115,"context_line":"            if not candidates:"},{"line_number":116,"context_line":"                LOG.warn(_(\u0027No lbaas agent supporting device driver % s\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAASn%2F%2Ffo8%3D","line":113,"in_reply_to":"AAAASn%2F%2Fg1Q%3D","updated":"2013-09-04 04:44:31.000000000","message":"Devices are not given in the config in service type framework.","commit_id":"4a97ea19bd17194fa9f03ab593ef9259930da89a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            candidates \u003d plugin.get_lbaas_agent_candidates(device_driver,"},{"line_number":114,"context_line":"                                                           active_agents)"},{"line_number":115,"context_line":"            if not candidates:"},{"line_number":116,"context_line":"                LOG.warn(_(\u0027No lbaas agent supporting device driver % s\u0027),"},{"line_number":117,"context_line":"                         device_driver)"},{"line_number":118,"context_line":"                return"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B7EE%3D","line":116,"updated":"2013-11-18 15:59:01.000000000","message":"Need to remove a space in \"% s\".","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            candidates \u003d plugin.get_lbaas_agent_candidates(device_driver,"},{"line_number":114,"context_line":"                                                           active_agents)"},{"line_number":115,"context_line":"            if not candidates:"},{"line_number":116,"context_line":"                LOG.warn(_(\u0027No lbaas agent supporting device driver % s\u0027),"},{"line_number":117,"context_line":"                         device_driver)"},{"line_number":118,"context_line":"                return"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B2Ak%3D","line":116,"in_reply_to":"AAAATn%2F%2B7EE%3D","updated":"2013-11-19 15:57:47.000000000","message":"Good catch!","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"}],"neutron/services/loadbalancer/drivers/abstract_device_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3ce623a0cffda5187fce6770c092a0748e20213","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class LbaasAbstractDeviceDriver(object):"},{"line_number":24,"context_line":"    \"\"\"Abstract device driver that defines the API required by LBaaS agent.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAATn%2F%2BwvA%3D","line":23,"updated":"2013-11-20 15:06:31.000000000","message":"I think AgentDriver or AgentDeviceDriver looks better.\n\nI am not sure that agent based implementation is the only implmentation which uses device drivers in LBaaS.","commit_id":"425d80dfc050467e9bb7f34e985b47152d6b2786"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"483a6558030822d8cf8411786194e486de2080f6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class LbaasAbstractDeviceDriver(object):"},{"line_number":24,"context_line":"    \"\"\"Abstract device driver that defines the API required by LBaaS agent.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAATn%2F%2BwqU%3D","line":23,"in_reply_to":"AAAATn%2F%2BwvA%3D","updated":"2013-11-20 15:21:07.000000000","message":"Agree, will rename to AgentDeviceDriver, thanks","commit_id":"425d80dfc050467e9bb7f34e985b47152d6b2786"}],"neutron/services/loadbalancer/drivers/haproxy/agent_api.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # history"},{"line_number":27,"context_line":"    #   1.0 Initial version"},{"line_number":28,"context_line":"    #   2.0 get_logical_device() handling changed on plugin side;"},{"line_number":29,"context_line":"    #       pool_deployed() and update_status() methods added;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, topic, context, host):"},{"line_number":32,"context_line":"        super(LbaasAgentApi, self).__init__(topic, self.API_VERSION)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fkrk%3D","line":29,"updated":"2013-09-03 11:15:31.000000000","message":"It is better to add the background the major version is incremented, e.g., \"Generic API for agent based driver\".","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # history"},{"line_number":27,"context_line":"    #   1.0 Initial version"},{"line_number":28,"context_line":"    #   2.0 get_logical_device() handling changed on plugin side;"},{"line_number":29,"context_line":"    #       pool_deployed() and update_status() methods added;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, topic, context, host):"},{"line_number":32,"context_line":"        super(LbaasAgentApi, self).__init__(topic, self.API_VERSION)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkXI%3D","line":29,"in_reply_to":"AAAASn%2F%2Fkrk%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    #   1.0 Initial version"},{"line_number":28,"context_line":"    #   2.0 Generic API for agent based drivers"},{"line_number":29,"context_line":"    #       - get_logical_device() handling changed on plugin side;"},{"line_number":30,"context_line":"    #       - pool_deployed() and update_status() methods added;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, topic, context, host):"},{"line_number":33,"context_line":"        super(LbaasAgentApi, self).__init__(topic, self.API_VERSION)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B7BA%3D","line":30,"updated":"2013-11-18 15:59:01.000000000","message":"Incrementing the major version of RPC API means the API is completely incompatible and we cannot do rolling upgrade and it requires the service needs to be stopped. Is it true?","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    #   1.0 Initial version"},{"line_number":28,"context_line":"    #   2.0 Generic API for agent based drivers"},{"line_number":29,"context_line":"    #       - get_logical_device() handling changed on plugin side;"},{"line_number":30,"context_line":"    #       - pool_deployed() and update_status() methods added;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, topic, context, host):"},{"line_number":33,"context_line":"        super(LbaasAgentApi, self).__init__(topic, self.API_VERSION)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B19E%3D","line":30,"in_reply_to":"AAAATn%2F%2B7BA%3D","updated":"2013-11-19 15:57:47.000000000","message":"Yeah, that\u0027s true","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"}],"neutron/services/loadbalancer/drivers/haproxy/agent_manager.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c4b9edab088180b1c8e21ed615a43de34d3590c0","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class LbaasAgentManager(periodic_task.PeriodicTasks):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    RPC_API_VERSION \u003d \u00272.0\u0027"},{"line_number":51,"context_line":"    # history"},{"line_number":52,"context_line":"    #   1.0 Initial version"},{"line_number":53,"context_line":"    #   1.1 Support agent_updated call"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJlg%3D","line":50,"updated":"2013-08-06 12:18:21.000000000","message":"Since APIs are being updated in this bug, are there companion bugs for documentation updates?","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"27e69c16a3e4ab9096d0f888556ca7f040602126","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class LbaasAgentManager(periodic_task.PeriodicTasks):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    RPC_API_VERSION \u003d \u00272.0\u0027"},{"line_number":51,"context_line":"    # history"},{"line_number":52,"context_line":"    #   1.0 Initial version"},{"line_number":53,"context_line":"    #   1.1 Support agent_updated call"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJek%3D","line":50,"in_reply_to":"AAAAQn%2F%2FJlg%3D","updated":"2013-08-06 12:37:21.000000000","message":"This is internal plugin-agent rpc api which I believe is not reflected in any documentation","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c4b9edab088180b1c8e21ed615a43de34d3590c0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                )"},{"line_number":92,"context_line":"            except ImportError:"},{"line_number":93,"context_line":"                msg \u003d _(\u0027Error importing loadbalancer device driver: %s\u0027)"},{"line_number":94,"context_line":"                raise SystemExit(msg % driver)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            driver_name \u003d driver_inst.get_name()"},{"line_number":97,"context_line":"            if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJkk%3D","line":94,"updated":"2013-08-06 12:18:21.000000000","message":"LBaaS specific exception used here for import error (or create a common one that could be used for multiple services, since multiple drivers will be supported by several).","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"27e69c16a3e4ab9096d0f888556ca7f040602126","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                )"},{"line_number":92,"context_line":"            except ImportError:"},{"line_number":93,"context_line":"                msg \u003d _(\u0027Error importing loadbalancer device driver: %s\u0027)"},{"line_number":94,"context_line":"                raise SystemExit(msg % driver)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            driver_name \u003d driver_inst.get_name()"},{"line_number":97,"context_line":"            if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJeY%3D","line":94,"in_reply_to":"AAAAQn%2F%2FJkk%3D","updated":"2013-08-06 12:37:21.000000000","message":"This is not new here. SystemExit was raised by the original AgentManager (see #142 in the left side of diff) to indicate that agent can\u0027t proceed further.","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c4b9edab088180b1c8e21ed615a43de34d3590c0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                self.device_drivers[driver_name] \u003d driver_inst"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                msg \u003d _(\u0027Multiple device drivers with the same name found: %s\u0027)"},{"line_number":101,"context_line":"                raise SystemExit(msg % driver_name)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _setup_state_rpc(self):"},{"line_number":104,"context_line":"        self.state_rpc \u003d agent_rpc.PluginReportStateAPI("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJkc%3D","line":101,"updated":"2013-08-06 12:18:21.000000000","message":"LBaaS exception or a common one that all services can use.","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"27e69c16a3e4ab9096d0f888556ca7f040602126","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                self.device_drivers[driver_name] \u003d driver_inst"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                msg \u003d _(\u0027Multiple device drivers with the same name found: %s\u0027)"},{"line_number":101,"context_line":"                raise SystemExit(msg % driver_name)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _setup_state_rpc(self):"},{"line_number":104,"context_line":"        self.state_rpc \u003d agent_rpc.PluginReportStateAPI("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJeU%3D","line":101,"in_reply_to":"AAAAQn%2F%2FJkc%3D","updated":"2013-08-06 12:37:21.000000000","message":"same answer","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @periodic_task.periodic_task(spacing\u003d6)"},{"line_number":132,"context_line":"    def collect_stats(self, context):"},{"line_number":133,"context_line":"        for pool_id, driver_name in self.devices.iteritems():"},{"line_number":134,"context_line":"            driver \u003d self.device_drivers[driver_name]"},{"line_number":135,"context_line":"            try:"},{"line_number":136,"context_line":"                stats \u003d driver.get_stats(pool_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2F0Ng%3D","line":133,"updated":"2013-08-22 11:17:39.000000000","message":"nit: .items() for py3 compat","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @periodic_task.periodic_task(spacing\u003d6)"},{"line_number":132,"context_line":"    def collect_stats(self, context):"},{"line_number":133,"context_line":"        for pool_id, driver_name in self.devices.iteritems():"},{"line_number":134,"context_line":"            driver \u003d self.device_drivers[driver_name]"},{"line_number":135,"context_line":"            try:"},{"line_number":136,"context_line":"                stats \u003d driver.get_stats(pool_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvXI%3D","line":133,"in_reply_to":"AAAARn%2F%2F0Ng%3D","updated":"2013-08-22 14:32:08.000000000","message":"Done","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        self.remove_orphans()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def reload_pool(self, pool_id):"},{"line_number":161,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            logical_config \u003d self.plugin_rpc.get_logical_device(pool_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2F0M4%3D","line":160,"updated":"2013-08-22 11:17:39.000000000","message":"I think that \u0027device\u0027 or \u0027instance\u0027 is more suitable here","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        self.remove_orphans()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def reload_pool(self, pool_id):"},{"line_number":161,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            logical_config \u003d self.plugin_rpc.get_logical_device(pool_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvXM%3D","line":160,"in_reply_to":"AAAARn%2F%2F0M4%3D","updated":"2013-08-22 14:32:08.000000000","message":"The method is named according to RPC API, pl. see docstring below. Same for destroy_pool().","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"},{"line_number":216,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2F0LM%3D","line":213,"updated":"2013-08-22 11:17:39.000000000","message":"Is it possible to use error message from exception to propagate it to the plugin to status_description?\nHere and below","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"},{"line_number":216,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvVg%3D","line":213,"in_reply_to":"AAAARn%2F%2F0LM%3D","updated":"2013-08-22 14:32:08.000000000","message":"Well, I think that such message won\u0027t bring much information to the user so that she/he can do smth to fix the problem.\n\nAnother thing is that we don\u0027t want to provide an ability for drivers to update status_description (discussed with Salvatore, the field shouldn\u0027t contain any specific info) and on #90 you can see that it is passed to device drivers.","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            if self.admin_state_up:"},{"line_number":317,"context_line":"                self.needs_resync \u003d True"},{"line_number":318,"context_line":"            else:"},{"line_number":319,"context_line":"                for pool_id in self.devices.keys():"},{"line_number":320,"context_line":"                    self.destroy_pool(pool_id)"},{"line_number":321,"context_line":"            LOG.info(_(\"agent_updated by server side %s!\"), payload)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2F0Gs%3D","line":319,"updated":"2013-08-22 11:17:39.000000000","message":"I\u0027d add info log message here indicating that pools are going to be destroyed","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            if self.admin_state_up:"},{"line_number":317,"context_line":"                self.needs_resync \u003d True"},{"line_number":318,"context_line":"            else:"},{"line_number":319,"context_line":"                for pool_id in self.devices.keys():"},{"line_number":320,"context_line":"                    self.destroy_pool(pool_id)"},{"line_number":321,"context_line":"            LOG.info(_(\"agent_updated by server side %s!\"), payload)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvVY%3D","line":319,"in_reply_to":"AAAARn%2F%2F0Gs%3D","updated":"2013-08-22 14:32:08.000000000","message":"Good point, thanks","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    # history"},{"line_number":52,"context_line":"    #   1.0 Initial version"},{"line_number":53,"context_line":"    #   1.1 Support agent_updated call"},{"line_number":54,"context_line":"    #   2.0 Changed handling for reload/destroy_pool;"},{"line_number":55,"context_line":"    #       Removed modify_pool method;"},{"line_number":56,"context_line":"    #       Added methods to handle create/update/delete for every lbaas"},{"line_number":57,"context_line":"    #       object individually;"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkoE%3D","line":54,"updated":"2013-09-03 11:15:31.000000000","message":"It is better to add a description about the background of the major version change.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    # history"},{"line_number":52,"context_line":"    #   1.0 Initial version"},{"line_number":53,"context_line":"    #   1.1 Support agent_updated call"},{"line_number":54,"context_line":"    #   2.0 Changed handling for reload/destroy_pool;"},{"line_number":55,"context_line":"    #       Removed modify_pool method;"},{"line_number":56,"context_line":"    #       Added methods to handle create/update/delete for every lbaas"},{"line_number":57,"context_line":"    #       object individually;"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkW4%3D","line":54,"in_reply_to":"AAAASn%2F%2FkoE%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            driver.create_vip(vip)"},{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fkpg%3D","line":212,"updated":"2013-09-03 11:15:31.000000000","message":"It is better to contain information about VIP, pool or driver. This applies to the similar log below.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            driver.create_vip(vip)"},{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEk%3D","line":212,"updated":"2013-09-03 09:27:28.000000000","message":"nit: First letter capital: Create","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            driver.create_vip(vip)"},{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkQE%3D","line":212,"in_reply_to":"AAAASn%2F%2Fkpg%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            driver.create_vip(vip)"},{"line_number":210,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":211,"context_line":"        except Exception:"},{"line_number":212,"context_line":"            LOG.exception(_(\u0027create vip failed on device driver\u0027))"},{"line_number":213,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def update_vip(self, context, old_vip, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlAA%3D","line":212,"in_reply_to":"AAAASn%2F%2FlEk%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            driver.update_vip(old_vip, vip)"},{"line_number":219,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":220,"context_line":"        except Exception:"},{"line_number":221,"context_line":"            LOG.exception(_(\u0027update vip failed on device driver\u0027))"},{"line_number":222,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def delete_vip(self, context, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEg%3D","line":221,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            driver.update_vip(old_vip, vip)"},{"line_number":219,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":220,"context_line":"        except Exception:"},{"line_number":221,"context_line":"            LOG.exception(_(\u0027update vip failed on device driver\u0027))"},{"line_number":222,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def delete_vip(self, context, vip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2F8%3D","line":221,"in_reply_to":"AAAASn%2F%2FlEg%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"},{"line_number":237,"context_line":"            self.devices[pool[\u0027id\u0027]] \u003d driver_name"},{"line_number":238,"context_line":"        except Exception:"},{"line_number":239,"context_line":"            LOG.exception(_(\u0027create pool failed on device driver\u0027))"},{"line_number":240,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_pool(self, context, old_pool, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEU%3D","line":239,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"},{"line_number":237,"context_line":"            self.devices[pool[\u0027id\u0027]] \u003d driver_name"},{"line_number":238,"context_line":"        except Exception:"},{"line_number":239,"context_line":"            LOG.exception(_(\u0027create pool failed on device driver\u0027))"},{"line_number":240,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_pool(self, context, old_pool, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2F4%3D","line":239,"in_reply_to":"AAAASn%2F%2FlEU%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            driver.update_pool(old_pool, pool)"},{"line_number":246,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"},{"line_number":247,"context_line":"        except Exception:"},{"line_number":248,"context_line":"            LOG.exception(_(\u0027update pool failed on device driver\u0027))"},{"line_number":249,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def delete_pool(self, context, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEQ%3D","line":248,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            driver.update_pool(old_pool, pool)"},{"line_number":246,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"},{"line_number":247,"context_line":"        except Exception:"},{"line_number":248,"context_line":"            LOG.exception(_(\u0027update pool failed on device driver\u0027))"},{"line_number":249,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def delete_pool(self, context, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2Fw%3D","line":248,"in_reply_to":"AAAASn%2F%2FlEQ%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":261,"context_line":"                                          constants.ACTIVE)"},{"line_number":262,"context_line":"        except Exception:"},{"line_number":263,"context_line":"            LOG.exception(_(\u0027create member failed on device driver\u0027))"},{"line_number":264,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":265,"context_line":"                                          constants.ERROR)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEM%3D","line":263,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":261,"context_line":"                                          constants.ACTIVE)"},{"line_number":262,"context_line":"        except Exception:"},{"line_number":263,"context_line":"            LOG.exception(_(\u0027create member failed on device driver\u0027))"},{"line_number":264,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":265,"context_line":"                                          constants.ERROR)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2Fs%3D","line":263,"in_reply_to":"AAAASn%2F%2FlEM%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":272,"context_line":"                                          constants.ACTIVE)"},{"line_number":273,"context_line":"        except Exception:"},{"line_number":274,"context_line":"            LOG.exception(_(\u0027update member failed on device driver\u0027))"},{"line_number":275,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":276,"context_line":"                                          constants.ERROR)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlEA%3D","line":274,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":272,"context_line":"                                          constants.ACTIVE)"},{"line_number":273,"context_line":"        except Exception:"},{"line_number":274,"context_line":"            LOG.exception(_(\u0027update member failed on device driver\u0027))"},{"line_number":275,"context_line":"            self.plugin_rpc.update_status(\u0027member\u0027, member[\u0027id\u0027],"},{"line_number":276,"context_line":"                                          constants.ERROR)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2Fo%3D","line":274,"in_reply_to":"AAAASn%2F%2FlEA%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            self.plugin_rpc.update_status("},{"line_number":288,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ACTIVE)"},{"line_number":289,"context_line":"        except Exception:"},{"line_number":290,"context_line":"            LOG.exception(_(\u0027create health monitor failed on device driver\u0027))"},{"line_number":291,"context_line":"            self.plugin_rpc.update_status("},{"line_number":292,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ERROR)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlD4%3D","line":290,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            self.plugin_rpc.update_status("},{"line_number":288,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ACTIVE)"},{"line_number":289,"context_line":"        except Exception:"},{"line_number":290,"context_line":"            LOG.exception(_(\u0027create health monitor failed on device driver\u0027))"},{"line_number":291,"context_line":"            self.plugin_rpc.update_status("},{"line_number":292,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ERROR)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2Fk%3D","line":290,"in_reply_to":"AAAASn%2F%2FlD4%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b0d186c36279331ef81e78876299c88ade3acea1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            self.plugin_rpc.update_status("},{"line_number":302,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ACTIVE)"},{"line_number":303,"context_line":"        except Exception:"},{"line_number":304,"context_line":"            LOG.exception(_(\u0027create health monitor failed on device driver\u0027))"},{"line_number":305,"context_line":"            self.plugin_rpc.update_status("},{"line_number":306,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ERROR)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FlD0%3D","line":304,"updated":"2013-09-03 09:27:28.000000000","message":"nit: cap","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"44448d8a2d854b3b421fb9d2c067c7bbe4186305","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            self.plugin_rpc.update_status("},{"line_number":302,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ACTIVE)"},{"line_number":303,"context_line":"        except Exception:"},{"line_number":304,"context_line":"            LOG.exception(_(\u0027create health monitor failed on device driver\u0027))"},{"line_number":305,"context_line":"            self.plugin_rpc.update_status("},{"line_number":306,"context_line":"                \u0027health_monitor\u0027, assoc_id, constants.ERROR)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fk%2Fg%3D","line":304,"in_reply_to":"AAAASn%2F%2FlD0%3D","updated":"2013-09-03 09:30:48.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            driver_name \u003d logical_config[\u0027driver\u0027]"},{"line_number":169,"context_line":"            if driver_name not in self.device_drivers:"},{"line_number":170,"context_line":"                LOG.error(_(\u0027No device driver \u0027"},{"line_number":171,"context_line":"                            \u0027on agent: %s.\u0027) % driver_name)"},{"line_number":172,"context_line":"                return"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B67c%3D","line":171,"updated":"2013-11-18 15:59:01.000000000","message":"% -\u003e , (comma)","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            driver_name \u003d logical_config[\u0027driver\u0027]"},{"line_number":169,"context_line":"            if driver_name not in self.device_drivers:"},{"line_number":170,"context_line":"                LOG.error(_(\u0027No device driver \u0027"},{"line_number":171,"context_line":"                            \u0027on agent: %s.\u0027) % driver_name)"},{"line_number":172,"context_line":"                return"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B18A%3D","line":171,"in_reply_to":"AAAATn%2F%2B67c%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if pool_id not in self.devices:"},{"line_number":203,"context_line":"            msg \u003d _(\u0027Unknown device with pool_id %s\u0027) % pool_id"},{"line_number":204,"context_line":"            LOG.error(msg)"},{"line_number":205,"context_line":"            raise n_exc.Invalid(msg)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":208,"context_line":"        return self.device_drivers[driver_name]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B650%3D","line":205,"updated":"2013-11-18 15:59:01.000000000","message":"It is better to define an exception.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if pool_id not in self.devices:"},{"line_number":203,"context_line":"            msg \u003d _(\u0027Unknown device with pool_id %s\u0027) % pool_id"},{"line_number":204,"context_line":"            LOG.error(msg)"},{"line_number":205,"context_line":"            raise n_exc.Invalid(msg)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":208,"context_line":"        return self.device_drivers[driver_name]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B114%3D","line":205,"in_reply_to":"AAAATn%2F%2B650%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            raise n_exc.Invalid(msg)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":208,"context_line":"        return self.device_drivers[driver_name]"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def create_vip(self, context, vip):"},{"line_number":211,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B66E%3D","line":208,"updated":"2013-11-18 15:59:01.000000000","message":"_get_driver is called from both above and below here. How about moving it before reload_pool()?","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            raise n_exc.Invalid(msg)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":208,"context_line":"        return self.device_drivers[driver_name]"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def create_vip(self, context, vip):"},{"line_number":211,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B174%3D","line":208,"in_reply_to":"AAAATn%2F%2B66E%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            driver.create_vip(vip)"},{"line_number":214,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            LOG.exception(_(\u0027Create vip %(vip)s failed on device driver \u0027"},{"line_number":217,"context_line":"                            \u0027%(driver)s\u0027),"},{"line_number":218,"context_line":"                          {\u0027vip\u0027: vip[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B60s%3D","line":215,"updated":"2013-11-18 15:59:01.000000000","message":"This exception catches both an exception from a driver and RPC exception. It may be better to split try-except for each.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            driver.create_vip(vip)"},{"line_number":214,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":215,"context_line":"        except Exception:"},{"line_number":216,"context_line":"            LOG.exception(_(\u0027Create vip %(vip)s failed on device driver \u0027"},{"line_number":217,"context_line":"                            \u0027%(driver)s\u0027),"},{"line_number":218,"context_line":"                          {\u0027vip\u0027: vip[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1uE%3D","line":215,"in_reply_to":"AAAATn%2F%2B60s%3D","updated":"2013-11-19 15:57:47.000000000","message":"Actually I want to handle only driver\u0027s exceptions here to update status of the object properly. Will move update_status out of try block.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def delete_vip(self, context, vip):"},{"line_number":233,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"},{"line_number":234,"context_line":"        driver.delete_vip(vip)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B64k%3D","line":234,"updated":"2013-11-18 15:59:01.000000000","message":"Don\u0027t we need to handle exception here?","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def delete_vip(self, context, vip):"},{"line_number":233,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"},{"line_number":234,"context_line":"        driver.delete_vip(vip)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1p8%3D","line":234,"in_reply_to":"AAAATn%2F%2B64k%3D","updated":"2013-11-19 15:57:47.000000000","message":"At this moment object is already deleted from db by plugin driver so no need for special handling here (like status updating)","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"},{"line_number":238,"context_line":"            LOG.error(_(\u0027No device driver on agent: %s.\u0027) % driver_name)"},{"line_number":239,"context_line":"            return"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        driver \u003d self.device_drivers[driver_name]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B64c%3D","line":238,"updated":"2013-11-18 15:59:01.000000000","message":"% -\u003e ,","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"},{"line_number":238,"context_line":"            LOG.error(_(\u0027No device driver on agent: %s.\u0027) % driver_name)"},{"line_number":239,"context_line":"            return"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        driver \u003d self.device_drivers[driver_name]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1pQ%3D","line":238,"in_reply_to":"AAAATn%2F%2B64c%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"},{"line_number":238,"context_line":"            LOG.error(_(\u0027No device driver on agent: %s.\u0027) % driver_name)"},{"line_number":239,"context_line":"            return"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        driver \u003d self.device_drivers[driver_name]"},{"line_number":242,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B63Q%3D","line":239,"updated":"2013-11-18 15:59:01.000000000","message":"Don\u0027t we need to set status to ERROR?","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":237,"context_line":"        if driver_name not in self.device_drivers:"},{"line_number":238,"context_line":"            LOG.error(_(\u0027No device driver on agent: %s.\u0027) % driver_name)"},{"line_number":239,"context_line":"            return"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        driver \u003d self.device_drivers[driver_name]"},{"line_number":242,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1oY%3D","line":239,"in_reply_to":"AAAATn%2F%2B63Q%3D","updated":"2013-11-19 15:57:47.000000000","message":"Yeah, we better do it, thanks for pointing","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":264,"context_line":"        driver \u003d self._get_driver(pool[\u0027id\u0027])"},{"line_number":265,"context_line":"        driver.delete_pool(pool)"},{"line_number":266,"context_line":"        del self.devices[pool[\u0027id\u0027]]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B628%3D","line":265,"updated":"2013-11-18 15:59:01.000000000","message":"Don\u0027t we need to handle an exception?","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":264,"context_line":"        driver \u003d self._get_driver(pool[\u0027id\u0027])"},{"line_number":265,"context_line":"        driver.delete_pool(pool)"},{"line_number":266,"context_line":"        del self.devices[pool[\u0027id\u0027]]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1nA%3D","line":265,"in_reply_to":"AAAATn%2F%2B628%3D","updated":"2013-11-19 15:57:47.000000000","message":"Same here - at the moment pool is already deleted from db - can\u0027t think of any special handling here","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class LogicalDeviceCache(object):"},{"line_number":64,"context_line":"    \"\"\"Manage a cache of known devices.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    class Device(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yIg%3D","side":"PARENT","line":63,"updated":"2013-12-05 23:15:02.000000000","message":"I do not have an opinion on this specific matter, but I think the reason behind the removal of this cache - and its replacements with a dict - should be in the commit message.","commit_id":"5e61aa57e6282b44353ab8be1a54596bee623e8f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class LogicalDeviceCache(object):"},{"line_number":64,"context_line":"    \"\"\"Manage a cache of known devices.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    class Device(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wfA%3D","side":"PARENT","line":63,"in_reply_to":"AAAATn%2F9yIg%3D","updated":"2013-12-06 13:36:27.000000000","message":"Will update the commit message.","commit_id":"5e61aa57e6282b44353ab8be1a54596bee623e8f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._setup_state_rpc()"},{"line_number":87,"context_line":"        self.needs_resync \u003d False"},{"line_number":88,"context_line":"        # pool_id-\u003edevice_driver_name mapping used to store known devices"},{"line_number":89,"context_line":"        self.devices \u003d {}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _load_drivers(self):"},{"line_number":92,"context_line":"        self.device_drivers \u003d {}"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yWk%3D","line":89,"updated":"2013-12-05 23:15:02.000000000","message":"This is just a pedant rant, but I find the use of the term \u0027device\u0027 here rather confusing, especially as it appears to be a synonim of agent.\n\nI would consider calling this member instance_mappings\nand the one at line 92 instance_drivers","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._setup_state_rpc()"},{"line_number":87,"context_line":"        self.needs_resync \u003d False"},{"line_number":88,"context_line":"        # pool_id-\u003edevice_driver_name mapping used to store known devices"},{"line_number":89,"context_line":"        self.devices \u003d {}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _load_drivers(self):"},{"line_number":92,"context_line":"        self.device_drivers \u003d {}"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wWs%3D","line":89,"in_reply_to":"AAAATn%2F9yWk%3D","updated":"2013-12-06 13:36:27.000000000","message":"Agree to rename to instance_mapping. As for device_drivers I think it should keep \u0027device\u0027 in its name as they are in fact drivers for physical or virtual devices, not instances","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":173,"context_line":"        return self.device_drivers[driver_name]"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def reload_pool(self, pool_id):"},{"line_number":176,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            logical_config \u003d self.plugin_rpc.get_logical_device(pool_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9ySM%3D","line":175,"updated":"2013-12-05 23:15:02.000000000","message":"Are all the driver operations called by this function, and the others like this supposed to be idempotent?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        driver_name \u003d self.devices[pool_id]"},{"line_number":173,"context_line":"        return self.device_drivers[driver_name]"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def reload_pool(self, pool_id):"},{"line_number":176,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            logical_config \u003d self.plugin_rpc.get_logical_device(pool_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wQQ%3D","line":175,"in_reply_to":"AAAATn%2F9ySM%3D","updated":"2013-12-06 13:36:27.000000000","message":"Yes, that\u0027s correct","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            if driver_name not in self.device_drivers:"},{"line_number":181,"context_line":"                LOG.error(_(\u0027No device driver \u0027"},{"line_number":182,"context_line":"                            \u0027on agent: %s.\u0027), driver_name)"},{"line_number":183,"context_line":"                return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"},{"line_number":186,"context_line":"            self.devices[pool_id] \u003d driver_name"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yWE%3D","line":183,"updated":"2013-12-05 23:15:02.000000000","message":"Will this trigger something to mark the status of the corresponding pool as \u0027DOWN\u0027 or \u0027ERROR\u0027?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            if driver_name not in self.device_drivers:"},{"line_number":181,"context_line":"                LOG.error(_(\u0027No device driver \u0027"},{"line_number":182,"context_line":"                            \u0027on agent: %s.\u0027), driver_name)"},{"line_number":183,"context_line":"                return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"},{"line_number":186,"context_line":"            self.devices[pool_id] \u003d driver_name"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wJA%3D","line":183,"in_reply_to":"AAAATn%2F9yWE%3D","updated":"2013-12-06 13:36:27.000000000","message":"I tend to agree, it\u0027s better to update pool status to ERROR","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                            \u0027on agent: %s.\u0027), driver_name)"},{"line_number":183,"context_line":"                return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"},{"line_number":186,"context_line":"            self.devices[pool_id] \u003d driver_name"},{"line_number":187,"context_line":"            self.plugin_rpc.pool_deployed(pool_id)"},{"line_number":188,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yXY%3D","line":185,"updated":"2013-12-05 23:15:02.000000000","message":"In case of long running operations this method might take a while to complete, possibly preempting other synchronization tasks.\n\nAlso, if there is a chance for repeated messages of the same kind in a fairly short interval, this would probably result in redeploying the instance in the same way multiple times.\n\nIt might be worth considering a coalesce scheme in which the reload_pool notification populates a data structure of \u0027instance_to_reload\u0027, which is then processed by something like the main periodic task of the routine.\n\nThis might be relevant for device drivers which might require some data plane downtime for redeploying an instance.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                            \u0027on agent: %s.\u0027), driver_name)"},{"line_number":183,"context_line":"                return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            self.device_drivers[driver_name].deploy_instance(logical_config)"},{"line_number":186,"context_line":"            self.devices[pool_id] \u003d driver_name"},{"line_number":187,"context_line":"            self.plugin_rpc.pool_deployed(pool_id)"},{"line_number":188,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wB0%3D","line":185,"in_reply_to":"AAAATn%2F9yXY%3D","updated":"2013-12-06 13:36:27.000000000","message":"I understand your concern. After a small investigation I realized that with current implementation server (plugin driver in fact) does not call this method at all, as well as destroy_pool. They are only used within agent in sync_state task. \n\nProbably I decided to leave these methods in agent API just in case, for future. But now I think It\u0027s better to remove them so that they not produce concerns like yours. However they can be added when needed without breaking backward compatibility.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Handle RPC cast from plugin to destroy a pool if known to agent.\"\"\""},{"line_number":194,"context_line":"        driver \u003d self._get_driver(pool_id)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            driver.undeploy_instance(pool_id)"},{"line_number":197,"context_line":"            del self.devices[pool_id]"},{"line_number":198,"context_line":"            self.plugin_rpc.pool_destroyed(pool_id)"},{"line_number":199,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9ySY%3D","line":196,"updated":"2013-12-05 23:15:02.000000000","message":"same question as above.\n\nThis is however expected to happen only once for pool, so perhaps it\u0027s not even worth addressing.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Handle RPC cast from plugin to destroy a pool if known to agent.\"\"\""},{"line_number":194,"context_line":"        driver \u003d self._get_driver(pool_id)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            driver.undeploy_instance(pool_id)"},{"line_number":197,"context_line":"            del self.devices[pool_id]"},{"line_number":198,"context_line":"            self.plugin_rpc.pool_destroyed(pool_id)"},{"line_number":199,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wBs%3D","line":196,"in_reply_to":"AAAATn%2F9ySY%3D","updated":"2013-12-06 13:36:27.000000000","message":"Please see my comment above.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            try:"},{"line_number":208,"context_line":"                self.device_drivers[driver_name].remove_orphans(pool_ids)"},{"line_number":209,"context_line":"            except NotImplementedError:"},{"line_number":210,"context_line":"                pass  # Not all drivers will support this"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def create_vip(self, context, vip):"},{"line_number":213,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yR4%3D","line":210,"updated":"2013-12-05 23:15:02.000000000","message":"to log or not to log?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            try:"},{"line_number":208,"context_line":"                self.device_drivers[driver_name].remove_orphans(pool_ids)"},{"line_number":209,"context_line":"            except NotImplementedError:"},{"line_number":210,"context_line":"                pass  # Not all drivers will support this"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def create_vip(self, context, vip):"},{"line_number":213,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wAg%3D","line":210,"in_reply_to":"AAAATn%2F9yR4%3D","updated":"2013-12-06 13:36:27.000000000","message":"Well, as this is a normal case when a driver doesn\u0027t support this I think there is no need for logging","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                          {\u0027vip\u0027: vip[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"},{"line_number":220,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":221,"context_line":"            return"},{"line_number":222,"context_line":"        self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def update_vip(self, context, old_vip, vip):"},{"line_number":225,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yRo%3D","line":222,"updated":"2013-12-05 23:15:02.000000000","message":"a syntax alternative to returning at line 221 would consist in using the try..except..else block.\n\nYou\u0027re not required to address this comment however, it\u0027s just for saying.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                          {\u0027vip\u0027: vip[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"},{"line_number":220,"context_line":"            self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ERROR)"},{"line_number":221,"context_line":"            return"},{"line_number":222,"context_line":"        self.plugin_rpc.update_status(\u0027vip\u0027, vip[\u0027id\u0027], constants.ACTIVE)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def update_vip(self, context, old_vip, vip):"},{"line_number":225,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9v%2Fs%3D","line":222,"in_reply_to":"AAAATn%2F9yRo%3D","updated":"2013-12-06 13:36:27.000000000","message":"Yeah, I think try..except..else looks better, I\u0027ll change, thanks","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def delete_vip(self, context, vip):"},{"line_number":237,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"},{"line_number":238,"context_line":"        driver.delete_vip(vip)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":241,"context_line":"        if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yRk%3D","line":238,"updated":"2013-12-05 23:15:02.000000000","message":"Is it ok to just ignore VIP deletion errors?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def delete_vip(self, context, vip):"},{"line_number":237,"context_line":"        driver \u003d self._get_driver(vip[\u0027pool_id\u0027])"},{"line_number":238,"context_line":"        driver.delete_vip(vip)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def create_pool(self, context, pool, driver_name):"},{"line_number":241,"context_line":"        if driver_name not in self.device_drivers:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9wME%3D","line":238,"in_reply_to":"AAAATn%2F9yRk%3D","updated":"2013-12-06 13:36:27.000000000","message":"At this point vip object is already deleted from DB so we can\u0027t update object status. So only an exception will be logged on the agent side","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            LOG.exception(_(\u0027Create pool %(pool)s failed on device driver \u0027"},{"line_number":251,"context_line":"                            \u0027%(driver)s\u0027),"},{"line_number":252,"context_line":"                          {\u0027pool\u0027: pool[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"},{"line_number":253,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":254,"context_line":"            return"},{"line_number":255,"context_line":"        self.devices[pool[\u0027id\u0027]] \u003d driver_name"},{"line_number":256,"context_line":"        self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yRQ%3D","line":253,"updated":"2013-12-05 23:15:02.000000000","message":"these two lines are repeated over and over and seem to be begging for a refactoring... do you agree or is there a reason for keeping them like they are?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            LOG.exception(_(\u0027Create pool %(pool)s failed on device driver \u0027"},{"line_number":251,"context_line":"                            \u0027%(driver)s\u0027),"},{"line_number":252,"context_line":"                          {\u0027pool\u0027: pool[\u0027id\u0027], \u0027driver\u0027: driver.get_name()})"},{"line_number":253,"context_line":"            self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ERROR)"},{"line_number":254,"context_line":"            return"},{"line_number":255,"context_line":"        self.devices[pool[\u0027id\u0027]] \u003d driver_name"},{"line_number":256,"context_line":"        self.plugin_rpc.update_status(\u0027pool\u0027, pool[\u0027id\u0027], constants.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9v%2BE%3D","line":253,"in_reply_to":"AAAATn%2F9yRQ%3D","updated":"2013-12-06 13:36:27.000000000","message":"No special reason, refactoring makes sence to me, thanks for pointing","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":271,"context_line":"        driver \u003d self._get_driver(pool[\u0027id\u0027])"},{"line_number":272,"context_line":"        driver.delete_pool(pool)"},{"line_number":273,"context_line":"        del self.devices[pool[\u0027id\u0027]]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yQ8%3D","line":272,"updated":"2013-12-05 23:15:02.000000000","message":"again: is it ok to silently ignore failures on delete?","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":271,"context_line":"        driver \u003d self._get_driver(pool[\u0027id\u0027])"},{"line_number":272,"context_line":"        driver.delete_pool(pool)"},{"line_number":273,"context_line":"        del self.devices[pool[\u0027id\u0027]]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9v98%3D","line":272,"in_reply_to":"AAAATn%2F9yQ8%3D","updated":"2013-12-06 13:36:27.000000000","message":"please see comment above","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"}],"neutron/services/loadbalancer/drivers/haproxy/cfg.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"2763580a32bc0f8e12dbc2e20b90364dd3d4d671","unresolved":false,"context_lines":[{"line_number":158,"context_line":"def _get_server_health_option(config):"},{"line_number":159,"context_line":"    \"\"\"return the first active health option.\"\"\""},{"line_number":160,"context_line":"    for monitor in config[\u0027healthmonitors\u0027]:"},{"line_number":161,"context_line":"        # not checking the status of healthmonitor for two reasons:"},{"line_number":162,"context_line":"        # 1) status field is absent in HealthMonitor model"},{"line_number":163,"context_line":"        # 2) only active HealthMonitors are fetched with"},{"line_number":164,"context_line":"        # LoadBalancerCallbacks.get_logical_device"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FzGc%3D","line":161,"updated":"2013-08-21 20:39:19.000000000","message":"SHould this be a TODO? IOW, will the status field be added to the model later?","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0ae0c14b4154cffea6adb5ec4bfa51ae8b067aa9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"def _get_server_health_option(config):"},{"line_number":159,"context_line":"    \"\"\"return the first active health option.\"\"\""},{"line_number":160,"context_line":"    for monitor in config[\u0027healthmonitors\u0027]:"},{"line_number":161,"context_line":"        # not checking the status of healthmonitor for two reasons:"},{"line_number":162,"context_line":"        # 1) status field is absent in HealthMonitor model"},{"line_number":163,"context_line":"        # 2) only active HealthMonitors are fetched with"},{"line_number":164,"context_line":"        # LoadBalancerCallbacks.get_logical_device"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2Fwg0%3D","line":161,"in_reply_to":"AAAARn%2F%2FzGc%3D","updated":"2013-08-22 07:40:15.000000000","message":"Actually status field was deleted intentionally. See bug https://bugs.launchpad.net/neutron/+bug/1207650","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"}],"neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"27e69c16a3e4ab9096d0f888556ca7f040602126","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        self._refresh_device(pool[\u0027id\u0027])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def delete_pool(self, pool):"},{"line_number":266,"context_line":"        # nothing to do here as instance was undeployed on vip deletion"},{"line_number":267,"context_line":"        pass"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def create_member(self, member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FJi4%3D","line":266,"updated":"2013-08-06 12:37:21.000000000","message":"delete_pool may be called before vip deletion in case pool\u0027s admin state set to down. Will fix in next patch set.","commit_id":"f589827e4b56f1d564434cb70d84f7534aa37e6d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"class HaproxyNSDriver(object):"},{"line_number":63,"context_line":"    def __init__(self, root_helper, plugin_rpc):"},{"line_number":64,"context_line":"        self.root_helper \u003d root_helper"},{"line_number":65,"context_line":"        self.state_path \u003d cfg.CONF.haproxy.loadbalancer_state_path"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            vif_driver \u003d importutils.import_object("},{"line_number":68,"context_line":"                cfg.CONF.haproxy.interface_driver, cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2Fv48%3D","line":65,"updated":"2013-08-22 11:17:39.000000000","message":"See the comment about backward compatibility, i think you need  more handling here","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"class HaproxyNSDriver(object):"},{"line_number":63,"context_line":"    def __init__(self, root_helper, plugin_rpc):"},{"line_number":64,"context_line":"        self.root_helper \u003d root_helper"},{"line_number":65,"context_line":"        self.state_path \u003d cfg.CONF.haproxy.loadbalancer_state_path"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            vif_driver \u003d importutils.import_object("},{"line_number":68,"context_line":"                cfg.CONF.haproxy.interface_driver, cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvPE%3D","line":65,"in_reply_to":"AAAARn%2F%2Fv48%3D","updated":"2013-08-22 14:32:08.000000000","message":"Agree","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # do actual deploy only if vip is configured and active"},{"line_number":246,"context_line":"        if (\u0027vip\u0027 not in logical_config or"},{"line_number":247,"context_line":"            logical_config[\u0027vip\u0027][\u0027status\u0027] not in ACTIVE_PENDING or"},{"line_number":248,"context_line":"            logical_config[\u0027vip\u0027][\u0027admin_state_up\u0027] !\u003d True):"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if self.exists(logical_config[\u0027pool\u0027][\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkpE%3D","line":248,"updated":"2013-09-03 11:15:31.000000000","message":"\"not logical_config[\u0027vip\u0027][\u0027admin_state_up\u0027]\"","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # do actual deploy only if vip is configured and active"},{"line_number":246,"context_line":"        if (\u0027vip\u0027 not in logical_config or"},{"line_number":247,"context_line":"            logical_config[\u0027vip\u0027][\u0027status\u0027] not in ACTIVE_PENDING or"},{"line_number":248,"context_line":"            logical_config[\u0027vip\u0027][\u0027admin_state_up\u0027] !\u003d True):"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if self.exists(logical_config[\u0027pool\u0027][\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkWE%3D","line":248,"in_reply_to":"AAAASn%2F%2FkpE%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def create_pool_health_monitor(self, health_monitor, pool_id):"},{"line_number":292,"context_line":"        self._refresh_device(pool_id)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def update_health_monitor(self, old_health_monitor, health_monitor,"},{"line_number":295,"context_line":"                              pool_id):"},{"line_number":296,"context_line":"        self._refresh_device(pool_id)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fkow%3D","line":294,"updated":"2013-09-03 11:15:31.000000000","message":"update_pool_health_monitor?\ncreate/delete health monitor have \"pool_\".","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def create_pool_health_monitor(self, health_monitor, pool_id):"},{"line_number":292,"context_line":"        self._refresh_device(pool_id)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def update_health_monitor(self, old_health_monitor, health_monitor,"},{"line_number":295,"context_line":"                              pool_id):"},{"line_number":296,"context_line":"        self._refresh_device(pool_id)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkU4%3D","line":294,"in_reply_to":"AAAASn%2F%2Fkow%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"cfg.CONF.register_opts(OPTS)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(object):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc):"},{"line_number":66,"context_line":"        self.conf \u003d conf"},{"line_number":67,"context_line":"        self.root_helper \u003d config.get_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B6uc%3D","line":64,"updated":"2013-11-18 15:59:01.000000000","message":"Where is the interface of agent-side driver defined? I might miss something.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":61,"context_line":"cfg.CONF.register_opts(OPTS)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(object):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc):"},{"line_number":66,"context_line":"        self.conf \u003d conf"},{"line_number":67,"context_line":"        self.root_helper \u003d config.get_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1mE%3D","line":64,"in_reply_to":"AAAATn%2F%2B6uc%3D","updated":"2013-11-19 15:57:47.000000000","message":"You are right, it should be specified separately","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":"cfg.CONF.register_opts(OPTS, \u0027haproxy\u0027)"},{"line_number":61,"context_line":"# registering in DEFAULT to ensure backward compatibility"},{"line_number":62,"context_line":"cfg.CONF.register_opts(OPTS)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yQY%3D","line":62,"updated":"2013-12-05 23:15:02.000000000","message":"I think oslo.cfg should have a strategy for dealing for cases like this.\nDoesn\u0027t look great to have the same options in two groups for bw compatibility.","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":"cfg.CONF.register_opts(OPTS, \u0027haproxy\u0027)"},{"line_number":61,"context_line":"# registering in DEFAULT to ensure backward compatibility"},{"line_number":62,"context_line":"cfg.CONF.register_opts(OPTS)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9vy0%3D","line":62,"in_reply_to":"AAAATn%2F9yQY%3D","updated":"2013-12-06 13:36:27.000000000","message":"Looks like DeprecatedOpt suits here","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"}],"neutron/services/loadbalancer/drivers/haproxy/plugin_driver.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"740bbd55d45e9556c6a1376a33bd25cdfa5490e1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_ready_devices(self, context, host\u003dNone):"},{"line_number":76,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"            qry \u003d context.session.query(loadbalancer_db.Pool.id)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.status.in_(ACTIVE_PENDING))"},{"line_number":80,"context_line":"            up \u003d True  # makes pep8 and sqlalchemy happy"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2Fv4A%3D","line":77,"updated":"2013-08-22 11:17:39.000000000","message":"currently driver only works with pools having a vip.\nWhat/why has changed?","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd1d3d6def8050a068800ad4ae4d32dc2b7d39cd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_ready_devices(self, context, host\u003dNone):"},{"line_number":76,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"            qry \u003d context.session.query(loadbalancer_db.Pool.id)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.status.in_(ACTIVE_PENDING))"},{"line_number":80,"context_line":"            up \u003d True  # makes pep8 and sqlalchemy happy"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARn%2F%2FvUg%3D","line":77,"in_reply_to":"AAAARn%2F%2Fv4A%3D","updated":"2013-08-22 14:32:08.000000000","message":"This is true for haproxy-on-host implementation but other drivers may be able to create pools/members/healthmonitors even if vip is not created yet.","commit_id":"d0a8ac996da89f64bd4d27e91e1ef9c19342a8f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # history"},{"line_number":64,"context_line":"    #   1.0 Initial version"},{"line_number":65,"context_line":"    #   2.0 get_logical_device() handling changed;"},{"line_number":66,"context_line":"    #       pool_deployed() and update_status() methods added;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def __init__(self, plugin):"},{"line_number":69,"context_line":"        self.plugin \u003d plugin"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fkn8%3D","line":66,"updated":"2013-09-03 11:15:31.000000000","message":"It is better to add a description about the background of the major version change.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # history"},{"line_number":64,"context_line":"    #   1.0 Initial version"},{"line_number":65,"context_line":"    #   2.0 get_logical_device() handling changed;"},{"line_number":66,"context_line":"    #       pool_deployed() and update_status() methods added;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def __init__(self, plugin):"},{"line_number":69,"context_line":"        self.plugin \u003d plugin"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkUE%3D","line":66,"in_reply_to":"AAAASn%2F%2Fkn8%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                return []"},{"line_number":86,"context_line":"            elif len(agents) \u003e 1:"},{"line_number":87,"context_line":"                LOG.warning(_(\u0027Multiple lbaas agents found on host %s\u0027) % host)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            pools \u003d self.plugin.list_pools_on_lbaas_agent(context,"},{"line_number":90,"context_line":"                                                          agents[0].id)"},{"line_number":91,"context_line":"            pool_ids \u003d [pool[\u0027id\u0027] for pool in pools[\u0027pools\u0027]]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FknM%3D","line":88,"updated":"2013-09-03 11:15:31.000000000","message":"How about moving L.77-81 to here?\nIf \"not agents\" is true, there is no need to construct the query.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                return []"},{"line_number":86,"context_line":"            elif len(agents) \u003e 1:"},{"line_number":87,"context_line":"                LOG.warning(_(\u0027Multiple lbaas agents found on host %s\u0027) % host)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            pools \u003d self.plugin.list_pools_on_lbaas_agent(context,"},{"line_number":90,"context_line":"                                                          agents[0].id)"},{"line_number":91,"context_line":"            pool_ids \u003d [pool[\u0027id\u0027] for pool in pools[\u0027pools\u0027]]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkTc%3D","line":88,"in_reply_to":"AAAASn%2F%2FknM%3D","updated":"2013-09-03 12:43:18.000000000","message":"Good suggestion, thanks","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        super(LoadBalancerAgentApi, self).__init__("},{"line_number":251,"context_line":"            topic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _cast(self, context, method_name, method_args, host):"},{"line_number":254,"context_line":"        return self.cast("},{"line_number":255,"context_line":"            context,"},{"line_number":256,"context_line":"            self.make_msg(method_name, **method_args),"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fkmg%3D","line":253,"updated":"2013-09-03 11:15:31.000000000","message":"It is better to add optional argument \"version\". In a minor RPC API version change, there is a case where not all methods have a same number, e.g., some methods are v2.0 and some methdos are v2.1.\n\nFor more detail, neutron/openstack/common/rpc/dispatcher.py has a good explanation about RPC versioning policy.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        super(LoadBalancerAgentApi, self).__init__("},{"line_number":251,"context_line":"            topic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _cast(self, context, method_name, method_args, host):"},{"line_number":254,"context_line":"        return self.cast("},{"line_number":255,"context_line":"            context,"},{"line_number":256,"context_line":"            self.make_msg(method_name, **method_args),"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkTI%3D","line":253,"in_reply_to":"AAAASn%2F%2Fkmg%3D","updated":"2013-09-03 12:43:18.000000000","message":"Done","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def update_member(self, context, old_member, member):"},{"line_number":411,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":412,"context_line":"        # member may change pool id"},{"line_number":413,"context_line":"        if member[\u0027pool_id\u0027] !\u003d old_member[\u0027pool_id\u0027]:"},{"line_number":414,"context_line":"            old_pool_agent \u003d self.plugin.get_lbaas_agent_hosting_pool("},{"line_number":415,"context_line":"                context, old_member[\u0027pool_id\u0027])"},{"line_number":416,"context_line":"            if old_pool_agent:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkkA%3D","line":413,"updated":"2013-09-03 11:15:31.000000000","message":"Is there a case where a member goes to a pool with different provider? If so, loadbalancer_plugin layer needs to deal with it.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27d3528b163f237f5c851c4e2686c63223e731e7","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def update_member(self, context, old_member, member):"},{"line_number":411,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":412,"context_line":"        # member may change pool id"},{"line_number":413,"context_line":"        if member[\u0027pool_id\u0027] !\u003d old_member[\u0027pool_id\u0027]:"},{"line_number":414,"context_line":"            old_pool_agent \u003d self.plugin.get_lbaas_agent_hosting_pool("},{"line_number":415,"context_line":"                context, old_member[\u0027pool_id\u0027])"},{"line_number":416,"context_line":"            if old_pool_agent:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fiq4%3D","line":413,"in_reply_to":"AAAASn%2F%2FjPA%3D","updated":"2013-09-03 17:37:45.000000000","message":"Agree. Do you mean this will be dealt with in lbaas service framework patch or a later patch?","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def update_member(self, context, old_member, member):"},{"line_number":411,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":412,"context_line":"        # member may change pool id"},{"line_number":413,"context_line":"        if member[\u0027pool_id\u0027] !\u003d old_member[\u0027pool_id\u0027]:"},{"line_number":414,"context_line":"            old_pool_agent \u003d self.plugin.get_lbaas_agent_hosting_pool("},{"line_number":415,"context_line":"                context, old_member[\u0027pool_id\u0027])"},{"line_number":416,"context_line":"            if old_pool_agent:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkRo%3D","line":413,"in_reply_to":"AAAASn%2F%2FkkA%3D","updated":"2013-09-03 12:43:18.000000000","message":"Good catch, I think it\u0027s possible but it\u0027s out of scope of this patch I believe","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c6d36bba19e04ec24464d54dff82cef4cafa79bb","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def update_member(self, context, old_member, member):"},{"line_number":411,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":412,"context_line":"        # member may change pool id"},{"line_number":413,"context_line":"        if member[\u0027pool_id\u0027] !\u003d old_member[\u0027pool_id\u0027]:"},{"line_number":414,"context_line":"            old_pool_agent \u003d self.plugin.get_lbaas_agent_hosting_pool("},{"line_number":415,"context_line":"                context, old_member[\u0027pool_id\u0027])"},{"line_number":416,"context_line":"            if old_pool_agent:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FjPA%3D","line":413,"in_reply_to":"AAAASn%2F%2FkkA%3D","updated":"2013-09-03 16:02:33.000000000","message":"You\u0027re right. I\u0027d like to move it out of scope of this and the parent patch. I\u0027ll file a bug on this.","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68d5e6592eb6887a0d542fed1a87ff4b5ae2c860","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":427,"context_line":"        self.agent_rpc.delete_member(context, member, agent[\u0027host\u0027])"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def update_health_monitor(self, context, old_health_monitor,"},{"line_number":430,"context_line":"                              health_monitor, pool_id):"},{"line_number":431,"context_line":"        agent \u003d self.get_pool_agent(context, pool_id)"},{"line_number":432,"context_line":"        self.agent_rpc.update_health_monitor(context, old_health_monitor,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2Fklg%3D","line":429,"updated":"2013-09-03 11:15:31.000000000","message":"update_pool_health_monitor?","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"96c616662ad23296512960a86dbf8e183e1f8d58","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        agent \u003d self.get_pool_agent(context, member[\u0027pool_id\u0027])"},{"line_number":427,"context_line":"        self.agent_rpc.delete_member(context, member, agent[\u0027host\u0027])"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def update_health_monitor(self, context, old_health_monitor,"},{"line_number":430,"context_line":"                              health_monitor, pool_id):"},{"line_number":431,"context_line":"        agent \u003d self.get_pool_agent(context, pool_id)"},{"line_number":432,"context_line":"        self.agent_rpc.update_health_monitor(context, old_health_monitor,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAASn%2F%2FkS0%3D","line":429,"in_reply_to":"AAAASn%2F%2Fklg%3D","updated":"2013-09-03 12:43:18.000000000","message":"yeah, will update abstract driver as well","commit_id":"3d12ae7509c0d8e0be481275f00022008cd0cfdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                           \u0027health_monitor\u0027: health_monitor,"},{"line_number":305,"context_line":"                           \u0027pool_id\u0027: pool_id}, host)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id,"},{"line_number":308,"context_line":"                                   host):"},{"line_number":309,"context_line":"        return self._cast(context, \u0027create_pool_health_monitor\u0027,"},{"line_number":310,"context_line":"                          {\u0027health_monitor\u0027: health_monitor,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B6vs%3D","line":307,"updated":"2013-11-18 15:59:01.000000000","message":"It is better to move create_pool_health_monitor before update_pool_health_monitor.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                           \u0027health_monitor\u0027: health_monitor,"},{"line_number":305,"context_line":"                           \u0027pool_id\u0027: pool_id}, host)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id,"},{"line_number":308,"context_line":"                                   host):"},{"line_number":309,"context_line":"        return self._cast(context, \u0027create_pool_health_monitor\u0027,"},{"line_number":310,"context_line":"                          {\u0027health_monitor\u0027: health_monitor,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1m4%3D","line":307,"in_reply_to":"AAAATn%2F%2B6vs%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            qry \u003d context.session.query(loadbalancer_db.Pool.id)"},{"line_number":89,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.id.in_(pool_ids))"},{"line_number":90,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.status.in_(ACTIVE_PENDING))"},{"line_number":91,"context_line":"            up \u003d True  # makes pep8 and sqlalchemy happy"},{"line_number":92,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.admin_state_up \u003d\u003d up)"},{"line_number":93,"context_line":"            return [id for id, in qry]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yPc%3D","line":91,"updated":"2013-12-05 23:15:02.000000000","message":"I had a similar fight with pep8 refusing sqlalchemy syntax for filter expressions.\n\nSorted this way: https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L101","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            qry \u003d context.session.query(loadbalancer_db.Pool.id)"},{"line_number":89,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.id.in_(pool_ids))"},{"line_number":90,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.status.in_(ACTIVE_PENDING))"},{"line_number":91,"context_line":"            up \u003d True  # makes pep8 and sqlalchemy happy"},{"line_number":92,"context_line":"            qry \u003d qry.filter(loadbalancer_db.Pool.admin_state_up \u003d\u003d up)"},{"line_number":93,"context_line":"            return [id for id, in qry]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9vrc%3D","line":91,"in_reply_to":"AAAATn%2F9yPc%3D","updated":"2013-12-06 13:36:27.000000000","message":"Hm.., my IDE still shows pep8 warning on https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L102\n\nPrefer to leave as is if you don\u0027t mind (It wasn\u0027t introduced in my patch :-P)","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"61fbdcec83f9d0396115dd38683dd2508913d9f3","unresolved":false,"context_lines":[{"line_number":458,"context_line":"class HaproxyOnHostPluginDriver(AgentBasedPluginDriver):"},{"line_number":459,"context_line":"    #TODO(obondarev): change hardcoded driver name"},{"line_number":460,"context_line":"    # to namespace_driver.DRIVER_NAME after moving HaproxyOnHostPluginDriver"},{"line_number":461,"context_line":"    # to a separate file (follow-up patch)"},{"line_number":462,"context_line":"    device_driver \u003d \u0027haproxy_ns\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9yPE%3D","line":461,"updated":"2013-12-05 23:15:02.000000000","message":"and I will look back at this file in 2020, and there will still this TODO waiting for your followup patch :)","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f73b63329f736b420331355e295a8333ce34ceea","unresolved":false,"context_lines":[{"line_number":458,"context_line":"class HaproxyOnHostPluginDriver(AgentBasedPluginDriver):"},{"line_number":459,"context_line":"    #TODO(obondarev): change hardcoded driver name"},{"line_number":460,"context_line":"    # to namespace_driver.DRIVER_NAME after moving HaproxyOnHostPluginDriver"},{"line_number":461,"context_line":"    # to a separate file (follow-up patch)"},{"line_number":462,"context_line":"    device_driver \u003d \u0027haproxy_ns\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9vwA%3D","line":461,"in_reply_to":"AAAATn%2F9yPE%3D","updated":"2013-12-06 13:36:27.000000000","message":"no, noway :)\nseriously, I guarantee I\u0027ll upload a follow-up patch right after this one is merged. As I stated in the commit message I don\u0027t replace files here to make review easier","commit_id":"7630d851f54dfe3789ac4f7075335ed424bd4ca4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"260a0258a82cb0b72857665d5e3881b4b6e30381","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class DriverNotSpecified(q_exc.NeutronException):"},{"line_number":319,"context_line":"    message \u003d _(\"Device driver for agent should be specified \""},{"line_number":320,"context_line":"                \"in plugin driver.\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"class AgentBasedPluginDriver(abstract_driver.LoadBalancerAbstractDriver):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAATn%2F9ktM%3D","line":320,"updated":"2013-12-10 03:38:58.000000000","message":"(suggestion for further refactoring; no action required) IMO it is better exception(s) should be define at the top of a file rather than between big classes if we have more exceptions. It is easier to find exceptions.","commit_id":"4a64b4aec4906054c198d4773693a89cb950fad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ddccde6db0c9e8574ca71dfb0df4045532973fb8","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class DriverNotSpecified(q_exc.NeutronException):"},{"line_number":319,"context_line":"    message \u003d _(\"Device driver for agent should be specified \""},{"line_number":320,"context_line":"                \"in plugin driver.\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"class AgentBasedPluginDriver(abstract_driver.LoadBalancerAbstractDriver):"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAATn%2F9kB0%3D","line":320,"in_reply_to":"AAAATn%2F9ktM%3D","updated":"2013-12-10 08:09:03.000000000","message":"Agree, it\u0027s not hard to fix now since have to upload new patch set fixing typo in ut. Thanks","commit_id":"4a64b4aec4906054c198d4773693a89cb950fad5"}],"neutron/services/loadbalancer/drivers/radware/driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"86a8f4a1555ef0fca5ec1cbd4c2e3d4ffe154025","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                help\u003d_(\u0027Resource pool ids\u0027)),"},{"line_number":119,"context_line":"    cfg.IntOpt(\u0027service_isl_vlan\u0027,"},{"line_number":120,"context_line":"               default\u003d-1,"},{"line_number":121,"context_line":"               help\u003d_(\u0027A required VLAN for the interswitch link to use\u0027)),"},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027service_session_mirroring_enabled\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d_(\u0027Support an Alteon interswitch \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAATn%2F%2F06w%3D","line":121,"updated":"2013-10-28 11:51:02.000000000","message":"Couple of questions. If this is a required config item, should it have a default value (that I assume is invalid)?\n\nFor some of the other configs being added, should default values be described in the help messages?","commit_id":"c762b4652e2c32559a8b2827c7726035dcb6c56b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"058525a5444724fdf225988c3b73d3a75b6357b9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                help\u003d_(\u0027Resource pool ids\u0027)),"},{"line_number":119,"context_line":"    cfg.IntOpt(\u0027service_isl_vlan\u0027,"},{"line_number":120,"context_line":"               default\u003d-1,"},{"line_number":121,"context_line":"               help\u003d_(\u0027A required VLAN for the interswitch link to use\u0027)),"},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027service_session_mirroring_enabled\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d_(\u0027Support an Alteon interswitch \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAATn%2F%2F04E%3D","line":121,"in_reply_to":"AAAATn%2F%2F05U%3D","updated":"2013-10-28 12:43:12.000000000","message":"Duh! Was looking at patch set difference between previous version and this showed up. Ignore.","commit_id":"c762b4652e2c32559a8b2827c7726035dcb6c56b"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d0515433b17b5e534dcc78b7d280151f33d3bbe1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                help\u003d_(\u0027Resource pool ids\u0027)),"},{"line_number":119,"context_line":"    cfg.IntOpt(\u0027service_isl_vlan\u0027,"},{"line_number":120,"context_line":"               default\u003d-1,"},{"line_number":121,"context_line":"               help\u003d_(\u0027A required VLAN for the interswitch link to use\u0027)),"},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027service_session_mirroring_enabled\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d_(\u0027Support an Alteon interswitch \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAATn%2F%2F05U%3D","line":121,"in_reply_to":"AAAATn%2F%2F06w%3D","updated":"2013-10-28 12:04:15.000000000","message":"I think it\u0027s radware-specific and out of scope of this patch","commit_id":"c762b4652e2c32559a8b2827c7726035dcb6c56b"}],"neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_cfg.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Oleg Bondarev (obondarev@mirantis.com)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import contextlib"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.services.loadbalancer.drivers.haproxy import cfg"},{"line_number":24,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fitg%3D","line":21,"updated":"2013-09-03 17:33:44.000000000","message":"mock is third party lib","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Oleg Bondarev (obondarev@mirantis.com)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import contextlib"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.services.loadbalancer.drivers.haproxy import cfg"},{"line_number":24,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fipw%3D","line":21,"in_reply_to":"AAAASn%2F%2Fitg%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"}],"neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_namespace_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Mark McClain, DreamHost"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import contextlib"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fitw%3D","line":20,"updated":"2013-09-03 17:33:44.000000000","message":"mock is third party lib.","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Mark McClain, DreamHost"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import contextlib"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fioc%3D","line":20,"in_reply_to":"AAAASn%2F%2Fitw%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"260a0258a82cb0b72857665d5e3881b4b6e30381","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            kill.assert_called_once_with(\u0027sudo_test\u0027, \u0027/pool/pid\u0027)"},{"line_number":118,"context_line":"            unplug.assert_called_once_with(\u0027qlbaas-pool_id\u0027, \u0027port_id\u0027)"},{"line_number":119,"context_line":"            isdir.called_once_with(\u0027/pool\u0027)"},{"line_number":120,"context_line":"            rmtree.assert_called_once_with(\u0027/pool\u0027)"},{"line_number":121,"context_line":"            ip_wrap.assert_has_calls(["},{"line_number":122,"context_line":"                mock.call(\u0027sudo_test\u0027, \u0027qlbaas-pool_id\u0027),"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAATn%2F9ks8%3D","line":119,"updated":"2013-12-10 03:38:58.000000000","message":"assert_called_once_with","commit_id":"4a64b4aec4906054c198d4773693a89cb950fad5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ddccde6db0c9e8574ca71dfb0df4045532973fb8","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            kill.assert_called_once_with(\u0027sudo_test\u0027, \u0027/pool/pid\u0027)"},{"line_number":118,"context_line":"            unplug.assert_called_once_with(\u0027qlbaas-pool_id\u0027, \u0027port_id\u0027)"},{"line_number":119,"context_line":"            isdir.called_once_with(\u0027/pool\u0027)"},{"line_number":120,"context_line":"            rmtree.assert_called_once_with(\u0027/pool\u0027)"},{"line_number":121,"context_line":"            ip_wrap.assert_has_calls(["},{"line_number":122,"context_line":"                mock.call(\u0027sudo_test\u0027, \u0027qlbaas-pool_id\u0027),"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAATn%2F9kCQ%3D","line":119,"in_reply_to":"AAAATn%2F9ks8%3D","updated":"2013-12-10 08:09:03.000000000","message":"Done","commit_id":"4a64b4aec4906054c198d4773693a89cb950fad5"}],"neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_plugin_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Mark McClain, DreamHost"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import contextlib"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fixw%3D","line":19,"updated":"2013-09-03 17:33:44.000000000","message":"contextlib is a part of standard library.\nNeeds a blank line after L.19","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Mark McClain, DreamHost"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import contextlib"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2FioM%3D","line":19,"in_reply_to":"AAAASn%2F%2Fixw%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def tearDown(self):"},{"line_number":58,"context_line":"        plugin_driver.AgentBasedPluginDriver.device_driver \u003d None"},{"line_number":59,"context_line":"        super(TestLoadBalancerPluginBase, self).tearDown()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class TestLoadBalancerCallbacks(TestLoadBalancerPluginBase):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fiwc%3D","line":59,"updated":"2013-09-03 17:33:44.000000000","message":"addCleanup is more robust than tearDown (though i am not sure the detail, it is the reason addCleanup is introduced)\nIt is better to define a method to reset device_driver to None and register it to addCleanup.","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def tearDown(self):"},{"line_number":58,"context_line":"        plugin_driver.AgentBasedPluginDriver.device_driver \u003d None"},{"line_number":59,"context_line":"        super(TestLoadBalancerPluginBase, self).tearDown()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class TestLoadBalancerCallbacks(TestLoadBalancerPluginBase):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Finw%3D","line":59,"in_reply_to":"AAAASn%2F%2Fiwc%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def test_update_status_health_monitor(self):"},{"line_number":310,"context_line":"        with contextlib.nested("},{"line_number":311,"context_line":"                self.pool(),"},{"line_number":312,"context_line":"                self.health_monitor()"},{"line_number":313,"context_line":"        ) as (pool, hm):"},{"line_number":314,"context_line":"            pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"},{"line_number":315,"context_line":"            ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fiu0%3D","line":312,"updated":"2013-09-03 17:33:44.000000000","message":"too more indentation than usual","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def test_update_status_health_monitor(self):"},{"line_number":310,"context_line":"        with contextlib.nested("},{"line_number":311,"context_line":"                self.pool(),"},{"line_number":312,"context_line":"                self.health_monitor()"},{"line_number":313,"context_line":"        ) as (pool, hm):"},{"line_number":314,"context_line":"            pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"},{"line_number":315,"context_line":"            ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fing%3D","line":312,"in_reply_to":"AAAASn%2F%2Fiu0%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                hm \u003d self.plugin.get_health_monitor("},{"line_number":587,"context_line":"                    ctx, hm[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":588,"context_line":"                (self.mock_api.create_pool_health_monitor."},{"line_number":589,"context_line":"                 assert_called_once_with("},{"line_number":590,"context_line":"                     mock.ANY, hm, pool_id, \u0027host\u0027))"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def test_delete_pool_health_monitor(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fiuk%3D","line":589,"updated":"2013-09-03 17:33:44.000000000","message":"If contextlib.nested is used, this fits into one line.","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                hm \u003d self.plugin.get_health_monitor("},{"line_number":587,"context_line":"                    ctx, hm[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":588,"context_line":"                (self.mock_api.create_pool_health_monitor."},{"line_number":589,"context_line":"                 assert_called_once_with("},{"line_number":590,"context_line":"                     mock.ANY, hm, pool_id, \u0027host\u0027))"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def test_delete_pool_health_monitor(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fim4%3D","line":589,"in_reply_to":"AAAASn%2F%2Fiuk%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                self.plugin_instance.delete_pool_health_monitor("},{"line_number":605,"context_line":"                    ctx, hm[\u0027id\u0027], pool_id)"},{"line_number":606,"context_line":"                (self.mock_api.delete_pool_health_monitor."},{"line_number":607,"context_line":"                 assert_called_once_with("},{"line_number":608,"context_line":"                     mock.ANY, hm, pool_id, \u0027host\u0027))"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def test_update_health_monitor_associated_with_pool(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2FiuY%3D","line":607,"updated":"2013-09-03 17:33:44.000000000","message":"Ditto","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                self.plugin_instance.delete_pool_health_monitor("},{"line_number":605,"context_line":"                    ctx, hm[\u0027id\u0027], pool_id)"},{"line_number":606,"context_line":"                (self.mock_api.delete_pool_health_monitor."},{"line_number":607,"context_line":"                 assert_called_once_with("},{"line_number":608,"context_line":"                     mock.ANY, hm, pool_id, \u0027host\u0027))"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def test_update_health_monitor_associated_with_pool(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fim0%3D","line":607,"in_reply_to":"AAAASn%2F%2FiuY%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                hm \u003d self.plugin.get_health_monitor("},{"line_number":630,"context_line":"                    ctx, monitor[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":631,"context_line":"                (self.mock_api.create_pool_health_monitor."},{"line_number":632,"context_line":"                 assert_called_once_with("},{"line_number":633,"context_line":"                     mock.ANY,"},{"line_number":634,"context_line":"                     hm,"},{"line_number":635,"context_line":"                     pool[\u0027pool\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2FiuQ%3D","line":632,"updated":"2013-09-03 17:33:44.000000000","message":"Ditto","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                hm \u003d self.plugin.get_health_monitor("},{"line_number":630,"context_line":"                    ctx, monitor[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":631,"context_line":"                (self.mock_api.create_pool_health_monitor."},{"line_number":632,"context_line":"                 assert_called_once_with("},{"line_number":633,"context_line":"                     mock.ANY,"},{"line_number":634,"context_line":"                     hm,"},{"line_number":635,"context_line":"                     pool[\u0027pool\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fik8%3D","line":632,"in_reply_to":"AAAASn%2F%2FiuQ%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40491201dc389673d165c26e1b7b6aa95ab87398","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                                              monitor[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":649,"context_line":"                req.get_response(self.ext_api)"},{"line_number":650,"context_line":"                (self.mock_api.update_pool_health_monitor."},{"line_number":651,"context_line":"                 assert_called_once_with("},{"line_number":652,"context_line":"                     mock.ANY,"},{"line_number":653,"context_line":"                     hm,"},{"line_number":654,"context_line":"                     updated,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2FiuM%3D","line":651,"updated":"2013-09-03 17:33:44.000000000","message":"Ditto","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"847587bd2a8d26c79c7dd27f411ed9d13223fd5e","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                                              monitor[\u0027health_monitor\u0027][\u0027id\u0027])"},{"line_number":649,"context_line":"                req.get_response(self.ext_api)"},{"line_number":650,"context_line":"                (self.mock_api.update_pool_health_monitor."},{"line_number":651,"context_line":"                 assert_called_once_with("},{"line_number":652,"context_line":"                     mock.ANY,"},{"line_number":653,"context_line":"                     hm,"},{"line_number":654,"context_line":"                     updated,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAASn%2F%2Fikw%3D","line":651,"in_reply_to":"AAAASn%2F%2FiuM%3D","updated":"2013-09-03 17:54:25.000000000","message":"Done","commit_id":"5324f57c083bd415a4706f11032dc208d68123f7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"91722e306e5a0bed73902306d0633f65e9637165","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        )"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_pool_deployed(self):"},{"line_number":320,"context_line":"        with self.pool() as pool:"},{"line_number":321,"context_line":"            with self.vip(pool\u003dpool) as vip:"},{"line_number":322,"context_line":"                with self.member(pool_id\u003dvip[\u0027vip\u0027][\u0027pool_id\u0027]) as member:"},{"line_number":323,"context_line":"                    ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2F56I%3D","line":320,"updated":"2013-10-25 13:09:22.000000000","message":"Could nest the with statements.","commit_id":"70b1303c818b8ab3413911261edff40b3899ff3e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"773272361044686ce5f703f159322b91045dbf79","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        )"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_pool_deployed(self):"},{"line_number":320,"context_line":"        with self.pool() as pool:"},{"line_number":321,"context_line":"            with self.vip(pool\u003dpool) as vip:"},{"line_number":322,"context_line":"                with self.member(pool_id\u003dvip[\u0027vip\u0027][\u0027pool_id\u0027]) as member:"},{"line_number":323,"context_line":"                    ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2F1is%3D","line":320,"in_reply_to":"AAAATn%2F%2F56I%3D","updated":"2013-10-28 08:15:45.000000000","message":"need to pass \u0027pool\u0027 parameter to self.vip()","commit_id":"70b1303c818b8ab3413911261edff40b3899ff3e"}],"neutron/tests/unit/services/loadbalancer/test_agent_scheduler.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19394baaf8149facc7ae6aab49dc551ac9b3d6c7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027lb_plugin_name\u0027: test_db_loadbalancer.DB_LB_PLUGIN_KLASS}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # need to reload provider configuration"},{"line_number":75,"context_line":"        st_db.ServiceTypeManager._instance \u003d None"},{"line_number":76,"context_line":"        #default provider should support agent scheduling"},{"line_number":77,"context_line":"        cfg.CONF.set_override("},{"line_number":78,"context_line":"            \u0027service_provider\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B6qs%3D","line":75,"updated":"2013-11-18 15:59:01.000000000","message":"I don\u0027t think it needs to be moved, but it is no problem if it is better.","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2e157b3b2c68fd602c8c124e1a27083e244d887","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027lb_plugin_name\u0027: test_db_loadbalancer.DB_LB_PLUGIN_KLASS}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # need to reload provider configuration"},{"line_number":75,"context_line":"        st_db.ServiceTypeManager._instance \u003d None"},{"line_number":76,"context_line":"        #default provider should support agent scheduling"},{"line_number":77,"context_line":"        cfg.CONF.set_override("},{"line_number":78,"context_line":"            \u0027service_provider\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAATn%2F%2B1mY%3D","line":75,"in_reply_to":"AAAATn%2F%2B6qs%3D","updated":"2013-11-19 15:57:47.000000000","message":"Done","commit_id":"ebf69009ca04f77270ee2a9477ac370be4d50025"}]}
