)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"070a0ed92fd66dd46bead513d5ccb7d0615b272a","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            msg \u003d _(\u0027Unable to determine mac address for %s\u0027) % self.br_name"},{"line_number":550,"context_line":"            raise Exception(msg)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def get_bridge_ports(self, port_type\u003dNone):"},{"line_number":553,"context_line":"        port_names \u003d self.get_port_name_list() + [self.br_name]"},{"line_number":554,"context_line":"        ports \u003d self.get_ports_attributes(\u0027Interface\u0027,"},{"line_number":555,"context_line":"                                          ports\u003dport_names,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_cbca274f","line":552,"updated":"2016-12-20 21:13:57.000000000","message":"maybe better name would be \"port_types\" as You are handling it as list of types later?","commit_id":"119fdffd816f4547dae9a63be5706ac8050e99c9"}],"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"070a0ed92fd66dd46bead513d5ccb7d0615b272a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        for network, phys_br in self.agent_api.request_phy_brs():"},{"line_number":140,"context_line":"            ports \u003d phys_br.get_bridge_ports(port_type\u003d\u0027\u0027)"},{"line_number":141,"context_line":"            if ports:"},{"line_number":142,"context_line":"                link_speed \u003d phys_br.get_port_link_speed(ports[0])"},{"line_number":143,"context_line":"                self.nic_bw_manager.add_device(ports[0],"},{"line_number":144,"context_line":"                                               link_speed,"},{"line_number":145,"context_line":"                                               network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2b4abbac","line":142,"updated":"2016-12-20 21:13:57.000000000","message":"I\u0027m just curious, why You are checking link_speed on first port from bridge only?","commit_id":"119fdffd816f4547dae9a63be5706ac8050e99c9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"7b2ec24d96958001ae0c00c0f3ea714042ad4590","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                               set())"},{"line_number":147,"context_line":"        if self.agent_api.request_tun_br():"},{"line_number":148,"context_line":"            ip \u003d ip_lib.IPWrapper()"},{"line_number":149,"context_line":"            ip_dev \u003d ip.get_device_by_ip(self.agent_api.request_local_ip)"},{"line_number":150,"context_line":"            nic_dev \u003d self.ethtool_wrapper.get_device(ip_dev.device_name)"},{"line_number":151,"context_line":"            self.nic_bw_manager.add_device(ip_dev.device_name, nic_dev.speed,"},{"line_number":152,"context_line":"                                           None, set())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0c8d7d31","line":149,"range":{"start_line":149,"start_character":41,"end_line":149,"end_character":72},"updated":"2016-12-01 13:28:02.000000000","message":"local_ip is set to None by default, should a check be put here in case it isn\u0027t provided?","commit_id":"119fdffd816f4547dae9a63be5706ac8050e99c9"}]}