)]}'
{"neutron/conf/extensions/qos.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fae5af52d742ef04fda9c8babdd54787149d73c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"qos_options \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027physical_interface_bandwidth\u0027,"},{"line_number":25,"context_line":"                default\u003dDEFAULT_INTERFACE_BANDWIDTH,"},{"line_number":26,"context_line":"                help\u003d_(\"\"\""},{"line_number":27,"context_line":"Comma-separated list of \u003cphysical_interface\u003e:\u003cbandwidth\u003e tuples mapping"},{"line_number":28,"context_line":"physical interface names to the total bandwidth available on this interface."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_ca2a3ce7","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":51},"updated":"2016-12-01 06:08:14.000000000","message":"I think we don\u0027t need it. I prefer just \"default\u003d[]\".","commit_id":"0f2f3859ce968516798a7db7f31a2a6c78a03413"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb50bd5937d3415f8a472916cc712fa06f55843d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"qos_options \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027physical_interface_bandwidth\u0027,"},{"line_number":25,"context_line":"                default\u003dDEFAULT_INTERFACE_BANDWIDTH,"},{"line_number":26,"context_line":"                help\u003d_(\"\"\""},{"line_number":27,"context_line":"Comma-separated list of \u003cphysical_interface\u003e:\u003cbandwidth\u003e tuples mapping"},{"line_number":28,"context_line":"physical interface names to the total bandwidth available on this interface."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1a3a1dce","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":51},"in_reply_to":"5a74a57a_ca2a3ce7","updated":"2016-12-01 08:19:59.000000000","message":"This is an opinion I don\u0027t share, but I\u0027ll change it.","commit_id":"0f2f3859ce968516798a7db7f31a2a6c78a03413"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fae5af52d742ef04fda9c8babdd54787149d73c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"qos_options \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027physical_interface_bandwidth\u0027,"},{"line_number":25,"context_line":"                default\u003dDEFAULT_INTERFACE_BANDWIDTH,"},{"line_number":26,"context_line":"                help\u003d_(\"\"\""},{"line_number":27,"context_line":"Comma-separated list of \u003cphysical_interface\u003e:\u003cbandwidth\u003e tuples mapping"},{"line_number":28,"context_line":"physical interface names to the total bandwidth available on this interface."},{"line_number":29,"context_line":"The total bandwidth could be expressed in bps or in percentage over the"},{"line_number":30,"context_line":"physical interface link speed.\"\"\")),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_6a684822","line":30,"range":{"start_line":26,"start_character":23,"end_line":30,"end_character":33},"updated":"2016-12-01 06:08:14.000000000","message":"Don\u0027t use triple-double quote here. It\u0027s used as multiline docstring.","commit_id":"0f2f3859ce968516798a7db7f31a2a6c78a03413"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb50bd5937d3415f8a472916cc712fa06f55843d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"qos_options \u003d ["},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027physical_interface_bandwidth\u0027,"},{"line_number":25,"context_line":"                default\u003dDEFAULT_INTERFACE_BANDWIDTH,"},{"line_number":26,"context_line":"                help\u003d_(\"\"\""},{"line_number":27,"context_line":"Comma-separated list of \u003cphysical_interface\u003e:\u003cbandwidth\u003e tuples mapping"},{"line_number":28,"context_line":"physical interface names to the total bandwidth available on this interface."},{"line_number":29,"context_line":"The total bandwidth could be expressed in bps or in percentage over the"},{"line_number":30,"context_line":"physical interface link speed.\"\"\")),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_9a4c6d78","line":30,"range":{"start_line":26,"start_character":23,"end_line":30,"end_character":33},"in_reply_to":"5a74a57a_6a684822","updated":"2016-12-01 08:19:59.000000000","message":"This is widely used in nova help texts for conf options.","commit_id":"0f2f3859ce968516798a7db7f31a2a6c78a03413"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e32981e6faf454f1c90e1d92366f54099200988b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def register_linuxbridge_opts(cfg\u003dcfg.CONF):"},{"line_number":35,"context_line":"    cfg.register_opts(qos_options, QOS_OPTIONS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_be1116b2","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":24},"updated":"2016-12-01 10:36:52.000000000","message":"Is this option used by linuxbridge driver only?\n\nAnyway, I think it\u0027s better to put this option in [1].\n\n[1]: https://github.com/openstack/neutron/blob/master/neutron/conf/services/qos_driver_manager.py","commit_id":"426d1fa8aa6c926c2f5cb038fdcadc8bd8d61b7c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0362b2429b450eec52d07d31c2a1c94cd3ef9ccd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def register_linuxbridge_opts(cfg\u003dcfg.CONF):"},{"line_number":35,"context_line":"    cfg.register_opts(qos_options, QOS_OPTIONS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_11175b52","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":24},"in_reply_to":"3a71b18c_be1116b2","updated":"2016-12-01 11:16:39.000000000","message":"Ok, I\u0027ll move this option to services","commit_id":"426d1fa8aa6c926c2f5cb038fdcadc8bd8d61b7c"}],"neutron/conf/services/qos_driver_manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6dc040b9ab2dfc19b2d744944d87077324ced3f0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                       \"physical interface names to the total bandwidth \""},{"line_number":25,"context_line":"                       \"available on this interface. The total bandwidth \""},{"line_number":26,"context_line":"                       \"could be expressed in bps or in percentage over the \""},{"line_number":27,"context_line":"                       \"physical interface link speed.\")),"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_47b9552d","line":27,"updated":"2016-12-06 12:26:30.000000000","message":"does this mean, if you specify bps, it overrides the actual value, but if you specify a percentage, it\u0027s meant relative to the actual value?","commit_id":"6773424c57c595103d7a1451fbc746379b97b065"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c74d4f357c7ee9e32669bbf58245b4b1b5912141","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                       \"physical interface names to the total bandwidth \""},{"line_number":25,"context_line":"                       \"available on this interface. The total bandwidth \""},{"line_number":26,"context_line":"                       \"could be expressed in bps or in percentage over the \""},{"line_number":27,"context_line":"                       \"physical interface link speed.\")),"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_8784460b","line":27,"in_reply_to":"3a71b18c_47b9552d","updated":"2016-12-06 15:05:10.000000000","message":"Yes, that\u0027s right.\n* If you specify a value, it will override the physical value.\n* If you specify a percentage, it will apply to the physical link speed.\n\nDo you think I need to rewrite the help message?\n\nThanks for your reviews!","commit_id":"6773424c57c595103d7a1451fbc746379b97b065"}]}