)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5b94a5bd375cdb55924262f99e91b42be908c650","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactor ml2_db to pass context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"of usage new enginefacade which expect context to be passed and"},{"line_number":12,"context_line":"session will be injected in current context."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_bfb269e3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":3},"updated":"2016-12-10 18:47:23.000000000","message":"Nit: of the","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"585318d6085aec3ffd349880f2b5bcbfcf8208ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactor ml2_db to pass context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"of usage new enginefacade which expect context to be passed and"},{"line_number":12,"context_line":"session will be injected in current context."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_af2b0681","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":3},"in_reply_to":"3a71b18c_bfb269e3","updated":"2016-12-12 08:04:26.000000000","message":"Done","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5b94a5bd375cdb55924262f99e91b42be908c650","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"of usage new enginefacade which expect context to be passed and"},{"line_number":12,"context_line":"session will be injected in current context."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"NeutronLibImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_1fc27d34","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"updated":"2016-12-10 18:47:23.000000000","message":"Nit: the usage of","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"585318d6085aec3ffd349880f2b5bcbfcf8208ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"of usage new enginefacade which expect context to be passed and"},{"line_number":12,"context_line":"session will be injected in current context."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"NeutronLibImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_cf1cc268","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"in_reply_to":"3a71b18c_1fc27d34","updated":"2016-12-12 08:04:26.000000000","message":"Done","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"624775866c1a40102b75e98b7c55bd4d22b8d55a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor ml2_db to pass context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one of"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"the usage of new enginefacade which expect context to be passed"},{"line_number":12,"context_line":"and session will be injected in current context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_5730d056","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":29},"updated":"2016-12-13 07:10:21.000000000","message":"So we still have such functions. Do we need to fix them?","commit_id":"8855c86ad37244bec8a3df69af11be87a92b8a4d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0677ab0d6b62f7c2389e8cd2a818205bab05b570","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor ml2_db to pass context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one of"},{"line_number":10,"context_line":"the arguments. Passing session is not correct and this prevents"},{"line_number":11,"context_line":"the usage of new enginefacade which expect context to be passed"},{"line_number":12,"context_line":"and session will be injected in current context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_1a8e7d78","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":29},"in_reply_to":"1a6eadb0_5730d056","updated":"2016-12-13 07:23:16.000000000","message":"Yes, we should.","commit_id":"8855c86ad37244bec8a3df69af11be87a92b8a4d"}],"neutron/plugins/ml2/db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6a1205c41a60cedd3d8c82c305aec3bd6942a315","unresolved":false,"context_lines":[{"line_number":38,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def add_port_binding(context, port_id):"},{"line_number":42,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":43,"context_line":"        record \u003d models.PortBinding("},{"line_number":44,"context_line":"            port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_20a2b599","line":41,"updated":"2016-12-11 13:05:22.000000000","message":"could this API change break any of the external drivers?","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"41ecf0584bdec7f6417af43b21930ed899d714a6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def add_port_binding(context, port_id):"},{"line_number":42,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":43,"context_line":"        record \u003d models.PortBinding("},{"line_number":44,"context_line":"            port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_dd363b02","line":41,"in_reply_to":"3a71b18c_20a2b599","updated":"2016-12-12 08:02:32.000000000","message":"I checked usage and propose patches for all affected repos - https://review.openstack.org/#/q/topic:refactor_ml2db also I sent an email to openstack-dev poiniting to this. I hope this should be fine.","commit_id":"5f40b512758efd5728ad1e1f2d6d3e3513e27477"}]}
