)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d4f60eb3c54a86b3888dbaea59b4acc46581124","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New enginefacade for ports and sg groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Usage reader and writer for db operations."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements blueprint: enginefacade-switch"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"fa31d9ce_10fc2871","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"updated":"2017-02-14 14:48:16.000000000","message":"Use","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"61efae93572e2cdb0316b12091e36647bde213c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New enginefacade for ports and sg groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Usage reader and writer for db operations."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially-Implements blueprint: enginefacade-switch"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"fa31d9ce_39664d2a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"in_reply_to":"fa31d9ce_10fc2871","updated":"2017-02-15 11:31:33.000000000","message":"Done","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d638beae75134b2a2b1e577e9f5c3dccc30bed3c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def _generate_mac():"},{"line_number":85,"context_line":"        return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @db_api.context_manager.reader"},{"line_number":88,"context_line":"    def _is_mac_in_use(self, context, network_id, mac_address):"},{"line_number":89,"context_line":"        return bool(context.session.query(models_v2.Port)."},{"line_number":90,"context_line":"                    filter(models_v2.Port.network_id \u003d\u003d network_id)."}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_1b86e5dc","line":87,"updated":"2017-04-03 11:09:49.000000000","message":"why do we need this here?","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7d11ad9814655434c6427e5dfc24e810faa82ae2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def _generate_mac():"},{"line_number":85,"context_line":"        return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @db_api.context_manager.reader"},{"line_number":88,"context_line":"    def _is_mac_in_use(self, context, network_id, mac_address):"},{"line_number":89,"context_line":"        return bool(context.session.query(models_v2.Port)."},{"line_number":90,"context_line":"                    filter(models_v2.Port.network_id \u003d\u003d network_id)."}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_f6947846","line":87,"in_reply_to":"dfeb2761_1b86e5dc","updated":"2017-04-03 11:30:08.000000000","message":"we get data from db","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"05fc7b673b294d0ca088b965234363e344899936","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def _generate_mac():"},{"line_number":85,"context_line":"        return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @db_api.context_manager.reader"},{"line_number":88,"context_line":"    def _is_mac_in_use(self, context, network_id, mac_address):"},{"line_number":89,"context_line":"        return bool(context.session.query(models_v2.Port)."},{"line_number":90,"context_line":"                    filter(models_v2.Port.network_id \u003d\u003d network_id)."}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_c1352cdc","line":87,"in_reply_to":"dfeb2761_f66c7837","updated":"2017-04-03 11:51:00.000000000","message":"Yes, every place need this, only exclusion if it is always called from method covered with reader/writer.\n\nI split changes as a chain of patches, so that each one won\u0027t be too huge. We need to use it now as new engine facade require this and the old one is deprecated.","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8fa2b2a3a08e78945d89eaa7148735ab8726bfdf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def _generate_mac():"},{"line_number":85,"context_line":"        return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @db_api.context_manager.reader"},{"line_number":88,"context_line":"    def _is_mac_in_use(self, context, network_id, mac_address):"},{"line_number":89,"context_line":"        return bool(context.session.query(models_v2.Port)."},{"line_number":90,"context_line":"                    filter(models_v2.Port.network_id \u003d\u003d network_id)."}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_f66c7837","line":87,"in_reply_to":"dfeb2761_f6947846","updated":"2017-04-03 11:36:21.000000000","message":"so every place where we are doing a query fo we need this? this just feels like this is a random place. why now and not before. what am I missing. sorry for the questions. i just would like to understand this better","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d638beae75134b2a2b1e577e9f5c3dccc30bed3c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                context.session.delete(ipal)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    @db_api.context_manager.writer"},{"line_number":112,"context_line":"    def _store_ip_allocation(context, ip_address, network_id, subnet_id,"},{"line_number":113,"context_line":"                             port_id):"},{"line_number":114,"context_line":"        LOG.debug(\"Allocated IP %(ip_address)s \""}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_9b71d50f","line":111,"updated":"2017-04-03 11:09:49.000000000","message":"ditto","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7d11ad9814655434c6427e5dfc24e810faa82ae2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                context.session.delete(ipal)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    @db_api.context_manager.writer"},{"line_number":112,"context_line":"    def _store_ip_allocation(context, ip_address, network_id, subnet_id,"},{"line_number":113,"context_line":"                             port_id):"},{"line_number":114,"context_line":"        LOG.debug(\"Allocated IP %(ip_address)s \""}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_1687dc11","line":111,"in_reply_to":"dfeb2761_9b71d50f","updated":"2017-04-03 11:30:08.000000000","message":"line 126 - add in db","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"50950f87eb98c6c6fc9072074854c11fc2464d5f","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                # conflict, bubble up a retry instead that should bring things"},{"line_number":1265,"context_line":"                # back to sanity."},{"line_number":1266,"context_line":"                raise os_db_exc.RetryRequest(e)"},{"line_number":1267,"context_line":"            result \u003d self._make_port_dict(db_port)"},{"line_number":1268,"context_line":"        return result"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_e1de316c","line":1267,"updated":"2016-12-14 13:37:18.000000000","message":"Why don\u0027t return this result in this line?","commit_id":"6a42341d0aff796bd5e40905669cbdf8f995f8ab"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d37c089e7a9352655eb279e372ee255971429028","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"                # conflict, bubble up a retry instead that should bring things"},{"line_number":1271,"context_line":"                # back to sanity."},{"line_number":1272,"context_line":"                raise os_db_exc.RetryRequest(e)"},{"line_number":1273,"context_line":"            result \u003d self._make_port_dict(db_port)"},{"line_number":1274,"context_line":"        return result"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":1277,"context_line":"    def delete_port(self, context, id):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_b4c22483","line":1274,"range":{"start_line":1273,"start_character":11,"end_line":1274,"end_character":21},"updated":"2017-01-18 12:13:55.000000000","message":"The same comment made in PS7: why don\u0027t return this directly in L1273?","commit_id":"09bca5e6382b56aa1e8049c3738b1450ac98bc2b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e4b3dc1c52dbded61072cb41a4593f0ac4c56be5","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"                # conflict, bubble up a retry instead that should bring things"},{"line_number":1271,"context_line":"                # back to sanity."},{"line_number":1272,"context_line":"                raise os_db_exc.RetryRequest(e)"},{"line_number":1273,"context_line":"            result \u003d self._make_port_dict(db_port)"},{"line_number":1274,"context_line":"        return result"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":1277,"context_line":"    def delete_port(self, context, id):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_340ab48a","line":1274,"range":{"start_line":1273,"start_character":11,"end_line":1274,"end_character":21},"in_reply_to":"7a3c09a3_b4c22483","updated":"2017-01-18 12:18:43.000000000","message":"Done","commit_id":"09bca5e6382b56aa1e8049c3738b1450ac98bc2b"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d4f60eb3c54a86b3888dbaea59b4acc46581124","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                                                   ip_address\u003dip_address,"},{"line_number":428,"context_line":"                                                   subnet_id\u003dsubnet[\u0027id\u0027])"},{"line_number":429,"context_line":"                try:"},{"line_number":430,"context_line":"                    # Do the insertion of each IP allocation entry within"},{"line_number":431,"context_line":"                    # the context of a nested transaction, so that the entry"},{"line_number":432,"context_line":"                    # is rolled back independently of other entries whenever"},{"line_number":433,"context_line":"                    # the corresponding port has been deleted."}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_90e3b8a3","side":"PARENT","line":430,"updated":"2017-02-14 14:48:16.000000000","message":"doesn\u0027t the comment still apply?","commit_id":"c634355201d8ecad523d921fbbd8a817f530d3a9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"61efae93572e2cdb0316b12091e36647bde213c7","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                                                   ip_address\u003dip_address,"},{"line_number":428,"context_line":"                                                   subnet_id\u003dsubnet[\u0027id\u0027])"},{"line_number":429,"context_line":"                try:"},{"line_number":430,"context_line":"                    # Do the insertion of each IP allocation entry within"},{"line_number":431,"context_line":"                    # the context of a nested transaction, so that the entry"},{"line_number":432,"context_line":"                    # is rolled back independently of other entries whenever"},{"line_number":433,"context_line":"                    # the corresponding port has been deleted."}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_53cda02f","side":"PARENT","line":430,"in_reply_to":"fa31d9ce_90e3b8a3","updated":"2017-02-15 11:31:33.000000000","message":"Done","commit_id":"c634355201d8ecad523d921fbbd8a817f530d3a9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d638beae75134b2a2b1e577e9f5c3dccc30bed3c","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                \"Subnet manager doesn\u0027t match subnet. %s !\u003d %s\""},{"line_number":410,"context_line":"                % (subnet[\u0027id\u0027], ipam_subnet.subnet_manager.neutron_id))"},{"line_number":411,"context_line":"        # TODO(ataraday): revisit when https://review.openstack.org/433758/"},{"line_number":412,"context_line":"        # will be available is oslo.db"},{"line_number":413,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":414,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":415,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_bb4ff9bb","line":412,"range":{"start_line":412,"start_character":28,"end_line":412,"end_character":30},"updated":"2017-04-03 11:09:49.000000000","message":"in","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a461f5eb221f7c449e48f31d592c7063312a583b","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                \"Subnet manager doesn\u0027t match subnet. %s !\u003d %s\""},{"line_number":410,"context_line":"                % (subnet[\u0027id\u0027], ipam_subnet.subnet_manager.neutron_id))"},{"line_number":411,"context_line":"        # TODO(ataraday): revisit when https://review.openstack.org/433758/"},{"line_number":412,"context_line":"        # will be available is oslo.db"},{"line_number":413,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":414,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":415,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_5c090393","line":412,"range":{"start_line":412,"start_character":28,"end_line":412,"end_character":30},"in_reply_to":"dfeb2761_bb4ff9bb","updated":"2017-04-03 12:35:23.000000000","message":"please fix this","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3f584a0fe17f05683880c723445b41e37653ea5e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":190,"context_line":"    def delete_security_group(self, context, id):"},{"line_number":191,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [id]}"},{"line_number":192,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":193,"context_line":"            ports \u003d self._get_port_security_group_bindings(context, filters)"},{"line_number":194,"context_line":"            if ports:"},{"line_number":195,"context_line":"                raise ext_sg.SecurityGroupInUse(id\u003did)"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_526e7095","line":192,"range":{"start_line":192,"start_character":36,"end_line":192,"end_character":42},"updated":"2017-04-04 06:30:46.000000000","message":"reader","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c21cb85fdc2eca2ab8a2c353761e5df4f9a77577","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":190,"context_line":"    def delete_security_group(self, context, id):"},{"line_number":191,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [id]}"},{"line_number":192,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":193,"context_line":"            ports \u003d self._get_port_security_group_bindings(context, filters)"},{"line_number":194,"context_line":"            if ports:"},{"line_number":195,"context_line":"                raise ext_sg.SecurityGroupInUse(id\u003did)"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_329acc6d","line":192,"range":{"start_line":192,"start_character":36,"end_line":192,"end_character":42},"in_reply_to":"dfeb2761_526e7095","updated":"2017-04-04 06:38:35.000000000","message":"This is done in that way as we need to get sg in the same session where we going to delete it otherwise it will fail.","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3f584a0fe17f05683880c723445b41e37653ea5e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                \u0027security_group_id\u0027: id,"},{"line_number":204,"context_line":"                \u0027security_group\u0027: sg,"},{"line_number":205,"context_line":"            }"},{"line_number":206,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":207,"context_line":"                                  events.BEFORE_DELETE,"},{"line_number":208,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":209,"context_line":"                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_1206a8cf","line":206,"updated":"2017-04-04 06:30:46.000000000","message":"some callbacks may expect that this is not done within a DB transaction","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3f584a0fe17f05683880c723445b41e37653ea5e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                                  events.BEFORE_DELETE,"},{"line_number":208,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":209,"context_line":"                                  **kwargs)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            # pass security_group_rule_ids to ensure"},{"line_number":212,"context_line":"            # consistency with deleted rules"},{"line_number":213,"context_line":"            kwargs[\u0027security_group_rule_ids\u0027] \u003d [r[\u0027id\u0027] for r in sg.rules]"}],"source_content_type":"text/x-python","patch_set":48,"id":"dfeb2761_b25dbcea","line":210,"updated":"2017-04-04 06:30:46.000000000","message":"with db_api.context_manager.writer.using(context):","commit_id":"3b4ba7dc3ddeb418903e049424fe4c14be40aea5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5d31a770cddc8ca95684436f55e4a5efa1a14aed","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # pass security_group_rule_ids to ensure"},{"line_number":212,"context_line":"        # consistency with deleted rules"},{"line_number":213,"context_line":"        kwargs[\u0027security_group_rule_ids\u0027] \u003d [r[\u0027id\u0027] for r in sg.rules]"},{"line_number":214,"context_line":"        self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":215,"context_line":"                              events.PRECOMMIT_DELETE,"},{"line_number":216,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":217,"context_line":"                              **kwargs)"}],"source_content_type":"text/x-python","patch_set":49,"id":"dfeb2761_18636744","line":214,"updated":"2017-04-04 08:11:26.000000000","message":"this should be inside the context manager that deletes it for callbacks that want to delete things as part of the same transaction.","commit_id":"a6eff3b4d7491f77aba3b4bdcc67c59c6a875f8e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3f3d6a42ac093b927af85fb2e12311c062f90bb5","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # pass security_group_rule_ids to ensure"},{"line_number":212,"context_line":"        # consistency with deleted rules"},{"line_number":213,"context_line":"        kwargs[\u0027security_group_rule_ids\u0027] \u003d [r[\u0027id\u0027] for r in sg.rules]"},{"line_number":214,"context_line":"        self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":215,"context_line":"                              events.PRECOMMIT_DELETE,"},{"line_number":216,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":217,"context_line":"                              **kwargs)"}],"source_content_type":"text/x-python","patch_set":49,"id":"bff0334d_03f810c2","line":214,"in_reply_to":"dfeb2761_18636744","updated":"2017-04-06 06:31:07.000000000","message":"Done","commit_id":"a6eff3b4d7491f77aba3b4bdcc67c59c6a875f8e"}],"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d4f60eb3c54a86b3888dbaea59b4acc46581124","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def release_segment(self, context, segment):"},{"line_number":115,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":116,"context_line":"        with db_api.context_manager.using(context):"},{"line_number":117,"context_line":"            obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":118,"context_line":"                context,"},{"line_number":119,"context_line":"                physical_network\u003dphysical_network)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_f01eb46e","line":116,"updated":"2017-02-14 14:48:16.000000000","message":"should it be reader or writer? Is it a typo? Does it suggest the code is not covered?","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"61efae93572e2cdb0316b12091e36647bde213c7","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def release_segment(self, context, segment):"},{"line_number":115,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":116,"context_line":"        with db_api.context_manager.using(context):"},{"line_number":117,"context_line":"            obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":118,"context_line":"                context,"},{"line_number":119,"context_line":"                physical_network\u003dphysical_network)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_b38c1cdb","line":116,"in_reply_to":"fa31d9ce_f01eb46e","updated":"2017-02-15 11:31:33.000000000","message":"Done","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"}],"neutron/services/revisions/revision_plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d4f60eb3c54a86b3888dbaea59b4acc46581124","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                resource, [self.extend_resource_dict_revision])"},{"line_number":37,"context_line":"        db_api.sqla_listen(se.Session, \u0027before_flush\u0027, self.bump_revisions)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def bump_revisions(self, session, context, instances):"},{"line_number":40,"context_line":"        # bump revision number for any updated objects in the session"},{"line_number":41,"context_line":"        for obj in context.session.dirty:"},{"line_number":42,"context_line":"            if isinstance(obj, standard_attr.HasStandardAttributes):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_ab184d76","line":39,"range":{"start_line":39,"start_character":29,"end_line":39,"end_character":38},"updated":"2017-02-14 14:48:16.000000000","message":"should we kill the argument, while at it? or do you plan to follow up on it? then at least add a TODO.","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"61efae93572e2cdb0316b12091e36647bde213c7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                resource, [self.extend_resource_dict_revision])"},{"line_number":37,"context_line":"        db_api.sqla_listen(se.Session, \u0027before_flush\u0027, self.bump_revisions)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def bump_revisions(self, session, context, instances):"},{"line_number":40,"context_line":"        # bump revision number for any updated objects in the session"},{"line_number":41,"context_line":"        for obj in context.session.dirty:"},{"line_number":42,"context_line":"            if isinstance(obj, standard_attr.HasStandardAttributes):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa31d9ce_7643726c","line":39,"range":{"start_line":39,"start_character":29,"end_line":39,"end_character":38},"in_reply_to":"fa31d9ce_ab184d76","updated":"2017-02-15 11:31:33.000000000","message":"I got crazy, I do not need to change this.","commit_id":"471fc5c19e6b506ecc407e1408c3d0c84da68ff9"}],"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4843159c204d556fe5d3fdfa9087777b20ec5a0c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_handle_expired_object(self):"},{"line_number":53,"context_line":"        rp \u003d directory.get_plugin(\u0027revision_plugin\u0027)"},{"line_number":54,"context_line":"        with self.port():"},{"line_number":55,"context_line":"            from neutron.db import api as db_api"},{"line_number":56,"context_line":"            with db_api.context_manager.writer.using(self.ctx):"},{"line_number":57,"context_line":"                ipal_obj \u003d self.ctx.session.query(models_v2.IPAllocation).one()"},{"line_number":58,"context_line":"                # load port into our session"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a3c09a3_bfcd0e5f","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":48},"updated":"2017-01-16 16:40:15.000000000","message":"Shouldn\u0027t you move this to the import section?","commit_id":"24240fb2a7c29c599a9bbb298ba94e10a800be8b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d37c089e7a9352655eb279e372ee255971429028","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_handle_expired_object(self):"},{"line_number":54,"context_line":"        rp \u003d directory.get_plugin(\u0027revision_plugin\u0027)"},{"line_number":55,"context_line":"        with self.port():"},{"line_number":56,"context_line":"            from neutron.db import api as db_api"},{"line_number":57,"context_line":"            with db_api.context_manager.writer.using(self.ctx):"},{"line_number":58,"context_line":"                ipal_obj \u003d self.ctx.session.query(models_v2.IPAllocation).one()"},{"line_number":59,"context_line":"                # load port into our session"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_d40250b3","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":48},"updated":"2017-01-18 12:13:55.000000000","message":"The same comment made in PS19: you should move this to L22+","commit_id":"09bca5e6382b56aa1e8049c3738b1450ac98bc2b"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e4b3dc1c52dbded61072cb41a4593f0ac4c56be5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_handle_expired_object(self):"},{"line_number":54,"context_line":"        rp \u003d directory.get_plugin(\u0027revision_plugin\u0027)"},{"line_number":55,"context_line":"        with self.port():"},{"line_number":56,"context_line":"            from neutron.db import api as db_api"},{"line_number":57,"context_line":"            with db_api.context_manager.writer.using(self.ctx):"},{"line_number":58,"context_line":"                ipal_obj \u003d self.ctx.session.query(models_v2.IPAllocation).one()"},{"line_number":59,"context_line":"                # load port into our session"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_94a608ac","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":48},"in_reply_to":"7a3c09a3_d40250b3","updated":"2017-01-18 12:18:43.000000000","message":"Done","commit_id":"09bca5e6382b56aa1e8049c3738b1450ac98bc2b"}]}
