)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"71c1bf06a93dc4a43211cfe7841564162ba5015b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t compile OVS kernel modules for functional job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] required"},{"line_number":10,"context_line":"for test_install_flood_to_tun."},{"line_number":11,"context_line":"Current 2.6 branch has issues with ovsdb where connection is getting"},{"line_number":12,"context_line":"lost and job gets stuck."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_e348475e","line":10,"updated":"2016-12-01 15:20:32.000000000","message":"Do you suggest here that the commit is not in kernel modules? If so, then it\u0027s not clear for someone not close to OVS code.","commit_id":"7dc764cbe6f5d3d5be7a8470ad5704f689c58ade"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"464799eb7e5174b24ce47e1c44bff99e0cf5c1d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t compile OVS kernel modules for functional job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] required"},{"line_number":10,"context_line":"for test_install_flood_to_tun."},{"line_number":11,"context_line":"Current 2.6 branch has issues with ovsdb where connection is getting"},{"line_number":12,"context_line":"lost and job gets stuck."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_f7cf1db1","line":10,"in_reply_to":"3a71b18c_e348475e","updated":"2016-12-01 16:35:57.000000000","message":"Right, the fix is in user-space part of openvswitch.","commit_id":"7dc764cbe6f5d3d5be7a8470ad5704f689c58ade"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"71c1bf06a93dc4a43211cfe7841564162ba5015b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] required"},{"line_number":10,"context_line":"for test_install_flood_to_tun."},{"line_number":11,"context_line":"Current 2.6 branch has issues with ovsdb where connection is getting"},{"line_number":12,"context_line":"lost and job gets stuck."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/openvswitch/ovs/commit/56de2148f626d559a199028952fdd13f301ca80a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_c31d0b68","line":11,"updated":"2016-12-01 15:20:32.000000000","message":"You missed the fact that you also downgrade to 2.5.1 for functional tests. Or is this line supposed to communicate it?","commit_id":"7dc764cbe6f5d3d5be7a8470ad5704f689c58ade"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"464799eb7e5174b24ce47e1c44bff99e0cf5c1d9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] required"},{"line_number":10,"context_line":"for test_install_flood_to_tun."},{"line_number":11,"context_line":"Current 2.6 branch has issues with ovsdb where connection is getting"},{"line_number":12,"context_line":"lost and job gets stuck."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/openvswitch/ovs/commit/56de2148f626d559a199028952fdd13f301ca80a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_f2e80b19","line":11,"in_reply_to":"3a71b18c_c31d0b68","updated":"2016-12-01 16:35:57.000000000","message":"Done","commit_id":"7dc764cbe6f5d3d5be7a8470ad5704f689c58ade"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cfc61cb0ac8541a9eb58bf5f2f15d70ed6139bd9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-01 11:28:17 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t compile OVS kernel modules for functional job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] for"},{"line_number":10,"context_line":"user-space part of openvswitch. This patch fixes our"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a71b18c_cd77edd2","line":7,"updated":"2016-12-01 19:23:06.000000000","message":"All this OVS version handling, plus the recent snafus with dnsmasq minimum [1] requirements makes me think that we need to more explicit and formalized way to address bleeding edge feature development.\n\n[1] https://review.openstack.org/#/c/401985/","commit_id":"b0ea7c95a3e08199a5d72a4dbd6ebf8a54296bdf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"671c19ba5fb3086a03fb84bd2bf540d0d68f7f8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-01 11:28:17 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t compile OVS kernel modules for functional job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The only reason we need newer openvswitch is following fix [1] for"},{"line_number":10,"context_line":"user-space part of openvswitch. This patch fixes our"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a71b18c_d0ee84b3","line":7,"in_reply_to":"3a71b18c_cd77edd2","updated":"2016-12-02 08:42:15.000000000","message":"Before we started working on Xenial I optimistically believed we won\u0027t need to compile OVS at all for Xenial :( This is not because we need new version but because Xenial kernel and openvswitch 2.5.0 contain bugs that are failing jobs.","commit_id":"b0ea7c95a3e08199a5d72a4dbd6ebf8a54296bdf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cfc61cb0ac8541a9eb58bf5f2f15d70ed6139bd9","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openvswitch/ovs/commit/56de2148f626d559a199028952fdd13f301ca80a"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Related-bug: bug/1646107"},{"line_number":25,"context_line":"Change-Id: Ic5419afe7170e759749afd7055441c82c317efe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a71b18c_cddb6dec","line":24,"updated":"2016-12-01 19:23:06.000000000","message":"this is not picked up, but it\u0027s harmless.","commit_id":"b0ea7c95a3e08199a5d72a4dbd6ebf8a54296bdf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"671c19ba5fb3086a03fb84bd2bf540d0d68f7f8f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openvswitch/ovs/commit/56de2148f626d559a199028952fdd13f301ca80a"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Related-bug: bug/1646107"},{"line_number":25,"context_line":"Change-Id: Ic5419afe7170e759749afd7055441c82c317efe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a71b18c_10163ca7","line":24,"in_reply_to":"3a71b18c_cddb6dec","updated":"2016-12-02 08:42:15.000000000","message":"Damn, I fixed it in previous PS6 via gerrit UI and then updated commit message locally not fetching latest from gerrit.","commit_id":"b0ea7c95a3e08199a5d72a4dbd6ebf8a54296bdf"}],"devstack/lib/ovs":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9e91f4292257173f01759987bd5d126b862fc522","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    if ! is_ovs_version_ok; then"},{"line_number":97,"context_line":"        if [ \"$NEUTRON_OVERRIDE_OVS_BRANCH\" ]; then"},{"line_number":98,"context_line":"            OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"},{"line_number":99,"context_line":"        elif is_kernel_supported_for_ovs25; then"},{"line_number":100,"context_line":"            # The order of conditions here is such that on Trusty we install"},{"line_number":101,"context_line":"            # version 2.5.1, and on Xenial we upgrade to 2.6.1 (Since Xenial"},{"line_number":102,"context_line":"            # kernel is not compatible with 2.5.1)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a74a57a_695dd6eb","line":99,"range":{"start_line":99,"start_character":13,"end_line":99,"end_character":42},"updated":"2016-11-30 15:51:40.000000000","message":"This might be required only if compile_modules is set","commit_id":"391223f499e7a132b945cf2dbd1837a406a9e7d1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8bcd23d370c3d044670bf020c5eaef558377bb81","unresolved":false,"context_lines":[{"line_number":92,"context_line":"#                              Accepts one parameter for kernel modules compilation:"},{"line_number":93,"context_line":"#                                 - if True is passed, OVS is compiled with kernel modules"},{"line_number":94,"context_line":"function upgrade_ovs_if_necessary {"},{"line_number":95,"context_line":"    local compile_modules\u003d$1"},{"line_number":96,"context_line":"    if ! is_ovs_version_ok; then"},{"line_number":97,"context_line":"        if [ \"$NEUTRON_OVERRIDE_OVS_BRANCH\" ]; then"},{"line_number":98,"context_line":"            OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a71b18c_caa0cca8","line":95,"updated":"2016-12-01 11:50:43.000000000","message":"nit: Maybe give this a default value?","commit_id":"7c8406f4a3891e1c16570a7b009a813f0fcac0be"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"93c04a605115f20e102c82b4da64e691621d4eb6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"#                              Accepts one parameter for kernel modules compilation:"},{"line_number":93,"context_line":"#                                 - if True is passed, OVS is compiled with kernel modules"},{"line_number":94,"context_line":"function upgrade_ovs_if_necessary {"},{"line_number":95,"context_line":"    local compile_modules\u003d$1"},{"line_number":96,"context_line":"    if ! is_ovs_version_ok; then"},{"line_number":97,"context_line":"        if [ \"$NEUTRON_OVERRIDE_OVS_BRANCH\" ]; then"},{"line_number":98,"context_line":"            OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a71b18c_46b594cb","line":95,"in_reply_to":"3a71b18c_caa0cca8","updated":"2016-12-01 12:51:53.000000000","message":"Done","commit_id":"7c8406f4a3891e1c16570a7b009a813f0fcac0be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8c1a34aae7c1027b9aba17907b4e2ecce4d29301","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# compile_ovs() - Compile OVS from source and load needed modules."},{"line_number":117,"context_line":"#                 Accepts two parameters:"},{"line_number":118,"context_line":"#                   - first one is True, modules are built and installed."},{"line_number":119,"context_line":"#                   - second optional parameter defines prefix for ovs compilation"},{"line_number":120,"context_line":"#                   - third optional parameter defines localstatedir for ovs single machine runtime"},{"line_number":121,"context_line":"#                 Env variables OVS_REPO_NAME, OVS_REPO and OVS_BRANCH must be set"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a71b18c_eaa588b5","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":39},"updated":"2016-12-01 11:48:21.000000000","message":"If first one is True?","commit_id":"7c8406f4a3891e1c16570a7b009a813f0fcac0be"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"93c04a605115f20e102c82b4da64e691621d4eb6","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# compile_ovs() - Compile OVS from source and load needed modules."},{"line_number":117,"context_line":"#                 Accepts two parameters:"},{"line_number":118,"context_line":"#                   - first one is True, modules are built and installed."},{"line_number":119,"context_line":"#                   - second optional parameter defines prefix for ovs compilation"},{"line_number":120,"context_line":"#                   - third optional parameter defines localstatedir for ovs single machine runtime"},{"line_number":121,"context_line":"#                 Env variables OVS_REPO_NAME, OVS_REPO and OVS_BRANCH must be set"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a71b18c_66ca9051","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":39},"in_reply_to":"3a71b18c_eaa588b5","updated":"2016-12-01 12:51:53.000000000","message":"Done","commit_id":"7c8406f4a3891e1c16570a7b009a813f0fcac0be"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"214e2c3cd7fe30337f7b382e473747507d369654","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    configure_host_for_func_testing"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Kernel modules are not needed for functional job. They are needed only"},{"line_number":48,"context_line":"    # for fullstack because of bug present in Ubuntu Xenial kernel version"},{"line_number":49,"context_line":"    # that makes VXLAN local tunneling fail."},{"line_number":50,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-functional\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3a71b18c_5eb7f738","line":47,"updated":"2016-12-02 01:02:44.000000000","message":"Better to say \"2.6.1 is broken for functional job\".","commit_id":"b0ea7c95a3e08199a5d72a4dbd6ebf8a54296bdf"}]}