)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"543d3ca9cdfec52acbba65961dac82d81d6d5576","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a function to check the default_prefixlen, when create or"},{"line_number":10,"context_line":"update a subnetpool, if it is larger than network prefixlen."},{"line_number":11,"context_line":"Otherwise, tt will be failed to allocate a subnet, When using"},{"line_number":12,"context_line":"it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I051b8d65c8901df500bbd8fde8775620313a7a92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_43c45791","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":13},"updated":"2016-12-01 07:35:46.000000000","message":"it","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0462a60a4605158a293ef27877cd4747e352239f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a function to check the default_prefixlen, when create or"},{"line_number":10,"context_line":"update a subnetpool, if it is larger than network prefixlen."},{"line_number":11,"context_line":"Otherwise, tt will be failed to allocate a subnet, When using"},{"line_number":12,"context_line":"it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I051b8d65c8901df500bbd8fde8775620313a7a92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_618121c3","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":13},"updated":"2016-12-05 08:17:50.000000000","message":"typo","commit_id":"2b2c537d57eaca0e13ed483127c985c1db8c9210"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"27c5ba00422fef4474ed452be6cf585a21392b87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajiv Kumar \u003crajiv.kumar@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-14 08:47:22 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check the default_prefixlen, When create or update a subnetpool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a function to check the default_prefixlen, when create or"},{"line_number":10,"context_line":"update a subnetpool, if it is larger than network prefixlen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_ddfb99bf","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":63},"updated":"2017-02-14 09:13:52.000000000","message":"too long, \n\nCheck default_prefixlen on subnetpool create/update","commit_id":"0c00c8cf206f92478512709ec0ad5919fe3fa212"}],"neutron/common/exceptions.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"461cc9e5387abaf430642fdd25f32b2554b434ac","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class IllegalSubnetPoolDefaultPrefixlen(e.BadRequest):"},{"line_number":271,"context_line":"    message \u003d _(\"Illegal subnetpool default prefixlen: %(reason)s.\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class IllegalSubnetPoolUpdate(e.BadRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_97b9a6ef","line":271,"range":{"start_line":271,"start_character":17,"end_line":271,"end_character":52},"updated":"2016-12-01 08:03:10.000000000","message":"you do not need this message. The message raised by the exception in https://review.openstack.org/#/c/405131/1/neutron/db/db_base_plugin_v2.py Lin#976 seems to be sufficient.\nOr else change the reason there so that the same information does not seem repeated","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"543d3ca9cdfec52acbba65961dac82d81d6d5576","unresolved":false,"context_lines":[{"line_number":968,"context_line":"                self._get_subnets_by_network(context, network_id)]"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def _validate_default_prefixlen(self, context, default_prefixlen,"},{"line_number":971,"context_line":"\t\t\t\t    prefixes):"},{"line_number":972,"context_line":"\t\"\"\"Check if the subnetpool can be allocated by the default prefixlen\"\"\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"\tfor prefix in prefixes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_a3b44b35","line":971,"range":{"start_line":971,"start_character":0,"end_line":971,"end_character":8},"updated":"2016-12-01 07:35:46.000000000","message":"Use space not tab.","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"461cc9e5387abaf430642fdd25f32b2554b434ac","unresolved":false,"context_lines":[{"line_number":968,"context_line":"                self._get_subnets_by_network(context, network_id)]"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def _validate_default_prefixlen(self, context, default_prefixlen,"},{"line_number":971,"context_line":"\t\t\t\t    prefixes):"},{"line_number":972,"context_line":"\t\"\"\"Check if the subnetpool can be allocated by the default prefixlen\"\"\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"\tfor prefix in prefixes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_57038eb8","line":971,"range":{"start_line":971,"start_character":0,"end_line":971,"end_character":8},"in_reply_to":"5a74a57a_a3b44b35","updated":"2016-12-01 08:03:10.000000000","message":"+1","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"461cc9e5387abaf430642fdd25f32b2554b434ac","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def _validate_default_prefixlen(self, context, default_prefixlen,"},{"line_number":971,"context_line":"\t\t\t\t    prefixes):"},{"line_number":972,"context_line":"\t\"\"\"Check if the subnetpool can be allocated by the default prefixlen\"\"\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"\tfor prefix in prefixes:"},{"line_number":975,"context_line":"\t    if default_prefixlen \u003c prefix.prefixlen:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_371d3210","line":972,"range":{"start_line":972,"start_character":45,"end_line":972,"end_character":47},"updated":"2016-12-01 08:03:10.000000000","message":"by -\u003e with","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"461cc9e5387abaf430642fdd25f32b2554b434ac","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":1058,"context_line":"                                                  sp_reader.ip_version)"},{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":"\tself._validate_default_prefixlen(context, sp_reader.default_prefixlen,"},{"line_number":1061,"context_line":"                                         sp_reader.prefixes)"},{"line_number":1062,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1063,"context_line":"                                        id, sp_reader.prefixes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d7aa3e85","line":1060,"updated":"2016-12-01 08:03:10.000000000","message":"tab spacing!","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"461cc9e5387abaf430642fdd25f32b2554b434ac","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"                self._check_subnetpool_update_allowed(context, id,"},{"line_number":1097,"context_line":"                                                      orig_sp.address_scope_id)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"\t    self._validate_default_prefixlen(context, reader.default_prefixlen,"},{"line_number":1100,"context_line":"                                             reader.prefixes)"},{"line_number":1101,"context_line":"            self._validate_address_scope_id(context, reader.address_scope_id,"},{"line_number":1102,"context_line":"                                            id, reader.prefixes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_37929258","line":1099,"updated":"2016-12-01 08:03:10.000000000","message":"tab spacing should be replaced with spaces","commit_id":"16a7f3a5c667da092db34dadc936c09a37e7cca3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0bfa3e91d81d8bf5c4bc66136a2a87e874c43a00","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"        for prefix in prefixes:"},{"line_number":977,"context_line":"            if default_prefixlen \u003c prefix.prefixlen:"},{"line_number":978,"context_line":"                msg \u003d _(\"/%s\")"},{"line_number":979,"context_line":"                raise n_exc.IllegalSubnetPoolDefaultPrefixlen("},{"line_number":980,"context_line":"                    reason\u003dmsg % str(default_prefixlen))"},{"line_number":981,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_7b3cba93","line":978,"range":{"start_line":978,"start_character":16,"end_line":978,"end_character":30},"updated":"2016-12-02 05:51:52.000000000","message":"Users cannot understand intention of this massage. Please set proper massage.","commit_id":"61b02f7395852323805874e1ac4895adad82e320"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1dc04ff9bcd581153d39f77009dce8ce1ba184e1","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        for prefix in prefixes:"},{"line_number":977,"context_line":"            if default_prefixlen \u003c prefix.prefixlen:"},{"line_number":978,"context_line":"                msg \u003d _(\"Illegal subnetpool default prefixlen /%s\")"},{"line_number":979,"context_line":"                raise n_exc.SubnetPoolCreateError("},{"line_number":980,"context_line":"                    reason\u003dmsg % str(default_prefixlen))"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"    def _validate_address_scope_id(self, context, address_scope_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_41cee52e","line":979,"updated":"2016-12-05 08:18:55.000000000","message":"this is also called when updating - so the exception here should maybe be changed","commit_id":"2b2c537d57eaca0e13ed483127c985c1db8c9210"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"27c5ba00422fef4474ed452be6cf585a21392b87","unresolved":false,"context_lines":[{"line_number":986,"context_line":"        for prefix in prefixes:"},{"line_number":987,"context_line":"            if default_prefixlen \u003c prefix.prefixlen:"},{"line_number":988,"context_line":"                msg \u003d _(\"Illegal subnetpool default prefixlen /%s\")"},{"line_number":989,"context_line":"                raise n_exc.SubnetPoolCreateError("},{"line_number":990,"context_line":"                    reason\u003dmsg % str(default_prefixlen))"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    def _validate_address_scope_id(self, context, address_scope_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_9df12104","line":989,"range":{"start_line":989,"start_character":28,"end_line":989,"end_character":49},"updated":"2017-02-14 09:13:52.000000000","message":"Please refer garyk\u0027s comment in PS#4","commit_id":"0c00c8cf206f92478512709ec0ad5919fe3fa212"}]}
