)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f7c041fcef050b1b84d71248a13d766eadb8b4aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"driver that would make it update MTU on existing ports."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":"The change adds a new abstract method to base interface driver class,"},{"line_number":25,"context_line":"which will break all 3party interface drivers. The easiest way to fix"},{"line_number":26,"context_line":"such a breakage is proposing an empty implementation for set_mtu."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_01643647","line":24,"updated":"2016-12-13 18:10:54.000000000","message":"+1. Warning is good","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e111a1acb7fbc16ccaa83d78060afafdab06f3a0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"driver that would make it update MTU on existing ports."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":"The change adds a new abstract method to base interface driver class,"},{"line_number":25,"context_line":"which will break all 3party interface drivers. The easiest way to fix"},{"line_number":26,"context_line":"such a breakage is proposing an empty implementation for set_mtu."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_1b13c367","line":24,"updated":"2016-12-13 17:31:41.000000000","message":"An alternative would be making it non abstract, and providing a default implementation that would warn, as we do for IVS.","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"19e83327b230d153638af900508872f4c7bcafe6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"driver that would make it update MTU on existing ports."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":"The change adds a new abstract method to base interface driver class,"},{"line_number":25,"context_line":"which will break all 3party interface drivers. The easiest way to fix"},{"line_number":26,"context_line":"such a breakage is proposing an empty implementation for set_mtu."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_4ebb9727","line":24,"in_reply_to":"1a6eadb0_01643647","updated":"2016-12-14 12:54:54.000000000","message":"Done","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f7c041fcef050b1b84d71248a13d766eadb8b4aa","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        ns_dev.link.set_mtu(mtu)"},{"line_number":403,"context_line":"        if self.conf.ovs_use_veth:"},{"line_number":404,"context_line":"            root_dev.link.set_mtu(mtu)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"class IVSInterfaceDriver(LinuxInterfaceDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_215bf288","line":404,"updated":"2016-12-13 18:10:54.000000000","message":"can you just move this after L398 to avoid the extra conditional? Based on the ordering in the BridgeInterfaceDriver, it doesn\u0027t matter which one goes first.","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"19e83327b230d153638af900508872f4c7bcafe6","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        ns_dev.link.set_mtu(mtu)"},{"line_number":403,"context_line":"        if self.conf.ovs_use_veth:"},{"line_number":404,"context_line":"            root_dev.link.set_mtu(mtu)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"class IVSInterfaceDriver(LinuxInterfaceDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_0e98bfbf","line":404,"in_reply_to":"1a6eadb0_215bf288","updated":"2016-12-14 12:54:54.000000000","message":"Done","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"49daa854aaa2e34ed44083ace546fde6eb08a1cd","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                self.set_mtu("},{"line_number":253,"context_line":"                    device_name, mtu, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":254,"context_line":"            else:"},{"line_number":255,"context_line":"                LOG.warning(_LW(\"No MTU configured for port %s\"), port_id)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @abc.abstractmethod"},{"line_number":258,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_06903594","line":255,"updated":"2016-12-16 11:17:47.000000000","message":"I guess plug requests with no mtu will be the uncommon case, right?, otherwise we\u0027ll have lots of warnings.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"249fb9fb7947392f789a9a58f2c2c4be14118ad5","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                self.set_mtu("},{"line_number":253,"context_line":"                    device_name, mtu, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":254,"context_line":"            else:"},{"line_number":255,"context_line":"                LOG.warning(_LW(\"No MTU configured for port %s\"), port_id)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @abc.abstractmethod"},{"line_number":258,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_3c77fea0","line":255,"in_reply_to":"1a6eadb0_06903594","updated":"2016-12-16 11:38:14.000000000","message":"It\u0027s the same as we do when plugging each port if correct MTU is not passed. At this point where we calculate MTU from configuration options on each network fetch, it\u0027s probably a huge screw-up of the setup that would result in those messages, so I think it\u0027s fair.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ce7ca071a45ff026a66ed8649a064daadaceedc4","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                self.set_mtu("},{"line_number":253,"context_line":"                    device_name, mtu, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":254,"context_line":"            else:"},{"line_number":255,"context_line":"                LOG.warning(_LW(\"No MTU configured for port %s\"), port_id)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @abc.abstractmethod"},{"line_number":258,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_d066ebeb","line":255,"in_reply_to":"1a6eadb0_3c77fea0","updated":"2016-12-16 12:57:46.000000000","message":"Makes sense then :)","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"}],"neutron/tests/functional/agent/linux/test_interface.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25e93461938335aa78b510121688425e078259a5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            ip_lib.IPDevice(device_name, namespace\u003dnamespace).link.mtu"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_plug_multiple_calls_update_mtu(self):"},{"line_number":97,"context_line":"        ovs_bridge \u003d self.useFixture(net_helpers.OVSBridgeFixture()).bridge"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        device_name \u003d utils.get_rand_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_fe027508","line":96,"updated":"2016-12-13 17:32:23.000000000","message":"there is maybe some place for code reuse; I need to think","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"19e83327b230d153638af900508872f4c7bcafe6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            ip_lib.IPDevice(device_name, namespace\u003dnamespace).link.mtu"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_plug_multiple_calls_update_mtu(self):"},{"line_number":97,"context_line":"        ovs_bridge \u003d self.useFixture(net_helpers.OVSBridgeFixture()).bridge"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        device_name \u003d utils.get_rand_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_dc24b8b0","line":96,"in_reply_to":"1a6eadb0_fe027508","updated":"2016-12-14 12:54:54.000000000","message":"Done","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f7c041fcef050b1b84d71248a13d766eadb8b4aa","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        _plug_and_check_mtu(1450)"},{"line_number":117,"context_line":"        _plug_and_check_mtu(1500)"},{"line_number":118,"context_line":"        _plug_and_check_mtu(9000)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_set_mtu(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_e1601a38","line":117,"updated":"2016-12-13 18:10:54.000000000","message":"maybe repeat one value just for the fun of it","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"19e83327b230d153638af900508872f4c7bcafe6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        _plug_and_check_mtu(1450)"},{"line_number":117,"context_line":"        _plug_and_check_mtu(1500)"},{"line_number":118,"context_line":"        _plug_and_check_mtu(9000)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_set_mtu(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_6e1773ed","line":117,"in_reply_to":"1a6eadb0_e1601a38","updated":"2016-12-14 12:54:54.000000000","message":"Done","commit_id":"9bf7400ed6020429ddbd52801d789519b61571fd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6046f59b771a57e7891381caddd66ccb76d3262d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            mac_address\u003dmac_address,"},{"line_number":41,"context_line":"            bridge\u003dself.bridge_name,"},{"line_number":42,"context_line":"            namespace\u003dnamespace)"},{"line_number":43,"context_line":"        plug(mtu\u003d1500)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_cc92e1f5","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":22},"updated":"2016-12-16 11:08:31.000000000","message":"Nit: Can this be squashed with previous line. Calling partial object with keyword argument overrides the defaults.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ce7ca071a45ff026a66ed8649a064daadaceedc4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            mac_address\u003dmac_address,"},{"line_number":41,"context_line":"            bridge\u003dself.bridge_name,"},{"line_number":42,"context_line":"            namespace\u003dnamespace)"},{"line_number":43,"context_line":"        plug(mtu\u003d1500)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_50649bb7","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":22},"in_reply_to":"1a6eadb0_3ad37e61","updated":"2016-12-16 12:57:46.000000000","message":"I mean that he used plug again later, but I\u0027m probably missing what you mean too :)","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"033b37e5e2f5f65459cc9a1119f8bf03f91da031","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            mac_address\u003dmac_address,"},{"line_number":41,"context_line":"            bridge\u003dself.bridge_name,"},{"line_number":42,"context_line":"            namespace\u003dnamespace)"},{"line_number":43,"context_line":"        plug(mtu\u003d1500)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_3ad37e61","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":22},"in_reply_to":"1a6eadb0_5ca11af7","updated":"2016-12-16 12:21:23.000000000","message":"No, mtu is always keyword argument on L51 so it would be overridden on L47. Or maybe I just don\u0027t see it :) Anyway, no need for change, I just wanted to point it out.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"249fb9fb7947392f789a9a58f2c2c4be14118ad5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            mac_address\u003dmac_address,"},{"line_number":41,"context_line":"            bridge\u003dself.bridge_name,"},{"line_number":42,"context_line":"            namespace\u003dnamespace)"},{"line_number":43,"context_line":"        plug(mtu\u003d1500)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_5ca11af7","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":22},"in_reply_to":"1a6eadb0_89f29604","updated":"2016-12-16 11:38:14.000000000","message":"Right, I need it later to define default action","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"49daa854aaa2e34ed44083ace546fde6eb08a1cd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            mac_address\u003dmac_address,"},{"line_number":41,"context_line":"            bridge\u003dself.bridge_name,"},{"line_number":42,"context_line":"            namespace\u003dnamespace)"},{"line_number":43,"context_line":"        plug(mtu\u003d1500)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_89f29604","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":22},"in_reply_to":"1a6eadb0_cc92e1f5","updated":"2016-12-16 11:17:47.000000000","message":"He uses it down again in L47","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6046f59b771a57e7891381caddd66ccb76d3262d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"},{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_cc2e61a4","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":77},"updated":"2016-12-16 11:08:31.000000000","message":"What does this validate? That interface won\u0027t disappear after calling plug twice?","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ec160e7a928cf311c0b450ade979b7344d9f27e0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"},{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_bab30e97","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":77},"in_reply_to":"1a6eadb0_1ad6c2f0","updated":"2016-12-16 12:28:14.000000000","message":"That would cope the old code. But I\u0027m fine with leaving it here as device existence is tested on L113","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"033b37e5e2f5f65459cc9a1119f8bf03f91da031","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"},{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_7a0ed6e5","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":77},"in_reply_to":"1a6eadb0_5c883a71","updated":"2016-12-16 12:21:23.000000000","message":"I understand that old-style validated that the first plug created the actual interface. Here you\u0027ve already called plug on L43.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bbc58f2119ca79fd028622ae54f7ff07299636d2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"},{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_1ad6c2f0","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":77},"in_reply_to":"1a6eadb0_7a0ed6e5","updated":"2016-12-16 12:23:41.000000000","message":"You suggest to move the check to line 44?","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"249fb9fb7947392f789a9a58f2c2c4be14118ad5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if action is None:"},{"line_number":46,"context_line":"            def action(*args, **kwargs):"},{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_5c883a71","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":77},"in_reply_to":"1a6eadb0_cc2e61a4","updated":"2016-12-16 11:38:14.000000000","message":"It\u0027s from line 89 of the old side, I thought it\u0027s better to keep it for that other test.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6046f59b771a57e7891381caddd66ccb76d3262d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"},{"line_number":52,"context_line":"            self.assertEqual("},{"line_number":53,"context_line":"                mtu,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_1729428a","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":35},"updated":"2016-12-16 11:08:31.000000000","message":"Did you make this function just in sake of readability? You could just move the block of code below to the \"for\" block.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"49daa854aaa2e34ed44083ace546fde6eb08a1cd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"},{"line_number":52,"context_line":"            self.assertEqual("},{"line_number":53,"context_line":"                mtu,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_e9f78ad0","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":35},"in_reply_to":"1a6eadb0_1729428a","updated":"2016-12-16 11:17:47.000000000","message":"I like readability :D, which can be exchanged for a comment, I\u0027m fine with both approaches.","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"249fb9fb7947392f789a9a58f2c2c4be14118ad5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"},{"line_number":52,"context_line":"            self.assertEqual("},{"line_number":53,"context_line":"                mtu,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_7cf25607","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":35},"in_reply_to":"1a6eadb0_1729428a","updated":"2016-12-16 11:38:14.000000000","message":"Yeah, its name hopefully explains the intent","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"033b37e5e2f5f65459cc9a1119f8bf03f91da031","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                plug(*args, **kwargs)"},{"line_number":48,"context_line":"                self.assertTrue(ip_lib.device_exists(device_name, namespace))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def _check_mtu_after_action(mtu):"},{"line_number":51,"context_line":"            action(mtu\u003dmtu)"},{"line_number":52,"context_line":"            self.assertEqual("},{"line_number":53,"context_line":"                mtu,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_bafceeb8","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":35},"in_reply_to":"1a6eadb0_7cf25607","updated":"2016-12-16 12:21:23.000000000","message":"K :)","commit_id":"f49212eede29f63184bac5fb488bbf47884937f1"}]}