)]}'
{"neutron/plugins/ml2/driver_api.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6b439bcf509eb2b0ddfe041cf6c3f37ca3daa641","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        pass"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    def check_port_rebind(self, context):"},{"line_number":902,"context_line":"        \"\"\"Check if the port should be rebound when binding:profile updated"},{"line_number":903,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":904,"context_line":"        The contents of binding:profile can influence the outcome of ML2\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1aa61253","line":901,"range":{"start_line":901,"start_character":8,"end_line":901,"end_character":25},"updated":"2016-12-05 09:38:54.000000000","message":"nit: check_port_rebind_needed would be more clear","commit_id":"fee312a8d63b7169e4ade3c6fa1708d994df34eb"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6b439bcf509eb2b0ddfe041cf6c3f37ca3daa641","unresolved":false,"context_lines":[{"line_number":866,"context_line":"        return True"},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"    def check_port_rebind(self, context):"},{"line_number":869,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":870,"context_line":"            if driver.obj.check_port_rebind(context):"},{"line_number":871,"context_line":"                return True"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        return False"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    def get_workers(self):"},{"line_number":876,"context_line":"        workers \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_757ab778","line":873,"range":{"start_line":869,"start_character":8,"end_line":873,"end_character":20},"updated":"2016-12-05 09:38:54.000000000","message":"If no driver defines check_port_rebind() this will return False which means no rebind needed, which is not bw compatible. Please correct me if I\u0027m wrong","commit_id":"fee312a8d63b7169e4ade3c6fa1708d994df34eb"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6b439bcf509eb2b0ddfe041cf6c3f37ca3daa641","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                msg \u003d _(\"binding:profile value too large\")"},{"line_number":326,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":327,"context_line":"            changes \u003d changes or self.mechanism_manager.check_port_rebind("},{"line_number":328,"context_line":"                      mech_context)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        # Unbind the port if needed."},{"line_number":331,"context_line":"        if changes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_fa4cf6c9","line":328,"range":{"start_line":328,"start_character":22,"end_line":328,"end_character":34},"updated":"2016-12-05 09:38:54.000000000","message":"is this enough for a mech driver to decide? Seems it should have info on new binding profile, just wanted to make sure.","commit_id":"fee312a8d63b7169e4ade3c6fa1708d994df34eb"}]}
