)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"858c81f4269ff47d9483e482ee4dcb0111a0bad8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     AKamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-07 14:14:29 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change passing session to context in segments db functions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a number of functions that expect to get session as one"},{"line_number":10,"context_line":"of the arguments. Passing session is not correct and this prevents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_b4613514","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"updated":"2016-12-07 15:41:42.000000000","message":"nit: the title exceeds the maximum number of characters allowed [1]\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"bf05ea69588d0228086af08b09f297d53cc7e671"}],"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":"        if network[\u0027router:external\u0027]:"},{"line_number":308,"context_line":"            return True"},{"line_number":309,"context_line":"        segments \u003d segments_db.get_network_segments(context,"},{"line_number":310,"context_line":"                                                    network[\u0027id\u0027])"},{"line_number":311,"context_line":"        if len(segments) \u003e 1:"},{"line_number":312,"context_line":"            return False"},{"line_number":313,"context_line":"        provider_net \u003d segments[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_880b727c","line":310,"range":{"start_line":309,"start_character":8,"end_line":310,"end_character":66},"updated":"2016-12-06 17:37:53.000000000","message":"nit: now these lines can be combined\n\n    segments \u003d segments_db.get_network_segments(context, network[\u0027id\u0027])","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":"        if network[\u0027router:external\u0027]:"},{"line_number":308,"context_line":"            return True"},{"line_number":309,"context_line":"        segments \u003d segments_db.get_network_segments(context,"},{"line_number":310,"context_line":"                                                    network[\u0027id\u0027])"},{"line_number":311,"context_line":"        if len(segments) \u003e 1:"},{"line_number":312,"context_line":"            return False"},{"line_number":313,"context_line":"        provider_net \u003d segments[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_22441948","line":310,"range":{"start_line":309,"start_character":8,"end_line":310,"end_character":66},"in_reply_to":"3a71b18c_880b727c","updated":"2016-12-07 10:14:44.000000000","message":"Done","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        raise exc.NoNetworkAvailable()"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def release_network_segments(self, context, network_id):"},{"line_number":280,"context_line":"        segments \u003d segments_db.get_network_segments(context.session,"},{"line_number":281,"context_line":"                                                    network_id,"},{"line_number":282,"context_line":"                                                    filter_dynamic\u003dNone)"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_889e1205","line":280,"range":{"start_line":280,"start_character":52,"end_line":280,"end_character":67},"updated":"2016-12-06 17:37:53.000000000","message":"shouldn\u0027t be changed this method as well?","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        raise exc.NoNetworkAvailable()"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def release_network_segments(self, context, network_id):"},{"line_number":280,"context_line":"        segments \u003d segments_db.get_network_segments(context.session,"},{"line_number":281,"context_line":"                                                    network_id,"},{"line_number":282,"context_line":"                                                    filter_dynamic\u003dNone)"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_df6c1ed2","line":280,"range":{"start_line":280,"start_character":52,"end_line":280,"end_character":67},"in_reply_to":"3a71b18c_889e1205","updated":"2016-12-07 10:14:44.000000000","message":"Yes, thanks!","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"    def filter_hosts_with_network_access("},{"line_number":1844,"context_line":"            self, context, network_id, candidate_hosts):"},{"line_number":1845,"context_line":"        segments \u003d segments_db.get_network_segments(context,"},{"line_number":1846,"context_line":"                                                    network_id)"},{"line_number":1847,"context_line":"        return self.mechanism_manager.filter_hosts_with_segment_access("},{"line_number":1848,"context_line":"            context, segments, candidate_hosts, self.get_agents)"},{"line_number":1849,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9b281a35","line":1846,"range":{"start_line":1845,"start_character":0,"end_line":1846,"end_character":63},"updated":"2016-12-06 17:37:53.000000000","message":"nit: those lines can be combined","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"    def filter_hosts_with_network_access("},{"line_number":1844,"context_line":"            self, context, network_id, candidate_hosts):"},{"line_number":1845,"context_line":"        segments \u003d segments_db.get_network_segments(context,"},{"line_number":1846,"context_line":"                                                    network_id)"},{"line_number":1847,"context_line":"        return self.mechanism_manager.filter_hosts_with_segment_access("},{"line_number":1848,"context_line":"            context, segments, candidate_hosts, self.get_agents)"},{"line_number":1849,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_62e61145","line":1846,"range":{"start_line":1845,"start_character":0,"end_line":1846,"end_character":63},"in_reply_to":"3a71b18c_9b281a35","updated":"2016-12-07 10:14:44.000000000","message":"Done","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                              network_id\u003dnetwork[\u0027id\u0027],"},{"line_number":276,"context_line":"                              segmentation_id\u003d200)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        network_segments \u003d segments_db.get_network_segments(cxt,"},{"line_number":279,"context_line":"                                                            network[\u0027id\u0027])"},{"line_number":280,"context_line":"        self.assertEqual([], network_segments)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_create_segments_in_certain_order(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_db24520e","line":279,"range":{"start_line":278,"start_character":8,"end_line":279,"end_character":74},"updated":"2016-12-06 17:37:53.000000000","message":"nit: those lines can be combined","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                              network_id\u003dnetwork[\u0027id\u0027],"},{"line_number":276,"context_line":"                              segmentation_id\u003d200)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        network_segments \u003d segments_db.get_network_segments(cxt,"},{"line_number":279,"context_line":"                                                            network[\u0027id\u0027])"},{"line_number":280,"context_line":"        self.assertEqual([], network_segments)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_create_segments_in_certain_order(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_22fc19b7","line":279,"range":{"start_line":278,"start_character":8,"end_line":279,"end_character":74},"in_reply_to":"3a71b18c_db24520e","updated":"2016-12-07 10:14:44.000000000","message":"Done","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                network_id\u003dnetwork[\u0027id\u0027], segmentation_id\u003d201)"},{"line_number":290,"context_line":"            segment3 \u003d self.segment("},{"line_number":291,"context_line":"                network_id\u003dnetwork[\u0027id\u0027], segmentation_id\u003d202)"},{"line_number":292,"context_line":"            network_segments \u003d segments_db.get_network_segments(cxt,"},{"line_number":293,"context_line":"                                                                network[\u0027id\u0027])"},{"line_number":294,"context_line":"            self.assertEqual(segment1[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":295,"context_line":"                             network_segments[0][\u0027id\u0027])"},{"line_number":296,"context_line":"            self.assertEqual(segment2[\u0027segment\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_1b1b2acb","line":293,"range":{"start_line":292,"start_character":12,"end_line":293,"end_character":78},"updated":"2016-12-06 17:37:53.000000000","message":"ditto: line 279","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                network_id\u003dnetwork[\u0027id\u0027], segmentation_id\u003d201)"},{"line_number":290,"context_line":"            segment3 \u003d self.segment("},{"line_number":291,"context_line":"                network_id\u003dnetwork[\u0027id\u0027], segmentation_id\u003d202)"},{"line_number":292,"context_line":"            network_segments \u003d segments_db.get_network_segments(cxt,"},{"line_number":293,"context_line":"                                                                network[\u0027id\u0027])"},{"line_number":294,"context_line":"            self.assertEqual(segment1[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":295,"context_line":"                             network_segments[0][\u0027id\u0027])"},{"line_number":296,"context_line":"            self.assertEqual(segment2[\u0027segment\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a20749c8","line":293,"range":{"start_line":292,"start_character":12,"end_line":293,"end_character":78},"in_reply_to":"3a71b18c_1b1b2acb","updated":"2016-12-07 10:14:44.000000000","message":"This one cannot :P","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ce019b4f001b32ce2a53f60c66ad5bc25ad182e","unresolved":false,"context_lines":[{"line_number":2670,"context_line":"        with self.network() as network:"},{"line_number":2671,"context_line":"            network \u003d network[\u0027network\u0027]"},{"line_number":2672,"context_line":""},{"line_number":2673,"context_line":"        for stale_seg in segments_db.get_network_segments(self.context,"},{"line_number":2674,"context_line":"                                                          network[\u0027id\u0027]):"},{"line_number":2675,"context_line":"            segments_db.delete_network_segment(self.context,"},{"line_number":2676,"context_line":"                                               stale_seg[\u0027id\u0027])"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"        for seg in [seg1, seg2, seg3]:"},{"line_number":2679,"context_line":"            seg[\u0027network_id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3b66262a","line":2676,"range":{"start_line":2673,"start_character":0,"end_line":2676,"end_character":63},"updated":"2016-12-06 17:37:53.000000000","message":"nit: the format can be improved to reduce the number of lines","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4f8776834deec7996caebe0fc47e81aec145988d","unresolved":false,"context_lines":[{"line_number":2670,"context_line":"        with self.network() as network:"},{"line_number":2671,"context_line":"            network \u003d network[\u0027network\u0027]"},{"line_number":2672,"context_line":""},{"line_number":2673,"context_line":"        for stale_seg in segments_db.get_network_segments(self.context,"},{"line_number":2674,"context_line":"                                                          network[\u0027id\u0027]):"},{"line_number":2675,"context_line":"            segments_db.delete_network_segment(self.context,"},{"line_number":2676,"context_line":"                                               stale_seg[\u0027id\u0027])"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"        for seg in [seg1, seg2, seg3]:"},{"line_number":2679,"context_line":"            seg[\u0027network_id\u0027] \u003d network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e2db014d","line":2676,"range":{"start_line":2673,"start_character":0,"end_line":2676,"end_character":63},"in_reply_to":"3a71b18c_3b66262a","updated":"2016-12-07 10:14:44.000000000","message":"Done","commit_id":"8ed5dab195df456134a5dbe2aaa2b065f328201d"}]}