)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c5af3417f15fd35a4c6e99485ae609018a12f9d0","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            # Check if attr based check is enforced and omit items from the"},{"line_number":316,"context_line":"            # list that should not be visible. If check is not enforced, do"},{"line_number":317,"context_line":"            # overall action check, i.e. \"get_port\": \"rule:\"."},{"line_number":318,"context_line":"            if policy.enforce_attr_based_check("},{"line_number":319,"context_line":"                    self._plugin_handlers[self.SHOW],"},{"line_number":320,"context_line":"                    self._collection):"},{"line_number":321,"context_line":"                obj_list \u003d [obj for obj in obj_list"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0cf600d7","line":318,"updated":"2016-12-03 02:28:24.000000000","message":"I may be missing something, but I am having trouble understanding how this is a solution. In the case of a get or delete, aren\u0027t we are always going to take the else path? And once we are in the else path, are we potentially returning to the caller objects that he or she shouldn\u0027t see if we only check the first element in the list?","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fd151194bb47b416f00041b61a686edf22d768a3","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            # Check if attr based check is enforced and omit items from the"},{"line_number":316,"context_line":"            # list that should not be visible. If check is not enforced, do"},{"line_number":317,"context_line":"            # overall action check, i.e. \"get_port\": \"rule:\"."},{"line_number":318,"context_line":"            if policy.enforce_attr_based_check("},{"line_number":319,"context_line":"                    self._plugin_handlers[self.SHOW],"},{"line_number":320,"context_line":"                    self._collection):"},{"line_number":321,"context_line":"                obj_list \u003d [obj for obj in obj_list"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6c304d9f","line":318,"in_reply_to":"3a71b18c_0cf600d7","updated":"2016-12-03 17:02:06.000000000","message":"Fields are stripped starting at line 342, so no fields will be see that they shouldn\u0027t see.\n\nThe way I see the policy enforced for a get or delete is only at the get_port level or get_****, which is only based on the action.  So, if the object list contains objects all from the same action, I don\u0027t think this would be the case for get or delete.","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c5af3417f15fd35a4c6e99485ae609018a12f9d0","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                                 obj_list[0],"},{"line_number":334,"context_line":"                                                 plugin\u003dself._plugin,"},{"line_number":335,"context_line":"                                                 pluralized\u003dself._collection):"},{"line_number":336,"context_line":"                    obj_list \u003d {}"},{"line_number":337,"context_line":"        # Use the first element in the list for discriminating which attributes"},{"line_number":338,"context_line":"        # should be filtered out because of authZ policies"},{"line_number":339,"context_line":"        # fields_to_add contains a list of attributes added for request policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ec3b84cf","line":336,"range":{"start_line":336,"start_character":31,"end_line":336,"end_character":33},"updated":"2016-12-03 02:28:24.000000000","message":"To be consistent with the code above, shouldn\u0027t this be []?","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"f06f16cfd7777778ebe53267d7e0be8f1dc888a0","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                                 obj_list[0],"},{"line_number":334,"context_line":"                                                 plugin\u003dself._plugin,"},{"line_number":335,"context_line":"                                                 pluralized\u003dself._collection):"},{"line_number":336,"context_line":"                    obj_list \u003d {}"},{"line_number":337,"context_line":"        # Use the first element in the list for discriminating which attributes"},{"line_number":338,"context_line":"        # should be filtered out because of authZ policies"},{"line_number":339,"context_line":"        # fields_to_add contains a list of attributes added for request policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e3b3aa08","line":336,"range":{"start_line":336,"start_character":31,"end_line":336,"end_character":33},"in_reply_to":"3a71b18c_ec3b84cf","updated":"2016-12-09 00:29:48.000000000","message":"Done","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fd151194bb47b416f00041b61a686edf22d768a3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                                 obj_list[0],"},{"line_number":334,"context_line":"                                                 plugin\u003dself._plugin,"},{"line_number":335,"context_line":"                                                 pluralized\u003dself._collection):"},{"line_number":336,"context_line":"                    obj_list \u003d {}"},{"line_number":337,"context_line":"        # Use the first element in the list for discriminating which attributes"},{"line_number":338,"context_line":"        # should be filtered out because of authZ policies"},{"line_number":339,"context_line":"        # fields_to_add contains a list of attributes added for request policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_8c276963","line":336,"range":{"start_line":336,"start_character":31,"end_line":336,"end_character":33},"in_reply_to":"3a71b18c_ec3b84cf","updated":"2016-12-03 17:02:06.000000000","message":"Possibly yes.","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"}],"neutron/policy.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c5af3417f15fd35a4c6e99485ae609018a12f9d0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_resource(action, pluralized\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Return resource resource and action extracted from api operation.\"\"\""},{"line_number":67,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":68,"context_line":"    resource \u003d pluralized or (\"%ss\" % data[-1])"},{"line_number":69,"context_line":"    return resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ac218ca1","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":42},"updated":"2016-12-03 02:28:24.000000000","message":"We are returning only the resource, right? In any case, the comment needs some ltc","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fd151194bb47b416f00041b61a686edf22d768a3","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_resource(action, pluralized\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Return resource resource and action extracted from api operation.\"\"\""},{"line_number":67,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":68,"context_line":"    resource \u003d pluralized or (\"%ss\" % data[-1])"},{"line_number":69,"context_line":"    return resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_cc21614f","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":42},"in_reply_to":"3a71b18c_ac218ca1","updated":"2016-12-03 17:02:06.000000000","message":"Agree.","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"f06f16cfd7777778ebe53267d7e0be8f1dc888a0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_resource(action, pluralized\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Return resource resource and action extracted from api operation.\"\"\""},{"line_number":67,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":68,"context_line":"    resource \u003d pluralized or (\"%ss\" % data[-1])"},{"line_number":69,"context_line":"    return resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_23ce8283","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":42},"in_reply_to":"3a71b18c_ac218ca1","updated":"2016-12-09 00:29:48.000000000","message":"Done","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c5af3417f15fd35a4c6e99485ae609018a12f9d0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"       from api operation."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d1165f54","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":29},"updated":"2016-12-03 02:28:24.000000000","message":"Since we are creating this variable in the context of function enforce_attr_based_check, why not name this just \u0027enforce_check\u0027 and we get rid of the _","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fd151194bb47b416f00041b61a686edf22d768a3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"       from api operation."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ec1c5d15","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":29},"in_reply_to":"3a71b18c_d1165f54","updated":"2016-12-03 17:02:06.000000000","message":"Agree.","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"f06f16cfd7777778ebe53267d7e0be8f1dc888a0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"       from api operation."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_43c9be78","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":29},"in_reply_to":"3a71b18c_d1165f54","updated":"2016-12-09 00:29:48.000000000","message":"Done","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c5af3417f15fd35a4c6e99485ae609018a12f9d0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def set_rules(policies, overwrite\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ec73847e","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":36},"updated":"2016-12-03 02:28:24.000000000","message":"Ditto","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"f06f16cfd7777778ebe53267d7e0be8f1dc888a0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def set_rules(policies, overwrite\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_63c87a75","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":36},"in_reply_to":"3a71b18c_ec73847e","updated":"2016-12-09 00:29:48.000000000","message":"Done","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fd151194bb47b416f00041b61a686edf22d768a3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    _enforce_attr_based_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return _enforce_attr_based_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def set_rules(policies, overwrite\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_2c1735ee","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":36},"in_reply_to":"3a71b18c_ec73847e","updated":"2016-12-03 17:02:06.000000000","message":"Same.","commit_id":"f4f03e86367a127c9d208ca61e05f5fb9396e18e"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d2e080493e6c4fc889c7e2489a44f9f7f6982e33","unresolved":false,"context_lines":[{"line_number":74,"context_line":"       api operation."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    data \u003d action.split(\u0027:\u0027, 1)[0].split(\u0027_\u0027, 1)"},{"line_number":77,"context_line":"    enforce_check \u003d data[0] not in (\u0027get\u0027, \u0027delete\u0027)"},{"line_number":78,"context_line":"    return enforce_check"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b8e1d99c","line":77,"updated":"2017-01-26 16:54:47.000000000","message":"Very small nit:  \"in\" boolean expression would be slightly better using list rather than tuple:\ni.e:  data[0] not in [\u0027get\u0027, \u0027delete\u0027], as the sequence of the actions does not matter. Tuple is fine","commit_id":"c150f224dd2a2518781019917d5d1d4cf03cd631"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d2e080493e6c4fc889c7e2489a44f9f7f6982e33","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            except Exception:"},{"line_number":353,"context_line":"                pass"},{"line_number":354,"context_line":"        elif isinstance(_ENFORCER.rules[rule.match], OwnerCheck):"},{"line_number":355,"context_line":"            return True"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def is_owner_check(action, target, pluralized):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_98c5fd3d","line":355,"updated":"2017-01-26 16:54:47.000000000","message":"nit: Adding other return False here to make it explicitly, rather than return None.\n\nZen of Python #2:  Explicit is better than implicit.","commit_id":"c150f224dd2a2518781019917d5d1d4cf03cd631"}]}
