)]}'
{"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c894b71a83d506d654c9016ccd1cc4581b4a1307","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        raise exceptions.InvalidConfiguration(message)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"def require_qos_rule_type(rule_type, *args, **kwargs):"},{"line_number":501,"context_line":"    def decorator(f):"},{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_fc530f69","line":500,"range":{"start_line":500,"start_character":35,"end_line":500,"end_character":52},"updated":"2016-12-05 11:55:00.000000000","message":"You don\u0027t need these arguments there. You are calling the decorator function with only one defined argument:\n@base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)\n\n\nYou should remove them.","commit_id":"268dc7a780e806a2f2ffac0aaa2ac8ccede89ff2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f1000585765c989ce422ab62cbf8e179ce050bff","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        raise exceptions.InvalidConfiguration(message)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"def require_qos_rule_type(rule_type, *args, **kwargs):"},{"line_number":501,"context_line":"    def decorator(f):"},{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_915d9217","line":500,"range":{"start_line":500,"start_character":35,"end_line":500,"end_character":52},"in_reply_to":"3a71b18c_fc530f69","updated":"2016-12-05 17:12:07.000000000","message":"Done","commit_id":"268dc7a780e806a2f2ffac0aaa2ac8ccede89ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d820c672894d5f877f02b5c1482e98ef80f28252","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    def decorator(f):"},{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"},{"line_number":504,"context_line":"            if rule_type not in self.supported_qos_rule_types:"},{"line_number":505,"context_line":"                self.skipTest(\"%s rule type is required. \" % rule_type)"},{"line_number":506,"context_line":"            return f(self, *func_args, **func_kwargs)"},{"line_number":507,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_40af3494","line":504,"range":{"start_line":504,"start_character":32,"end_line":504,"end_character":61},"updated":"2016-12-07 18:51:23.000000000","message":"couldn\u0027t the decorator itself call to API to get the list of types? Then test classes would not need to initialize the list.\n\nYes, it\u0027s some more API calls, but I don\u0027t think it will make the test time significantly higher.","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78d583b66abebafa6c3a1c61b1039f5e2524278e","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    def decorator(f):"},{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"},{"line_number":504,"context_line":"            if rule_type not in self.supported_qos_rule_types:"},{"line_number":505,"context_line":"                self.skipTest(\"%s rule type is required. \" % rule_type)"},{"line_number":506,"context_line":"            return f(self, *func_args, **func_kwargs)"},{"line_number":507,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_dc68888a","line":504,"range":{"start_line":504,"start_character":32,"end_line":504,"end_character":61},"in_reply_to":"3a71b18c_40af3494","updated":"2016-12-07 22:23:07.000000000","message":"yes, I thought about that but I didn\u0027t want to make too many (unnessassary) calls to API. But if said it will be fine, I changed it :)","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d820c672894d5f877f02b5c1482e98ef80f28252","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"},{"line_number":504,"context_line":"            if rule_type not in self.supported_qos_rule_types:"},{"line_number":505,"context_line":"                self.skipTest(\"%s rule type is required. \" % rule_type)"},{"line_number":506,"context_line":"            return f(self, *func_args, **func_kwargs)"},{"line_number":507,"context_line":"        return wrapper"},{"line_number":508,"context_line":"    return decorator"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_20dcf845","line":505,"range":{"start_line":505,"start_character":56,"end_line":505,"end_character":57},"updated":"2016-12-07 18:51:23.000000000","message":"redundant space","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78d583b66abebafa6c3a1c61b1039f5e2524278e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        @functools.wraps(f)"},{"line_number":503,"context_line":"        def wrapper(self, *func_args, **func_kwargs):"},{"line_number":504,"context_line":"            if rule_type not in self.supported_qos_rule_types:"},{"line_number":505,"context_line":"                self.skipTest(\"%s rule type is required. \" % rule_type)"},{"line_number":506,"context_line":"            return f(self, *func_args, **func_kwargs)"},{"line_number":507,"context_line":"        return wrapper"},{"line_number":508,"context_line":"    return decorator"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_3c0edce5","line":505,"range":{"start_line":505,"start_character":56,"end_line":505,"end_character":57},"in_reply_to":"3a71b18c_20dcf845","updated":"2016-12-07 22:23:07.000000000","message":"Done","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7fc6cb28465ba80999211939ee12821f81989c31","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"},{"line_number":364,"context_line":"    def resource_setup(cls):"},{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5f4cf59d","line":366,"range":{"start_line":366,"start_character":12,"end_line":366,"end_character":36},"updated":"2016-12-05 11:55:32.000000000","message":"One more question: cls.supported_qos_rule_types, why do you need it?\n\nditto in next test classes","commit_id":"268dc7a780e806a2f2ffac0aaa2ac8ccede89ff2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59a3cbafdfb7210cd2c3d44116d10e6149773a95","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"},{"line_number":364,"context_line":"    def resource_setup(cls):"},{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6ac3b1ed","line":366,"range":{"start_line":366,"start_character":12,"end_line":366,"end_character":36},"in_reply_to":"3a71b18c_5f4cf59d","updated":"2016-12-05 12:19:52.000000000","message":"Sorry, my bad. Now I see where are you using that.","commit_id":"268dc7a780e806a2f2ffac0aaa2ac8ccede89ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d820c672894d5f877f02b5c1482e98ef80f28252","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":370,"context_line":"    def test_rule_create(self):"},{"line_number":371,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_e08da02b","line":368,"updated":"2016-12-07 18:51:23.000000000","message":"you could instead implement a single skip_checks classmethod per test class that would skip all test cases in the class, instead of applying the decorator to each test case (and risk that in the future we will forget to mark a new test case with it).","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"05d6b81e9d3b9d34534041831c2f31f04bc69566","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":370,"context_line":"    def test_rule_create(self):"},{"line_number":371,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_ffcd1d87","line":368,"in_reply_to":"3a71b18c_4d2033f8","updated":"2016-12-08 11:50:26.000000000","message":"Yes it can be done like that. Thx for help.","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"317b3ec5f83b441d882f802b1c46589919d66476","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":370,"context_line":"    def test_rule_create(self):"},{"line_number":371,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4d2033f8","line":368,"in_reply_to":"3a71b18c_b7c76563","updated":"2016-12-08 09:53:39.000000000","message":"Oh. But I see we can reuse resource_setup() for that matter, it\u0027s called after clients are set.","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78d583b66abebafa6c3a1c61b1039f5e2524278e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        super(QosBandwidthLimitRuleTestJSON, cls).resource_setup()"},{"line_number":366,"context_line":"        cls.supported_qos_rule_types \u003d cls.get_supported_qos_rule_types()"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":369,"context_line":"    @test.idempotent_id(\u00278a59b00b-3e9c-4787-92f8-93a5cdf5e378\u0027)"},{"line_number":370,"context_line":"    def test_rule_create(self):"},{"line_number":371,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_b7c76563","line":368,"in_reply_to":"3a71b18c_e08da02b","updated":"2016-12-07 22:23:07.000000000","message":"I\u0027m not sure if it is possible (in easy way) because as it is in https://github.com/openstack/tempest/blob/master/tempest/test.py#L231 skip_checks() is called before setup_clients() so there is no client initialized yet in skip_checks() method.\n\nDo You think I should call setup_clients() in skip_tests()? I\u0027m not sure if it\u0027s good idea","commit_id":"a7f66342de1f1a895d21db92767b35e10e1bc4ee"}]}
