)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c57ce5437fd02a606204d7ddde6ab202311bf37e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The scope of this implementation is reduced to N/S traffic."},{"line_number":12,"context_line":"There is no QoS applied on traffic between VMs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The QoS rules are aplied to exit ports in bridges other than"},{"line_number":15,"context_line":"br-int; that means all physical bridges. No tunneled traffic"},{"line_number":16,"context_line":"will be shaped. This feature will be implemented in a following"},{"line_number":17,"context_line":"patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"9fdfeff1_ea40cba4","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":24},"updated":"2019-02-27 11:47:34.000000000","message":"nit: applied","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8aa1f071101ff75fa786aade71dc21597a19fad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The scope of this implementation is reduced to N/S traffic."},{"line_number":12,"context_line":"There is no QoS applied on traffic between VMs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The QoS rules are aplied to exit ports in bridges other than"},{"line_number":15,"context_line":"br-int; that means all physical bridges. No tunneled traffic"},{"line_number":16,"context_line":"will be shaped. This feature will be implemented in a following"},{"line_number":17,"context_line":"patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"9fdfeff1_4bcd0f2e","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":24},"in_reply_to":"9fdfeff1_ea40cba4","updated":"2019-03-01 10:19:57.000000000","message":"Done","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"70907748a7be9f23632903e41b1ef1bc8bf28d84","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            in_port\u003dqueue_num,"},{"line_number":605,"context_line":"            reg4\u003d0,"},{"line_number":606,"context_line":"            priority\u003d100,"},{"line_number":607,"context_line":"            actions\u003d(\"set_queue:%s,load:1-\u003eNXM_NX_REG3[0],\""},{"line_number":608,"context_line":"                     \"resubmit(,%s)\" % (queue_num, constants.LOCAL_SWITCHING)))"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def _unset_queue_for_minimum_bandwidth(self, queue_num):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2235d9f6","line":607,"range":{"start_line":607,"start_character":43,"end_line":607,"end_character":54},"updated":"2016-12-19 10:19:44.000000000","message":"NXM_NX_REG3 ;) You set reg4\u003d0 so this must be NXM_NX_REG4.","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1714f86850c50ab3f85ed5c114754c42974db9b9","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        qos_id, qos_queues \u003d self._find_qos(QOS_MINIMUM_BANDWIDTH)"},{"line_number":638,"context_line":"        if queue_num in six.iterkeys(qos_queues):"},{"line_number":639,"context_line":"            qos_queues.pop(queue_num)"},{"line_number":640,"context_line":"            self._update_qos(qos_id\u003dqos_id,"},{"line_number":641,"context_line":"                             queues\u003dqos_queues,"},{"line_number":642,"context_line":"                             type\u003dQOS_MINIMUM_BANDWIDTH)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def clear_minimum_bandwidth_qos(self):"},{"line_number":645,"context_line":"        qos_id, _ \u003d self._find_qos(QOS_MINIMUM_BANDWIDTH)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_ea92984a","line":642,"range":{"start_line":640,"start_character":12,"end_line":642,"end_character":56},"updated":"2016-12-14 07:56:05.000000000","message":"I guess that we should make Queue clear before update.","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"92dae75e8dfe3f0e024b256274ec3edfa4ac69f5","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        qos_id, qos_queues \u003d self._find_qos(QOS_MINIMUM_BANDWIDTH)"},{"line_number":638,"context_line":"        if queue_num in six.iterkeys(qos_queues):"},{"line_number":639,"context_line":"            qos_queues.pop(queue_num)"},{"line_number":640,"context_line":"            self._update_qos(qos_id\u003dqos_id,"},{"line_number":641,"context_line":"                             queues\u003dqos_queues,"},{"line_number":642,"context_line":"                             type\u003dQOS_MINIMUM_BANDWIDTH)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def clear_minimum_bandwidth_qos(self):"},{"line_number":645,"context_line":"        qos_id, _ \u003d self._find_qos(QOS_MINIMUM_BANDWIDTH)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_9abda06a","line":642,"range":{"start_line":640,"start_character":12,"end_line":642,"end_character":56},"in_reply_to":"1a6eadb0_ea92984a","updated":"2016-12-15 15:01:02.000000000","message":"You are right. We should delete the queue after this command (we can\u0027t delete an used queue, so we need first to unset this queue id in the QoS register queue list)","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b35ea4ad16b240d1f7c9b7c0cf519c9e2231e7fd","unresolved":false,"context_lines":[{"line_number":954,"context_line":"    def update_minimum_bandwidth_queue(self, port_id, egress_port_names,"},{"line_number":955,"context_line":"                                       queue_num, min_kbps):"},{"line_number":956,"context_line":"        if not isinstance(queue_num, int):"},{"line_number":957,"context_line":"            queue_num \u003d int(queue_num)"},{"line_number":958,"context_line":"        queue_id \u003d self._update_queue(port_id, queue_num, min_kbps\u003dmin_kbps)"},{"line_number":959,"context_line":"        qos_id, qos_queues \u003d self._find_qos()"},{"line_number":960,"context_line":"        if qos_queues:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9fdfeff1_3ca8b3d9","line":957,"updated":"2019-01-23 22:15:07.000000000","message":"why check if it\u0027s an int first?","commit_id":"1809423462b12092a713499250b8eb19bc841f84"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e72715010183859a9022f31430c0a6b63e29ef5d","unresolved":false,"context_lines":[{"line_number":954,"context_line":"    def update_minimum_bandwidth_queue(self, port_id, egress_port_names,"},{"line_number":955,"context_line":"                                       queue_num, min_kbps):"},{"line_number":956,"context_line":"        if not isinstance(queue_num, int):"},{"line_number":957,"context_line":"            queue_num \u003d int(queue_num)"},{"line_number":958,"context_line":"        queue_id \u003d self._update_queue(port_id, queue_num, min_kbps\u003dmin_kbps)"},{"line_number":959,"context_line":"        qos_id, qos_queues \u003d self._find_qos()"},{"line_number":960,"context_line":"        if qos_queues:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9fdfeff1_b2d9f1f3","line":957,"in_reply_to":"9fdfeff1_3ca8b3d9","updated":"2019-01-28 12:00:29.000000000","message":"I need to enforce this value to be an int, but nothing prevents from passing a number in a string. Just for precaution.","commit_id":"1809423462b12092a713499250b8eb19bc841f84"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b35ea4ad16b240d1f7c9b7c0cf519c9e2231e7fd","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                \u0027QoS\u0027,"},{"line_number":1083,"context_line":"                (\u0027external_ids\u0027, \u0027\u003d\u0027, external_ids),"},{"line_number":1084,"context_line":"                colmuns\u003d[\u0027_uuid\u0027, \u0027queues\u0027]).execute(check_error\u003dTrue)"},{"line_number":1085,"context_line":"        else:"},{"line_number":1086,"context_line":"            return self.ovsdb.db_find("},{"line_number":1087,"context_line":"                \u0027QoS\u0027, colmuns\u003d[\u0027_uuid\u0027, \u0027queues\u0027]).execute(check_error\u003dTrue)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9fdfeff1_1ca5af04","line":1085,"updated":"2019-01-23 22:15:07.000000000","message":"nit: don\u0027t need the else as L1081 returns","commit_id":"1809423462b12092a713499250b8eb19bc841f84"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e72715010183859a9022f31430c0a6b63e29ef5d","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                \u0027QoS\u0027,"},{"line_number":1083,"context_line":"                (\u0027external_ids\u0027, \u0027\u003d\u0027, external_ids),"},{"line_number":1084,"context_line":"                colmuns\u003d[\u0027_uuid\u0027, \u0027queues\u0027]).execute(check_error\u003dTrue)"},{"line_number":1085,"context_line":"        else:"},{"line_number":1086,"context_line":"            return self.ovsdb.db_find("},{"line_number":1087,"context_line":"                \u0027QoS\u0027, colmuns\u003d[\u0027_uuid\u0027, \u0027queues\u0027]).execute(check_error\u003dTrue)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9fdfeff1_52e205a2","line":1085,"in_reply_to":"9fdfeff1_1ca5af04","updated":"2019-01-28 12:00:29.000000000","message":"Right.","commit_id":"1809423462b12092a713499250b8eb19bc841f84"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c57ce5437fd02a606204d7ddde6ab202311bf37e","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            actions\u003d(\"set_queue:%s,load:1-\u003eNXM_NX_REG4[0],\""},{"line_number":953,"context_line":"                     \"resubmit(,%s)\" % (queue_num, constants.LOCAL_SWITCHING)))"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _unset_queue_for_minimum_bandwidth(self, queue_num):"},{"line_number":956,"context_line":"        self.delete_flows("},{"line_number":957,"context_line":"            table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":958,"context_line":"            in_port\u003dqueue_num,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_ca7b87bc","line":955,"range":{"start_line":955,"start_character":49,"end_line":955,"end_character":58},"updated":"2019-02-27 11:47:34.000000000","message":"Should this be queue_num or port_num?\nIs the Queue ID used by ovs as it\u0027s in_port when a packet goes through that queue?","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b7f4650707f4b16bbeb2ac7c525a8e0e29314ef7","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            actions\u003d(\"set_queue:%s,load:1-\u003eNXM_NX_REG4[0],\""},{"line_number":953,"context_line":"                     \"resubmit(,%s)\" % (queue_num, constants.LOCAL_SWITCHING)))"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _unset_queue_for_minimum_bandwidth(self, queue_num):"},{"line_number":956,"context_line":"        self.delete_flows("},{"line_number":957,"context_line":"            table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":958,"context_line":"            in_port\u003dqueue_num,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_907220b0","line":955,"range":{"start_line":955,"start_character":49,"end_line":955,"end_character":58},"in_reply_to":"9fdfeff1_4be66fb2","updated":"2019-03-04 09:49:58.000000000","message":"yes, but maybe using ofport_number would be easier to understand later :) But this can be changed/updated in follow-up patch later","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8aa1f071101ff75fa786aade71dc21597a19fad","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            actions\u003d(\"set_queue:%s,load:1-\u003eNXM_NX_REG4[0],\""},{"line_number":953,"context_line":"                     \"resubmit(,%s)\" % (queue_num, constants.LOCAL_SWITCHING)))"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _unset_queue_for_minimum_bandwidth(self, queue_num):"},{"line_number":956,"context_line":"        self.delete_flows("},{"line_number":957,"context_line":"            table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":958,"context_line":"            in_port\u003dqueue_num,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_4be66fb2","line":955,"range":{"start_line":955,"start_character":49,"end_line":955,"end_character":58},"in_reply_to":"9fdfeff1_ca7b87bc","updated":"2019-03-01 10:19:57.000000000","message":"TODO: document this function. I\u0027ll do this in the next respin.\n\nAs you can see in [1], wee use the ofport number to identify the queue. So queue and ofport must always be the same.\n\n[1] https://review.openstack.org/#/c/406841/22/neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py@199","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"}],"neutron/common/utils.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"090997e23401919507e1c494688ff4dfb2c2093c","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                \"device mappings\") % {\u0027dev_name\u0027: dev_name})"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"def compare(a, b):"},{"line_number":844,"context_line":"    \"\"\"Compare two objects."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    Removed in Python 3.0.1."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f974f605","line":843,"updated":"2018-11-09 14:16:11.000000000","message":"Seems like a candidate for neutron-lib to me.","commit_id":"e3a44a152e16f32539d0dd1c6c0d36d5c1c19b7d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"81d8263be7c3c4c7d0e8dad10c7e7e63d7521f41","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                \"device mappings\") % {\u0027dev_name\u0027: dev_name})"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"def compare(a, b):"},{"line_number":844,"context_line":"    \"\"\"Compare two objects."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    Removed in Python 3.0.1."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0f7f4169","line":843,"in_reply_to":"3f79a3b5_f974f605","updated":"2018-11-26 14:27:36.000000000","message":"Yes, sure. I\u0027ll submit a patch for n-lib.","commit_id":"e3a44a152e16f32539d0dd1c6c0d36d5c1c19b7d"}],"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1714f86850c50ab3f85ed5c114754c42974db9b9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                                            rule.min_kbps)"},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        for phy_br in self.agent_api.request_phy_brs():"},{"line_number":167,"context_line":"            ports.extend(phy_br.get_bridge_port(\u0027\u0027))"},{"line_number":168,"context_line":"        LOG.debug(\"update_minimum_bandwidth: ports updated with \""},{"line_number":169,"context_line":"                  \"qos\u003d%(qos_id)s: %(ports)s\", {\u0027qos_id\u0027: qos_id,"},{"line_number":170,"context_line":"                                                \u0027ports\u0027: ports})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_ac544021","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":52},"updated":"2016-12-14 07:56:05.000000000","message":"I guess that this sets QoS into all physical_network if we have some physical networks although actual \"port\" corresponds to a physical_network.","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6521c5de271e0ae39ea35744a3b14d4289757e3c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                                            rule.min_kbps)"},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        for phy_br in self.agent_api.request_phy_brs():"},{"line_number":167,"context_line":"            ports.extend(phy_br.get_bridge_port(\u0027\u0027))"},{"line_number":168,"context_line":"        LOG.debug(\"update_minimum_bandwidth: ports updated with \""},{"line_number":169,"context_line":"                  \"qos\u003d%(qos_id)s: %(ports)s\", {\u0027qos_id\u0027: qos_id,"},{"line_number":170,"context_line":"                                                \u0027ports\u0027: ports})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_7050895f","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":52},"in_reply_to":"1a6eadb0_95001303","updated":"2016-12-19 00:50:07.000000000","message":"I thought your intention doesn\u0027t set \"all\" physical bridges, for example, this[1] shows you doesn\u0027t set QoS rule in br-phy2. I agree the idea.\n\n[1]: https://github.com/ralonsoh/min_bw_egress/blob/master/Neutron%20-%20Minimum%20bandwidth%20egress%20-%20OVS%20backend.pdf","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"92dae75e8dfe3f0e024b256274ec3edfa4ac69f5","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                                            rule.min_kbps)"},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        for phy_br in self.agent_api.request_phy_brs():"},{"line_number":167,"context_line":"            ports.extend(phy_br.get_bridge_port(\u0027\u0027))"},{"line_number":168,"context_line":"        LOG.debug(\"update_minimum_bandwidth: ports updated with \""},{"line_number":169,"context_line":"                  \"qos\u003d%(qos_id)s: %(ports)s\", {\u0027qos_id\u0027: qos_id,"},{"line_number":170,"context_line":"                                                \u0027ports\u0027: ports})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_95001303","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":52},"in_reply_to":"1a6eadb0_ac544021","updated":"2016-12-15 15:01:02.000000000","message":"Excuse Hirofumi, I don\u0027t understand your question here.\n\nIn this loop we\u0027ll set the QoS rule in all physical bridges, in the port attached to the physical interface. Is that what you are asking?","commit_id":"c5fec50e2d645983779b4d2df2d198e3a43514c3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"03138a5878d34aa5f5f7638c1227b0ef06262972","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            max_burst_kbps"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Note(lajoskatona): As minimum bandwidth rule was allowed to be used by"},{"line_number":183,"context_line":"    # OVS and SRIOV even with ingress direction for the placement based"},{"line_number":184,"context_line":"    # enforcement, but the dataplane enforcement implementation is not yet"},{"line_number":185,"context_line":"    # ready these methods are empty."},{"line_number":186,"context_line":"    # For details see:"},{"line_number":187,"context_line":"    # RFE for placement based enforcement:"},{"line_number":188,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1578989"},{"line_number":189,"context_line":"    # RFE for dataplane based enforcement:"},{"line_number":190,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1560963"},{"line_number":191,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":192,"context_line":"        self.update_minimum_bandwidth(port, rule)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_03dbaa7a","line":190,"range":{"start_line":182,"start_character":4,"end_line":190,"end_character":53},"updated":"2018-12-07 12:28:38.000000000","message":"This comment can be removed I suppose.","commit_id":"575b3ea3061f361fed53df0a1b48b6303d065618"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"835c23a8f8bdd9fa1a8f7755d0e3a5298787b90e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            max_burst_kbps"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Note(lajoskatona): As minimum bandwidth rule was allowed to be used by"},{"line_number":183,"context_line":"    # OVS and SRIOV even with ingress direction for the placement based"},{"line_number":184,"context_line":"    # enforcement, but the dataplane enforcement implementation is not yet"},{"line_number":185,"context_line":"    # ready these methods are empty."},{"line_number":186,"context_line":"    # For details see:"},{"line_number":187,"context_line":"    # RFE for placement based enforcement:"},{"line_number":188,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1578989"},{"line_number":189,"context_line":"    # RFE for dataplane based enforcement:"},{"line_number":190,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1560963"},{"line_number":191,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":192,"context_line":"        self.update_minimum_bandwidth(port, rule)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_bb5e8b11","line":190,"range":{"start_line":182,"start_character":4,"end_line":190,"end_character":53},"in_reply_to":"3f79a3b5_03dbaa7a","updated":"2018-12-08 10:07:39.000000000","message":"Yes, I\u0027ll remove this once I have the new neutron-lib with the needed patch.","commit_id":"575b3ea3061f361fed53df0a1b48b6303d065618"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_agent_extension_api.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"2d14593cd5a480a426a2b9234ed93779b49bc0b4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    method which has been added to the AgentExtension class."},{"line_number":41,"context_line":"    \u0027\u0027\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, int_br, tun_br, phys_brs):"},{"line_number":44,"context_line":"        super(OVSAgentExtensionAPI, self).__init__()"},{"line_number":45,"context_line":"        self.br_int \u003d int_br"},{"line_number":46,"context_line":"        self.br_tun \u003d tun_br"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_c9e0e2fb","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":48},"updated":"2019-03-05 15:35:18.000000000","message":"Heads-up, this breaks UT in networking-sfc https://review.openstack.org/#/c/640999/ (and possibly other projects using OVSAgentExtensionAPI)","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c57ce5437fd02a606204d7ddde6ab202311bf37e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI(self.int_br,"},{"line_number":252,"context_line":"                                                     self.tun_br,"},{"line_number":253,"context_line":"                                                     self.phys_brs)"},{"line_number":254,"context_line":"        self.ext_manager.initialize("},{"line_number":255,"context_line":"            self.connection, constants.EXTENSION_DRIVER_TYPE, agent_api)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # In order to keep existed device\u0027s local vlan unchanged,"},{"line_number":258,"context_line":"        # restore local vlan mapping at start"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_27f6fc5e","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":72},"updated":"2019-02-27 11:47:34.000000000","message":"This doesn\u0027t seem to have changed between this PS and base, weird that it\u0027s highlighted.\nI can\u0027t see the change, only drawing attention to it in case someone else does.","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8aa1f071101ff75fa786aade71dc21597a19fad","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        agent_api \u003d ovs_ext_api.OVSAgentExtensionAPI(self.int_br,"},{"line_number":252,"context_line":"                                                     self.tun_br,"},{"line_number":253,"context_line":"                                                     self.phys_brs)"},{"line_number":254,"context_line":"        self.ext_manager.initialize("},{"line_number":255,"context_line":"            self.connection, constants.EXTENSION_DRIVER_TYPE, agent_api)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # In order to keep existed device\u0027s local vlan unchanged,"},{"line_number":258,"context_line":"        # restore local vlan mapping at start"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fdfeff1_eba2c33e","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":72},"in_reply_to":"9fdfeff1_27f6fc5e","updated":"2019-03-01 10:19:57.000000000","message":"I push forward this method. We need first to have br_phys initialized [1]. This is done in L229.\n\n[1] https://review.openstack.org/#/c/406841/22/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_agent_extension_api.py@47","commit_id":"cc8808d539e9b40fe8c7b9b9001f146edc663203"}]}
