)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00461e79d6a409f3245287d24db7359b8b96bfe6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Render service plugins configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch permits to configure Neutron service plugins through"},{"line_number":10,"context_line":"environment"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Thomas Morin \u003cthomas.morin@orange.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_389c095d","line":9,"updated":"2017-02-02 20:53:54.000000000","message":"commit message could mention that it\u0027s for fullstack","commit_id":"05c91443a526eb39fc169c2eed83ded3bacbad6c"}],"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f3f9cb1e9f43ade6d1c500d6e51e918fe2a4dae8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins +\u003d \u0027,qos\u0027"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a394f642","line":57,"updated":"2016-12-06 00:13:31.000000000","message":"I\u0027d suggest you do this instead:\n\nservice_plugins \u003d self.env_desc.service_plugins or [\u0027router\u0027, \u0027trunk\u0027]\n\nand keep sevice_plugins\u003dNone on the env description.\n\nIt\u0027s slightly cleaner and it keeps the use of these plugins isolated to this fixture. If the environment description is reused, it may be done so in context where router and trunk may not make much sense.","commit_id":"ea6c6bb5d86655ce94cf8ca4986557e02b8d528c"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"70024f388e5b12560d795fa40c5ce72238cf4389","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins +\u003d \u0027,qos\u0027"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_4c77c79f","line":57,"in_reply_to":"3a71b18c_a394f642","updated":"2016-12-06 10:41:55.000000000","message":"This was only written in this way to be consistent with ML2 mechanism drivers configuration syntax. But it can be done like what you are suggesting.","commit_id":"ea6c6bb5d86655ce94cf8ca4986557e02b8d528c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a93416e92552919cc04f5070906ae993ccc2243","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins or [\u0027router\u0027, \u0027trunk\u0027]"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins.append(\u0027qos\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_cb4b592a","line":57,"range":{"start_line":57,"start_character":55,"end_line":57,"end_character":78},"updated":"2016-12-13 08:46:13.000000000","message":"I see that Armando suggested to use it this way in previous PS, though this introduces inconsistency in neutron_cfg_fixture object and env_desc object.\n\nIt\u0027s better to define the environment in one place and let config to be generated from that data. That said, we should define the implicit service plugins in environment description.","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f9c8422cbd069b6fc52956e60d60586075e6512e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins or [\u0027router\u0027, \u0027trunk\u0027]"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins.append(\u0027qos\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_b8f7ed89","line":57,"range":{"start_line":57,"start_character":55,"end_line":57,"end_character":78},"in_reply_to":"1a6eadb0_9fb14092","updated":"2016-12-14 21:52:59.000000000","message":"Understood. I was suggesting to keep things as close to how they were originally codified, but to be perfectly honest, this looks like a mess of cross-cutting concerns and I welcome any attempt to revise this for the better (though I don\u0027t want to stop this from making progerss). For instance:\n\na) service_plugins are hard-coded here, but mech drivers are hard-coded somewhere else; however they depend on the core plugin, which is hard coded here instead.\n\nb) qos is enabled with a bool, which is hardcoded elsewhere.\n\nc) l2pop, which is another mechdriver is singled out and defined as bool rather than another string in the list of mech drivers.\n\nI can go on :)","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c37e84c81b132bfbd76661bf6482f90d048216e6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins or [\u0027router\u0027, \u0027trunk\u0027]"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins.append(\u0027qos\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_9fb14092","line":57,"range":{"start_line":57,"start_character":55,"end_line":57,"end_character":78},"in_reply_to":"1a6eadb0_c2cb00a4","updated":"2016-12-14 18:40:02.000000000","message":"It is local but then you have neutron_server that exposes neutron_cfg_fixture with config attribute that is out-of-sync with env_desc that introduces service_plugins attribute.\n\nThe behavior is weird - I don\u0027t set anything for my environment, neutron server runs with \u0027router\u0027 and \u0027trunk\u0027. While env_desc has no service_plugins set.\n\nWe should define all service plugins (including qos) at environment and let the fixture to consume what was set and create the config.","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b01b861f8ddce833ed5d5038fee7bfe2b7a6e874","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(NeutronConfigFixture, self).__init__("},{"line_number":55,"context_line":"            env_desc, host_desc, temp_dir, base_filename\u003d\u0027neutron.conf\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        service_plugins \u003d self.env_desc.service_plugins or [\u0027router\u0027, \u0027trunk\u0027]"},{"line_number":58,"context_line":"        if env_desc.qos:"},{"line_number":59,"context_line":"            service_plugins.append(\u0027qos\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c2cb00a4","line":57,"range":{"start_line":57,"start_character":55,"end_line":57,"end_character":78},"in_reply_to":"1a6eadb0_cb4b592a","updated":"2016-12-14 09:36:38.000000000","message":"Where is the source of inconsistency? Isn\u0027t this supposed to be the fixture for \u0027local\u0027 neutron fullstack testing?","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f3f9cb1e9f43ade6d1c500d6e51e918fe2a4dae8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    def __init__(self, network_type\u003d\u0027vxlan\u0027, l2_pop\u003dTrue, qos\u003dFalse,"},{"line_number":37,"context_line":"                 mech_drivers\u003d\u0027openvswitch,linuxbridge\u0027,"},{"line_number":38,"context_line":"                 service_plugins\u003d\u0027router,trunk\u0027, arp_responder\u003dFalse):"},{"line_number":39,"context_line":"        self.network_type \u003d network_type"},{"line_number":40,"context_line":"        self.l2_pop \u003d l2_pop"},{"line_number":41,"context_line":"        self.qos \u003d qos"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_03b84ac7","line":38,"updated":"2016-12-06 00:13:31.000000000","message":"please set service_plugins\u003dNone. Besides, isn\u0027t wrong? You\u0027re setting a string here when the fixture expect a list of strings.","commit_id":"ea6c6bb5d86655ce94cf8ca4986557e02b8d528c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a93416e92552919cc04f5070906ae993ccc2243","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    def __init__(self, network_type\u003d\u0027vxlan\u0027, l2_pop\u003dTrue, qos\u003dFalse,"},{"line_number":37,"context_line":"                 mech_drivers\u003d\u0027openvswitch,linuxbridge\u0027,"},{"line_number":38,"context_line":"                 service_plugins\u003dNone, arp_responder\u003dFalse):"},{"line_number":39,"context_line":"        self.network_type \u003d network_type"},{"line_number":40,"context_line":"        self.l2_pop \u003d l2_pop"},{"line_number":41,"context_line":"        self.qos \u003d qos"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8bfec169","line":38,"range":{"start_line":38,"start_character":17,"end_line":38,"end_character":37},"updated":"2016-12-13 08:46:13.000000000","message":"An idea: now when we want to have service_plugins defined in the environment instead of setting booleans, maybe we could consider service_plugins as an interface on this object. We could remove this and qos parameter from __init__ and set it with default service_plugins at the beginning. Later, when consumers want to add or modify the service_plugins, they can access the service_plugins list directly and modify as they want.","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a93416e92552919cc04f5070906ae993ccc2243","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                 service_plugins\u003dNone, arp_responder\u003dFalse):"},{"line_number":39,"context_line":"        self.network_type \u003d network_type"},{"line_number":40,"context_line":"        self.l2_pop \u003d l2_pop"},{"line_number":41,"context_line":"        self.qos \u003d qos"},{"line_number":42,"context_line":"        self.network_range \u003d None"},{"line_number":43,"context_line":"        self.mech_drivers \u003d mech_drivers"},{"line_number":44,"context_line":"        self.service_plugins \u003d service_plugins"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8bb401f3","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":22},"updated":"2016-12-13 08:46:13.000000000","message":"This now introduces some redundancy. I suggest to remove this attribute and introduce a property instead:\n\n @property\n def qos(self):\n     return \u0027qos\u0027 in self.service_plugins","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f3f9cb1e9f43ade6d1c500d6e51e918fe2a4dae8","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, env_desc, host_desc,"},{"line_number":103,"context_line":"                 test_name, neutron_cfg_fixture, plugin_cfg_fixture,"},{"line_number":104,"context_line":"                 service_cfg_fixtures\u003d[]):"},{"line_number":105,"context_line":"        super(NeutronServerFixture, self).__init__()"},{"line_number":106,"context_line":"        self.env_desc \u003d env_desc"},{"line_number":107,"context_line":"        self.host_desc \u003d host_desc"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c3d9f223","line":104,"updated":"2016-12-06 00:13:31.000000000","message":"passing a mutable like this on the signature is a big no-no\n\nhttp://docs.python-guide.org/en/latest/writing/gotchas/","commit_id":"ea6c6bb5d86655ce94cf8ca4986557e02b8d528c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a93416e92552919cc04f5070906ae993ccc2243","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.test_name \u003d test_name"},{"line_number":109,"context_line":"        self.neutron_cfg_fixture \u003d neutron_cfg_fixture"},{"line_number":110,"context_line":"        self.plugin_cfg_fixture \u003d plugin_cfg_fixture"},{"line_number":111,"context_line":"        self.service_cfg_fixtures \u003d service_cfg_fixtures"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def _setUp(self):"},{"line_number":114,"context_line":"        config_filenames \u003d [self.neutron_cfg_fixture.filename,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_6036e404","line":111,"range":{"start_line":111,"start_character":36,"end_line":111,"end_character":56},"updated":"2016-12-13 08:46:13.000000000","message":"Nit: I suggest to use\n\n self.service_cfg_fixtures \u003d service_cfg_fixtures or []\n\nand on L117 remove condition as now you always have a list type in service_cfg_fixture attribute.","commit_id":"f946857fcb8ca2dd0a5fd93d45f97e3315b0c7a3"}]}
