)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f599f497288f0632f70c489a12dec341ab0c7af4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sindhu Devale \u003csindhu.devale@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-07 09:45:55 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"get_random_object_fields() for setting object attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to introduce a modified get_random_fields() method to set the"},{"line_number":10,"context_line":"attributes of an object as currently get_random_fields() returns"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_bc058c15","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":56},"updated":"2016-12-07 22:17:44.000000000","message":"This exceeds the limit of 50 chars","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"593542411b12ec36abd0d2ceb218fa4d0e12b908","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sindhu Devale \u003csindhu.devale@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-07 09:45:55 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"get_random_object_fields() for setting object attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to introduce a modified get_random_fields() method to set the"},{"line_number":10,"context_line":"attributes of an object as currently get_random_fields() returns"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_ae3c7830","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":56},"in_reply_to":"3a71b18c_bc058c15","updated":"2016-12-13 01:42:47.000000000","message":"Done","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f599f497288f0632f70c489a12dec341ab0c7af4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"get_random_object_fields() for setting object attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to introduce a modified get_random_fields() method to set the"},{"line_number":10,"context_line":"attributes of an object as currently get_random_fields() returns"},{"line_number":11,"context_line":"the modified fields which are suitable to be stored in the database,"},{"line_number":12,"context_line":"however when fields of the objects are assigned with these values"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_9c08d02f","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":75},"updated":"2016-12-07 22:17:44.000000000","message":"This exceeds the margin","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"593542411b12ec36abd0d2ceb218fa4d0e12b908","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"get_random_object_fields() for setting object attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to introduce a modified get_random_fields() method to set the"},{"line_number":10,"context_line":"attributes of an object as currently get_random_fields() returns"},{"line_number":11,"context_line":"the modified fields which are suitable to be stored in the database,"},{"line_number":12,"context_line":"however when fields of the objects are assigned with these values"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_ee4670be","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":75},"in_reply_to":"3a71b18c_9c08d02f","updated":"2016-12-13 01:42:47.000000000","message":"Done","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"}],"neutron/tests/unit/objects/qos/test_policy.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c0a19b4019d816fe92f9a52930faa6cbf338007e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        rules \u003d []"},{"line_number":138,"context_line":"        for obj_cls in (RULE_OBJ_CLS.get(rule_type)"},{"line_number":139,"context_line":"                        for rule_type in rule_type):"},{"line_number":140,"context_line":"            rule_fields \u003d self.get_random_db_fields(obj_cls\u003dobj_cls)"},{"line_number":141,"context_line":"            rule_fields[\u0027qos_policy_id\u0027] \u003d policy_obj.id"},{"line_number":142,"context_line":"            rule_obj \u003d obj_cls(self.context, **rule_fields)"},{"line_number":143,"context_line":"            rule_obj.create()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_dfc9f879","line":140,"range":{"start_line":140,"start_character":41,"end_line":140,"end_character":45},"updated":"2016-12-14 18:31:42.000000000","message":"They are used here as object_fields - is this correct?","commit_id":"70c55b79b5994c430ca6adba088c4f2af69e6f1d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b402c5524aceb5b2cae890c87382d1d2404c6821","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        rules \u003d []"},{"line_number":138,"context_line":"        for obj_cls in (RULE_OBJ_CLS.get(rule_type)"},{"line_number":139,"context_line":"                        for rule_type in rule_type):"},{"line_number":140,"context_line":"            rule_fields \u003d self.get_random_db_fields(obj_cls\u003dobj_cls)"},{"line_number":141,"context_line":"            rule_fields[\u0027qos_policy_id\u0027] \u003d policy_obj.id"},{"line_number":142,"context_line":"            rule_obj \u003d obj_cls(self.context, **rule_fields)"},{"line_number":143,"context_line":"            rule_obj.create()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_4db5262f","line":140,"range":{"start_line":140,"start_character":41,"end_line":140,"end_character":45},"in_reply_to":"1a6eadb0_dfc5783c","updated":"2016-12-15 09:50:27.000000000","message":"I\u0027ve changed it to get_random_object_fields.","commit_id":"70c55b79b5994c430ca6adba088c4f2af69e6f1d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fbc5e8857c62a660a73753f6a999d8c0113ec527","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        rules \u003d []"},{"line_number":138,"context_line":"        for obj_cls in (RULE_OBJ_CLS.get(rule_type)"},{"line_number":139,"context_line":"                        for rule_type in rule_type):"},{"line_number":140,"context_line":"            rule_fields \u003d self.get_random_db_fields(obj_cls\u003dobj_cls)"},{"line_number":141,"context_line":"            rule_fields[\u0027qos_policy_id\u0027] \u003d policy_obj.id"},{"line_number":142,"context_line":"            rule_obj \u003d obj_cls(self.context, **rule_fields)"},{"line_number":143,"context_line":"            rule_obj.create()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_dfc5783c","line":140,"range":{"start_line":140,"start_character":41,"end_line":140,"end_character":45},"in_reply_to":"1a6eadb0_dfc9f879","updated":"2016-12-14 18:33:26.000000000","message":"Yeah, you are right.","commit_id":"70c55b79b5994c430ca6adba088c4f2af69e6f1d"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb25355af849f8eb17dd605cd1c69bd12787adb","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    # TODO(ihrachys): rename the method to explicitly reflect it returns db"},{"line_number":494,"context_line":"    # attributes not object fields"},{"line_number":495,"context_line":"    def get_random_fields(self, obj_cls\u003dNone):"},{"line_number":496,"context_line":"        obj_cls \u003d obj_cls or self._test_class"},{"line_number":497,"context_line":"        fields \u003d {}"},{"line_number":498,"context_line":"        ip_version \u003d tools.get_random_ip_version()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_368df77b","line":495,"updated":"2016-12-08 14:38:34.000000000","message":"You could reuse get_random_object_fields here.","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cc389cf237be6bf942485496394b7243c9b12445","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    # TODO(ihrachys): rename the method to explicitly reflect it returns db"},{"line_number":494,"context_line":"    # attributes not object fields"},{"line_number":495,"context_line":"    def get_random_fields(self, obj_cls\u003dNone):"},{"line_number":496,"context_line":"        obj_cls \u003d obj_cls or self._test_class"},{"line_number":497,"context_line":"        fields \u003d {}"},{"line_number":498,"context_line":"        ip_version \u003d tools.get_random_ip_version()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ee74b0fe","line":495,"in_reply_to":"3a71b18c_368df77b","updated":"2016-12-13 01:43:26.000000000","message":"Done","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f599f497288f0632f70c489a12dec341ab0c7af4","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f799ddd1","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"updated":"2016-12-07 22:17:44.000000000","message":"I\u0027d prefer to modify this line instead of create a new one.  But if it\u0027s required maybe this can be achieved better with a private function consumed by other public methods, something like \n\ndef get_random_fields(self, obj_cls\u003dNone):\n    return obj_cls.modify_fields_to_db(self._get_random_fields(obj_cls))\n\ndef get_random_object_fields(self, obj_cls\u003dNone):\n    return self._get_random_fields(obj_cls)\n\n\ndef _get_random_fields(self, obj_cls):\n    ...","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"593542411b12ec36abd0d2ceb218fa4d0e12b908","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_4e83e4cc","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"in_reply_to":"3a71b18c_bb02d26d","updated":"2016-12-13 01:42:47.000000000","message":"Done","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb25355af849f8eb17dd605cd1c69bd12787adb","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d6ae83e6","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"in_reply_to":"3a71b18c_bb02d26d","updated":"2016-12-08 14:38:34.000000000","message":"Yeap. See the TODO in line 493-494. This should be handled and then we can kill the TODO. I would suggest to rename get_random_fields on the first step, then add this new method.","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"593542411b12ec36abd0d2ceb218fa4d0e12b908","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8e6dfc34","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"in_reply_to":"3a71b18c_d6ae83e6","updated":"2016-12-13 01:42:47.000000000","message":"Done","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b1fc55659c334a72ce19a53837fab9e47eccefb5","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_bb02d26d","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"in_reply_to":"3a71b18c_f799ddd1","updated":"2016-12-08 14:28:33.000000000","message":"Agree, but I would call it:\n- get_random_db_fields\n- get_random_object_fields","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"593542411b12ec36abd0d2ceb218fa4d0e12b908","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":501,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":502,"context_line":"                fields[field] \u003d get_value(generator, ip_version)"},{"line_number":503,"context_line":"        return obj_cls.modify_fields_to_db(fields)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def get_random_object_fields(self, obj_cls\u003dNone):"},{"line_number":506,"context_line":"        obj_cls \u003d obj_cls or self._test_class"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ee1d90be","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":42},"in_reply_to":"3a71b18c_f799ddd1","updated":"2016-12-13 01:42:47.000000000","message":"Is there a particular reason for making it a private function?","commit_id":"d46ccf6ba49339cfa92224b94dbab077dd1c141f"}]}