)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6568af5f0206034b7e956c642b296f510142c53e","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":531,"context_line":"            for subnet in p[\u0027subnets\u0027]:"},{"line_number":532,"context_line":"                if ipv6_utils.is_ipv6_pd_enabled(subnet):"},{"line_number":533,"context_line":"                    interface_name \u003d self.get_internal_device_name(p[\u0027id\u0027])"},{"line_number":534,"context_line":"                    self.agent.pd.enable_subnet(self.router_id, subnet[\u0027id\u0027],"},{"line_number":535,"context_line":"                                     subnet[\u0027cidr\u0027],"},{"line_number":536,"context_line":"                                     interface_name, p[\u0027mac_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_fbe5d808","line":533,"updated":"2017-01-11 17:42:51.000000000","message":"Why don\u0027t we add a rule in this case?","commit_id":"d0d5d019cb01c9ac22d2a4f746b599fdd0b9da50"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"4caadbe731a0205e229217d5a26464b481a0d1be","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":531,"context_line":"            for subnet in p[\u0027subnets\u0027]:"},{"line_number":532,"context_line":"                if ipv6_utils.is_ipv6_pd_enabled(subnet):"},{"line_number":533,"context_line":"                    interface_name \u003d self.get_internal_device_name(p[\u0027id\u0027])"},{"line_number":534,"context_line":"                    self.agent.pd.enable_subnet(self.router_id, subnet[\u0027id\u0027],"},{"line_number":535,"context_line":"                                     subnet[\u0027cidr\u0027],"},{"line_number":536,"context_line":"                                     interface_name, p[\u0027mac_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_9c935ca3","line":533,"in_reply_to":"ba5201f7_fbe5d808","updated":"2017-01-13 11:27:23.000000000","message":"When the port is new the subnet will only have the temporary ::/64 prefix. It\u0027s in the port update that it gets its real prefix from the PD server.","commit_id":"d0d5d019cb01c9ac22d2a4f746b599fdd0b9da50"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e305d7ad49a488179e5becd61cbc734ee85c7921","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        ex_gw_device \u003d self.get_external_device_name("},{"line_number":222,"context_line":"            self.get_ex_gw_port()[\u0027id\u0027])"},{"line_number":223,"context_line":"        for prefix in prefixes:"},{"line_number":224,"context_line":"            ext_scope_mark \u003d self.get_address_scope_mark_mask(ext_scope)"},{"line_number":225,"context_line":"            self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":226,"context_line":"                \u0027neutron-l3-agent-scope\u0027,"},{"line_number":227,"context_line":"                \u0027-i %s -j MARK --set-xmark %s -d %s\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_0bc9d578","line":224,"updated":"2017-01-19 16:59:09.000000000","message":"This can be moved outside the loop since it doesn\u0027t change.","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e305d7ad49a488179e5becd61cbc734ee85c7921","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        for prefix in prefixes:"},{"line_number":224,"context_line":"            ext_scope_mark \u003d self.get_address_scope_mark_mask(ext_scope)"},{"line_number":225,"context_line":"            self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":226,"context_line":"                \u0027neutron-l3-agent-scope\u0027,"},{"line_number":227,"context_line":"                \u0027-i %s -j MARK --set-xmark %s -d %s\u0027"},{"line_number":228,"context_line":"                % (ex_gw_device, ext_scope_mark, prefix),"},{"line_number":229,"context_line":"                wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_c0024c3e","line":226,"updated":"2017-01-19 16:59:09.000000000","message":"Is this just supposed to be \u0027scope\u0027?  The name of the binary (neutron-l3-agent) will get added automatdially in the iptables code, right?  Maybe you don\u0027t need the wrap\u003dFalse below too?","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e305d7ad49a488179e5becd61cbc734ee85c7921","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            ext_scope_mark \u003d self.get_address_scope_mark_mask(ext_scope)"},{"line_number":225,"context_line":"            self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":226,"context_line":"                \u0027neutron-l3-agent-scope\u0027,"},{"line_number":227,"context_line":"                \u0027-i %s -j MARK --set-xmark %s -d %s\u0027"},{"line_number":228,"context_line":"                % (ex_gw_device, ext_scope_mark, prefix),"},{"line_number":229,"context_line":"                wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_abed218d","line":227,"updated":"2017-01-19 16:59:09.000000000","message":"We can create most of this rule outside the loop using address_scope_mangle_rule(), then just add the \u0027-d prefix\u0027 part in the loop","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e786aea10bf8c1e6ab8b2c10f85a9572b591812","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_38c816a8","line":227,"updated":"2017-01-23 14:27:32.000000000","message":"I still don\u0027t think this is correct, we shouldn\u0027t be using the name of the agent for the chain to add the rule to.  For example, when the vpn-agent is run it inherits all the L3 code, but the binary name is neutron-vpn-agent.  In that case this rule will not work.\n\nCan you send me a before/after of iptables-save?  There must be something I\u0027m missing.  I just don\u0027t have a PD server here at the moment, guess I should get one running...","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"16ea474c79c6475c2319dc7e135091ce421f4e78","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_271e2f5f","line":227,"in_reply_to":"5a3905b3_0e0cf0eb","updated":"2017-01-23 15:41:55.000000000","message":"BTW, here\u0027s the before/after of iptables-save when neutron-l3-agent-scope is used http://paste.openstack.org/show/596060/","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"318c15dbe6c47fabb8d39009109aa40914272aa9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_27cf0f2a","line":227,"in_reply_to":"5a3905b3_271e2f5f","updated":"2017-01-23 15:52:42.000000000","message":"Thanks John, can you get the output when just \u0027scope\u0027 and wrap\u003dFalse removed?\n\nThe one thing I did notice from that paste is that we need to build this iptables rule differently - need the prefix first:\n\n\u0027-d %s \u0027 % prefix + scope_rule\n\nThe iptables_manager wants things in the order iptables-save will dump them.  Don\u0027t think that\u0027s causing the problem.","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"b2798ce1809f696daa366b07d74f8acf0a977504","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_1fdc9e11","line":227,"in_reply_to":"5a3905b3_27cf0f2a","updated":"2017-01-26 13:54:00.000000000","message":"Hey Brian, the output with just \u0027scope\u0027 and wrap\u003dFalse removed is:\n\n  http://paste.openstack.org/show/596570/\n\nAnd I think I\u0027ve discovered why! The rule DOES get added, but it\u0027s removed almost immediately by [1] when it gets to [2]. I\u0027m going to fix this by modifying empty_chain() to take a tag and NOT remove rules that match. Once I\u0027ve done that and modified the tests to match I think we\u0027ll be good to go.\n\n  [1] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L1079\n  [2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L983","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"0487505e3bdeef50712c7683da55f6cbc0c8cb56","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_f87a0ef0","line":227,"in_reply_to":"5a3905b3_38c816a8","updated":"2017-01-23 14:31:19.000000000","message":"Yeah, there must be a step we\u0027re missing because just using \u0027scope\u0027 causes the creation of a new chain just called \u0027scope\u0027 that this rule is added to. Let me do some quick digging, hopefully it\u0027s something obvious.","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"3128c5f70bc529143326e1277a2da1b63ece336d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_0e0cf0eb","line":227,"in_reply_to":"5a3905b3_6e6ad4b4","updated":"2017-01-23 15:03:07.000000000","message":"Ah but of course it does, it\u0027s added in address_scope_mangle_rule(). Might be onto something here.","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"151516e7d63b09c26fe775c3164dc1ef320881d8","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_6e6ad4b4","line":227,"in_reply_to":"5a3905b3_db50ecd6","updated":"2017-01-23 14:58:56.000000000","message":"Except it doesn\u0027t because there\u0027s no \u0027$\u0027 char in our rule, so that logic is skipped. Elsewhere that only seems to be included if the rule has a target which ours doesn\u0027t","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b719393c93e56b51f236be95d9a4181255266a67","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        scope_rule \u003d self.address_scope_mangle_rule(ex_gw_device,"},{"line_number":225,"context_line":"                                                    ext_scope_mark)"},{"line_number":226,"context_line":"        self.iptables_manager.ipv6[\u0027mangle\u0027].add_rule("},{"line_number":227,"context_line":"            \u0027neutron-l3-agent-scope\u0027,"},{"line_number":228,"context_line":"            scope_rule + \u0027 -d %s\u0027 % prefix,"},{"line_number":229,"context_line":"            wrap\u003dFalse, tag\u003d(\u0027prefix_delegation_%s\u0027 % subnet_id))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_db50ecd6","line":227,"in_reply_to":"5a3905b3_f87a0ef0","updated":"2017-01-23 14:41:41.000000000","message":"Right.  Dropping the wrap\u003dFalse would cause the name to be changed to $binary_name-scope (neutron-l3-agent-scope in our case).  I\u0027m sure it\u0027s just a small tweak somewhere else.","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e786aea10bf8c1e6ab8b2c10f85a9572b591812","unresolved":false,"context_lines":[{"line_number":910,"context_line":"    def _initialize_address_scope_iptables(self, iptables_manager):"},{"line_number":911,"context_line":"        # Add address scope related chains"},{"line_number":912,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_chain(\u0027scope\u0027)"},{"line_number":913,"context_line":"        iptables_manager.ipv6[\u0027mangle\u0027].add_chain(\u0027scope\u0027)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_chain(\u0027floatingip\u0027)"},{"line_number":916,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_chain(\u0027float-snat\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_f8d4ce20","line":913,"updated":"2017-01-23 14:27:32.000000000","message":"Perhaps we\u0027re missing something here, like is done on L920?  i.e. there\u0027s a missing jump rule to what we\u0027re adding?","commit_id":"a1b6bad195386a2ebd447cdc4a7f7a326edcaa28"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8a70106ce32e75bf1e3a86cae9447cfc3dd65930","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.common import utils as common_utils"},{"line_number":30,"context_line":"from neutron.ipam import utils as ipam_utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import six"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"INTERNAL_DEV_PREFIX \u003d namespaces.INTERNAL_DEV_PREFIX"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_09e2739f","line":32,"updated":"2017-01-27 16:31:50.000000000","message":"This should be above the neutron imports, surprised pep8 passed","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"a111cdbc3448b30783ae8b17f956a0ef23d2b393","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.common import utils as common_utils"},{"line_number":30,"context_line":"from neutron.ipam import utils as ipam_utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import six"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"INTERNAL_DEV_PREFIX \u003d namespaces.INTERNAL_DEV_PREFIX"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_6ae57436","line":32,"in_reply_to":"3a461143_09e2739f","updated":"2017-01-30 15:05:40.000000000","message":"Done. Oddly, the only pep8 error I get is from putting it right at the top of the import list.","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"b1c8b63a66b9482970d07dec9c103e70c08cfa53","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            for subnet in p[\u0027subnets\u0027]:"},{"line_number":547,"context_line":"                if ipv6_utils.is_ipv6_pd_enabled(subnet):"},{"line_number":548,"context_line":"                    self.agent.pd.disable_subnet(self.router_id, subnet[\u0027id\u0027])"},{"line_number":549,"context_line":"                    del self.pd_subnets[subnet[\u0027id\u0027]]"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        updated_cidrs \u003d []"},{"line_number":552,"context_line":"        if updated_ports:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_99aedf83","line":549,"updated":"2017-01-26 17:45:36.000000000","message":"For some reason this doesn\u0027t seem to get called when I try it locally, despite the relevant unit test passing. Once I get to the bottom of this I\u0027ll remove the -workflow.","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"a111cdbc3448b30783ae8b17f956a0ef23d2b393","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            for subnet in p[\u0027subnets\u0027]:"},{"line_number":547,"context_line":"                if ipv6_utils.is_ipv6_pd_enabled(subnet):"},{"line_number":548,"context_line":"                    self.agent.pd.disable_subnet(self.router_id, subnet[\u0027id\u0027])"},{"line_number":549,"context_line":"                    del self.pd_subnets[subnet[\u0027id\u0027]]"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        updated_cidrs \u003d []"},{"line_number":552,"context_line":"        if updated_ports:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_1b5a802a","line":549,"in_reply_to":"3a461143_99aedf83","updated":"2017-01-30 15:05:40.000000000","message":"Having rebuilt my devstack env using the latest patchset, I can now see that this is actually being called correctly, which restores my faith in the unit test that covers this.","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"806e90afca689ba0210ca075bd4264b366d6a656","unresolved":false,"context_lines":[{"line_number":2681,"context_line":"        self._pd_assert_radvd_calls(ri)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"        # Check that iptables rule is added"},{"line_number":2684,"context_line":"        ipv6_mangle.add_rule.assert_called()"},{"line_number":2685,"context_line":""},{"line_number":2686,"context_line":"        # Now remove the interface"},{"line_number":2687,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_a78e5625","line":2684,"updated":"2017-01-19 04:47:45.000000000","message":"I think this would be better if it checked the call was the rule we expected, assert_called_once_with().  I actually started working on that change by triggering a failure and saw that add_rule() was called twice with the same arguments.  I would have only expected a single call, didn\u0027t dig in more than that.","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"b5992e31d4e91fbe7cdba31be810f72696914f39","unresolved":false,"context_lines":[{"line_number":2681,"context_line":"        self._pd_assert_radvd_calls(ri)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"        # Check that iptables rule is added"},{"line_number":2684,"context_line":"        ipv6_mangle.add_rule.assert_called()"},{"line_number":2685,"context_line":""},{"line_number":2686,"context_line":"        # Now remove the interface"},{"line_number":2687,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_f7c8f476","line":2684,"in_reply_to":"5a3905b3_a78e5625","updated":"2017-01-19 14:46:42.000000000","message":"You\u0027re right, that would be more precise. New patchset on the way.","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e305d7ad49a488179e5becd61cbc734ee85c7921","unresolved":false,"context_lines":[{"line_number":2687,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"        # Check that iptables rule is removed by tag"},{"line_number":2690,"context_line":"        ipv6_mangle.clear_rules_by_tag.assert_called()"},{"line_number":2691,"context_line":""},{"line_number":2692,"context_line":"    @mock.patch.object(dibbler.PDDibbler, \u0027get_prefix\u0027, autospec\u003dTrue)"},{"line_number":2693,"context_line":"    @mock.patch.object(dibbler.os, \u0027getpid\u0027, return_value\u003d1234)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_f3c55f5b","line":2690,"updated":"2017-01-19 16:59:09.000000000","message":"Should check argument here as well.","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e3350b76809bd1e2de2dd780e946cce5a6e06254","unresolved":false,"context_lines":[{"line_number":2684,"context_line":""},{"line_number":2685,"context_line":"        # Check that iptables rule is added"},{"line_number":2686,"context_line":"        # this needs work"},{"line_number":2687,"context_line":"        expected \u003d ["},{"line_number":2688,"context_line":"            mock.call.add_rule("},{"line_number":2689,"context_line":"                \u0027-i %s -j MARK --set-xmark 0x4000000/%s\u0027 % (ifname,"},{"line_number":2690,"context_line":"                    n_const.ROUTER_MARK_MASK),"},{"line_number":2691,"context_line":"                \u0027tag\u003dprefix_delegation_%s\u0027 % subnet_id)]"},{"line_number":2692,"context_line":"        ipv6_mangle.assert_has_calls(expected)"},{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        # Now remove the interface"},{"line_number":2695,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_5246f6bf","line":2692,"range":{"start_line":2687,"start_character":8,"end_line":2692,"end_character":46},"updated":"2017-01-20 14:39:59.000000000","message":"I think we\u0027re massively overcomplicating this. The test in test_router_info is already checking that process_pd_iptables_rules works correctly. Here we just need to make sure it\u0027s called. Will fix.","commit_id":"982ac5fecf81ac381ed0ea5a68581383f08ca124"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"41f988c07d38d7a568659a399e78da91e04e569d","unresolved":false,"context_lines":[{"line_number":2684,"context_line":""},{"line_number":2685,"context_line":"        # Check that iptables rule is added"},{"line_number":2686,"context_line":"        # this needs work"},{"line_number":2687,"context_line":"        expected \u003d ["},{"line_number":2688,"context_line":"            mock.call.add_rule("},{"line_number":2689,"context_line":"                \u0027-i %s -j MARK --set-xmark 0x4000000/%s\u0027 % (ifname,"},{"line_number":2690,"context_line":"                    n_const.ROUTER_MARK_MASK),"},{"line_number":2691,"context_line":"                \u0027tag\u003dprefix_delegation_%s\u0027 % subnet_id)]"},{"line_number":2692,"context_line":"        ipv6_mangle.assert_has_calls(expected)"},{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        # Now remove the interface"},{"line_number":2695,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_b8b7f984","line":2692,"range":{"start_line":2687,"start_character":8,"end_line":2692,"end_character":46},"in_reply_to":"5a3905b3_5246f6bf","updated":"2017-01-20 15:14:34.000000000","message":"Also, the way that this test is setup, updated_ciders on L550 of router_info.py is empty, meaning that the expected call to pv6_mangle is never made - which confirms my suspicions from yesterday about the rule being wrong. Investigating.","commit_id":"982ac5fecf81ac381ed0ea5a68581383f08ca124"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b2a13c2b404f741217660ebe378f48ccf9b6cd3","unresolved":false,"context_lines":[{"line_number":2684,"context_line":""},{"line_number":2685,"context_line":"        # Check that iptables rule is added"},{"line_number":2686,"context_line":"        # this needs work"},{"line_number":2687,"context_line":"        expected \u003d ["},{"line_number":2688,"context_line":"            mock.call.add_rule("},{"line_number":2689,"context_line":"                \u0027-i %s -j MARK --set-xmark 0x4000000/%s\u0027 % (ifname,"},{"line_number":2690,"context_line":"                    n_const.ROUTER_MARK_MASK),"},{"line_number":2691,"context_line":"                \u0027tag\u003dprefix_delegation_%s\u0027 % subnet_id)]"},{"line_number":2692,"context_line":"        ipv6_mangle.assert_has_calls(expected)"},{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        # Now remove the interface"},{"line_number":2695,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_4378e62a","line":2692,"range":{"start_line":2687,"start_character":8,"end_line":2692,"end_character":46},"in_reply_to":"5a3905b3_b8b7f984","updated":"2017-01-20 15:27:01.000000000","message":"Yeah, this really was just a hack of what a check could be, lines 2664-5 are pretty ugly too.  Making sure it\u0027s called didn\u0027t seem like enough, since it is called, just not with the prefix we expected.","commit_id":"982ac5fecf81ac381ed0ea5a68581383f08ca124"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8a70106ce32e75bf1e3a86cae9447cfc3dd65930","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"        # with the new prefix"},{"line_number":2687,"context_line":"        self._pd_assert_radvd_calls(ri)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"        self.assertEqual(ri.pd_subnets, {subnet_id: prefix})"},{"line_number":2690,"context_line":"        # Check that _process_pd_iptables_rules() is called correctly"},{"line_number":2691,"context_line":"        ri._process_pd_iptables_rules.assert_called_once_with(prefix,"},{"line_number":2692,"context_line":"                                                              subnet_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_c95a2b50","line":2689,"updated":"2017-01-27 16:31:50.000000000","message":"Reversed: (expected, actual)","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"a111cdbc3448b30783ae8b17f956a0ef23d2b393","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"        # with the new prefix"},{"line_number":2687,"context_line":"        self._pd_assert_radvd_calls(ri)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"        self.assertEqual(ri.pd_subnets, {subnet_id: prefix})"},{"line_number":2690,"context_line":"        # Check that _process_pd_iptables_rules() is called correctly"},{"line_number":2691,"context_line":"        ri._process_pd_iptables_rules.assert_called_once_with(prefix,"},{"line_number":2692,"context_line":"                                                              subnet_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_0acdd0b6","line":2689,"in_reply_to":"3a461143_c95a2b50","updated":"2017-01-30 15:05:40.000000000","message":"Done","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8a70106ce32e75bf1e3a86cae9447cfc3dd65930","unresolved":false,"context_lines":[{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        # Now remove the interface"},{"line_number":2695,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"},{"line_number":2696,"context_line":"        self.assertEqual(ri.pd_subnets, {})"},{"line_number":2697,"context_line":""},{"line_number":2698,"context_line":"    @mock.patch.object(dibbler.PDDibbler, \u0027get_prefix\u0027, autospec\u003dTrue)"},{"line_number":2699,"context_line":"    @mock.patch.object(dibbler.os, \u0027getpid\u0027, return_value\u003d1234)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_0955131c","line":2696,"updated":"2017-01-27 16:31:50.000000000","message":"Here too","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"a111cdbc3448b30783ae8b17f956a0ef23d2b393","unresolved":false,"context_lines":[{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        # Now remove the interface"},{"line_number":2695,"context_line":"        self._pd_remove_interfaces(intfs, agent, router, ri)"},{"line_number":2696,"context_line":"        self.assertEqual(ri.pd_subnets, {})"},{"line_number":2697,"context_line":""},{"line_number":2698,"context_line":"    @mock.patch.object(dibbler.PDDibbler, \u0027get_prefix\u0027, autospec\u003dTrue)"},{"line_number":2699,"context_line":"    @mock.patch.object(dibbler.os, \u0027getpid\u0027, return_value\u003d1234)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_4ac35889","line":2696,"in_reply_to":"3a461143_0955131c","updated":"2017-01-30 15:05:40.000000000","message":"Done","commit_id":"231b6444e68408e926c6b55530f837f2609beb57"}],"neutron/tests/unit/agent/l3/test_router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e305d7ad49a488179e5becd61cbc734ee85c7921","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                    \u0027via\u0027, \u002710.100.10.30\u0027]]"},{"line_number":124,"context_line":"        self._check_agent_method_called(expected)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_process_pd_iptables_rules(self):"},{"line_number":127,"context_line":"        subnet_id \u003d _uuid()"},{"line_number":128,"context_line":"        ex_gw_port \u003d {\u0027id\u0027: _uuid()}"},{"line_number":129,"context_line":"        prefix \u003d \u00272001:db8:cafe::/64\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_c668a4bd","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":14},"updated":"2017-01-19 16:59:09.000000000","message":"should be __p... since it\u0027s an internal method","commit_id":"6b6f9051092d35b5495e5426dfd2a30ef7a823ab"}]}
