)]}'
{"neutron/services/tag/tag_plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2ca2162c8527b7e8770abc7be3c7890711cfae98","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":105,"context_line":"            query \u003d context.session.query(tag_model.Tag)"},{"line_number":106,"context_line":"            query \u003d query.filter_by(standard_attr_id\u003dres.standard_attr_id)"},{"line_number":107,"context_line":"            query.delete()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @log_helpers.log_method_call"},{"line_number":110,"context_line":"    def delete_tag(self, context, resource, resource_id, tag):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_9be59839","line":107,"updated":"2016-12-15 19:17:32.000000000","message":"Ah, good catch.","commit_id":"58cd637e3309e40f4743f6d489f2fe323e2957ca"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9ed67906b0650b3222ec021a7ca5a6baca0f9f13","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":105,"context_line":"            query \u003d context.session.query(tag_model.Tag)"},{"line_number":106,"context_line":"            query \u003d query.filter_by(standard_attr_id\u003dres.standard_attr_id)"},{"line_number":107,"context_line":"            query.delete()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @log_helpers.log_method_call"},{"line_number":110,"context_line":"    def delete_tag(self, context, resource, resource_id, tag):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_dadc0f1b","line":107,"range":{"start_line":107,"start_character":12,"end_line":107,"end_character":26},"updated":"2016-12-13 01:07:35.000000000","message":"You misses this.","commit_id":"58cd637e3309e40f4743f6d489f2fe323e2957ca"}],"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0697cbb4d8be2fd17f51132cc308d0f191697d5e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            rev \u003d updated[\u0027revision_number\u0027]"},{"line_number":192,"context_line":"            updated \u003d directory.get_plugin().get_network("},{"line_number":193,"context_line":"                self.ctx, network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":"            self.assertGreater(updated[\u0027revision_number\u0027], rev)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_397f63e1","line":194,"range":{"start_line":194,"start_character":12,"end_line":194,"end_character":63},"updated":"2016-12-09 22:43:18.000000000","message":"this is fine also, but do we want to make sure its bumps by one when we add a tag to network?, can we have assertEqual(updated[\u0027revision_number\u0027], rev+1) too ?","commit_id":"58cd637e3309e40f4743f6d489f2fe323e2957ca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a7611ccbc7202e7b28ff4cd1541e794eee14aabd","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            rev \u003d updated[\u0027revision_number\u0027]"},{"line_number":192,"context_line":"            updated \u003d directory.get_plugin().get_network("},{"line_number":193,"context_line":"                self.ctx, network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":"            self.assertGreater(updated[\u0027revision_number\u0027], rev)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_39c203ea","line":194,"range":{"start_line":194,"start_character":12,"end_line":194,"end_character":63},"in_reply_to":"3a71b18c_397f63e1","updated":"2016-12-09 22:49:40.000000000","message":"No, we don\u0027t guarantee that it will bump by only one. We just guarantee that it bumps by at least one.","commit_id":"58cd637e3309e40f4743f6d489f2fe323e2957ca"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7a6c3b6bcdf3941e790fe6ca54e76cf6ae8dee8","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            rev \u003d updated[\u0027revision_number\u0027]"},{"line_number":192,"context_line":"            updated \u003d directory.get_plugin().get_network("},{"line_number":193,"context_line":"                self.ctx, network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":"            self.assertGreater(updated[\u0027revision_number\u0027], rev)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_39376300","line":194,"range":{"start_line":194,"start_character":12,"end_line":194,"end_character":63},"in_reply_to":"3a71b18c_39c203ea","updated":"2016-12-09 22:53:18.000000000","message":"ok thanks !","commit_id":"58cd637e3309e40f4743f6d489f2fe323e2957ca"}]}
