)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_364a18ad","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":20},"updated":"2017-02-23 05:35:09.000000000","message":"Not helper scripts but *WSGI* scripts. Also, it seems like we have a single script, not multiple.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_f6532069","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":46},"updated":"2017-02-23 05:35:09.000000000","message":"a WSGI compatible web server","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_f63ec026","line":7,"updated":"2017-02-23 05:35:09.000000000","message":"would you mind removing WIP?","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_b7cd0f33","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":20},"in_reply_to":"da36d5c6_364a18ad","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_d7ce032c","line":7,"in_reply_to":"da36d5c6_f63ec026","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 16:03:38 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_37767fd7","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":46},"in_reply_to":"da36d5c6_f6532069","updated":"2017-02-23 18:23:37.000000000","message":"Yeah, apache2 is associated how ubuntu names httpd server.  I\u0027m gonna change for web server","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_3673f816","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"updated":"2017-02-23 05:35:09.000000000","message":"it\u0027s not a \u0027helper\u0027, it\u0027s a wsgi script","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_b65d287b","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":57},"updated":"2017-02-23 05:35:09.000000000","message":"not \u0027neutron-server\u0027 (that is comprised of both api as well as rpc workers), but \u0027neutron API\u0027 (we are going to deploy RPC workers as a separate process, see neutron-rpc-server in setup.cfg).","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_361cd8c0","line":9,"updated":"2017-02-23 05:35:09.000000000","message":"why experimental? let\u0027s remove that notion, it should be supported in Pike.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_d76a83ec","line":9,"in_reply_to":"da36d5c6_361cd8c0","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Helper scripts for running under Apache2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"},{"line_number":13,"context_line":"Co-Authored-By: Brandon Logan \u003cbrandon.logan@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_968104c6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2017-02-23 05:35:09.000000000","message":"under ANY wsgi compatible web server","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"},{"line_number":13,"context_line":"Co-Authored-By: Brandon Logan \u003cbrandon.logan@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_9633c461","line":11,"updated":"2017-02-23 05:35:09.000000000","message":"DocImpact (you can steal it from https://review.openstack.org/#/c/436783/)","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EXPERIMENTAL support - Helpers for running neutron-server under"},{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"},{"line_number":13,"context_line":"Co-Authored-By: Brandon Logan \u003cbrandon.logan@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_3243ed43","line":11,"in_reply_to":"da36d5c6_9633c461","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Apache2 just like keystone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9bb8b33f6e1335219e574d832ac264b043d90e6"},{"line_number":13,"context_line":"Co-Authored-By: Brandon Logan \u003cbrandon.logan@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_b638c83e","line":13,"updated":"2017-02-23 05:35:09.000000000","message":"the change must include a release note that would describe the new operation mode.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"}],"doc/source/devref/apache-httpd.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9a0936c0b33bd1d443f91fddc240a8a0bb98baf3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"HTTPD in one of the default locations described in :doc:`configuration`."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Enable the site by creating a symlink from the file in ``sites-available`` to"},{"line_number":48,"context_line":"``sites-enabled``, for example, on Debian/Ubuntu systems"},{"line_number":49,"context_line":"(not required on Red Hat based systems)::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  ln -s /etc/apache2/sites-available/wsgi-neutron.conf /etc/apache2/sites-enabled/"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da36d5c6_cc9d8d67","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":39},"updated":"2017-02-23 20:56:25.000000000","message":"This whole paragraph is a little confusing. I would re-state it as:\n\nOn Debian/Ubuntu systems only, enable the site by creating a symlink from the file in ``sites-available`` to ``sites-enabled``, for example:","commit_id":"6f8730ae9a352fa4309ce5b19ce0bb4ddf81a604"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"c2566d8e92666e56ec4cecfa59d1ae60f447ed6b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"HTTPD in one of the default locations described in :doc:`configuration`."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Enable the site by creating a symlink from the file in ``sites-available`` to"},{"line_number":48,"context_line":"``sites-enabled``, for example, on Debian/Ubuntu systems"},{"line_number":49,"context_line":"(not required on Red Hat based systems)::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  ln -s /etc/apache2/sites-available/wsgi-neutron.conf /etc/apache2/sites-enabled/"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da36d5c6_7b18b4d3","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":39},"in_reply_to":"da36d5c6_cc9d8d67","updated":"2017-02-24 21:06:47.000000000","message":"Done","commit_id":"6f8730ae9a352fa4309ce5b19ce0bb4ddf81a604"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":".."},{"line_number":3,"context_line":"      Copyright 2017 Intel Corporation"},{"line_number":4,"context_line":"      All Rights Reserved."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da36d5c6_7de7c4ab","line":1,"updated":"2017-02-25 04:07:33.000000000","message":"I am not particularly happy about documenting it in devref (it\u0027s info that is valuable for actual users of the code, not developers). But I am ok with it, we may clean up the page once the info gets its way into manuals.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":".."},{"line_number":3,"context_line":"      Copyright 2017 Intel Corporation"},{"line_number":4,"context_line":"      All Rights Reserved."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba2be162_9a85f2ae","line":1,"in_reply_to":"da36d5c6_7de7c4ab","updated":"2017-03-01 20:55:15.000000000","message":"I like the idea of remove it once this is documented in another place.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"}],"doc/source/devref/index.rst":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":34,"context_line":"the developer guide includes information about Neutron testing infrastructure."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Programming HowTos and Tutorials"},{"line_number":38,"context_line":"--------------------------------"},{"line_number":39,"context_line":".. toctree::"},{"line_number":40,"context_line":"    :maxdepth: 3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da36d5c6_7d59848d","line":37,"updated":"2017-02-25 04:07:33.000000000","message":"I am not sure this is the right section for the page you add.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"the developer guide includes information about Neutron testing infrastructure."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Programming HowTos and Tutorials"},{"line_number":38,"context_line":"--------------------------------"},{"line_number":39,"context_line":".. toctree::"},{"line_number":40,"context_line":"    :maxdepth: 3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba2be162_1ac022e0","line":37,"in_reply_to":"da36d5c6_7d59848d","updated":"2017-03-01 20:55:15.000000000","message":"Any suggestion?","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":92,"context_line":"   fullstack_testing"},{"line_number":93,"context_line":"   testing_coverage"},{"line_number":94,"context_line":"   template_model_sync_test"},{"line_number":95,"context_line":"   db_transient_failure_injection"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Module Reference"},{"line_number":98,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da36d5c6_fd765404","line":95,"updated":"2017-02-25 04:07:33.000000000","message":"huh?","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"   fullstack_testing"},{"line_number":93,"context_line":"   testing_coverage"},{"line_number":94,"context_line":"   template_model_sync_test"},{"line_number":95,"context_line":"   db_transient_failure_injection"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Module Reference"},{"line_number":98,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba2be162_3ab7a687","line":95,"in_reply_to":"da36d5c6_dd4fcf31","updated":"2017-03-01 20:55:15.000000000","message":"My bad, I rebased it when it was not needed.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9adfe7157e41708755800cb409a7f71cd4729ab3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"   fullstack_testing"},{"line_number":93,"context_line":"   testing_coverage"},{"line_number":94,"context_line":"   template_model_sync_test"},{"line_number":95,"context_line":"   db_transient_failure_injection"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Module Reference"},{"line_number":98,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da36d5c6_dd4fcf31","line":95,"in_reply_to":"da36d5c6_fd765404","updated":"2017-02-25 04:50:38.000000000","message":"Nevermind, my gerrit mixed diff before.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"}],"httpd/wsgi-neutron.conf":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"030fad56db84779b0cfbfe83681180bd49e935f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a71b18c_b0de1d6b","updated":"2016-12-10 08:09:50.000000000","message":"This is really useful! Often we have to guess what configuration was used. However, it would be more appropriate to include it as documentation IMO.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da36d5c6_960ae477","in_reply_to":"3a71b18c_b0de1d6b","updated":"2017-02-23 05:35:09.000000000","message":"I don\u0027t actually think we should get into business of shipping httpd specific examples with neutron. It should be ok to keep it in docs/devstack.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da36d5c6_571bf372","in_reply_to":"da36d5c6_960ae477","updated":"2017-02-23 18:23:37.000000000","message":"I was following what keystone did[1], eventually those examples can be auto-generated as we are doing with configuration files.  I\u0027m going to include some documentation as well.\n\n[1] https://github.com/openstack/keystone/tree/master/httpd","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    WSGIScriptAlias / /usr/local/bin/neutron-wsgi-server"},{"line_number":7,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":8,"context_line":"    WSGIPassAuthorization On"},{"line_number":9,"context_line":"    LimitRequestBody 114688"},{"line_number":10,"context_line":"    \u003cIfVersion \u003e\u003d 2.4\u003e"},{"line_number":11,"context_line":"      ErrorLogFormat \"%{cu}t %M\""},{"line_number":12,"context_line":"    \u003c/IfVersion\u003e"}],"source_content_type":"text/plain","patch_set":1,"id":"da36d5c6_b6d448bd","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":27},"updated":"2017-02-23 05:35:09.000000000","message":"what\u0027s that limit for, exactly? (but again, I suggest we don\u0027t put ourselves in the position to guide on apache2 configuration).","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    WSGIScriptAlias / /usr/local/bin/neutron-wsgi-server"},{"line_number":7,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":8,"context_line":"    WSGIPassAuthorization On"},{"line_number":9,"context_line":"    LimitRequestBody 114688"},{"line_number":10,"context_line":"    \u003cIfVersion \u003e\u003d 2.4\u003e"},{"line_number":11,"context_line":"      ErrorLogFormat \"%{cu}t %M\""},{"line_number":12,"context_line":"    \u003c/IfVersion\u003e"}],"source_content_type":"text/plain","patch_set":1,"id":"da36d5c6_97272bb5","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":27},"in_reply_to":"da36d5c6_b6d448bd","updated":"2017-02-23 18:23:37.000000000","message":"I\u0027m gonna remove it","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            Require all granted"},{"line_number":18,"context_line":"        \u003c/IfVersion\u003e"},{"line_number":19,"context_line":"        \u003cIfVersion \u003c 2.4\u003e"},{"line_number":20,"context_line":"            Order allow,denyw"},{"line_number":21,"context_line":"            Allow from all"},{"line_number":22,"context_line":"        \u003c/IfVersion\u003e"},{"line_number":23,"context_line":"    \u003c/Directory\u003e"}],"source_content_type":"text/plain","patch_set":3,"id":"da36d5c6_dd527066","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"updated":"2017-02-25 04:07:33.000000000","message":"?","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            Require all granted"},{"line_number":18,"context_line":"        \u003c/IfVersion\u003e"},{"line_number":19,"context_line":"        \u003cIfVersion \u003c 2.4\u003e"},{"line_number":20,"context_line":"            Order allow,denyw"},{"line_number":21,"context_line":"            Allow from all"},{"line_number":22,"context_line":"        \u003c/IfVersion\u003e"},{"line_number":23,"context_line":"    \u003c/Directory\u003e"}],"source_content_type":"text/plain","patch_set":3,"id":"ba2be162_7ab11e8f","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"in_reply_to":"da36d5c6_dd527066","updated":"2017-03-01 20:55:15.000000000","message":"Done","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"}],"neutron/server/__init__.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron._i18n import _"},{"line_number":24,"context_line":"from neutron.common import config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def init_configuration():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_ad1b621a","line":24,"updated":"2017-03-01 20:55:15.000000000","message":"It seems like there is a circular import issue here[1]\n\n[1] http://paste.openstack.org/show/601003/","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b182caf74874d2822906c992da18456f6934fade","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron._i18n import _"},{"line_number":24,"context_line":"from neutron.common import config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def init_configuration():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_514bdb58","line":24,"in_reply_to":"ba2be162_ad1b621a","updated":"2017-03-03 23:56:56.000000000","message":"Ihar\n\nI\u0027m getting the same error with your approach[1], apparently sometimes display the information and others don\u0027t\n\n[1] http://paste.openstack.org/show/601389/","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa52abda2015696d9d83f64c2a181cfef6bb132","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.common import profiler"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def init_configuration():"},{"line_number":29,"context_line":"    # the configuration will be read into the cfg.CONF global data structure"},{"line_number":30,"context_line":"    config.init(sys.argv[1:])"},{"line_number":31,"context_line":"    config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_a54a6824","line":28,"updated":"2017-04-06 06:44:56.000000000","message":"this is an internal method can we prefix with _","commit_id":"6995bb85cb00def58700933f7a8db5ceb1dec565"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa52abda2015696d9d83f64c2a181cfef6bb132","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    init_configuration()"},{"line_number":51,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":52,"context_line":"    return config.load_paste_app(\u0027neutron\u0027)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_053c7491","line":53,"updated":"2017-04-06 06:44:56.000000000","message":"nit - please delete this line","commit_id":"6995bb85cb00def58700933f7a8db5ceb1dec565"}],"neutron/server/wsgi.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"WSGI script for Neutron Server"},{"line_number":17,"context_line":"EXPERIMENTAL support script for running Neutron Server under Apache2 etc."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_161fd4b7","line":17,"updated":"2017-02-23 05:35:09.000000000","message":"Please remove that EXPERIMENTAL part, we are going to officially support it in Pike, as a default mode.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"WSGI script for Neutron Server"},{"line_number":17,"context_line":"EXPERIMENTAL support script for running Neutron Server under Apache2 etc."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_b7534f16","line":17,"in_reply_to":"da36d5c6_161fd4b7","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_application():"},{"line_number":31,"context_line":"    # TODO(electrocucaracha) Validate plugin/extension configurations are"},{"line_number":32,"context_line":"    # loaded"},{"line_number":33,"context_line":"    config.init(sys.argv[1:])"},{"line_number":34,"context_line":"    config.setup_logging()"},{"line_number":35,"context_line":"    config.set_config_defaults()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_56beac65","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":12},"updated":"2017-02-23 05:35:09.000000000","message":"what do you mean? if they are not, the server will fail to load, because then core_plugin would not be set.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_application():"},{"line_number":31,"context_line":"    # TODO(electrocucaracha) Validate plugin/extension configurations are"},{"line_number":32,"context_line":"    # loaded"},{"line_number":33,"context_line":"    config.init(sys.argv[1:])"},{"line_number":34,"context_line":"    config.setup_logging()"},{"line_number":35,"context_line":"    config.set_config_defaults()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_f77ea768","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":12},"in_reply_to":"da36d5c6_56beac65","updated":"2017-02-23 18:23:37.000000000","message":"Our major concern is about the way that other configuration files are loaded, but given that this is only targeting to neutron-server and not to the agents I think that we\u0027re ok.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def get_application():"},{"line_number":31,"context_line":"    # TODO(electrocucaracha) Validate plugin/extension configurations are"},{"line_number":32,"context_line":"    # loaded"},{"line_number":33,"context_line":"    config.init(sys.argv[1:])"},{"line_number":34,"context_line":"    config.setup_logging()"},{"line_number":35,"context_line":"    config.set_config_defaults()"},{"line_number":36,"context_line":"    if not cfg.CONF.config_file:"},{"line_number":37,"context_line":"        sys.exit(_(\"ERROR: Unable to find configuration file via the default\""},{"line_number":38,"context_line":"                   \" search paths (~/.neutron/, ~/, /etc/neutron/, /etc/) and\""},{"line_number":39,"context_line":"                   \" the \u0027--config-file\u0027 option!\"))"},{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_169274f6","line":39,"range":{"start_line":33,"start_character":4,"end_line":39,"end_character":51},"updated":"2017-02-23 05:35:09.000000000","message":"this code is almost identical to neutron.server.__init__:boot_server. Could we reuse it from a single place?","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def get_application():"},{"line_number":31,"context_line":"    # TODO(electrocucaracha) Validate plugin/extension configurations are"},{"line_number":32,"context_line":"    # loaded"},{"line_number":33,"context_line":"    config.init(sys.argv[1:])"},{"line_number":34,"context_line":"    config.setup_logging()"},{"line_number":35,"context_line":"    config.set_config_defaults()"},{"line_number":36,"context_line":"    if not cfg.CONF.config_file:"},{"line_number":37,"context_line":"        sys.exit(_(\"ERROR: Unable to find configuration file via the default\""},{"line_number":38,"context_line":"                   \" search paths (~/.neutron/, ~/, /etc/neutron/, /etc/) and\""},{"line_number":39,"context_line":"                   \" the \u0027--config-file\u0027 option!\"))"},{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_174dfb3d","line":39,"range":{"start_line":33,"start_character":4,"end_line":39,"end_character":51},"in_reply_to":"da36d5c6_169274f6","updated":"2017-02-23 18:23:37.000000000","message":"Done","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"030fad56db84779b0cfbfe83681180bd49e935f5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                   \" search paths (~/.neutron/, ~/, /etc/neutron/, /etc/) and\""},{"line_number":39,"context_line":"                   \" the \u0027--config-file\u0027 option!\"))"},{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"},{"line_number":43,"context_line":"    # registry.notify(resources.PROCESS, events.BEFORE_SPAWN, service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f08df57c","line":41,"updated":"2016-12-10 08:09:50.000000000","message":"if neutron is moving to pecan, it might be useful to use that for this.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                   \" search paths (~/.neutron/, ~/, /etc/neutron/, /etc/) and\""},{"line_number":39,"context_line":"                   \" the \u0027--config-file\u0027 option!\"))"},{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"},{"line_number":43,"context_line":"    # registry.notify(resources.PROCESS, events.BEFORE_SPAWN, service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_96b4a482","line":41,"in_reply_to":"3a71b18c_f08df57c","updated":"2017-02-23 05:35:09.000000000","message":"Why do we care about it? We seem to expose a generic application, we should not care about what\u0027s underneath.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"030fad56db84779b0cfbfe83681180bd49e935f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"},{"line_number":43,"context_line":"    # registry.notify(resources.PROCESS, events.BEFORE_SPAWN, service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_30ea0d10","line":43,"updated":"2016-12-10 08:09:50.000000000","message":"I guess this should be removed?","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    profiler.setup(\u0027neutron-server\u0027, cfg.CONF.host)"},{"line_number":41,"context_line":"    # NOTE(electrocucaracha) Determine if eventlet or pecan will be used"},{"line_number":42,"context_line":"    return service.get_wsgi_application(\u0027neutron\u0027)"},{"line_number":43,"context_line":"    # registry.notify(resources.PROCESS, events.BEFORE_SPAWN, service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_77fe37af","line":43,"in_reply_to":"3a71b18c_30ea0d10","updated":"2017-02-23 18:23:37.000000000","message":"Given that this is only targeting to Neutron API makes sense to remove it","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"}],"neutron/service.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    return workers"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def get_wsgi_application(app_name):"},{"line_number":288,"context_line":"    return config.load_paste_app(app_name)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_f676c0d5","line":287,"updated":"2017-02-23 05:35:09.000000000","message":"what\u0027s the point of having this additional function if we can directly point to config.load_paste_app?","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    return workers"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def get_wsgi_application(app_name):"},{"line_number":288,"context_line":"    return config.load_paste_app(app_name)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_579db364","line":287,"in_reply_to":"da36d5c6_f676c0d5","updated":"2017-02-23 18:23:37.000000000","message":"The main idea was to reuse the way to get the application, but  for a single line maybe it\u0027s better to duplicate code and reduce imports.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"9f5951eeeb049153bf9ac89ff7299390f579317a","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def get_wsgi_application(app_name):"},{"line_number":288,"context_line":"    return config.load_paste_app(app_name)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"def _run_wsgi(app_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_b801ad3a","line":288,"updated":"2016-12-14 21:56:05.000000000","message":"app_name here could be legacy app or pecan app in my understanding ? If thats the case, dont we need to do have pecan paste conf like etc/api-paste.ini. I dont know much on pastedeploy but just my observation.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def get_wsgi_application(app_name):"},{"line_number":288,"context_line":"    return config.load_paste_app(app_name)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"def _run_wsgi(app_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_b670c8dd","line":288,"in_reply_to":"1a6eadb0_b801ad3a","updated":"2017-02-23 05:35:09.000000000","message":"I think we should just pass \u0027neutron\u0027 unconditionally.","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def get_wsgi_application(app_name):"},{"line_number":288,"context_line":"    return config.load_paste_app(app_name)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"def _run_wsgi(app_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_771b97ca","line":288,"in_reply_to":"da36d5c6_b670c8dd","updated":"2017-02-23 18:23:37.000000000","message":"That is the default value[1], but it\u0027s only used for the server, so I can hardcode it\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/service.py#L76","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"}],"releasenotes/notes/add-wsgi-script-support-e611fa5b5c2043a5.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9a0936c0b33bd1d443f91fddc240a8a0bb98baf3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web servers(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da36d5c6_acd059f7","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"updated":"2017-02-23 20:56:25.000000000","message":"drop the s. The phrase is written in singular","commit_id":"6f8730ae9a352fa4309ce5b19ce0bb4ddf81a604"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"c2566d8e92666e56ec4cecfa59d1ae60f447ed6b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web servers(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da36d5c6_db29a0e7","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"in_reply_to":"da36d5c6_acd059f7","updated":"2017-02-24 21:06:47.000000000","message":"Done","commit_id":"6f8730ae9a352fa4309ce5b19ce0bb4ddf81a604"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_9dd398d4","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":43},"updated":"2017-02-25 04:07:33.000000000","message":"Please expand into a sentence, like \u0027This release adds support of serving Neutron API component from a WSGI compatible web server.\u0027","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_fa18ae86","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":43},"in_reply_to":"da36d5c6_9dd398d4","updated":"2017-03-01 20:55:15.000000000","message":"Done","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_bdde9cda","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"updated":"2017-02-25 04:07:33.000000000","message":"insert space before brace","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_da2bea92","line":5,"range":{"start_line":5,"start_character":68,"end_line":5,"end_character":69},"in_reply_to":"da36d5c6_bdde9cda","updated":"2017-03-01 20:55:15.000000000","message":"Done","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"},{"line_number":9,"context_line":"    \u003chttps://docs.openstack.org/developer/neutron/devref/apache-httpd.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_ddd990f4","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":32},"updated":"2017-02-25 04:07:33.000000000","message":"redundant dot?","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Support for WSGI compatible web servers"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server(e.g."},{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"},{"line_number":9,"context_line":"    \u003chttps://docs.openstack.org/developer/neutron/devref/apache-httpd.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_1a1ca276","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":32},"in_reply_to":"da36d5c6_ddd990f4","updated":"2017-03-01 20:55:15.000000000","message":"Done","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"807be12bc4fccb5c699464748de5f84b8e0ac814","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"},{"line_number":9,"context_line":"    \u003chttps://docs.openstack.org/developer/neutron/devref/apache-httpd.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_fde494ac","line":9,"updated":"2017-02-25 04:07:33.000000000","message":"No, we should not mention that. Devref is for developers, release notes are for consumers of the release. I think we better kill the subsection, and leave it up to manuals to document details of httpd-managed setup.","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"617c88e9aac3a74c7da89aad687911a8af3feefb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    apache2/httpd, nginx, etc.)."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Please read the `Neutron\u0027s developer documentation"},{"line_number":9,"context_line":"    \u003chttps://docs.openstack.org/developer/neutron/devref/apache-httpd.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_cde33632","line":9,"in_reply_to":"da36d5c6_fde494ac","updated":"2017-03-01 20:55:15.000000000","message":"Maybe I should split this information in a separate patch referring to the NEUTRON_DEPLOY usage[1]. But this can be a chicken and egg problem, because that patch depends on this one.\n\n[1] https://review.openstack.org/#/c/439191/1/lib/neutron@89","commit_id":"2f6ca96e52e5d7e06dc5ee7b6be41cc200885415"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa52abda2015696d9d83f64c2a181cfef6bb132","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    compatible web servers"},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Neutron API is capable to run under a WSGI compatible web server (e.g."},{"line_number":7,"context_line":"    apache2/httpd, nginx, etc.)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_8591a455","line":7,"updated":"2017-04-06 06:44:56.000000000","message":"my understanding is that we may have some gaps with threads running in the background. I am not sure if this is something that you guys have looked into or is on your radar.","commit_id":"6995bb85cb00def58700933f7a8db5ceb1dec565"}],"setup.cfg":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"34ad7856fa4709ad533eb92f6c65b5ca45b0baa2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[entry_points]"},{"line_number":44,"context_line":"wsgi_scripts \u003d"},{"line_number":45,"context_line":"    neutron-wsgi-server \u003d neutron.server.wsgi:get_application"},{"line_number":46,"context_line":"console_scripts \u003d"},{"line_number":47,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":48,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"da36d5c6_d628dce4","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":23},"updated":"2017-02-23 05:35:09.000000000","message":"neutron-api maybe?","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f17058fa1df014a25ea0b365b6f1f08bf6752b7e","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[entry_points]"},{"line_number":44,"context_line":"wsgi_scripts \u003d"},{"line_number":45,"context_line":"    neutron-wsgi-server \u003d neutron.server.wsgi:get_application"},{"line_number":46,"context_line":"console_scripts \u003d"},{"line_number":47,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":48,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"da36d5c6_d780c3c1","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":23},"in_reply_to":"da36d5c6_d628dce4","updated":"2017-02-23 18:23:37.000000000","message":"Finally in compliance","commit_id":"9eabf4ed16de09e901274ceac3a457894bae2614"}]}