)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c43f2fb620920b91353183d937b414387f92ca96","unresolved":false,"context_lines":[{"line_number":584,"context_line":"    resource_extend.register_funcs("},{"line_number":585,"context_line":"        attributes.PORTS, [\u0027_ml2_extend_port_dict_binding\u0027])"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    # ML2\u0027s resource extend functions allow mechanism drivers that extend"},{"line_number":588,"context_line":"    # attributes for the resources to add those attributes to the result."},{"line_number":589,"context_line":"    resource_extend.register_funcs("},{"line_number":590,"context_line":"               attributes.NETWORKS, [\u0027_ml2_md_extend_network_dict\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a30ddce_39c67b9a","line":587,"range":{"start_line":587,"start_character":44,"end_line":587,"end_character":53},"updated":"2017-03-10 01:12:52.000000000","message":"This is not a mistake that was introduced by this patchset, but I think this is a good opportunity to fix it. The resource extend functions that are called in lines 598, 602 and 606 below are not implemented by mechanism drivers. The mechanism driver api doesn\u0027t have extend_\u003cresource\u003e_dict methods, whereas the extension driver api does: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/driver_api.py#L1126.\n\nSince you are touching the comment line anyway, why not take the opportunity to have an accurate description by changing this to \u0027extension\u0027.","commit_id":"ca5b87c9c36c8dc9be5d23c4e6765178bbe9bbc3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1e3d45f7e5f30fe54630f5bee1d1d349c25fbcbd","unresolved":false,"context_lines":[{"line_number":584,"context_line":"    resource_extend.register_funcs("},{"line_number":585,"context_line":"        attributes.PORTS, [\u0027_ml2_extend_port_dict_binding\u0027])"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    # ML2\u0027s resource extend functions allow mechanism drivers that extend"},{"line_number":588,"context_line":"    # attributes for the resources to add those attributes to the result."},{"line_number":589,"context_line":"    resource_extend.register_funcs("},{"line_number":590,"context_line":"               attributes.NETWORKS, [\u0027_ml2_md_extend_network_dict\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a30ddce_b8f7aa57","line":587,"range":{"start_line":587,"start_character":44,"end_line":587,"end_character":53},"in_reply_to":"9a30ddce_39c67b9a","updated":"2017-03-10 15:27:36.000000000","message":"Good catch! It is important for comments to be accurate.","commit_id":"ca5b87c9c36c8dc9be5d23c4e6765178bbe9bbc3"}]}