)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"2c57d710c4b5443b4bcfda61832552b528f088e7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Register bound functions for extending resources"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"By registering bound functions we cut off the dependency of the"},{"line_number":12,"context_line":"\"resource extend\" functions on the plugin. This is a step towards"},{"line_number":13,"context_line":"the goal of removing the CommonDbMixin mixin class."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a6eadb0_6d751931","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":30},"updated":"2016-12-18 10:02:55.000000000","message":"I know python has the concept of \"bound/unbound methods\", but what do you mean by \"bound function\"?","commit_id":"24226df72acac7f6161388da8f8da71ff5266c30"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"4b1cca1b21864260ec557efbcf8867e7f8e8b2d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Register bound functions for extending resources"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"By registering bound functions we cut off the dependency of the"},{"line_number":12,"context_line":"\"resource extend\" functions on the plugin. This is a step towards"},{"line_number":13,"context_line":"the goal of removing the CommonDbMixin mixin class."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a6eadb0_9971b27a","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":30},"in_reply_to":"1a6eadb0_1fecc68e","updated":"2016-12-19 15:07:39.000000000","message":"Thanks!","commit_id":"24226df72acac7f6161388da8f8da71ff5266c30"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f39aeeb6e1405bb9b09477471ca4977ac701ffff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Register bound functions for extending resources"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"By registering bound functions we cut off the dependency of the"},{"line_number":12,"context_line":"\"resource extend\" functions on the plugin. This is a step towards"},{"line_number":13,"context_line":"the goal of removing the CommonDbMixin mixin class."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a6eadb0_1fecc68e","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":30},"in_reply_to":"1a6eadb0_6d751931","updated":"2016-12-18 17:08:32.000000000","message":"Sloppy terminology on my part, sorry.\n\nCurrently, most of the functions (actually methods of the plugin class) for extending resources are registered by their name (a string). This means that when the functions need to be applied, they are looked up using getattr on the plugin. See [1], it\u0027s pretty gross.\n\nWhat I meant to say in this commit message is that this patch removes that \"deferred lookup of bound methods by name\" thing. I\u0027ll update the message.\n\n[1] https://github.com/openstack/neutron/blob/10.0.0.0b2/neutron/db/common_db_mixin.py#L203-L214","commit_id":"24226df72acac7f6161388da8f8da71ff5266c30"}],"neutron/db/_resource_extend.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8a5a8edbc25f55e229d55cb189df2293a9f9f148","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Any method decorated with @extends above is an unbound method on a class."},{"line_number":93,"context_line":"    This decorator sets up the class __new__ method to add the bound"},{"line_number":94,"context_line":"    method to _resource_extend_functions after object instantiation."},{"line_number":95,"context_line":"    \"\"\""},{"line_number":96,"context_line":"    orig_new \u003d klass.__new__"},{"line_number":97,"context_line":"    new_inherited \u003d \u0027__new__\u0027 not in klass.__dict__"}],"source_content_type":"text/x-python","patch_set":48,"id":"7ffa3b31_4670aa08","line":94,"updated":"2017-04-21 08:24:00.000000000","message":"looks familiar. :) We can probably resolve the duplication once this lives in neutron-lib","commit_id":"af6d339b0ec64368c645a349636e274d8caa29f1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fe09b862d4f5bdb3b75d16085751d3ab6aa0dbea","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    return _resource_extend_functions.get(resource, [])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def extends(resources):"},{"line_number":72,"context_line":"    \"\"\"Use to decorate methods on classes before initialization."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    Any classes that use this must themselves be decorated with the"}],"source_content_type":"text/x-python","patch_set":49,"id":"5ff73747_f89235f6","line":71,"updated":"2017-04-25 11:56:18.000000000","message":"sorry - i made this comment on one of the patches above - prior to this patch the order was somehow guaranteed for the extend calling methods. can we somehow add a priority here?","commit_id":"b3c0d5f2391c2f2333784bf70b13d8c8033572c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"63e65e831c448a4e0af372b8313b73a1f8355c07","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    return _resource_extend_functions.get(resource, [])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def extends(resources):"},{"line_number":72,"context_line":"    \"\"\"Use to decorate methods on classes before initialization."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    Any classes that use this must themselves be decorated with the"}],"source_content_type":"text/x-python","patch_set":49,"id":"5ff73747_6d908144","line":71,"in_reply_to":"5ff73747_093c63c6","updated":"2017-04-26 07:47:17.000000000","message":"Yes, in our decomposed plugin we see an issue. We have fixed that in the plugin","commit_id":"b3c0d5f2391c2f2333784bf70b13d8c8033572c3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d7b2df0596decca7f811efcc51612d217794ccf0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    return _resource_extend_functions.get(resource, [])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def extends(resources):"},{"line_number":72,"context_line":"    \"\"\"Use to decorate methods on classes before initialization."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    Any classes that use this must themselves be decorated with the"}],"source_content_type":"text/x-python","patch_set":49,"id":"5ff73747_093c63c6","line":71,"in_reply_to":"5ff73747_f89235f6","updated":"2017-04-25 18:07:22.000000000","message":"I don\u0027t think there was ever a guarantee of order. Before this patch, the order was the result of the module import sequence followed by the class method resolution order. With this patch it is (I think) only the MRO. Either way, the order can change when someone changes imports or changes inherited classes.\n\nAre you seeing a particular breakage? Is it because one extender depends on another extender being run prior to it?","commit_id":"b3c0d5f2391c2f2333784bf70b13d8c8033572c3"}],"neutron/db/availability_zone/network.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"165c11f270b794d044be4f112b77040cd161cf35","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.extensions import network_availability_zone as net_az"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _extend_availability_zone(net_res, net_db):"},{"line_number":23,"context_line":"    net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":24,"context_line":"        net_db[az_ext.AZ_HINTS])"},{"line_number":25,"context_line":"    plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_b35bc32c","line":22,"updated":"2017-04-17 06:20:29.000000000","message":"Is it possible for you to leave these behind on the class as staticmethods? In addition to making the changeset much smaller, in the future we can add a decorator to the class and the subscribe methods inside of it to eliminate the override of __new__ like we did with the @registry.receives decorator.","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c8e206cc567131ce3d77b9b1874113fe917d0d2f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.extensions import network_availability_zone as net_az"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _extend_availability_zone(net_res, net_db):"},{"line_number":23,"context_line":"    net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":24,"context_line":"        net_db[az_ext.AZ_HINTS])"},{"line_number":25,"context_line":"    plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_a0d99957","line":22,"in_reply_to":"7ffa3b31_5f76bda6","updated":"2017-04-21 03:42:11.000000000","message":"Done","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b610b6774f2600756715c2da7bf6d49b794be2d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.extensions import network_availability_zone as net_az"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _extend_availability_zone(net_res, net_db):"},{"line_number":23,"context_line":"    net_res[az_ext.AZ_HINTS] \u003d az_ext.convert_az_string_to_list("},{"line_number":24,"context_line":"        net_db[az_ext.AZ_HINTS])"},{"line_number":25,"context_line":"    plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_5f76bda6","line":22,"in_reply_to":"7ffa3b31_b35bc32c","updated":"2017-04-17 12:56:04.000000000","message":"Sounds interesting. I\u0027ll give it a try.","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"165c11f270b794d044be4f112b77040cd161cf35","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return super(NetworkAvailabilityZoneMixin, cls).__new__(cls, *args,"},{"line_number":37,"context_line":"                                                                **kwargs)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_network_availability_zones(self, network):"},{"line_number":40,"context_line":"        return super(NetworkAvailabilityZoneMixin,"},{"line_number":41,"context_line":"                     self).get_network_availability_zones(network)"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_9340c737","line":39,"updated":"2017-04-17 06:20:29.000000000","message":"what happened here? This function doesn\u0027t seem to do anything.","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c8e206cc567131ce3d77b9b1874113fe917d0d2f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return super(NetworkAvailabilityZoneMixin, cls).__new__(cls, *args,"},{"line_number":37,"context_line":"                                                                **kwargs)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_network_availability_zones(self, network):"},{"line_number":40,"context_line":"        return super(NetworkAvailabilityZoneMixin,"},{"line_number":41,"context_line":"                     self).get_network_availability_zones(network)"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_40e895e0","line":39,"in_reply_to":"7ffa3b31_5f4d9d70","updated":"2017-04-21 03:42:11.000000000","message":"Done","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b610b6774f2600756715c2da7bf6d49b794be2d9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return super(NetworkAvailabilityZoneMixin, cls).__new__(cls, *args,"},{"line_number":37,"context_line":"                                                                **kwargs)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_network_availability_zones(self, network):"},{"line_number":40,"context_line":"        return super(NetworkAvailabilityZoneMixin,"},{"line_number":41,"context_line":"                     self).get_network_availability_zones(network)"}],"source_content_type":"text/x-python","patch_set":47,"id":"7ffa3b31_5f4d9d70","line":39,"in_reply_to":"7ffa3b31_9340c737","updated":"2017-04-17 12:56:04.000000000","message":"Looks like it snuck in when I did not pay enough attention while resolving merge conflicts.","commit_id":"9b12b649555c0409e80161f2e42b8b7b358ff774"}],"neutron/db/common_db_mixin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a6e663eb8d903e994226795d1b5b6bd3413b8dcb","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _apply_dict_extend_functions(resource_type,"},{"line_number":175,"context_line":"                                     response, db_object):"},{"line_number":176,"context_line":"        for func in _resource_extend.get_funcs(resource_type):"},{"line_number":177,"context_line":"            _resolve_ref(func)(response, db_object)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _get_collection_query(self, context, model, filters\u003dNone,"},{"line_number":180,"context_line":"                              sorts\u003dNone, limit\u003dNone, marker_obj\u003dNone,"}],"source_content_type":"text/x-python","patch_set":45,"id":"7ffa3b31_76e65447","line":177,"updated":"2017-04-16 03:58:49.000000000","message":"_resolve_ref can return None if the weakref is dead. https://docs.python.org/2/library/weakref.html#weakref.ref","commit_id":"7c2b6e9f4522f9a37755364b0090bac129cd3f58"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"90e143a6653988ff47225153984d371ef85a69de","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _apply_dict_extend_functions(resource_type,"},{"line_number":175,"context_line":"                                     response, db_object):"},{"line_number":176,"context_line":"        for func in _resource_extend.get_funcs(resource_type):"},{"line_number":177,"context_line":"            _resolve_ref(func)(response, db_object)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _get_collection_query(self, context, model, filters\u003dNone,"},{"line_number":180,"context_line":"                              sorts\u003dNone, limit\u003dNone, marker_obj\u003dNone,"}],"source_content_type":"text/x-python","patch_set":45,"id":"7ffa3b31_a926bab6","line":177,"in_reply_to":"7ffa3b31_57047217","updated":"2017-04-16 19:21:37.000000000","message":"I think we don\u0027t need to weakref the query filters and hooks, nor the extend functions, once they all have be decoupled from the plugin. Sometimes they look up the plugin, but they do so via the plugin directory, which accesses the plugin via a weakref.","commit_id":"7c2b6e9f4522f9a37755364b0090bac129cd3f58"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb9613649c5d538685e0302d49de4da8d426667","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _apply_dict_extend_functions(resource_type,"},{"line_number":175,"context_line":"                                     response, db_object):"},{"line_number":176,"context_line":"        for func in _resource_extend.get_funcs(resource_type):"},{"line_number":177,"context_line":"            _resolve_ref(func)(response, db_object)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _get_collection_query(self, context, model, filters\u003dNone,"},{"line_number":180,"context_line":"                              sorts\u003dNone, limit\u003dNone, marker_obj\u003dNone,"}],"source_content_type":"text/x-python","patch_set":45,"id":"7ffa3b31_57047217","line":177,"in_reply_to":"7ffa3b31_76e65447","updated":"2017-04-16 18:59:25.000000000","message":"Do we need to weakref these functions once are decoupled from the plugin?","commit_id":"7c2b6e9f4522f9a37755364b0090bac129cd3f58"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0fffe14fbef32f228124837e125fd39a3e3c138d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _apply_dict_extend_functions(resource_type,"},{"line_number":175,"context_line":"                                     response, db_object):"},{"line_number":176,"context_line":"        for func in _resource_extend.get_funcs(resource_type):"},{"line_number":177,"context_line":"            _resolve_ref(func)(response, db_object)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _get_collection_query(self, context, model, filters\u003dNone,"},{"line_number":180,"context_line":"                              sorts\u003dNone, limit\u003dNone, marker_obj\u003dNone,"}],"source_content_type":"text/x-python","patch_set":45,"id":"7ffa3b31_29c62a69","line":177,"in_reply_to":"7ffa3b31_a926bab6","updated":"2017-04-16 22:22:06.000000000","message":"Meanwhile I am adding a check for func is None.","commit_id":"7c2b6e9f4522f9a37755364b0090bac129cd3f58"}]}
