)]}'
{"neutron/api/v2/resource.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ef37939b8faf974fae6a3c937604a7f4c25cccba","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":80,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":81,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":82,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":83,"context_line":"                    request.context.session.info[\u0027if_revision_match\u0027] \u003d rev"},{"line_number":84,"context_line":"                    request.context.session.info[\u0027api_collection\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_c92fd29f","line":81,"updated":"2017-01-02 07:23:37.000000000","message":"if the extension is not supported do we want to raise the exception?","commit_id":"e35b8afb8513c03abccb9ce9b4c8c62ebdba3051"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64e0c93f30d799758179354285f640ae61b029a6","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":80,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":81,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":82,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":83,"context_line":"                    request.context.session.info[\u0027if_revision_match\u0027] \u003d rev"},{"line_number":84,"context_line":"                    request.context.session.info[\u0027api_collection\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_fd744cfe","line":81,"in_reply_to":"ba5201f7_c92fd29f","updated":"2017-01-02 11:57:34.000000000","message":"yes, that\u0027s what that function will do if it\u0027s not supported. I want it to raise because we don\u0027t want users to silently think they are getting consistency guarantees when providing the revision number matching header.","commit_id":"e35b8afb8513c03abccb9ce9b4c8c62ebdba3051"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                args[\u0027id\u0027] \u003d \u0027.\u0027.join([args[\u0027id\u0027], fmt])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":93,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":94,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_8c5709cb","line":93,"updated":"2017-06-15 21:19:35.000000000","message":"can api users send multiple revision_numbers\u003d? how do we deal with it?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                args[\u0027id\u0027] \u003d \u0027.\u0027.join([args[\u0027id\u0027], fmt])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":93,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":94,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0c7419fd","line":93,"in_reply_to":"7f231b9d_8c5709cb","updated":"2017-06-15 21:27:52.000000000","message":"I suppose we should throw an error. I will add that.","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":93,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":94,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"},{"line_number":97,"context_line":"                                  \u0027resource\u0027: controller._collection,"},{"line_number":98,"context_line":"                                  \u0027id_of_resource\u0027: args[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0cbd3901","line":95,"range":{"start_line":95,"start_character":47,"end_line":95,"end_character":48},"updated":"2017-06-15 21:19:35.000000000","message":"if the api user sends garbage, like revision_number\u003dblablabla, then it will raise ValueError, and, I believe, 5xx? I think we want to avoid that.","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            for e in getattr(request.if_match, \u0027etags\u0027, []):"},{"line_number":93,"context_line":"                if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":94,"context_line":"                    api_common.ensure_if_match_supported()"},{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"},{"line_number":97,"context_line":"                                  \u0027resource\u0027: controller._collection,"},{"line_number":98,"context_line":"                                  \u0027id_of_resource\u0027: args[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_2c26b516","line":95,"range":{"start_line":95,"start_character":47,"end_line":95,"end_character":48},"in_reply_to":"7f231b9d_0cbd3901","updated":"2017-06-15 21:27:52.000000000","message":"ack. will add better error","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"},{"line_number":97,"context_line":"                                  \u0027resource\u0027: controller._collection,"},{"line_number":98,"context_line":"                                  \u0027id_of_resource\u0027: args[\u0027id\u0027]}"},{"line_number":99,"context_line":"                    # TODO(kevinbenton): add an interface to context to do this"},{"line_number":100,"context_line":"                    setattr(request.context, \u0027_CONSTRAINT\u0027, constraint)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_8c3ee988","line":98,"range":{"start_line":98,"start_character":34,"end_line":98,"end_character":49},"updated":"2017-06-15 21:19:35.000000000","message":"id? resource_id?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    rev \u003d int(e.split(\u0027revision_number\u003d\u0027)[1])"},{"line_number":96,"context_line":"                    constraint \u003d {\u0027if_revision_match\u0027: rev,"},{"line_number":97,"context_line":"                                  \u0027resource\u0027: controller._collection,"},{"line_number":98,"context_line":"                                  \u0027id_of_resource\u0027: args[\u0027id\u0027]}"},{"line_number":99,"context_line":"                    # TODO(kevinbenton): add an interface to context to do this"},{"line_number":100,"context_line":"                    setattr(request.context, \u0027_CONSTRAINT\u0027, constraint)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_6c85cdce","line":98,"range":{"start_line":98,"start_character":34,"end_line":98,"end_character":49},"in_reply_to":"7f231b9d_8c3ee988","updated":"2017-06-15 21:27:52.000000000","message":"resource_id works. I had started out with \u0027id_of_resource_to_match\u0027 but that was too much so I truncated it. :)","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"}],"neutron/extensions/revisionifmatch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Revisionifmatch(api_extensions.ExtensionDescriptor):"},{"line_number":18,"context_line":"    \"\"\"Indicate that if-match constraints on revision_number are supported.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @classmethod"},{"line_number":21,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ac340594","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":29},"updated":"2017-06-15 21:19:35.000000000","message":"If-Match","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Revisionifmatch(api_extensions.ExtensionDescriptor):"},{"line_number":18,"context_line":"    \"\"\"Indicate that if-match constraints on revision_number are supported.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @classmethod"},{"line_number":21,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ec70bd0a","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":29},"in_reply_to":"7f231b9d_ac340594","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @classmethod"},{"line_number":21,"context_line":"    def get_name(cls):"},{"line_number":22,"context_line":"        return \"If-match constraints based on revision_number\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_cc2f413d","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":25},"updated":"2017-06-15 21:19:35.000000000","message":"If-Match","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @classmethod"},{"line_number":21,"context_line":"    def get_name(cls):"},{"line_number":22,"context_line":"        return \"If-match constraints based on revision_number\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_cc63c141","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":25},"in_reply_to":"7f231b9d_cc2f413d","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def get_description(cls):"},{"line_number":30,"context_line":"        return (\"Extension indicating that if-match based on revision_number \""},{"line_number":31,"context_line":"                \"is supported.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0c0099aa","line":30,"range":{"start_line":30,"start_character":43,"end_line":30,"end_character":51},"updated":"2017-06-15 21:19:35.000000000","message":"If-Match","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def get_description(cls):"},{"line_number":30,"context_line":"        return (\"Extension indicating that if-match based on revision_number \""},{"line_number":31,"context_line":"                \"is supported.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ac68851c","line":30,"range":{"start_line":30,"start_character":43,"end_line":30,"end_character":51},"in_reply_to":"7f231b9d_0c0099aa","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b83e165baa85442c5ee07643fd39b7075ffed2d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return \"2016-12-11T00:00:00-00:00\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def get_resources(cls):"},{"line_number":39,"context_line":"        return []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_extended_resources(self, version):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_e5c1d255","line":38,"updated":"2017-06-16 19:15:58.000000000","message":"you gonna add this one to neutron-lib and document please?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2d7f126dd35e16f2a720bc00325bc1f5b97748a0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return \"2016-12-11T00:00:00-00:00\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def get_resources(cls):"},{"line_number":39,"context_line":"        return []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_extended_resources(self, version):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_5110484e","line":38,"in_reply_to":"7f231b9d_e5c1d255","updated":"2017-06-16 22:18:26.000000000","message":"Sure, you want me to make this patch dependent on it or is follow-up okay?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38dc4abbc798a9c9dae63181b753b2842b1f43d6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.api import extensions as api_extensions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Revisionifmatch(api_extensions.ExtensionDescriptor):"},{"line_number":18,"context_line":"    \"\"\"Indicate that If-Match constraints on revision_number are supported.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_2f72d27d","line":17,"updated":"2017-07-07 18:21:35.000000000","message":"please propose for neutron-lib","commit_id":"7f17b4759e41aa0a922ac27c2dabc595e7d2f67c"}],"neutron/pecan_wsgi/hooks/query_parameters.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        collection \u003d state.request.context.get(\u0027collection\u0027)"},{"line_number":114,"context_line":"        if not collection:"},{"line_number":115,"context_line":"            return"},{"line_number":116,"context_line":"        # add in if-match criterion to the context if present"},{"line_number":117,"context_line":"        for e in getattr(state.request.if_match, \u0027etags\u0027, []):"},{"line_number":118,"context_line":"            if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":119,"context_line":"                ctx \u003d state.request.context[\u0027neutron_context\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0cee59ec","line":116,"updated":"2017-06-15 21:19:35.000000000","message":"seems like a lot of code here is similar to what we have in resource.py. We may want to reuse the code maybe.","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        collection \u003d state.request.context.get(\u0027collection\u0027)"},{"line_number":114,"context_line":"        if not collection:"},{"line_number":115,"context_line":"            return"},{"line_number":116,"context_line":"        # add in if-match criterion to the context if present"},{"line_number":117,"context_line":"        for e in getattr(state.request.if_match, \u0027etags\u0027, []):"},{"line_number":118,"context_line":"            if e.startswith(\u0027revision_number\u003d\u0027):"},{"line_number":119,"context_line":"                ctx \u003d state.request.context[\u0027neutron_context\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0c4d39c3","line":116,"in_reply_to":"7f231b9d_0cee59ec","updated":"2017-06-15 21:27:52.000000000","message":"Ack. I\u0027ll put this in a helper function somewhere","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"}],"neutron/services/revisions/revision_plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"035b9c091d2e5d6bebd300ba53dfb1bee0dafc8d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if instance and instance \u003d\u003d obj:"},{"line_number":165,"context_line":"            # one last check before bumping revision and removing constraint"},{"line_number":166,"context_line":"            self._enforce_if_match_constraints(session)"},{"line_number":167,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"},{"line_number":168,"context_line":"        obj.bump_revision()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_1476c8a3","line":167,"updated":"2016-12-28 09:14:38.000000000","message":"Ah, good point. I need to make sure this only happens after a successful commit.","commit_id":"ec3fa9484bce7cdc21dcf3a3d17465e3a4c4e91b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"672a3b98efbe688ccd742e28f5c7b574ccc874b2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if instance and instance \u003d\u003d obj:"},{"line_number":165,"context_line":"            # one last check before bumping revision and removing constraint"},{"line_number":166,"context_line":"            self._enforce_if_match_constraints(session)"},{"line_number":167,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"},{"line_number":168,"context_line":"        obj.bump_revision()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_d537e3fc","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":49},"updated":"2016-12-28 05:11:21.000000000","message":"how is this feature supposed to work with db retries?\npoping this here means it only takes effects for the first attempt?","commit_id":"ec3fa9484bce7cdc21dcf3a3d17465e3a4c4e91b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"86e3a755fb0bdf9ecc3c7f7e4f1268c007f77272","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                                                   pk.name, rel_id)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _find_instance_by_column_value(self, session, model, column, value):"},{"line_number":112,"context_line":"        for session_obj in session:"},{"line_number":113,"context_line":"            if not isinstance(session_obj, model):"},{"line_number":114,"context_line":"                continue"},{"line_number":115,"context_line":"            if getattr(session_obj, column) \u003d\u003d value:"},{"line_number":116,"context_line":"                return session_obj"},{"line_number":117,"context_line":"        # object isn\u0027t in session so we have to query for it"},{"line_number":118,"context_line":"        related_obj \u003d (session.query(model).filter_by(**{column: value})."},{"line_number":119,"context_line":"                       first())"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_31c9ff59","line":116,"range":{"start_line":112,"start_character":0,"end_line":116,"end_character":34},"updated":"2017-01-18 01:07:18.000000000","message":"does this \"fast path\" make a significant difference?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf673aa48647d538b52abb95acf563497741dcaa","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                                                   pk.name, rel_id)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _find_instance_by_column_value(self, session, model, column, value):"},{"line_number":112,"context_line":"        for session_obj in session:"},{"line_number":113,"context_line":"            if not isinstance(session_obj, model):"},{"line_number":114,"context_line":"                continue"},{"line_number":115,"context_line":"            if getattr(session_obj, column) \u003d\u003d value:"},{"line_number":116,"context_line":"                return session_obj"},{"line_number":117,"context_line":"        # object isn\u0027t in session so we have to query for it"},{"line_number":118,"context_line":"        related_obj \u003d (session.query(model).filter_by(**{column: value})."},{"line_number":119,"context_line":"                       first())"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_1d5dbf48","line":116,"range":{"start_line":112,"start_character":0,"end_line":116,"end_character":34},"in_reply_to":"7a3c09a3_31c9ff59","updated":"2017-01-18 19:31:30.000000000","message":"It avoids an additional query to the DB that sqlalchemy would emit to ensure that the item still exists. We can possibly remove it in a separate patch, but I don\u0027t want to change that behavior as part of this one.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"20eb0c1fd29e56a96f9a41c2cfbf68c60e7e8618","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_27afc6e4","line":183,"updated":"2017-01-19 04:32:16.000000000","message":"But what do you think should happen if the transaction number has changed in between? If we error after the first transaction, it\u0027s too late for a rollback.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7b70a28d475dd476a06f0766fb3107f1d1cb20b1","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_b1a1e9ab","line":183,"updated":"2017-02-13 08:57:14.000000000","message":"Good idea. Let me check it out and see how the implementation looks.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0b4a46a4cab5b0bf850db745b3a6d3d7bbf5d48","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_fee4360e","line":183,"updated":"2017-01-19 21:57:23.000000000","message":"Well we do obey it for the first mutation of the request. Maybe a release note describing this behavior for multi-transaction operations would help?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d857817192c5ac00adce6e9a0cd882a3017140d2","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_75b6b68b","line":183,"updated":"2017-02-10 14:20:15.000000000","message":"Yes, once device owner/host_id is updated, that\u0027s enough for their use case. The port updates the neutron server performs (the port binding) don\u0027t impact this use case.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"86e3a755fb0bdf9ecc3c7f7e4f1268c007f77272","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Remove constraint after successful commit."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_51768b3e","line":183,"range":{"start_line":182,"start_character":42,"end_line":183,"end_character":22},"updated":"2017-01-18 01:07:18.000000000","message":"doesn\u0027t it mean the API call is no longer atomic silently?\nit would surprise the user.\ni prefer to detect the second transaction and raise an error.\nhow do you think?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bb207948e0a0b135e9d36f4c95ec33d1db586ad0","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_67770e03","line":183,"in_reply_to":"5a3905b3_27afc6e4","updated":"2017-01-19 04:58:07.000000000","message":"sure, it might be a problem.\nbut i feel awkward if we say \"ok\" while we couldn\u0027t actually obey the request.\nis it ok to proceed silently for the specific use case?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a0abfad3240bfad1a0e6aa10a762157ece49b011","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_0c619839","line":183,"in_reply_to":"5a3905b3_fee4360e","updated":"2017-02-07 03:17:38.000000000","message":"obeying it for the first mutation is enough for the nova use-case?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"392397d2e12199b045fa8ebe1033817fd17d79c6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Remove constraint after successful commit."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_e3e5b0dc","line":183,"range":{"start_line":182,"start_character":42,"end_line":183,"end_character":22},"in_reply_to":"7a3c09a3_28a2379b","updated":"2017-01-18 19:47:27.000000000","message":"Oh, I can\u0027t do that because even port binding is multi-transactional. I think we need to keep this logic otherwise we won\u0027t be able to fix the use case that Nova needs to only update a port if it currently isn\u0027t in use by something else.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf673aa48647d538b52abb95acf563497741dcaa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Remove constraint after successful commit."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_28a2379b","line":183,"range":{"start_line":182,"start_character":42,"end_line":183,"end_character":22},"in_reply_to":"7a3c09a3_51768b3e","updated":"2017-01-18 19:31:30.000000000","message":"The issue is that some operations are multi-transactional. For example, deleting a DVR router will clear CSNAT interfaces in one transaction since it\u0027s a call to the core plugin, which will bump the revision of the router. Then when the actual router is deleted in a separate transaction it will not match revision anymore.\n\nMaybe I need to change the behavior of those multi-transaction l3 operations.","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9defd6142d13939ad608b0be24c0b9b4336a1c74","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Remove constraint after successful commit."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_56c80a75","line":183,"range":{"start_line":182,"start_character":42,"end_line":183,"end_character":22},"in_reply_to":"7a3c09a3_e3e5b0dc","updated":"2017-01-19 02:40:49.000000000","message":"maybe we can record the revision number after the first transaction, and make the second transaction check it\u0027s intact?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8bf78d27aa71e0b11cd308f622887c5d51f46128","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        If we successfully committed with a constraint, we remove it from the"},{"line_number":182,"context_line":"        session info so it doesn\u0027t affect future transactions as part of the"},{"line_number":183,"context_line":"        same API call."},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        if session.info.get(\u0027constraint_satisfied_on_commit\u0027):"},{"line_number":186,"context_line":"            session.info.pop(\u0027if_revision_match\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_a7160fef","line":183,"in_reply_to":"fa31d9ce_75b6b68b","updated":"2017-02-13 05:11:30.000000000","message":"are you talking about _bind_port_if_needed?\ni guess it\u0027s ok to say it\u0027s the server\u0027s own activity rather than a part of the user-requested operation.\nin that case, it\u0027s more reasonable to make _bind_port_if_needed clear the constraints by itself.\nhow do you think?","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return instance, match"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _enforce_if_match_constraints(self, session):"},{"line_number":165,"context_line":"        \"\"\"Check for if-match constraints and except if violated."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        We determine the collection being modified and look for any"},{"line_number":168,"context_line":"        objects of the collection type in the dirty/deleted items in"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_6c86ed15","line":165,"range":{"start_line":165,"start_character":46,"end_line":165,"end_character":52},"updated":"2017-06-15 21:19:35.000000000","message":"raise an exception you mean?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return instance, match"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _enforce_if_match_constraints(self, session):"},{"line_number":165,"context_line":"        \"\"\"Check for if-match constraints and except if violated."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        We determine the collection being modified and look for any"},{"line_number":168,"context_line":"        objects of the collection type in the dirty/deleted items in"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_8ccee92a","line":165,"range":{"start_line":165,"start_character":46,"end_line":165,"end_character":52},"in_reply_to":"7f231b9d_6c86ed15","updated":"2017-06-15 21:27:52.000000000","message":"Yeah, trying to fit onto one line. :)","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        We are protected from a concurrent update because if we match"},{"line_number":173,"context_line":"        revision number here and another update commits to the database"},{"line_number":174,"context_line":"        first, the compare and swap of revision_number will fail and a"},{"line_number":175,"context_line":"        staledataerror (or deadlock in galera multi-writer) will be raised,"},{"line_number":176,"context_line":"        at which point this will be retried and fail to match."},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ac952535","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":23},"updated":"2017-06-15 21:19:35.000000000","message":"StaleDataError? for grep sake","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        We are protected from a concurrent update because if we match"},{"line_number":173,"context_line":"        revision number here and another update commits to the database"},{"line_number":174,"context_line":"        first, the compare and swap of revision_number will fail and a"},{"line_number":175,"context_line":"        staledataerror (or deadlock in galera multi-writer) will be raised,"},{"line_number":176,"context_line":"        at which point this will be retried and fail to match."},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_2cd915f2","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":23},"in_reply_to":"7f231b9d_ac952535","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"},{"line_number":179,"context_line":"        if not instance or getattr(instance, \u0027_rev_bumped\u0027, False):"},{"line_number":180,"context_line":"            # no constraints present or constrain satisifed in this transaction"},{"line_number":181,"context_line":"            return"},{"line_number":182,"context_line":"        if instance.revision_number !\u003d match:"},{"line_number":183,"context_line":"            raise RevisionNumberConstraintFailed(match,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_2ca11595","line":180,"range":{"start_line":180,"start_character":50,"end_line":180,"end_character":59},"updated":"2017-06-15 21:19:35.000000000","message":"satisfied","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"},{"line_number":179,"context_line":"        if not instance or getattr(instance, \u0027_rev_bumped\u0027, False):"},{"line_number":180,"context_line":"            # no constraints present or constrain satisifed in this transaction"},{"line_number":181,"context_line":"            return"},{"line_number":182,"context_line":"        if instance.revision_number !\u003d match:"},{"line_number":183,"context_line":"            raise RevisionNumberConstraintFailed(match,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ecde7dd8","line":180,"range":{"start_line":180,"start_character":50,"end_line":180,"end_character":59},"in_reply_to":"7f231b9d_2ca11595","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2185fbb84942fa2aa4f612041632c9b401cc7634","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            return"},{"line_number":123,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"},{"line_number":124,"context_line":"        if instance and instance \u003d\u003d obj:"},{"line_number":125,"context_line":"            # one last check before bumping revision and removing constraint"},{"line_number":126,"context_line":"            self._enforce_if_match_constraints(session)"},{"line_number":127,"context_line":"        obj.bump_revision()"},{"line_number":128,"context_line":"        setattr(obj, \u0027_rev_bumped\u0027, True)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_896b40ef","line":125,"range":{"start_line":125,"start_character":57,"end_line":125,"end_character":76},"updated":"2017-06-28 12:00:39.000000000","message":"do we still remove constraint? where?","commit_id":"1eb2a6857ed4cfc97ed4fd130192882fd97ef0c8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8658eb0b9709b92f9302e3058ba5968793f24c18","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            return"},{"line_number":123,"context_line":"        instance, match \u003d self._get_constrained_instance_match(session)"},{"line_number":124,"context_line":"        if instance and instance \u003d\u003d obj:"},{"line_number":125,"context_line":"            # one last check before bumping revision and removing constraint"},{"line_number":126,"context_line":"            self._enforce_if_match_constraints(session)"},{"line_number":127,"context_line":"        obj.bump_revision()"},{"line_number":128,"context_line":"        setattr(obj, \u0027_rev_bumped\u0027, True)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_3be31f36","line":125,"range":{"start_line":125,"start_character":57,"end_line":125,"end_character":76},"in_reply_to":"5f201791_896b40ef","updated":"2017-06-29 22:49:43.000000000","message":"oh, nope not anymore. I will have a follow up patch for ML2 to explicitly remove the constraint when it does binding.","commit_id":"1eb2a6857ed4cfc97ed4fd130192882fd97ef0c8"}],"neutron/tests/functional/pecan_wsgi/test_hooks.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def setUp(self):"},{"line_number":69,"context_line":"        cfg.CONF.set_override("},{"line_number":70,"context_line":"            \u0027service_plugins\u0027,"},{"line_number":71,"context_line":"            [\u0027neutron.services.revisions.revision_plugin.RevisionPlugin\u0027])"},{"line_number":72,"context_line":"        super(TestQueryParamatersHookWithRevision, self).setUp()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_if_match_on_update(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_8caf097c","line":71,"updated":"2017-06-15 21:19:35.000000000","message":"we have a stevedore alias for it, don\u0027t we","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def setUp(self):"},{"line_number":69,"context_line":"        cfg.CONF.set_override("},{"line_number":70,"context_line":"            \u0027service_plugins\u0027,"},{"line_number":71,"context_line":"            [\u0027neutron.services.revisions.revision_plugin.RevisionPlugin\u0027])"},{"line_number":72,"context_line":"        super(TestQueryParamatersHookWithRevision, self).setUp()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_if_match_on_update(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_0cfbf946","line":71,"in_reply_to":"7f231b9d_8caf097c","updated":"2017-06-15 21:27:52.000000000","message":"Done","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"}],"neutron/tests/tempest/api/test_revisions.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c07e50ecf614e271625a4b14ee811f40d493134","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % stale}"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # using current should pass. in case something is updating the network"},{"line_number":51,"context_line":"        # on the server at the same time, we have to re-read and update to be"},{"line_number":52,"context_line":"        # safe"},{"line_number":53,"context_line":"        for i in range(100):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_ecd43deb","line":50,"updated":"2017-06-15 21:19:35.000000000","message":"hm, what would it be? we just created a network just for the test case, haven\u0027t we?","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"62321910cfb30d6930442dea768b1cd23cd0bc94","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % stale}"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # using current should pass. in case something is updating the network"},{"line_number":51,"context_line":"        # on the server at the same time, we have to re-read and update to be"},{"line_number":52,"context_line":"        # safe"},{"line_number":53,"context_line":"        for i in range(100):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f231b9d_4cb33199","line":50,"in_reply_to":"7f231b9d_ecd43deb","updated":"2017-06-15 21:27:52.000000000","message":"Well with a real server running (this is API test) someone might have an ML2 plugin that contacts a backend that asynchronously comes back and updates something.","commit_id":"9910967255473cbd48fb128819701e0c8d006f60"}],"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"86e3a755fb0bdf9ecc3c7f7e4f1268c007f77272","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                             headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % val},"},{"line_number":90,"context_line":"                             expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":91,"context_line":"            after_attempt \u003d self._show(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":92,"context_line":"            self.assertEqual(rev, after_attempt[\u0027port\u0027][\u0027revision_number\u0027])"},{"line_number":93,"context_line":"            # correct revision should work"},{"line_number":94,"context_line":"            self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], new,"},{"line_number":95,"context_line":"                         headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % rev})"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_f1113705","line":92,"updated":"2017-01-18 01:07:18.000000000","message":"it\u0027s better to check the name as well","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0c31ededa7d162a259125754a26af8af343f82d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                             headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % val},"},{"line_number":90,"context_line":"                             expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":91,"context_line":"            after_attempt \u003d self._show(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":92,"context_line":"            self.assertEqual(rev, after_attempt[\u0027port\u0027][\u0027revision_number\u0027])"},{"line_number":93,"context_line":"            # correct revision should work"},{"line_number":94,"context_line":"            self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], new,"},{"line_number":95,"context_line":"                         headers\u003d{\u0027If-Match\u0027: \u0027revision_number\u003d%s\u0027 % rev})"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_f5dba74d","line":92,"in_reply_to":"7a3c09a3_f1113705","updated":"2017-01-18 20:03:02.000000000","message":"Done","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"86e3a755fb0bdf9ecc3c7f7e4f1268c007f77272","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            def concurrent_increment(s):"},{"line_number":118,"context_line":"                event.remove(se.Session, \u0027before_commit\u0027, concurrent_increment)"},{"line_number":119,"context_line":"                # slip in a conccurent update that will bump the revision"},{"line_number":120,"context_line":"                self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], new)"},{"line_number":121,"context_line":"                raise db_exc.DBDeadlock()"},{"line_number":122,"context_line":"            event.listen(se.Session, \u0027before_commit\u0027, concurrent_increment)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_f1285735","line":119,"range":{"start_line":119,"start_character":28,"end_line":119,"end_character":38},"updated":"2017-01-18 01:07:18.000000000","message":"concurrent","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0c31ededa7d162a259125754a26af8af343f82d","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            def concurrent_increment(s):"},{"line_number":118,"context_line":"                event.remove(se.Session, \u0027before_commit\u0027, concurrent_increment)"},{"line_number":119,"context_line":"                # slip in a conccurent update that will bump the revision"},{"line_number":120,"context_line":"                self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], new)"},{"line_number":121,"context_line":"                raise db_exc.DBDeadlock()"},{"line_number":122,"context_line":"            event.listen(se.Session, \u0027before_commit\u0027, concurrent_increment)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_f5ae4780","line":119,"range":{"start_line":119,"start_character":28,"end_line":119,"end_character":38},"in_reply_to":"7a3c09a3_f1285735","updated":"2017-01-18 20:03:02.000000000","message":"Done","commit_id":"160ddb9ac8bcb63be0bd2e35b5001b637bb21c26"}]}
