)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"0464353cc316b4c14b1963a7a06bd0b3eec51254","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update TrunkPortValidator.validate() rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some hardware switches doesn\u0027t support properly or not support at all"},{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_cb0cc33d","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":67},"updated":"2017-01-22 05:50:56.000000000","message":"typo","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6544349fccad2087417c071a762d23efd4676be1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_a2d2e032","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"updated":"2016-12-12 16:25:27.000000000","message":"this is not the right approach, I am afraid.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a82f147857e5caf523cb7863d1dd82466b138c4a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_992f09a1","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_5902d13f","updated":"2016-12-12 23:19:45.000000000","message":"ok, thanks for confirming this.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9cc0bd5652eddaac6e6487199edb4e4ca5fa4fb7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_9c73844d","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_629fe85f","updated":"2016-12-12 17:19:46.000000000","message":"There are a couple of approaches that could potentially work, but I will need to think about the consequences. One proposal I had in mind would work as follow:\n\na) a trunk parent port that is destined for Ironic would have vnic_type \u003d\u003d baremetal, as as such a user would need to specify that upfront.\nb) trunk rules could be modified to infer segmentation details from the network if they are missing and the subport is being added to a trunk whose parent port has vnic type \u003d\u003d baremetal, prior to checking their uniqueness, etc.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"915098d69e0f117b073835ba0fd271734ae91bea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_5902d13f","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_996c699e","updated":"2016-12-12 23:16:45.000000000","message":"At the moment we update vnic_type from Ironic code for both provision [0] and tenant ports [1]. But end user may precreate a tenant port with vnic_type\u003dbaremetal. So it is ok, if user will have to specify vnic_type explicitly when create a trunk port.\n\n[0] https://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L132\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/network/neutron.py#L195","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e3917514517ffd7edab4d2e63c31e627f6682bb0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_b95f650d","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_9c73844d","updated":"2016-12-12 22:59:03.000000000","message":"I\u0027m not Neutron expert, so please do not judge strictly... Have few thoughts on this:\nForcing vlan translation would affect performance, so it may be useful to do not force using vlan mapping when provider:net_type is VLAN with other vnic types like \u0027direct\u0027, \u0027macvtap\u0027 or even \u0027normal\u0027. \n\nThe biggest drawback  here, that end user will know provider network type details.\nMight be even introduce a config option that allow administrator to force disable inheriting missed subports segmentation details to explicitly hide provider network settings from end user.\n\nI will rework this patch to rely on vnic_type \u003d\u003d baremetal.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"80bb7373b12dec3dc55aa1e127328389c017f39d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_629fe85f","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_a2d2e032","updated":"2016-12-12 16:27:22.000000000","message":"Armando thanks for review, any advise how to allow use hardware that do not support VLAN mapping?","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eb60751511a2e52a92c683afd5dba730258f4bb5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VLAN translation. It prohibits using Neutron trunks functionallity even"},{"line_number":11,"context_line":"when provider segmentation_type is VLAN."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates TrunkPortValidator.validate() method to allow"},{"line_number":14,"context_line":"inherit segmentation_id and segmentation_type from subports network"},{"line_number":15,"context_line":"data in case of VLAN network only."},{"line_number":16,"context_line":"For other network_type than VLAN segmentation_id and segmentation_type"},{"line_number":17,"context_line":"still need to be set explicitly by user and requires VLAN mapping"},{"line_number":18,"context_line":"support on hardware side."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic22977afd8447cee92c0065c8979c01b33200eba"},{"line_number":21,"context_line":"Closes-Bug: #1648129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_996c699e","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"1a6eadb0_b95f650d","updated":"2016-12-12 23:04:05.000000000","message":"Because of the complexity of this issue, my suggestion is to park this for now, because this is not high priority for Ocata and you might not get enough attention from reviewers. I\u0027d advise against any config variable, because that would be affecting portability of the API across deployments and it\u0027s not discoverable.\n\nAs for the user knowing the vnic type. What do you expect the workflow to be like when booting Ironic instances? Isn\u0027t Ironic/Neutron which sets the vnic type when creating the neutron port?","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"}],"neutron/services/trunk/rules.py":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3891befc8295815a7cfcf1cbad49445235ae0817","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            type_msg \u003d _(\"Can\u0027t inherit segmentation_type from subports \""},{"line_number":235,"context_line":"                         \"network. Must be specified explicitly.\")"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            type_msg \u003d _(\"Unknown segmentation_type \u0027%s\u0027\") % segmentation_type"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if segmentation_type not in self._segmentation_types:"},{"line_number":240,"context_line":"            raise n_exc.InvalidInput(error_message\u003dtype_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0405ad0f","line":237,"updated":"2016-12-12 14:18:33.000000000","message":".","commit_id":"3b6a7dfb0dd18894368e02941750dd7b71f117b2"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3891befc8295815a7cfcf1cbad49445235ae0817","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                segmentation_id \u003d (converters.convert_to_int(segmentation_id))"},{"line_number":250,"context_line":"            except n_exc.InvalidInput:"},{"line_number":251,"context_line":"                msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""},{"line_number":252,"context_line":"                        \"not an integer\") % segmentation_id"},{"line_number":253,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            if not self._segmentation_types[segmentation_type]("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_440b2524","line":252,"updated":"2016-12-12 14:18:33.000000000","message":".","commit_id":"3b6a7dfb0dd18894368e02941750dd7b71f117b2"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3891befc8295815a7cfcf1cbad49445235ae0817","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            if not self._segmentation_types[segmentation_type]("},{"line_number":256,"context_line":"                    segmentation_id):"},{"line_number":257,"context_line":"                msg \u003d _(\"Segmentation ID \u0027%s\u0027 is not in \""},{"line_number":258,"context_line":"                        \"range\") % segmentation_id"},{"line_number":259,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Check if the subport is already participating in an active trunk"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_8411bd54","line":258,"updated":"2016-12-12 14:18:33.000000000","message":".","commit_id":"3b6a7dfb0dd18894368e02941750dd7b71f117b2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f2ea40a92b9a7db5af99044663ea169da8073b35","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        # them from network data. It allows to use Neutron VLAN networks"},{"line_number":217,"context_line":"        # without doing VLAN translation on the ToR switch. But requires"},{"line_number":218,"context_line":"        # to show provider:segmentation_type and segmentation_id to user."},{"line_number":219,"context_line":"        segmentation_type \u003d subport.get(\u0027segmentation_type\u0027)"},{"line_number":220,"context_line":"        segmentation_id \u003d subport.get(\u0027segmentation_id\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if segmentation_type is None or segmentation_id is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_02b0f4f3","line":219,"updated":"2016-12-12 16:27:40.000000000","message":"This change is too invasive, besides inferring the segmentation details from the network when they are missing it\u0027s not an approach that works for all trunk drivers. Hence we left it for after Newton, because it\u0027s a hard requirement to nail down.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"674fe9f13cf1b0491b5b540550bac1fc02a3138e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def _try_to_inherit_segmentation(self, context, port, subport,"},{"line_number":198,"context_line":"                                     core_plugin):"},{"line_number":199,"context_line":"        try:"},{"line_number":200,"context_line":"            net \u003d core_plugin.get_network(context, port[\u0027network_id\u0027])"},{"line_number":201,"context_line":"        except n_exc.NetworkNotFound:"},{"line_number":202,"context_line":"            msg \u003d _(\"Network %s not found\") % port[\u0027network_id\u0027]"},{"line_number":203,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_f3b87b77","line":200,"updated":"2017-02-14 15:57:52.000000000","message":"We already fetch the network when we deal with the MTU. This is a bit inefficient.","commit_id":"868098923c6653de0db6df42cac5d5772fb71910"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"33ce6cf89634693698bf3856f52c0a2825ed21d3","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if net[providernet.NETWORK_TYPE] \u003d\u003d constants.TYPE_VLAN:"},{"line_number":206,"context_line":"            subport[\"segmentation_id\"] \u003d str(net[providernet.SEGMENTATION_ID])"},{"line_number":207,"context_line":"            subport[\"segmentation_type\"] \u003d net[providernet.NETWORK_TYPE]"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            msg \u003d _(\"Can\u0027t inherit segmentation details from subports %s \""},{"line_number":210,"context_line":"                    \"network, they must be specified explicitly.\") % subport"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_62ebe813","line":207,"updated":"2017-02-14 08:39:13.000000000","message":"Instead of automatically trying to do this on blank segmentation_types, I think it might be a good idea to be explicit and have them specify \u0027INHERIT\u0027 or something similar for segmentation_type.\n\nOther than the advantage of being a big more explicit about intent, it also allows operators to block this with the policy engine if they are concerned about leaking segmentation details.","commit_id":"868098923c6653de0db6df42cac5d5772fb71910"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0043ff1316d433c7395271cf71067f91d2563b00","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if net[providernet.NETWORK_TYPE] \u003d\u003d constants.TYPE_VLAN:"},{"line_number":206,"context_line":"            subport[\"segmentation_id\"] \u003d str(net[providernet.SEGMENTATION_ID])"},{"line_number":207,"context_line":"            subport[\"segmentation_type\"] \u003d net[providernet.NETWORK_TYPE]"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            msg \u003d _(\"Can\u0027t inherit segmentation details from subports %s \""},{"line_number":210,"context_line":"                    \"network, they must be specified explicitly.\") % subport"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_b0499cb9","line":207,"in_reply_to":"fa31d9ce_62ebe813","updated":"2017-02-14 14:41:01.000000000","message":"So if user set segmentation_type to INHERIT, it is a trigger for Neutron to try to inherit segmentation. Do you think it should be available only for specific vnic_type?\nDo you think validate() is the proper place where we should try to inherit segmentation details or it should be done in another method that is called prior validate()?","commit_id":"868098923c6653de0db6df42cac5d5772fb71910"}],"neutron/tests/unit/services/trunk/test_rules.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"674fe9f13cf1b0491b5b540550bac1fc02a3138e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.tests.unit.services.trunk import fakes"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class SubPortsValidatorTestCase(test_plugin.Ml2PluginV2TestCase):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def setUp(self):"},{"line_number":40,"context_line":"        super(SubPortsValidatorTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_d30ff736","line":37,"updated":"2017-02-14 15:57:52.000000000","message":"My suggestion is to write a new testcase, just like we did for the MTU-related use cases.","commit_id":"868098923c6653de0db6df42cac5d5772fb71910"}],"releasenotes/notes/allow-inherit-provider-network-type-for-subports-bd89687400d8677c.yaml":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a8cc28397819cc2a8bedfc805d663993f0ff2b3a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    VLAN mapping."},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - The \u0027segmentation_id\u0027 and \u0027segmentation_type\u0027 fields are"},{"line_number":14,"context_line":"    no longer mandatory fields when adding subports to a trunk"},{"line_number":15,"context_line":"    for subports network_type \u003d\u003d VLAN."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_943430df","line":14,"updated":"2016-12-12 23:22:28.000000000","message":"segmentation details were never mandatory from an API standpoint. You can treat this as a bug fix and as such it does not strictly require a release note. That said, we need to revise the documentation to expand on how to address the Ironic use case.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3a8d6a1514b29ca2c66092f37bf684129a4d469d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    VLAN mapping."},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - The \u0027segmentation_id\u0027 and \u0027segmentation_type\u0027 fields are"},{"line_number":14,"context_line":"    no longer mandatory fields when adding subports to a trunk"},{"line_number":15,"context_line":"    for subports network_type \u003d\u003d VLAN."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_df3f57d4","line":14,"in_reply_to":"1a6eadb0_63e7c9e4","updated":"2016-12-14 09:29:12.000000000","message":"Making the platform picking random VLANs is not practical from a guest configuration standpoint, and we are not going to make neutron do so.","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ecae530829f9b9a9f3e1ff7d7a4c732aa751b629","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    VLAN mapping."},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - The \u0027segmentation_id\u0027 and \u0027segmentation_type\u0027 fields are"},{"line_number":14,"context_line":"    no longer mandatory fields when adding subports to a trunk"},{"line_number":15,"context_line":"    for subports network_type \u003d\u003d VLAN."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_63e7c9e4","line":14,"in_reply_to":"1a6eadb0_943430df","updated":"2016-12-13 10:14:19.000000000","message":"I\u0027ve opened a bug to track this issue [0]. So even if segmentation details are not mandatory from API standpoint they are mandatory from trunk standpoint (each network should be identified by a unique VLAN identifier on the trunk).\nBy making them optional for user on API side, we still need to generate them implicitly on Neutron side and provide generated values to user, as he should know segmentation_id to configure it on instance side.\n\nIf I\u0027m not mistaken in the conclusions above we have a new option here:\n\n1. Create a helper function _pick_segmentation_details() that is called prior to _validate() in [1]. This function will randomly pick an unique VLAN identifier for each subport if it is not set explicitly by user for this trunk. Should fix [0]\n\n2. For baremetal case. Fixing [2] \n    a) Based on vnic_type allow inheriting segmentation details from ports network\n    b) Inherit segmentation details for all vnic_type\u0027s \n       if network_type \u003d\u003d VLAN\n\n3. Document implementation and usage.\n\n\n[0] https://bugs.launchpad.net/neutron/+bug/1649531\n[1] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/rules.py#L166\n[2] https://launchpad.net/bugs/1648129","commit_id":"efc476f275bb3946ff014a7e078a8faa8fd28af8"}]}
