)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"1b30bdb5cfe94430a038388dae1859c641dd7e30","unresolved":false,"context_lines":[{"line_number":33,"context_line":"None of these fields are queryable from the API, so we don\u0027t need"},{"line_number":34,"context_line":"to worry about breaking queries against the models."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Closes-Bug: #1649317"},{"line_number":37,"context_line":"Change-Id: Ic1947e3d78d58a79b21344b10cb7ab0e573e419f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_20186784","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":10},"updated":"2016-12-13 10:01:49.000000000","message":"Given that the issue described in Bug 1649317 is not specific to this relation but could occur with other relations, wouldn\u0027t Partial-Bug make more sense ?","commit_id":"b914e712e8cc2c6c7486ff7ab098912b194352fd"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d7bccba9b17a71631c9af727ee3f07974c0aa78a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"None of these fields are queryable from the API, so we don\u0027t need"},{"line_number":34,"context_line":"to worry about breaking queries against the models."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Closes-Bug: #1649317"},{"line_number":37,"context_line":"Change-Id: Ic1947e3d78d58a79b21344b10cb7ab0e573e419f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_755f6041","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":10},"in_reply_to":"1a6eadb0_20186784","updated":"2016-12-13 19:42:33.000000000","message":"Well I think the issue in the bug of the server being unresponsive was specific to these relations. We need to distinguish between these particularly bad ones that can bring the server to a halt and ones that just impact performance negatively but still leave things operational.","commit_id":"b914e712e8cc2c6c7486ff7ab098912b194352fd"}],"neutron/db/models_v2.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"69557f90a76692aff42052a07af9d26a67504844","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    # subnets don\u0027t have their own rbac_entries, they just inherit from"},{"line_number":196,"context_line":"    # the network rbac entries"},{"line_number":197,"context_line":"    rbac_entries \u003d orm.relationship("},{"line_number":198,"context_line":"        rbac_db_models.NetworkRBAC, lazy\u003d\u0027subquery\u0027, uselist\u003dTrue,"},{"line_number":199,"context_line":"        foreign_keys\u003d\u0027Subnet.network_id\u0027,"},{"line_number":200,"context_line":"        primaryjoin\u003d\u0027Subnet.network_id\u003d\u003dNetworkRBAC.object_id\u0027)"},{"line_number":201,"context_line":"    api_collections \u003d [attr.SUBNETS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_76591c5a","line":198,"updated":"2016-12-14 02:36:01.000000000","message":"I\u0027m no expert here, but can lazy\u003d\u0027joined\u0027, innerjoin\u003dTrue be used here (and below)?","commit_id":"b914e712e8cc2c6c7486ff7ab098912b194352fd"},{"author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"change_message_id":"7648798c3bfe09cb40271efb26ca71762c207f93","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    # subnets don\u0027t have their own rbac_entries, they just inherit from"},{"line_number":196,"context_line":"    # the network rbac entries"},{"line_number":197,"context_line":"    rbac_entries \u003d orm.relationship("},{"line_number":198,"context_line":"        rbac_db_models.NetworkRBAC, lazy\u003d\u0027subquery\u0027, uselist\u003dTrue,"},{"line_number":199,"context_line":"        foreign_keys\u003d\u0027Subnet.network_id\u0027,"},{"line_number":200,"context_line":"        primaryjoin\u003d\u0027Subnet.network_id\u003d\u003dNetworkRBAC.object_id\u0027)"},{"line_number":201,"context_line":"    api_collections \u003d [attr.SUBNETS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_a548bc88","line":198,"in_reply_to":"1a6eadb0_76591c5a","updated":"2016-12-14 15:50:46.000000000","message":"No. inner or outer joins will build cross-product. But with an inner join the result would be false: all networks with no rbac entry would not be listed.","commit_id":"b914e712e8cc2c6c7486ff7ab098912b194352fd"}]}