)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ac28fe81be019a5646b70dd666c355fe5678681e","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            # Expire the db_network in current transaction, so that the join"},{"line_number":816,"context_line":"            # relationship can be updated."},{"line_number":817,"context_line":"            context.session.expire(db_network)"},{"line_number":818,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":821,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_4e9557dc","line":818,"updated":"2016-12-14 10:56:16.000000000","message":"fetching the network twice now doesn\u0027t seem like a great solution. This must have to do with the identity map and perhaps Kevin has a better suggestion.","commit_id":"288d2b07731c2fd8dba9a536eaee7eb1851abf10"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4b9328afb8b4b21aa71ba3995876b317e7c476a7","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            # Expire the db_network in current transaction, so that the join"},{"line_number":816,"context_line":"            # relationship can be updated."},{"line_number":817,"context_line":"            context.session.expire(db_network)"},{"line_number":818,"context_line":"            updated_network \u003d self.get_network(context, id)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":821,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7fc44b40","line":818,"in_reply_to":"1a6eadb0_4e9557dc","updated":"2017-03-29 06:22:27.000000000","message":"Make it \n\nupdated_network \u003d self._make_network_dict(db_network, context\u003dcontext)\n\nThat will make this back-portable. Then after the switch to engine facade we can get rid of this.\n\nPlease also make a TODO that says \u0027remove after switch to enginefacade\u0027.","commit_id":"288d2b07731c2fd8dba9a536eaee7eb1851abf10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a925b70a451808c80d5179b5f0c573a725c7e7a4","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                                                           updated_network)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"            # ToDO(QoS): This would change once EngineFacade moves out"},{"line_number":815,"context_line":"            updated_network \u003d self._make_network_dict(db_network, context\u003dcontext)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."},{"line_number":818,"context_line":"            need_network_update_notify \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_ecbe69d3","line":815,"range":{"start_line":815,"start_character":12,"end_line":815,"end_character":82},"updated":"2017-03-29 12:18:07.000000000","message":"Ok, I think this change is breaking a lot of things...\n\nI took a look at the code of self.get_network. This function is calling NeutronDbPluginV2.get_network. Inside this function \"_make_network_dict\" is called.\n\nNevermind, I think the problem is other. Please check \"update_subnets\". When \"_update_subnet_precommit\" is called, the session is forced to expire (https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L830). Then the subnet object is retrieved form the DB, but the updated object is already there.\n\nIn our case, we send the update command in this transaction and then, without writing the values in the DB, we retrieve the old network value again.\n\nPlease, can you check with Ann Taraday if this is the problem?","commit_id":"ae2779e331a9e139fd7b1ab6e456a8837ca474c4"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ac28fe81be019a5646b70dd666c355fe5678681e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            self.assertIn(rule, actual_rule_types)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _disassociate_network(self, client, network_id):"},{"line_number":179,"context_line":"        updated_network \u003d client.update_network(network_id,"},{"line_number":180,"context_line":"                                                qos_policy_id\u003dNone)"},{"line_number":181,"context_line":"        self.assertIsNone(updated_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2ead7b31","line":179,"updated":"2016-12-14 10:56:16.000000000","message":"nice cleanup. The way this was was clearly shadowed the issue!","commit_id":"288d2b07731c2fd8dba9a536eaee7eb1851abf10"}]}
