)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ZhaoBo \u003czhaobo6@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-22 10:33:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_87e203d4","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":14},"updated":"2016-12-22 21:12:45.000000000","message":"s/i/I","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ZhaoBo \u003czhaobo6@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-22 10:33:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_1eb571ed","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":14},"in_reply_to":"da4df55a_87e203d4","updated":"2016-12-23 06:21:16.000000000","message":"Done","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_47d9fb20","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"updated":"2016-12-22 21:12:45.000000000","message":"raises","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_e7f82f7f","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":25},"updated":"2016-12-22 21:12:45.000000000","message":"s/i/I","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_3eb875e5","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"in_reply_to":"da4df55a_47d9fb20","updated":"2016-12-23 06:21:16.000000000","message":"Done","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_5ecff97e","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":25},"in_reply_to":"da4df55a_e7f82f7f","updated":"2016-12-23 06:21:16.000000000","message":"Done","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1649750"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_47f01b91","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":42},"updated":"2016-12-22 21:12:45.000000000","message":"sets","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Raise Invalidinput exception on provider-net creation without seg_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch raise Invalidinput to users when they create provider net"},{"line_number":10,"context_line":"without seg_id if ml2_vlan_ranges just set the physical net name. This"},{"line_number":11,"context_line":"must be more friendly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1649750"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da4df55a_9ec9617b","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":42},"in_reply_to":"da4df55a_47f01b91","updated":"2016-12-23 06:21:16.000000000","message":"Many thanks for your kind review and help. :)","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"}],"neutron/plugins/ml2/drivers/type_vlan.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"49e825f2a6e2d64cb3fa0cafd981990e8f51a6a7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"},{"line_number":178,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":179,"context_line":"            alloc \u003d self.allocate_partially_specified_segment("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_62f12301","line":176,"updated":"2016-12-14 23:03:59.000000000","message":"The whole point of this code path is that the user didn\u0027t specify the segmentation id. Under that condition, is_partial_segment will return true and this branch of the if is executed: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_vlan.py#L134. Since segmentation_id wasn\u0027t specified, we call https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/helpers.py#L119. This method allocates any available segment id available in the specified physical net. It will only return a None if it doesn\u0027t find a segment available. So it doesn\u0027t make sense to return a message to the user asking him / her to specify a segmentation_id. The user didn\u0027t want to do that. Here\u0027s a CLI level example I just executed successfully in my dev system: http://paste.openstack.org/show/592402/","commit_id":"faa3689c4144d36e8f54cb17a195075089086127"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3b3dcc8dfab48603cf06b49b261bd417f6c90a72","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                filters[\u0027vlan_id\u0027] \u003d vlan_id"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_e5569e05","line":174,"updated":"2016-12-21 21:11:30.000000000","message":"I think that a more appropriate place for this validation is validate_provider_segment (L137 above). Input validation is the purpose of that method","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6abb7b664e26dfd68509f207f51f1993ab2dc613","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                filters[\u0027vlan_id\u0027] \u003d vlan_id"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_8e3401df","line":174,"in_reply_to":"da4df55a_e5569e05","updated":"2016-12-22 07:39:36.000000000","message":"Thanks for this suggestion. I will update in the next patch.:)","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3b3dcc8dfab48603cf06b49b261bd417f6c90a72","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"},{"line_number":178,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_6590ee96","line":175,"range":{"start_line":175,"start_character":24,"end_line":175,"end_character":27},"updated":"2016-12-21 21:11:30.000000000","message":"Do we really need any here? If I set network_vlan_ranges \u003d physnet1 in ml2_conf.ini, what we get in self.network_vlan_ranges is {\u0027physnet1\u0027: []}","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6abb7b664e26dfd68509f207f51f1993ab2dc613","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"},{"line_number":178,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_3311c2ad","line":175,"range":{"start_line":175,"start_character":24,"end_line":175,"end_character":27},"in_reply_to":"da4df55a_6590ee96","updated":"2016-12-22 07:39:36.000000000","message":"any not need here. Thanks. You are right.","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3b3dcc8dfab48603cf06b49b261bd417f6c90a72","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"},{"line_number":178,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":179,"context_line":"            alloc \u003d self.allocate_partially_specified_segment("},{"line_number":180,"context_line":"                session, **filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_1a6861ba","line":177,"range":{"start_line":176,"start_character":26,"end_line":177,"end_character":41},"updated":"2016-12-21 21:11:30.000000000","message":"For more clarity, I suggest changing the message to:\n\n\"Physical network %s requires segmentation_id to be specified when creating a provider network\"","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"6abb7b664e26dfd68509f207f51f1993ab2dc613","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if self.is_partial_segment(segment):"},{"line_number":174,"context_line":"            if (physical_network and"},{"line_number":175,"context_line":"                    not any(self.network_vlan_ranges.get(physical_network))):"},{"line_number":176,"context_line":"                msg \u003d (_(\"physical_network %s need specify the\""},{"line_number":177,"context_line":"                        \" segmentation_id\") % physical_network)"},{"line_number":178,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":179,"context_line":"            alloc \u003d self.allocate_partially_specified_segment("},{"line_number":180,"context_line":"                session, **filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_9320aef9","line":177,"range":{"start_line":176,"start_character":26,"end_line":177,"end_character":41},"in_reply_to":"da4df55a_1a6861ba","updated":"2016-12-22 07:39:36.000000000","message":"agree.:)","commit_id":"b2c56c2b59afefd41b80e2ecaefc6451310cba5c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                if not self.network_vlan_ranges.get(physical_network):"},{"line_number":154,"context_line":"                    msg \u003d (_(\"Physical network %s requires segmentation_id\""},{"line_number":155,"context_line":"                             \" to be specified when creating a provider \""},{"line_number":156,"context_line":"                             \"network\") % physical_network)"},{"line_number":157,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":158,"context_line":"        elif segmentation_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_e7958f40","line":155,"range":{"start_line":155,"start_character":30,"end_line":155,"end_character":31},"updated":"2016-12-22 21:12:45.000000000","message":"In one of my recent patchsets, a core reviewer asked me to move a blank space like this to the end of the previous line. I suggest you do the same and save a future comment from another reviewer","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                if not self.network_vlan_ranges.get(physical_network):"},{"line_number":154,"context_line":"                    msg \u003d (_(\"Physical network %s requires segmentation_id\""},{"line_number":155,"context_line":"                             \" to be specified when creating a provider \""},{"line_number":156,"context_line":"                             \"network\") % physical_network)"},{"line_number":157,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":158,"context_line":"        elif segmentation_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_9e77a139","line":155,"range":{"start_line":155,"start_character":30,"end_line":155,"end_character":31},"in_reply_to":"da4df55a_e7958f40","updated":"2016-12-23 06:21:16.000000000","message":"Thanks a lot. I should follow the others format. Thank you again.","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8aad0f4c1897f370fe51cf2317cc9d3d08f0de4d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                            \u0027max\u0027: p_const.MAX_VLAN_TAG})"},{"line_number":151,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                if not self.network_vlan_ranges.get(physical_network):"},{"line_number":154,"context_line":"                    msg \u003d (_(\"Physical network %s requires segmentation_id \""},{"line_number":155,"context_line":"                             \"to be specified when creating a provider \""},{"line_number":156,"context_line":"                             \"network\") % physical_network)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_aa632819","line":153,"updated":"2016-12-23 17:25:19.000000000","message":"Nit: No need to change. At this point, we know physical_network is in self.network_vlan_ranges due to L141. So we don\u0027t need the get. We can say:\n\nif not self.network_vlan_ranges[physical_network]:","commit_id":"2e86802c769cecce2816983472b33a8eb92e0448"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a31567a7b5de750b6fd02c78412f24c1b29d8379","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                            \u0027max\u0027: p_const.MAX_VLAN_TAG})"},{"line_number":151,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                if not self.network_vlan_ranges.get(physical_network):"},{"line_number":154,"context_line":"                    msg \u003d (_(\"Physical network %s requires segmentation_id \""},{"line_number":155,"context_line":"                             \"to be specified when creating a provider \""},{"line_number":156,"context_line":"                             \"network\") % physical_network)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_5a17e5ec","line":153,"in_reply_to":"da4df55a_aa632819","updated":"2016-12-24 01:59:17.000000000","message":"Thank you. You said must be more correct. And I think this may cause confused for our code reader. Thanks again.","commit_id":"2e86802c769cecce2816983472b33a8eb92e0448"}],"neutron/tests/unit/plugins/ml2/drivers/test_type_vlan.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d938b4360802b506e44b55f29d5e7d7a78c8e45a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                          self.driver.validate_provider_segment,"},{"line_number":122,"context_line":"                          segment)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_validate_provider_segment_with_physical_network(self):"},{"line_number":125,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_VLAN,"},{"line_number":126,"context_line":"                   api.PHYSICAL_NETWORK: PROVIDER_NET}"},{"line_number":127,"context_line":"        self.assertRaises(exc.InvalidInput,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_e7682fbd","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":60},"updated":"2016-12-22 21:12:45.000000000","message":"do you mind making this a little more descriptive? I propose: test_validate_provider_segment_with_physical_network_only","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"45e1a524c89d54ab763964825b2cd94d04df9445","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                          self.driver.validate_provider_segment,"},{"line_number":122,"context_line":"                          segment)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_validate_provider_segment_with_physical_network(self):"},{"line_number":125,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_VLAN,"},{"line_number":126,"context_line":"                   api.PHYSICAL_NETWORK: PROVIDER_NET}"},{"line_number":127,"context_line":"        self.assertRaises(exc.InvalidInput,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_be9b8571","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":60},"in_reply_to":"da4df55a_e7682fbd","updated":"2016-12-23 06:21:16.000000000","message":"Done","commit_id":"223f0d85fc23fd8275fc0e18008240e14c3d2746"}]}
