)]}'
{"neutron/agent/rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c0eeeeec1d6eb2525deb76e04e6b01ead91dac5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    ]"},{"line_number":170,"context_line":"    rcache \u003d resource_cache.RemoteResourceCache(resource_types)"},{"line_number":171,"context_line":"    rcache.start_watcher()"},{"line_number":172,"context_line":"    rcache.bulk_flood_cache()"},{"line_number":173,"context_line":"    return rcache"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_92071581","line":172,"updated":"2017-03-10 22:19:05.000000000","message":"since the flood does not filter by any means, aren\u0027t we concerned about scenario where multiple agents start at the same time and pull whole database via RPC in multiple parallel threads, making server overloaded?","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    ]"},{"line_number":170,"context_line":"    rcache \u003d resource_cache.RemoteResourceCache(resource_types)"},{"line_number":171,"context_line":"    rcache.start_watcher()"},{"line_number":172,"context_line":"    rcache.bulk_flood_cache()"},{"line_number":173,"context_line":"    return rcache"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_4df3ba9f","line":172,"in_reply_to":"9a30ddce_92071581","updated":"2017-04-06 11:48:13.000000000","message":"I plan to address the filter thing before release. Even without it though, pure lookups are cheaper than the annoying status update life cycle get_devices_details currently triggers.\n\nI\u0027ll put another loud TODO here.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ca46125d80cbfea728ad40c279b6fbd5d2ea87ae","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        self._legacy_interface \u003d legacy_interface"},{"line_number":189,"context_line":"        for e in (callback_events.AFTER_UPDATE, callback_events.AFTER_DELETE):"},{"line_number":190,"context_line":"            for r in (\u0027Port\u0027, \u0027Network\u0027):"},{"line_number":191,"context_line":"                registry.subscribe(self._legacy_notifier, r, e)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _legacy_notifier(self, rtype, event, trigger, context, resource_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_e70dc238","line":190,"range":{"start_line":190,"start_character":22,"end_line":190,"end_character":39},"updated":"2017-03-21 14:55:08.000000000","message":"resources.PORT and resources.NETWORK have exactly the same names. Could we use them as pointers? Technically, these are the same, but would spare the time for looking for a details.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        self._legacy_interface \u003d legacy_interface"},{"line_number":189,"context_line":"        for e in (callback_events.AFTER_UPDATE, callback_events.AFTER_DELETE):"},{"line_number":190,"context_line":"            for r in (\u0027Port\u0027, \u0027Network\u0027):"},{"line_number":191,"context_line":"                registry.subscribe(self._legacy_notifier, r, e)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _legacy_notifier(self, rtype, event, trigger, context, resource_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_cd134a66","line":190,"range":{"start_line":190,"start_character":22,"end_line":190,"end_character":39},"in_reply_to":"9a30ddce_e70dc238","updated":"2017-04-06 11:48:13.000000000","message":"Done","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c0eeeeec1d6eb2525deb76e04e6b01ead91dac5","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\"Checks if legacy interface is expecting calls for resource."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        looks for port_update, network_delete, etc and calls them with"},{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_922e35f9","line":198,"range":{"start_line":198,"start_character":38,"end_line":198,"end_character":46},"updated":"2017-03-10 22:19:05.000000000","message":"expecting","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\"Checks if legacy interface is expecting calls for resource."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        looks for port_update, network_delete, etc and calls them with"},{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_4d073a1e","line":198,"range":{"start_line":198,"start_character":38,"end_line":198,"end_character":46},"in_reply_to":"9a30ddce_922e35f9","updated":"2017-04-06 11:48:13.000000000","message":"Done","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ca46125d80cbfea728ad40c279b6fbd5d2ea87ae","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        looks for port_update, network_delete, etc and calls them with"},{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_0741f639","line":200,"updated":"2017-03-21 14:55:08.000000000","message":"If we would base on resources.PORT and resources.NETWORK, then values could be parsed as resources.PORT.lower() etc","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        looks for port_update, network_delete, etc and calls them with"},{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_2847444e","line":200,"in_reply_to":"9a30ddce_0741f639","updated":"2017-04-06 11:48:13.000000000","message":"Done","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ca46125d80cbfea728ad40c279b6fbd5d2ea87ae","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"},{"line_number":204,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_877326b4","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":11},"updated":"2017-03-21 14:55:08.000000000","message":"Just readability: could we use `suffix`?","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        the payloads the handlers are expecing (an ID)."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"},{"line_number":204,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_88dc1075","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":11},"in_reply_to":"9a30ddce_877326b4","updated":"2017-04-06 11:48:13.000000000","message":"Done","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c0eeeeec1d6eb2525deb76e04e6b01ead91dac5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"},{"line_number":204,"context_line":"            return"},{"line_number":205,"context_line":"        payload \u003d {resource_to_prefix[rtype]: {\u0027id\u0027: resource_id},"},{"line_number":206,"context_line":"                   \u0027%s_id\u0027 % resource_to_prefix[rtype]: resource_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_b21899d4","line":203,"updated":"2017-03-10 22:19:05.000000000","message":"do we want to eventually get rid of the legacy handler? in which case, maybe add a warning here (triggered once in process lifetime) about that.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        resource_to_prefix \u003d {\u0027Port\u0027: \u0027port\u0027, \u0027Network\u0027: \u0027network\u0027}"},{"line_number":201,"context_line":"        suf \u003d \u0027delete\u0027 if event \u003d\u003d callback_events.AFTER_DELETE else \u0027update\u0027"},{"line_number":202,"context_line":"        method \u003d \"%s_%s\" % (resource_to_prefix[rtype], suf)"},{"line_number":203,"context_line":"        if not hasattr(self._legacy_interface, method):"},{"line_number":204,"context_line":"            return"},{"line_number":205,"context_line":"        payload \u003d {resource_to_prefix[rtype]: {\u0027id\u0027: resource_id},"},{"line_number":206,"context_line":"                   \u0027%s_id\u0027 % resource_to_prefix[rtype]: resource_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_e83b9c99","line":203,"in_reply_to":"9a30ddce_b21899d4","updated":"2017-04-06 11:48:13.000000000","message":"I\u0027ll put a TODO to deprecate it later once things seem stable.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c0eeeeec1d6eb2525deb76e04e6b01ead91dac5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        return result"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def get_device_details(self, context, device, agent_id, host\u003dNone):"},{"line_number":223,"context_line":"        dev_ovo \u003d self.remote_resource_cache.get_resource_by_id(\u0027Port\u0027, device)"},{"line_number":224,"context_line":"        if not dev_ovo:"},{"line_number":225,"context_line":"            LOG.debug(\"Device %s does not exist.\", device)"},{"line_number":226,"context_line":"            return {\u0027device\u0027: device}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_52203df7","line":223,"range":{"start_line":223,"start_character":8,"end_line":223,"end_character":15},"updated":"2017-03-10 22:19:05.000000000","message":"port_obj?","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        return result"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def get_device_details(self, context, device, agent_id, host\u003dNone):"},{"line_number":223,"context_line":"        dev_ovo \u003d self.remote_resource_cache.get_resource_by_id(\u0027Port\u0027, device)"},{"line_number":224,"context_line":"        if not dev_ovo:"},{"line_number":225,"context_line":"            LOG.debug(\"Device %s does not exist.\", device)"},{"line_number":226,"context_line":"            return {\u0027device\u0027: device}"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_ae1c7d6a","line":223,"range":{"start_line":223,"start_character":8,"end_line":223,"end_character":15},"in_reply_to":"9a30ddce_52203df7","updated":"2017-04-06 11:48:13.000000000","message":"Done","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"15d8a30b6b36a79b9308bfef06b1a231ce21d3c7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    def get_device_details(self, context, device, agent_id, host\u003dNone):"},{"line_number":223,"context_line":"        dev_ovo \u003d self.remote_resource_cache.get_resource_by_id(\u0027Port\u0027, device)"},{"line_number":224,"context_line":"        if not dev_ovo:"},{"line_number":225,"context_line":"            LOG.debug(\"Device %s does not exist.\", device)"},{"line_number":226,"context_line":"            return {\u0027device\u0027: device}"},{"line_number":227,"context_line":"        if not dev_ovo.binding_levels:"},{"line_number":228,"context_line":"            LOG.warning(_LW(\"Device %s is not bound.\"), dev_ovo)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_39a75152","line":225,"updated":"2017-03-27 16:58:10.000000000","message":"it either doesn\u0027t exist or was not stored in the cache yet. It\u0027s possible that the agent requests a device before the cache has processed the port creation event.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    def get_device_details(self, context, device, agent_id, host\u003dNone):"},{"line_number":223,"context_line":"        dev_ovo \u003d self.remote_resource_cache.get_resource_by_id(\u0027Port\u0027, device)"},{"line_number":224,"context_line":"        if not dev_ovo:"},{"line_number":225,"context_line":"            LOG.debug(\"Device %s does not exist.\", device)"},{"line_number":226,"context_line":"            return {\u0027device\u0027: device}"},{"line_number":227,"context_line":"        if not dev_ovo.binding_levels:"},{"line_number":228,"context_line":"            LOG.warning(_LW(\"Device %s is not bound.\"), dev_ovo)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_8e32d9f0","line":225,"in_reply_to":"ffe62b97_39a75152","updated":"2017-04-06 11:48:13.000000000","message":"True, but once it comes into the cache, that will result in a port_update_end event which should restart the process, no?","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c0eeeeec1d6eb2525deb76e04e6b01ead91dac5","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def setup_rpc(self):"},{"line_number":363,"context_line":"        self.plugin_rpc \u003d OVSPluginApi(topics.PLUGIN)"},{"line_number":364,"context_line":"        # allow use to receive port_update/delete callbacks from the cache"},{"line_number":365,"context_line":"        self.plugin_rpc.register_legacy_notification_callbacks(self)"},{"line_number":366,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":367,"context_line":"        self.dvr_plugin_rpc \u003d dvr_rpc.DVRServerRpcApi(topics.PLUGIN)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_92cab519","line":364,"range":{"start_line":364,"start_character":16,"end_line":364,"end_character":19},"updated":"2017-03-10 22:19:05.000000000","message":"user? though I am not sure how users apply here.","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ced35bd8650d3888b6ed54bf4953681203ca209e","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def setup_rpc(self):"},{"line_number":363,"context_line":"        self.plugin_rpc \u003d OVSPluginApi(topics.PLUGIN)"},{"line_number":364,"context_line":"        # allow use to receive port_update/delete callbacks from the cache"},{"line_number":365,"context_line":"        self.plugin_rpc.register_legacy_notification_callbacks(self)"},{"line_number":366,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":367,"context_line":"        self.dvr_plugin_rpc \u003d dvr_rpc.DVRServerRpcApi(topics.PLUGIN)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_8e47794c","line":364,"range":{"start_line":364,"start_character":16,"end_line":364,"end_character":19},"in_reply_to":"9a30ddce_92cab519","updated":"2017-04-06 11:48:13.000000000","message":"us*","commit_id":"2100a5a708497b47f7258bb607da2f2a5fa92048"}]}
