)]}'
{"neutron/tests/unit/db/test_extraroute_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41fd89b9634a5c0e92f1ffd4e0cccc84ebb8f91e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertItemsEqual(router[\u0027routes\u0027], [])"},{"line_number":48,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":49,"context_line":"        routes \u003d ["},{"line_number":50,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":51,"context_line":"            {\u0027destination\u0027: \u002710.1.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.3\u0027},"},{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_459608f1","line":52,"range":{"start_line":50,"start_character":12,"end_line":52,"end_character":64},"updated":"2016-12-14 15:37:11.000000000","message":"This is fine as long as we send the right format[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/extraroute_db.py#L122-L123","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"02b697d7e9b77f895fce1065a4536fafe4a2d671","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertItemsEqual(router[\u0027routes\u0027], [])"},{"line_number":48,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":49,"context_line":"        routes \u003d ["},{"line_number":50,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":51,"context_line":"            {\u0027destination\u0027: \u002710.1.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.3\u0027},"},{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_e047021b","line":52,"range":{"start_line":50,"start_character":12,"end_line":52,"end_character":64},"in_reply_to":"1a6eadb0_459608f1","updated":"2016-12-14 15:43:37.000000000","message":"i\u0027m not sure what you mean.","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"64b5ec50723c5fe53c35e2db6b03b2b0e2e3cd9f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertItemsEqual(router[\u0027routes\u0027], [])"},{"line_number":48,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":49,"context_line":"        routes \u003d ["},{"line_number":50,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":51,"context_line":"            {\u0027destination\u0027: \u002710.1.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.3\u0027},"},{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c07da61d","line":52,"range":{"start_line":50,"start_character":12,"end_line":52,"end_character":64},"in_reply_to":"1a6eadb0_e047021b","updated":"2016-12-14 15:50:24.000000000","message":"What I mean is that given that you\u0027re using a dictionary of strings, the value for destination and/or nexthop have to be valid, in other case it fail when the update process attempts to create the objects.","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41fd89b9634a5c0e92f1ffd4e0cccc84ebb8f91e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["},{"line_number":56,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":57,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":58,"context_line":"            {\u0027destination\u0027: \u002710.3.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.1\u0027},"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _test_update_routes(self, ctx, router_id, router, routes):"},{"line_number":63,"context_line":"        router[\u0027routes\u0027] \u003d routes"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_85a02045","line":60,"range":{"start_line":55,"start_character":8,"end_line":60,"end_character":64},"updated":"2016-12-14 15:37:11.000000000","message":"Any reason to update routes for second time?","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"64b5ec50723c5fe53c35e2db6b03b2b0e2e3cd9f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["},{"line_number":56,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":57,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":58,"context_line":"            {\u0027destination\u0027: \u002710.3.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.1\u0027},"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _test_update_routes(self, ctx, router_id, router, routes):"},{"line_number":63,"context_line":"        router[\u0027routes\u0027] \u003d routes"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c0a4c6a7","line":60,"range":{"start_line":55,"start_character":8,"end_line":60,"end_character":64},"in_reply_to":"1a6eadb0_00923e9e","updated":"2016-12-14 15:50:24.000000000","message":"Gotcha","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"02b697d7e9b77f895fce1065a4536fafe4a2d671","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":53,"context_line":"        ]"},{"line_number":54,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":55,"context_line":"        routes \u003d ["},{"line_number":56,"context_line":"            {\u0027destination\u0027: \u002710.0.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.4\u0027},"},{"line_number":57,"context_line":"            {\u0027destination\u0027: \u002710.2.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.2\u0027},"},{"line_number":58,"context_line":"            {\u0027destination\u0027: \u002710.3.0.0/24\u0027, \u0027nexthop\u0027: \u00271.1.1.1\u0027},"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":"        self._test_update_routes(ctx, router_id, router, routes)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _test_update_routes(self, ctx, router_id, router, routes):"},{"line_number":63,"context_line":"        router[\u0027routes\u0027] \u003d routes"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_00923e9e","line":60,"range":{"start_line":55,"start_character":8,"end_line":60,"end_character":64},"in_reply_to":"1a6eadb0_85a02045","updated":"2016-12-14 15:43:37.000000000","message":"to examine if _update_extra_routes diffs routes correctly.","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41fd89b9634a5c0e92f1ffd4e0cccc84ebb8f91e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            updated_router \u003d self._plugin.update_router(ctx, router_id,"},{"line_number":69,"context_line":"                                                        update_request)"},{"line_number":70,"context_line":"        self.assertItemsEqual(updated_router[\u0027routes\u0027], routes)"},{"line_number":71,"context_line":"        got_router \u003d self._plugin.get_router(ctx, router_id)"},{"line_number":72,"context_line":"        self.assertItemsEqual(got_router[\u0027routes\u0027], routes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_05789029","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":18},"updated":"2016-12-14 15:37:11.000000000","message":"nit: s/got_router/obj_router","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"02b697d7e9b77f895fce1065a4536fafe4a2d671","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            updated_router \u003d self._plugin.update_router(ctx, router_id,"},{"line_number":69,"context_line":"                                                        update_request)"},{"line_number":70,"context_line":"        self.assertItemsEqual(updated_router[\u0027routes\u0027], routes)"},{"line_number":71,"context_line":"        got_router \u003d self._plugin.get_router(ctx, router_id)"},{"line_number":72,"context_line":"        self.assertItemsEqual(got_router[\u0027routes\u0027], routes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_4038b6a0","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":18},"in_reply_to":"1a6eadb0_05789029","updated":"2016-12-14 15:43:37.000000000","message":"why?\nit\u0027s a plain dict with strings.","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"64b5ec50723c5fe53c35e2db6b03b2b0e2e3cd9f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            updated_router \u003d self._plugin.update_router(ctx, router_id,"},{"line_number":69,"context_line":"                                                        update_request)"},{"line_number":70,"context_line":"        self.assertItemsEqual(updated_router[\u0027routes\u0027], routes)"},{"line_number":71,"context_line":"        got_router \u003d self._plugin.get_router(ctx, router_id)"},{"line_number":72,"context_line":"        self.assertItemsEqual(got_router[\u0027routes\u0027], routes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_800d6e92","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":18},"in_reply_to":"1a6eadb0_4038b6a0","updated":"2016-12-14 15:50:24.000000000","message":"Right, _make_router_dict converts the model to dict of strings.","commit_id":"7b6e236c7c02f81f268bfc9c9089d523187d543e"}]}
