)]}'
{"neutron/db/extraroute_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"444bbe84aef453ec132ab0d6f1ad183546e60eb7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self._update_extra_routes(context, router_db, r[\u0027routes\u0027])"},{"line_number":64,"context_line":"        # NOTE(yamamoto): expunge to ensure the following update_router"},{"line_number":65,"context_line":"        # see the effects of the above _update_extra_routes."},{"line_number":66,"context_line":"        context.session.expunge(router_db)"},{"line_number":67,"context_line":"        return super(ExtraRoute_dbonly_mixin, self).update_router("},{"line_number":68,"context_line":"            context, id, router)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_bf6a13ea","line":66,"updated":"2017-04-09 19:35:22.000000000","message":"Ah, maybe a garbage collection thing then. Try just changing L63 to\n\nself._update_extra_routes(context, self._get_router(context, id), r[\u0027routes\u0027])\n\nThat will keep us from having an sqla object in scope.","commit_id":"02c4246d747b77f2ce6df7dea4c62f62c6133d34"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cad3d484541e27d08c0d2a8785907fe47e1a173c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self._update_extra_routes(context, router_db, r[\u0027routes\u0027])"},{"line_number":64,"context_line":"        # NOTE(yamamoto): expunge to ensure the following update_router"},{"line_number":65,"context_line":"        # see the effects of the above _update_extra_routes."},{"line_number":66,"context_line":"        context.session.expunge(router_db)"},{"line_number":67,"context_line":"        return super(ExtraRoute_dbonly_mixin, self).update_router("},{"line_number":68,"context_line":"            context, id, router)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_ffda1f15","line":66,"updated":"2017-04-02 08:38:07.000000000","message":"Don\u0027t you want expire?","commit_id":"02c4246d747b77f2ce6df7dea4c62f62c6133d34"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"27c518cac4df060a074c8ddb3dc6a2a4818b7a6f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self._update_extra_routes(context, router_db, r[\u0027routes\u0027])"},{"line_number":64,"context_line":"        # NOTE(yamamoto): expunge to ensure the following update_router"},{"line_number":65,"context_line":"        # see the effects of the above _update_extra_routes."},{"line_number":66,"context_line":"        context.session.expunge(router_db)"},{"line_number":67,"context_line":"        return super(ExtraRoute_dbonly_mixin, self).update_router("},{"line_number":68,"context_line":"            context, id, router)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_edefd21b","line":66,"in_reply_to":"bff0334d_bf6a13ea","updated":"2017-04-10 05:40:21.000000000","message":"i tried with the master.  any of expunge, expire, \"del router_db\", your suggested elimination of the var, seem working.  i guess my memory was just wrong.\n\nwhich is the preferred way?","commit_id":"02c4246d747b77f2ce6df7dea4c62f62c6133d34"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"950b1a27634dda8f95c637ad5850875a2a4dbdec","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self._update_extra_routes(context, router_db, r[\u0027routes\u0027])"},{"line_number":64,"context_line":"        # NOTE(yamamoto): expunge to ensure the following update_router"},{"line_number":65,"context_line":"        # see the effects of the above _update_extra_routes."},{"line_number":66,"context_line":"        context.session.expunge(router_db)"},{"line_number":67,"context_line":"        return super(ExtraRoute_dbonly_mixin, self).update_router("},{"line_number":68,"context_line":"            context, id, router)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_8d14ffa1","line":66,"in_reply_to":"dfeb2761_ffda1f15","updated":"2017-04-07 04:36:27.000000000","message":"i vaguely remember expunge was necessary when i wrote this patch but i don\u0027t remember why.","commit_id":"02c4246d747b77f2ce6df7dea4c62f62c6133d34"}]}
