)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"664abf7b64ae11d346d655a6c839956e7fee7326","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable q-trunk to match with our scenario."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Note: At this point, this is redundant because our devstack plugin"},{"line_number":12,"context_line":"does the same. [1]   It is planned to be removed once project-config"},{"line_number":13,"context_line":"is updated to use this gate_hook.  gate_hook is preferable because"},{"line_number":14,"context_line":"it won\u0027t interfere other rally scenarios for which it isn\u0027t appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_590cf53a","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":38},"updated":"2016-12-15 15:18:18.000000000","message":"if you mean redundant as ineffective, yes. I think the dependency chain is the other way around, ie. this one depends on I574fc28ab010f9ba77e257ffa436054a999e8d91 so that we can validate it once the gate hook merges.\n\nAs a matter of fact this is even dangerous to merge, because it could break rally once the hook merges.","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5c45f3feb95937adbd34e0767de20ecdb73e31d2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable q-trunk to match with our scenario."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Note: At this point, this is redundant because our devstack plugin"},{"line_number":12,"context_line":"does the same. [1]   It is planned to be removed once project-config"},{"line_number":13,"context_line":"is updated to use this gate_hook.  gate_hook is preferable because"},{"line_number":14,"context_line":"it won\u0027t interfere other rally scenarios for which it isn\u0027t appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_9de25e00","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":38},"in_reply_to":"1a6eadb0_590cf53a","updated":"2016-12-20 06:21:15.000000000","message":"ok, how about doing it as 3 steps:\n\n1. make neutron\u0027s gate_hook accept \"rally\" but do nothing.\n2. make project-config change to consume the gate_hook\n3. make the rest of neutron change","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"581949d2ec8dc64effae56415b0b231efd86175f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable q-trunk to match with our scenario."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Note: At this point, this is redundant because our devstack plugin"},{"line_number":12,"context_line":"does the same. [1]   It is planned to be removed once project-config"},{"line_number":13,"context_line":"is updated to use this gate_hook.  gate_hook is preferable because"},{"line_number":14,"context_line":"it won\u0027t interfere other rally scenarios for which it isn\u0027t appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_450ae1d3","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":38},"in_reply_to":"1a6eadb0_9de25e00","updated":"2016-12-22 16:08:34.000000000","message":"sounds good to me!! Thanks","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fe3c3338832d887fba0cf5469947665bec00e5b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] devstack/lib/rally"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partial-Bug: #1643451"},{"line_number":20,"context_line":"Change-Id: I0a309272ec46b8477fe57eeb676a5cd850e4d60b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_597155a7","line":19,"updated":"2016-12-15 15:19:28.000000000","message":"I believe this should be Close-bug. I can take over this change if you want.","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fe3c3338832d887fba0cf5469947665bec00e5b9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # our rally scenario uses q-trunk."},{"line_number":81,"context_line":"    export ENABLED_SERVICES+\u003d,q-trunk"},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_d92f2586","line":82,"updated":"2016-12-15 15:19:28.000000000","message":"I don\u0027t believe calling devstack-vm-gate is necessary.","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ccf2b8cbdbd9ed45f6fccd01247723f3dbd889ce","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # our rally scenario uses q-trunk."},{"line_number":81,"context_line":"    export ENABLED_SERVICES+\u003d,q-trunk"},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_92ed2df2","line":82,"in_reply_to":"1a6eadb0_875176db","updated":"2016-12-18 18:54:45.000000000","message":"The hook should not interfere with the job execution, it should simply customize neutron\u0027s configuration.","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1bc46321e4e1225bfb890ef3091092408354295b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # our rally scenario uses q-trunk."},{"line_number":81,"context_line":"    export ENABLED_SERVICES+\u003d,q-trunk"},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_d515cf9b","line":82,"in_reply_to":"1a6eadb0_92ed2df2","updated":"2016-12-18 22:36:28.000000000","message":"but it\u0027s how the hook works currently.\n\nor are you suggesting we should use other hook?","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"831cca1721112d923950fc1b6531f311ec91d6ce","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # our rally scenario uses q-trunk."},{"line_number":81,"context_line":"    export ENABLED_SERVICES+\u003d,q-trunk"},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_875176db","line":82,"in_reply_to":"1a6eadb0_d92f2586","updated":"2016-12-18 05:01:16.000000000","message":"why not?","commit_id":"735e6fe76715c32d9799c5eebd9698959245de42"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5673b1c4274b385e692576a27303b9b7ae1e19f8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # NOTE(yamamoto): This is a no-op placeholder to allow"},{"line_number":81,"context_line":"    # further changes."},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da4df55a_1da27f4b","line":82,"updated":"2016-12-27 15:23:41.000000000","message":"a no-op is just \u0027:\u0027. I might not understand how devstack hooks work, but invoking this command is clearly not a no-op, or is it?","commit_id":"8ef0979700afc90634535b6991975ade639324d5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d91022dfe9c47351039aa2427f9e6dfca82cd4bd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # NOTE(yamamoto): This is a no-op placeholder to allow"},{"line_number":81,"context_line":"    # further changes."},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da4df55a_a65de016","line":82,"in_reply_to":"da4df55a_1da27f4b","updated":"2016-12-27 16:45:33.000000000","message":"this is the replacement of the default implementation. [1]\nit\u0027s no-op in sense it\u0027s an equivalent of the default and thus does not change the behaviour.\n\n[1] https://github.com/openstack-infra/devstack-gate/blob/8d680c44de55cd00a01968ecd453b8ac57da7ab4/devstack-vm-gate-wrap.sh#L452-L458","commit_id":"8ef0979700afc90634535b6991975ade639324d5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"30fd3ca9428c0f4911bdd118fbc793e48a2df2f7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"rally\")"},{"line_number":80,"context_line":"    # NOTE(yamamoto): This is a no-op placeholder to allow"},{"line_number":81,"context_line":"    # further changes."},{"line_number":82,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":83,"context_line":"    ;;"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"*)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da4df55a_1ff0a1fd","line":82,"in_reply_to":"da4df55a_a65de016","updated":"2016-12-28 09:52:34.000000000","message":"ack","commit_id":"8ef0979700afc90634535b6991975ade639324d5"}]}
