)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51315f989892d3a7a43469ce23fc21ecd9022032","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-05 18:58:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp: leak of metadta ns proxy process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_42ada030","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":21},"updated":"2017-01-19 06:27:10.000000000","message":"metadata","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-05 18:58:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp: leak of metadta ns proxy process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_70482f88","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":21},"in_reply_to":"5a3905b3_42ada030","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8fb982d48c035e10dcee3e1e3fda9b0bfa95f9d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp: leak of metadta ns proxy process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_583ebcda","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":60},"updated":"2017-01-05 23:59:46.000000000","message":"nit enable_isolated_metadata","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp: leak of metadta ns proxy process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_d059e35b","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":60},"in_reply_to":"ba5201f7_583ebcda","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51315f989892d3a7a43469ce23fc21ecd9022032","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"},{"line_number":13,"context_line":"try to kill metadata proxy unconditionally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_0272b8e5","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":27},"updated":"2017-01-19 06:27:10.000000000","message":"metadata","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With force_metadata\u003dTrue, enable_isolated_isolated_meatadata\u003dFalse"},{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"},{"line_number":13,"context_line":"try to kill metadata proxy unconditionally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_1019ab88","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":27},"in_reply_to":"5a3905b3_0272b8e5","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51315f989892d3a7a43469ce23fc21ecd9022032","unresolved":false,"context_lines":[{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"},{"line_number":13,"context_line":"try to kill metadata proxy unconditionally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"},{"line_number":16,"context_line":"Closes-Bug: #1648095"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_d68cf537","line":13,"updated":"2017-01-19 06:27:10.000000000","message":"Maybe it\u0027s better to just re-write this like the comment in the code too:\n\nKill the metadata proxy process unconditionally\n\nWhen force_metadata\u003dTrue and enable_isolated_metadata\u003dFalse,\nthe namespace metadata proxy process might not be terminated\nwhen the network is deleted because the subnets and ports\nwill have already been deleted, so we could incorrectly\ndetermine it was started.  Calling destroy_monitored_metadata_proxy() is a noop when there is no process running.","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2824f5d9731d03223a1b6e5eeb336fbbbdae77ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"},{"line_number":13,"context_line":"try to kill metadata proxy unconditionally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"},{"line_number":16,"context_line":"Closes-Bug: #1648095"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_f4b8f22c","line":13,"in_reply_to":"5a3905b3_d68cf537","updated":"2017-01-25 08:38:17.000000000","message":"+1, it\u0027s more clear","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"metadata proxy process is leaked when network is deleted."},{"line_number":11,"context_line":"As should_enable_metadata depends on the running status and"},{"line_number":12,"context_line":"destroy_monitored_meatadata_proxy is nop when the process doesn\u0027t exist,"},{"line_number":13,"context_line":"try to kill metadata proxy unconditionally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"},{"line_number":16,"context_line":"Closes-Bug: #1648095"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_b008d72e","line":13,"in_reply_to":"5a3905b3_f4b8f22c","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2824f5d9731d03223a1b6e5eeb336fbbbdae77ea","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I77ff545ce02f2dca4c38e587b37ea809ad6f072c"},{"line_number":16,"context_line":"Closes-Bug: #1648095"},{"line_number":17,"context_line":"Related-Bug: #1524916"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_549f06b4","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":21},"updated":"2017-01-25 08:38:17.000000000","message":"Bug #1524916 is related to the memory footprint of metadata proxy while your patch addresses its cleanup. I think they are not related","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51315f989892d3a7a43469ce23fc21ecd9022032","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            # NOTE(yamahata): try to kill the process unconditionally"},{"line_number":317,"context_line":"            # The condition when metadata proxy is kicked is subtle."},{"line_number":318,"context_line":"            # See should_enable_metadata."},{"line_number":319,"context_line":"            # destroy_monitored_meatadata_proxy works as nop"},{"line_number":320,"context_line":"            # when the process doesn\u0027t run."},{"line_number":321,"context_line":"            self.disable_isolated_metadata_proxy(network)"},{"line_number":322,"context_line":"            if self.call_driver(\u0027disable\u0027, network):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_6258dc57","line":319,"range":{"start_line":319,"start_character":32,"end_line":319,"end_character":41},"updated":"2017-01-19 06:27:10.000000000","message":"metadata","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            # NOTE(yamahata): try to kill the process unconditionally"},{"line_number":317,"context_line":"            # The condition when metadata proxy is kicked is subtle."},{"line_number":318,"context_line":"            # See should_enable_metadata."},{"line_number":319,"context_line":"            # destroy_monitored_meatadata_proxy works as nop"},{"line_number":320,"context_line":"            # when the process doesn\u0027t run."},{"line_number":321,"context_line":"            self.disable_isolated_metadata_proxy(network)"},{"line_number":322,"context_line":"            if self.call_driver(\u0027disable\u0027, network):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_90b11b92","line":319,"range":{"start_line":319,"start_character":32,"end_line":319,"end_character":41},"in_reply_to":"5a3905b3_6258dc57","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51315f989892d3a7a43469ce23fc21ecd9022032","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # The condition when metadata proxy is kicked is subtle."},{"line_number":318,"context_line":"            # See should_enable_metadata."},{"line_number":319,"context_line":"            # destroy_monitored_meatadata_proxy works as nop"},{"line_number":320,"context_line":"            # when the process doesn\u0027t run."},{"line_number":321,"context_line":"            self.disable_isolated_metadata_proxy(network)"},{"line_number":322,"context_line":"            if self.call_driver(\u0027disable\u0027, network):"},{"line_number":323,"context_line":"                self.cache.remove(network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_5648052e","line":320,"updated":"2017-01-19 06:27:10.000000000","message":"I actually think this comment could be a little better.\n\n# NOTE(yamahata): Kill the metadata proxy process\n# unconditionally, as in the case where a network\n# is deleted, all the subnets and ports are deleted\n# before this function is called, so determining if\n# the proxy should be terminated is error prone.\n# destroy_monitored_metadata_proxy() is a noop when\n# there is no process running.","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2824f5d9731d03223a1b6e5eeb336fbbbdae77ea","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # The condition when metadata proxy is kicked is subtle."},{"line_number":318,"context_line":"            # See should_enable_metadata."},{"line_number":319,"context_line":"            # destroy_monitored_meatadata_proxy works as nop"},{"line_number":320,"context_line":"            # when the process doesn\u0027t run."},{"line_number":321,"context_line":"            self.disable_isolated_metadata_proxy(network)"},{"line_number":322,"context_line":"            if self.call_driver(\u0027disable\u0027, network):"},{"line_number":323,"context_line":"                self.cache.remove(network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_94808e48","line":320,"in_reply_to":"5a3905b3_5648052e","updated":"2017-01-25 08:38:17.000000000","message":"ditto","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f1aa72aeee5d4ac61e8239a0efd53fd56a9208e6","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # The condition when metadata proxy is kicked is subtle."},{"line_number":318,"context_line":"            # See should_enable_metadata."},{"line_number":319,"context_line":"            # destroy_monitored_meatadata_proxy works as nop"},{"line_number":320,"context_line":"            # when the process doesn\u0027t run."},{"line_number":321,"context_line":"            self.disable_isolated_metadata_proxy(network)"},{"line_number":322,"context_line":"            if self.call_driver(\u0027disable\u0027, network):"},{"line_number":323,"context_line":"                self.cache.remove(network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_d082c393","line":320,"in_reply_to":"5a3905b3_94808e48","updated":"2017-01-27 19:51:38.000000000","message":"Done","commit_id":"ce85b41f23b03ef1d2e2ded65cf0e010a37ca6c1"}]}