)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6e3e282f53148e3c15d308b431a8cb476ee64359","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sort and Remove duplicate field types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The FIELD_TYPE_VALUE_GENERATOR_MAP dictionary contains several"},{"line_number":10,"context_line":"duplicated kes that override the function that generates random"},{"line_number":11,"context_line":"values. This change cleans up the current values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I230fdefe91c08a32bd783c5e5f7fcae776c9f979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_db1d1574","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":14},"updated":"2016-12-17 01:18:15.000000000","message":"keys","commit_id":"906c522f1f2c0a8ec00b2b705d75c8281ff92ab7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1a69d4eeef4674ae4102bc3005e7ce63bb1f4f74","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sort and Remove duplicate field types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The FIELD_TYPE_VALUE_GENERATOR_MAP dictionary contains several"},{"line_number":10,"context_line":"duplicated kes that override the function that generates random"},{"line_number":11,"context_line":"values. This change cleans up the current values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I230fdefe91c08a32bd783c5e5f7fcae776c9f979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_0341a839","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":14},"in_reply_to":"1a6eadb0_db1d1574","updated":"2016-12-19 18:27:55.000000000","message":"Done","commit_id":"906c522f1f2c0a8ec00b2b705d75c8281ff92ab7"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6e3e282f53148e3c15d308b431a8cb476ee64359","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    obj_fields.DateTimeField: tools.get_random_datetime,"},{"line_number":414,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"},{"line_number":415,"context_line":"    obj_fields.IPAddressField: tools.get_random_ip_address,"},{"line_number":416,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":417,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":418,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":419,"context_line":"    obj_fields.ListOfStringsField: tools.get_random_string_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_9b29dd9d","line":416,"updated":"2016-12-17 01:18:15.000000000","message":"Shouldn\u0027t we also remove the duplication of obj_fields.IPNetworkField since we have it in common_types. Running grep in the Neutron repo, I found only 2 references to obj_fields.IPNetworkField left:\n\n./neutron/objects/securitygroup.py|102 col 40| \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue)\n\n./neutron/objects/subnetpool.py|142 col 28| \u0027cidr\u0027: obj_fields.IPNetworkField()","commit_id":"906c522f1f2c0a8ec00b2b705d75c8281ff92ab7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1a69d4eeef4674ae4102bc3005e7ce63bb1f4f74","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    obj_fields.DateTimeField: tools.get_random_datetime,"},{"line_number":414,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"},{"line_number":415,"context_line":"    obj_fields.IPAddressField: tools.get_random_ip_address,"},{"line_number":416,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":417,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":418,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":419,"context_line":"    obj_fields.ListOfStringsField: tools.get_random_string_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_a351d410","line":416,"in_reply_to":"1a6eadb0_9b29dd9d","updated":"2016-12-19 18:27:55.000000000","message":"A couple of things to consider:\n\n* common_types.IPNetworkField validates if the value is an instance of netaddr.IPNetwork which means that it has a valid format.\n\n* obj_fields.IPNetworkField checks that the string provided is valid using the constructor of netaddr.IPNetwork.\n\nFrom my point of view, we should stop using obj_fields.IPNetworkField given that common_types.IPNetworkField has better coverage.  Thanks Miguel for highlighting this duplication.","commit_id":"906c522f1f2c0a8ec00b2b705d75c8281ff92ab7"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"de63e2c203d345dfd17fd2bede84602f3cc2e40c","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    obj_fields.DateTimeField: tools.get_random_datetime,"},{"line_number":414,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"},{"line_number":415,"context_line":"    obj_fields.IPAddressField: tools.get_random_ip_address,"},{"line_number":416,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":417,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":418,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":419,"context_line":"    obj_fields.ListOfStringsField: tools.get_random_string_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_f76e1d95","line":416,"in_reply_to":"1a6eadb0_a351d410","updated":"2016-12-19 22:55:21.000000000","message":"+1, Agree with Victor.","commit_id":"906c522f1f2c0a8ec00b2b705d75c8281ff92ab7"}]}