)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79c98aab79f0044576718faa4fc5aef60a0c4f43","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure dvr extension for DVR enabled dsvm jobs only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should skip dvr tests for non-dvr setups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch should fix I5022f42392c0a076aa4980082640392cad1688a0 non-dvr"},{"line_number":12,"context_line":"scenario job results by skipping proposed tests there."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da4df55a_2fee9c22","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":43},"updated":"2016-12-22 15:27:04.000000000","message":"This is somewhat confusing. There\u0027s two different aspects here: a) DVR capable deployments; and b) DVR capable deployments with DVR being default router type. What do you men with non-dvr setups, exactly?","commit_id":"a609f4b165d6fd17268c710fbffee7c52403b491"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"522e8c11af646e4e78ac3a221efdcf3ed1fe75a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure dvr extension for DVR enabled dsvm jobs only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should skip dvr tests for non-dvr setups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch should fix I5022f42392c0a076aa4980082640392cad1688a0 non-dvr"},{"line_number":12,"context_line":"scenario job results by skipping proposed tests there."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da4df55a_8fca284e","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":43},"in_reply_to":"da4df55a_2fee9c22","updated":"2016-12-22 15:33:07.000000000","message":"Mainly gate devstack setups that don\u0027t have their services configured for DVR (l2pop off, router_distributed \u003d False, etc.) but without getting into particular details.","commit_id":"a609f4b165d6fd17268c710fbffee7c52403b491"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79c98aab79f0044576718faa4fc5aef60a0c4f43","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should skip dvr tests for non-dvr setups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch should fix I5022f42392c0a076aa4980082640392cad1688a0 non-dvr"},{"line_number":12,"context_line":"scenario job results by skipping proposed tests there."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I0e94c5d7f65bbb1d803df0d2f99389ae19556480"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da4df55a_af1d2c11","line":11,"updated":"2016-12-22 15:27:04.000000000","message":"are you sure that flipping DVR by default won\u0027t fix your problem [1]? Easy peasy japanese?\n\n[1] https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/neutron.yaml#L623","commit_id":"a609f4b165d6fd17268c710fbffee7c52403b491"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"522e8c11af646e4e78ac3a221efdcf3ed1fe75a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should skip dvr tests for non-dvr setups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch should fix I5022f42392c0a076aa4980082640392cad1688a0 non-dvr"},{"line_number":12,"context_line":"scenario job results by skipping proposed tests there."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I0e94c5d7f65bbb1d803df0d2f99389ae19556480"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da4df55a_8f6dc834","line":11,"in_reply_to":"da4df55a_af1d2c11","updated":"2016-12-22 15:33:07.000000000","message":"There are three scenario jobs right now: linuxbridge, ovs non-dvr, and ovs-dvr. We should execute dvr scenarios on the last one only.\n\nIf we think that two others are not worth an effort, let\u0027s scrap them. Then we may assume the scenario gate is always dvr.","commit_id":"a609f4b165d6fd17268c710fbffee7c52403b491"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8c11a41091c13ec4ecc7ba23a82a94a0646def99","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    if [[ \"$VENV\" \u003d~ \"pecan\" ]]; then"},{"line_number":73,"context_line":"        load_conf_hook pecan"},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"},{"line_number":76,"context_line":"        load_rc_hook dvr"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_cbba626e","line":75,"range":{"start_line":75,"start_character":39,"end_line":75,"end_character":42},"updated":"2016-12-19 20:58:00.000000000","message":"Nit: -eq is for numeric comparisons, \u003d\u003d should make more sense here.","commit_id":"d66d2c4b57a47a2407ad1b1e9fd23a0ad7a8e01b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2483c5bd36e4f5eb06db6438ed86c2ee63b2a046","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function configure_api_extensions {"},{"line_number":47,"context_line":"    case $DVR_MODE in"},{"line_number":48,"context_line":"    \"dvr\")"},{"line_number":49,"context_line":"        load_rc_hook api_dvr_extensions"},{"line_number":50,"context_line":"    *)"},{"line_number":51,"context_line":"        load_rc_hook api_extensions"},{"line_number":52,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ba5201f7_2f72f3e3","line":49,"updated":"2017-01-10 20:24:12.000000000","message":"Missing ;; ?","commit_id":"bbc4293b46c5921300c08c83cd74a55005837810"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b26f528bf3bf4f42922ac3cc0ead9e0322018d0a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    ;;"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"\"api\"|\"api-pecan\"|\"full-ovsfw\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":75,"context_line":"    load_rc_hook api_extensions"},{"line_number":76,"context_line":"    load_conf_hook quotas"},{"line_number":77,"context_line":"    load_rc_hook dns"},{"line_number":78,"context_line":"    load_rc_hook qos"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba5201f7_90c1f031","side":"PARENT","line":75,"updated":"2017-01-12 05:54:58.000000000","message":"this could have simply been:\n\nload_rc_hook api_${DVR_MODE}_extensions","commit_id":"a47b137fe104c54f049481d43d9478904566c6c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b26f528bf3bf4f42922ac3cc0ead9e0322018d0a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"VENV\u003d${1:-\"dsvm-functional\"}"},{"line_number":6,"context_line":"DVR_MODE\u003d${2:-\"\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"GATE_DEST\u003d$BASE/new"},{"line_number":9,"context_line":"NEUTRON_PATH\u003d$GATE_DEST/neutron"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba5201f7_d0c7f80f","line":6,"updated":"2017-01-12 05:54:58.000000000","message":"How many values do you expect this variable to have? I fear this should probably be named differently to avoid making this specific about DVR. We could have multiple test suites in the future and this will end up being a misnomer.\n\nI understand this to be a qualifier for the test suite we want to execute, and I see the following values:\n\n\u0027all\u0027 (equivalent to \u0027\u0027 right now): run all tests for all known extensions.\n\u0027dvrskip\u0027: run all tests, except dvr,\n...","commit_id":"c88e40f9949bafbce46c46d570a9f7939d6c256c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3feb798047dbd08f3b559ee559d25d0fb7a3e327","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"VENV\u003d${1:-\"dsvm-functional\"}"},{"line_number":6,"context_line":"DVR_MODE\u003d${2:-\"\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"GATE_DEST\u003d$BASE/new"},{"line_number":9,"context_line":"NEUTRON_PATH\u003d$GATE_DEST/neutron"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a57fde8_3baa75d5","line":6,"in_reply_to":"ba5201f7_d0c7f80f","updated":"2017-01-12 15:18:31.000000000","message":"I was struggling with correct UX here. Thanks for suggestion. Done.","commit_id":"c88e40f9949bafbce46c46d570a9f7939d6c256c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5d24ae99a85c8e50ecf2b19fad7ce41b8e259e6d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"VENV\u003d${1:-\"dsvm-functional\"}"},{"line_number":6,"context_line":"FLAVOR\u003d${2:-\"all\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"GATE_DEST\u003d$BASE/new"},{"line_number":9,"context_line":"NEUTRON_PATH\u003d$GATE_DEST/neutron"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a57fde8_0d04967c","line":6,"updated":"2017-01-12 16:10:44.000000000","message":"let\u0027s hope flavor doesn\u0027t get confused with neutron\u0027s flavor ;)","commit_id":"47ee2532a70e775465fcc70beed61a0920e8c6b2"}],"neutron/tests/contrib/hooks/api_dvrskip_extensions":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5d24ae99a85c8e50ecf2b19fad7ce41b8e259e6d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"NETWORK_API_EXTENSIONS\u003d\""},{"line_number":2,"context_line":"    address-scope, \\"},{"line_number":3,"context_line":"    agent, \\"},{"line_number":4,"context_line":"    allowed-address-pairs, \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9a57fde8_0d2bb6ec","line":1,"updated":"2017-01-12 16:10:44.000000000","message":"I\u0027d add comments to these files to explain what they are for, but can do in a follow up, though.","commit_id":"47ee2532a70e775465fcc70beed61a0920e8c6b2"}],"neutron/tests/contrib/hooks/api_extensions":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79c98aab79f0044576718faa4fc5aef60a0c4f43","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    default-subnetpools, \\"},{"line_number":9,"context_line":"    dhcp_agent_scheduler, \\"},{"line_number":10,"context_line":"    dns-integration, \\"},{"line_number":11,"context_line":"    dvr, \\"},{"line_number":12,"context_line":"    ext-gw-mode, \\"},{"line_number":13,"context_line":"    external-net, \\"},{"line_number":14,"context_line":"    extra_dhcp_opt, \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da4df55a_8fc4e892","side":"PARENT","line":11,"updated":"2016-12-22 15:27:04.000000000","message":"I\u0027d rather you not do that.","commit_id":"14079d0f210a93e57de71542f59e3b922c1d36a6"}]}