)]}'
{"neutron/api/rpc/handlers/resources_rpc.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3b06a7469e469789646ec549afee8644944a792f","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # we\u0027ve already validated the resource type, so we are pretty sure the"},{"line_number":56,"context_line":"    # class is there \u003d\u003e no need to validate it specifically"},{"line_number":57,"context_line":"    return resources.get_resource_cls(resource_type)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def resource_type_versioned_topic(resource_type, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_8541340e","line":57,"updated":"2017-01-26 04:57:53.000000000","message":"Well we need to validate on both server side and agent side. This is called by both the agent (to check for programmer errors) and the server (to ensure the server has the resource the agent is looking for in case of version differences).","commit_id":"aad43e4bebdc6807e71b6ad740b2a54dde312c5d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a6394372ac394f20741daa050c12ad7dde579b0d","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # we\u0027ve already validated the resource type, so we are pretty sure the"},{"line_number":56,"context_line":"    # class is there \u003d\u003e no need to validate it specifically"},{"line_number":57,"context_line":"    return resources.get_resource_cls(resource_type)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def resource_type_versioned_topic(resource_type, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_0c874c10","line":57,"range":{"start_line":57,"start_character":11,"end_line":57,"end_character":52},"updated":"2017-01-25 16:43:32.000000000","message":"shouldn\u0027t be better to do the validation inside of the get_resources method instead of having to add the _validate_resource_type method before calling this?","commit_id":"aad43e4bebdc6807e71b6ad740b2a54dde312c5d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3b06a7469e469789646ec549afee8644944a792f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def bulk_pull(self, context, resource_type, version, filter_kwargs\u003dNone):"},{"line_number":137,"context_line":"        filter_kwargs \u003d filter_kwargs or {}"},{"line_number":138,"context_line":"        resource_type_cls \u003d _resource_to_class(resource_type)"},{"line_number":139,"context_line":"        # TODO(kevinbenton): add in producer registry so producers can add"},{"line_number":140,"context_line":"        # hooks to mangle these things like they can with \u0027pull\u0027."},{"line_number":141,"context_line":"        return [obj.obj_to_primitive(target_version\u003dversion)"},{"line_number":142,"context_line":"                for obj in resource_type_cls.get_objects(context, _pager\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a5463021","line":139,"updated":"2017-01-26 04:57:53.000000000","message":"+1","commit_id":"aad43e4bebdc6807e71b6ad740b2a54dde312c5d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3fd4896408173fedfd6c0c3770bbe95339593d5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def bulk_pull(self, context, resource_type, version, filter_kwargs\u003dNone):"},{"line_number":137,"context_line":"        filter_kwargs \u003d filter_kwargs or {}"},{"line_number":138,"context_line":"        resource_type_cls \u003d _resource_to_class(resource_type)"},{"line_number":139,"context_line":"        # TODO(kevinbenton): add in producer registry so producers can add"},{"line_number":140,"context_line":"        # hooks to mangle these things like they can with \u0027pull\u0027."},{"line_number":141,"context_line":"        return [obj.obj_to_primitive(target_version\u003dversion)"},{"line_number":142,"context_line":"                for obj in resource_type_cls.get_objects(context, _pager\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_7d2a1e2e","line":139,"updated":"2017-01-25 11:37:25.000000000","message":"or we can put an end to the producer registry as it probably isn\u0027t necessary anymore as we talked on IRC.","commit_id":"aad43e4bebdc6807e71b6ad740b2a54dde312c5d"}]}