)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8059da2887441789895e611f047d1bf99ba42694","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In this special error case (race condition case) a DhcpPortInUse"},{"line_number":12,"context_line":"RemoteError exception is triggered (Bug: #1425402)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This exception is actually not catched well, instead of trying with the"},{"line_number":15,"context_line":"next \"reserved DHCP port\" a new exception was raised."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I40cb8884b36c4a7c14f470d3a126f4a9a0a98d47"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_66bf8a60","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":38},"updated":"2016-12-20 21:56:41.000000000","message":"Nit: caught","commit_id":"72d86114dc7074d6f9f34fc6071e0721d6dbf765"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"4292bd60bd19a77b856160a8640a4426dc45bdb8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In this special error case (race condition case) a DhcpPortInUse"},{"line_number":12,"context_line":"RemoteError exception is triggered (Bug: #1425402)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This exception is actually not catched well, instead of trying with the"},{"line_number":15,"context_line":"next \"reserved DHCP port\" a new exception was raised."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I40cb8884b36c4a7c14f470d3a126f4a9a0a98d47"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_0727fa12","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":38},"in_reply_to":"1a6eadb0_66bf8a60","updated":"2017-01-02 17:09:54.000000000","message":"Done","commit_id":"72d86114dc7074d6f9f34fc6071e0721d6dbf765"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8d0c00912508f5627f1083a17097d6076f9077aa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In this special error case (race condition case) a DhcpPortInUse"},{"line_number":12,"context_line":"RemoteError exception is triggered (Bug: #1425402)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This exception is actually not catched well, instead of trying with the"},{"line_number":15,"context_line":"next \"reserved DHCP port\" an exception was raised."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I40cb8884b36c4a7c14f470d3a126f4a9a0a98d47"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_d5954687","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":38},"updated":"2017-01-04 21:04:48.000000000","message":"BTW, why not fix this grammatical nit: s/catched/caught","commit_id":"93d5fde46a744c706266174b0ce95e430683007d"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"7d183f9ff2339d30d4f3e78dd52d9f2f839e4cf1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In this special error case (race condition case) a DhcpPortInUse"},{"line_number":12,"context_line":"RemoteError exception is triggered (Bug: #1425402)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This exception is actually not catched well, instead of trying with the"},{"line_number":15,"context_line":"next \"reserved DHCP port\" an exception was raised."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I40cb8884b36c4a7c14f470d3a126f4a9a0a98d47"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_074a4555","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":38},"in_reply_to":"ba5201f7_d5954687","updated":"2017-01-04 21:33:57.000000000","message":"Done","commit_id":"93d5fde46a744c706266174b0ce95e430683007d"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0cf03423f75e1a71c0d10a16d81e55b4c53353b9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.tests import base"},{"line_number":33,"context_line":"from neutron.tests import tools"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"import testtools"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class FakeIPAllocation(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_be0e3032","line":35,"updated":"2017-01-03 06:52:05.000000000","message":"this should be in the third party section above","commit_id":"d46162ab863c90eb0215ae1de779716abb24f09f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6a1293947b170eafd9ec2f11d38b4e353bd3911f","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # Setup with a reserved DHCP port."},{"line_number":2433,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2434,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2435,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"        mock_plugin \u003d mock.Mock()"},{"line_number":2438,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, mock_plugin)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_1a13a80e","line":2435,"range":{"start_line":2435,"start_character":45,"end_line":2435,"end_character":47},"updated":"2017-01-03 23:48:47.000000000","message":"You specifically defined FakeDualNetworkReserved3 for the two tests cases you are adding with only two reserved ports. Does it make sense to reference them like this? Why not just fake_network.ports[1]?","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"f7aa4967ba004ec256db178a728d6d8703f65e5b","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # Setup with a reserved DHCP port."},{"line_number":2433,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2434,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2435,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"        mock_plugin \u003d mock.Mock()"},{"line_number":2438,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, mock_plugin)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_2e4664bf","line":2435,"range":{"start_line":2435,"start_character":45,"end_line":2435,"end_character":47},"in_reply_to":"ba5201f7_1a13a80e","updated":"2017-01-04 08:49:29.000000000","message":"@Miguel: agree, no reason to define a new FakeDualNetworkReserved3, I\u0027ll reuse FakeDualNetworkReserved2, regards","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6a1293947b170eafd9ec2f11d38b4e353bd3911f","unresolved":false,"context_lines":[{"line_number":2452,"context_line":"        # Setup with a reserved DHCP port."},{"line_number":2453,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2454,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2455,"context_line":"        reserved_port_1 \u003d fake_network.ports[-2]"},{"line_number":2456,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        mock_plugin \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_7a1bd41b","line":2455,"range":{"start_line":2455,"start_character":45,"end_line":2455,"end_character":47},"updated":"2017-01-03 23:48:47.000000000","message":"Similar question as in L2435","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"f7aa4967ba004ec256db178a728d6d8703f65e5b","unresolved":false,"context_lines":[{"line_number":2452,"context_line":"        # Setup with a reserved DHCP port."},{"line_number":2453,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2454,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2455,"context_line":"        reserved_port_1 \u003d fake_network.ports[-2]"},{"line_number":2456,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        mock_plugin \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_6e16aca8","line":2455,"range":{"start_line":2455,"start_character":45,"end_line":2455,"end_character":47},"in_reply_to":"ba5201f7_7a1bd41b","updated":"2017-01-04 08:49:29.000000000","message":"see comments above","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6a1293947b170eafd9ec2f11d38b4e353bd3911f","unresolved":false,"context_lines":[{"line_number":2453,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2454,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2455,"context_line":"        reserved_port_1 \u003d fake_network.ports[-2]"},{"line_number":2456,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        mock_plugin \u003d mock.Mock()"},{"line_number":2459,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, mock_plugin)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_1ab808e5","line":2456,"range":{"start_line":2456,"start_character":45,"end_line":2456,"end_character":47},"updated":"2017-01-03 23:48:47.000000000","message":"Similar question as in L2435","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"f7aa4967ba004ec256db178a728d6d8703f65e5b","unresolved":false,"context_lines":[{"line_number":2453,"context_line":"        fake_network \u003d FakeDualNetworkReserved3()"},{"line_number":2454,"context_line":"        fake_network.tenant_id \u003d \u0027Tenant A\u0027"},{"line_number":2455,"context_line":"        reserved_port_1 \u003d fake_network.ports[-2]"},{"line_number":2456,"context_line":"        reserved_port_2 \u003d fake_network.ports[-1]"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        mock_plugin \u003d mock.Mock()"},{"line_number":2459,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, mock_plugin)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_8e0d9092","line":2456,"range":{"start_line":2456,"start_character":45,"end_line":2456,"end_character":47},"in_reply_to":"ba5201f7_1ab808e5","updated":"2017-01-04 08:49:29.000000000","message":"see comments above","commit_id":"1c7c1360d3a38dea52e860df7af93a297d3a8bce"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4ea8360f7e6d0db39e319d1c54d9a7f0387f254d","unresolved":false,"context_lines":[{"line_number":2459,"context_line":"                          mock.call(reserved_port_2.id, mock.ANY)]"},{"line_number":2460,"context_line":"        self.assertEqual(expected_calls,"},{"line_number":2461,"context_line":"                         mock_plugin.update_dhcp_port.call_args_list)"},{"line_number":2462,"context_line":"        self.assertEqual(2,"},{"line_number":2463,"context_line":"                         mock_plugin.update_dhcp_port.call_count)"},{"line_number":2464,"context_line":""},{"line_number":2465,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_fa2dd9a8","line":2462,"updated":"2017-01-04 20:58:53.000000000","message":"This assertion is redundant. L2460 is only going to succeed if mock_plugin.update_dhcp_port is called twice (https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.call_args_list). I think it would be better to remove it","commit_id":"93d5fde46a744c706266174b0ce95e430683007d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"305b238bd1228f96b04f0e2b01c360838691a06f","unresolved":false,"context_lines":[{"line_number":2459,"context_line":"                          mock.call(reserved_port_2.id, mock.ANY)]"},{"line_number":2460,"context_line":"        self.assertEqual(expected_calls,"},{"line_number":2461,"context_line":"                         mock_plugin.update_dhcp_port.call_args_list)"},{"line_number":2462,"context_line":"        self.assertEqual(2,"},{"line_number":2463,"context_line":"                         mock_plugin.update_dhcp_port.call_count)"},{"line_number":2464,"context_line":""},{"line_number":2465,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_a7aed995","line":2462,"updated":"2017-01-04 21:46:04.000000000","message":"Why not remove this redundant assertion?","commit_id":"cc3bf8c11f3b95177e2320ac7d3583b414a940b4"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"792854182b7092a794700d6ec821e7dbbf0e3f01","unresolved":false,"context_lines":[{"line_number":2459,"context_line":"                          mock.call(reserved_port_2.id, mock.ANY)]"},{"line_number":2460,"context_line":"        self.assertEqual(expected_calls,"},{"line_number":2461,"context_line":"                         mock_plugin.update_dhcp_port.call_args_list)"},{"line_number":2462,"context_line":"        self.assertEqual(2,"},{"line_number":2463,"context_line":"                         mock_plugin.update_dhcp_port.call_count)"},{"line_number":2464,"context_line":""},{"line_number":2465,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_47dfed0c","line":2462,"in_reply_to":"ba5201f7_a7aed995","updated":"2017-01-04 21:51:07.000000000","message":"good catch","commit_id":"cc3bf8c11f3b95177e2320ac7d3583b414a940b4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"70039f762a0cc070e1c9ad6f61b397b17800bb26","unresolved":false,"context_lines":[{"line_number":2427,"context_line":""},{"line_number":2428,"context_line":"        mock_plugin \u003d mock.Mock()"},{"line_number":2429,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, mock_plugin)"},{"line_number":2430,"context_line":"        messaging_error \u003d \\"},{"line_number":2431,"context_line":"            oslo_messaging.RemoteError(exc_type\u003d\u0027FakeRemoteError\u0027)"},{"line_number":2432,"context_line":"        mock_plugin.update_dhcp_port.side_effect \u003d [messaging_error,"},{"line_number":2433,"context_line":"                                                    reserved_port_2]"},{"line_number":2434,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_d4535ee0","line":2431,"range":{"start_line":2430,"start_character":8,"end_line":2431,"end_character":66},"updated":"2017-01-05 19:27:32.000000000","message":"Shoot, I should have noticed this before :-( We avoid continuing lines with \u0027\\\u0027: http://docs.openstack.org/developer/hacking/#general. The easiest thing to do here is to break the line like this:\n\n    messaging_error \u003d oslo_messaging.RemoteError(\n        exc_type\u003d\u0027FakeRemoteError\u0027)","commit_id":"37461ef5a6b414060ff55a6d54d241e20042e928"}]}
