)]}'
{"neutron/services/segments/placement_client.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self):"},{"line_number":62,"context_line":"        auth_plugin \u003d ks_loading.load_auth_from_conf_options("},{"line_number":63,"context_line":"            cfg.CONF, \u0027placement\u0027)"},{"line_number":64,"context_line":"        self._client \u003d session.Session(auth\u003dauth_plugin)"},{"line_number":65,"context_line":"        self._disabled \u003d False"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_b982b892","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":12},"updated":"2017-01-03 17:14:45.000000000","message":"micro-nit: continuation indent should either be two levels (to distinguish from blocks) or visually aligned with the prior line.","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"464f4015874cf25d21f83bbdae8340102fb1ce17","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def delete(self, url, **kwargs):"},{"line_number":80,"context_line":"        return self._client.delete(url, endpoint_filter\u003dself.ks_filter,"},{"line_number":81,"context_line":"                                   **kwargs)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @safe_connect"},{"line_number":84,"context_line":"    def create_resource_provider(self, resource_provider):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_886a99b1","line":81,"range":{"start_line":81,"start_character":37,"end_line":81,"end_character":43},"updated":"2017-01-05 21:51:34.000000000","message":"Nit: I would assume that the above four methods are meant not to be exposed outside, consider prefixing the method name with \u0027_\u0027","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def delete(self, url, **kwargs):"},{"line_number":80,"context_line":"        return self._client.delete(url, endpoint_filter\u003dself.ks_filter,"},{"line_number":81,"context_line":"                                   **kwargs)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @safe_connect"},{"line_number":84,"context_line":"    def create_resource_provider(self, resource_provider):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_45f5c1ea","line":81,"range":{"start_line":81,"start_character":37,"end_line":81,"end_character":43},"in_reply_to":"ba5201f7_886a99b1","updated":"2017-01-10 01:27:40.000000000","message":"Yeah, nice catch!","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\"Create a resource provider."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param resource_provider: The resource provider"},{"line_number":88,"context_line":"        :type resource_provider: dict"},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        url \u003d \u0027/resource_providers\u0027"},{"line_number":91,"context_line":"        self.post(url, resource_provider)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_995a544f","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":37},"updated":"2017-01-03 17:14:45.000000000","message":"It might be clearer to describe the required and/or optional keys for this dict.","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\"Create a resource provider."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param resource_provider: The resource provider"},{"line_number":88,"context_line":"        :type resource_provider: dict"},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        url \u003d \u0027/resource_providers\u0027"},{"line_number":91,"context_line":"        self.post(url, resource_provider)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_5b2f2bf6","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":37},"in_reply_to":"ba5201f7_995a544f","updated":"2017-01-10 01:27:40.000000000","message":"Done","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @safe_connect"},{"line_number":94,"context_line":"    def delete_resource_provider(self, resource_provider_uuid):"},{"line_number":95,"context_line":"        \"\"\"Delete an resource provider."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":98,"context_line":"        :type resource_provider_uuid: str"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_193584f6","line":95,"range":{"start_line":95,"start_character":18,"end_line":95,"end_character":20},"updated":"2017-01-03 17:14:45.000000000","message":"nit: s/an/a","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @safe_connect"},{"line_number":94,"context_line":"    def delete_resource_provider(self, resource_provider_uuid):"},{"line_number":95,"context_line":"        \"\"\"Delete an resource provider."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":98,"context_line":"        :type resource_provider_uuid: str"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_a5bd8d03","line":95,"range":{"start_line":95,"start_character":18,"end_line":95,"end_character":20},"in_reply_to":"ba5201f7_193584f6","updated":"2017-01-10 01:27:40.000000000","message":"Done","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"464f4015874cf25d21f83bbdae8340102fb1ce17","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":98,"context_line":"        :type resource_provider_uuid: str"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        url \u003d \u0027/resource_providers/%s\u0027 % resource_provider_uuid"},{"line_number":101,"context_line":"        self.delete(url)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @safe_connect"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_dd6701b5","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":63},"updated":"2017-01-05 21:51:34.000000000","message":"it looks possible, and would be nice to come up with a method such as _make_url(resource_provider_uuid\u003dNone, inventories\u003dNone, aggregates\u003dFalse). In the above case, the line can be replaced with:\n   url \u003d _make_url(resource_provider_uuid)","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":98,"context_line":"        :type resource_provider_uuid: str"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        url \u003d \u0027/resource_providers/%s\u0027 % resource_provider_uuid"},{"line_number":101,"context_line":"        self.delete(url)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @safe_connect"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_fb48dfce","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":63},"in_reply_to":"ba5201f7_dd6701b5","updated":"2017-01-10 01:27:40.000000000","message":"The options are a little more intricate than that. For the sake of understandability, I\u0027ll keep it this way","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":108,"context_line":"        :type resource_provider_uuid: str"},{"line_number":109,"context_line":"        :param inventory: The inventory"},{"line_number":110,"context_line":"        :type inventory: dict"},{"line_number":111,"context_line":"        \"\"\""},{"line_number":112,"context_line":"        url \u003d \u0027/resource_providers/%s/inventories\u0027 % resource_provider_uuid"},{"line_number":113,"context_line":"        self.post(url, inventory)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_1403890e","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":29},"updated":"2017-01-03 17:14:45.000000000","message":"Same as above. The keys for the dict would be helpful to know.","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":108,"context_line":"        :type resource_provider_uuid: str"},{"line_number":109,"context_line":"        :param inventory: The inventory"},{"line_number":110,"context_line":"        :type inventory: dict"},{"line_number":111,"context_line":"        \"\"\""},{"line_number":112,"context_line":"        url \u003d \u0027/resource_providers/%s/inventories\u0027 % resource_provider_uuid"},{"line_number":113,"context_line":"        self.post(url, inventory)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_bb53b76b","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":29},"in_reply_to":"ba5201f7_1403890e","updated":"2017-01-10 01:27:40.000000000","message":"Done","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            resource_provider_uuid, resource_class)"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            return self.get(url).json()"},{"line_number":131,"context_line":"        except ks_exc.NotFound:"},{"line_number":132,"context_line":"            raise n_exc.PlacementInventoryNotFound("},{"line_number":133,"context_line":"                resource_provider\u003dresource_provider_uuid,"},{"line_number":134,"context_line":"                resource_class\u003dresource_class)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_943699e5","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":31},"updated":"2017-01-03 17:14:45.000000000","message":"What wasn\u0027t found? The resource provider? Or some inventory for that provider?","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            resource_provider_uuid, resource_class)"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            return self.get(url).json()"},{"line_number":131,"context_line":"        except ks_exc.NotFound:"},{"line_number":132,"context_line":"            raise n_exc.PlacementInventoryNotFound("},{"line_number":133,"context_line":"                resource_provider\u003dresource_provider_uuid,"},{"line_number":134,"context_line":"                resource_class\u003dresource_class)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_e6504661","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":31},"in_reply_to":"ba5201f7_943699e5","updated":"2017-01-10 01:27:40.000000000","message":"Yes, you are right. I should be more specific. Fixed in next revision","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":164,"context_line":"        :type resource_provider_uuid: str"},{"line_number":165,"context_line":"        :param aggregates: aggregates to be associated to the resource provider"},{"line_number":166,"context_line":"        :type aggregates: list of str"},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":169,"context_line":"        self.put(url, aggregates,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_346fadc6","line":166,"range":{"start_line":165,"start_character":9,"end_line":166,"end_character":37},"updated":"2017-01-03 17:14:45.000000000","message":"Are these strings UUIDs? Or names? Or something else?","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":164,"context_line":"        :type resource_provider_uuid: str"},{"line_number":165,"context_line":"        :param aggregates: aggregates to be associated to the resource provider"},{"line_number":166,"context_line":"        :type aggregates: list of str"},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":169,"context_line":"        self.put(url, aggregates,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_e53955a5","line":166,"range":{"start_line":165,"start_character":9,"end_line":166,"end_character":37},"in_reply_to":"ba5201f7_346fadc6","updated":"2017-01-10 01:27:40.000000000","message":"UUIDs. fixed","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"07a34cf5649a8c790268a469dacd798d37f704a3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":169,"context_line":"        self.put(url, aggregates,"},{"line_number":170,"context_line":"                 headers\u003d{\u0027openstack-api-version\u0027: \u0027placement 1.1\u0027})"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @safe_connect"},{"line_number":173,"context_line":"    def list_aggregates(self, resource_provider_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_b4babd21","line":170,"range":{"start_line":170,"start_character":51,"end_line":170,"end_character":66},"updated":"2017-01-03 17:14:45.000000000","message":"It seems that it would be better to make this a constant at the top of the file, so if you ever want to bump the microversion number, you can do it in one place.","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":169,"context_line":"        self.put(url, aggregates,"},{"line_number":170,"context_line":"                 headers\u003d{\u0027openstack-api-version\u0027: \u0027placement 1.1\u0027})"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @safe_connect"},{"line_number":173,"context_line":"    def list_aggregates(self, resource_provider_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_85708973","line":170,"range":{"start_line":170,"start_character":51,"end_line":170,"end_character":66},"in_reply_to":"ba5201f7_b4babd21","updated":"2017-01-10 01:27:40.000000000","message":"Done","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3b15a4c2646bf3f4fbf61319a1697b52f5c746c8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"PLACEMENT_API_WITH_AGGREGATES \u003d \u0027placement 1.1\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def safe_connect(f):"},{"line_number":33,"context_line":"    @functools.wraps(f)"},{"line_number":34,"context_line":"    def wrapper(self, *a, **k):"},{"line_number":35,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a57fde8_fe5b8d2c","line":32,"updated":"2017-01-12 09:51:19.000000000","message":"Question, what\u0027s the logic behind this?, wouldn\u0027t we want a less-softer failure in this case (miss configuration of the placement API?).\n\nWouldn\u0027t it make sense to exit/fail whatever is trying to talk to the placement API endpoint if that happens?","commit_id":"f65d927c48edf49cef37053713de475d6fce9f98"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cd7da5424d8510d0548d24010c35ad050d3c0fc7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"PLACEMENT_API_WITH_AGGREGATES \u003d \u0027placement 1.1\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def safe_connect(f):"},{"line_number":33,"context_line":"    @functools.wraps(f)"},{"line_number":34,"context_line":"    def wrapper(self, *a, **k):"},{"line_number":35,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_10be41d4","line":32,"in_reply_to":"9a57fde8_fe5b8d2c","updated":"2017-01-15 00:44:55.000000000","message":"Yes you are right. It will be better to just let the failures bubble up to the caller. Removing this","commit_id":"f65d927c48edf49cef37053713de475d6fce9f98"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c0fa12bf419ed8cd448bd8b3a7e128232956130d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            return self._get(url).json()"},{"line_number":103,"context_line":"        except ks_exc.NotFound as e:"},{"line_number":104,"context_line":"            if \"No resource provider with uuid\" in e.details:"},{"line_number":105,"context_line":"                raise n_exc.PlacementResourceProviderNotFound("},{"line_number":106,"context_line":"                    resource_provider\u003dresource_provider_uuid)"},{"line_number":107,"context_line":"            elif \"No inventory of class\" in e.details:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_ebdea9db","line":104,"updated":"2017-01-17 22:42:31.000000000","message":"I ran an experiment, where I log e.details just above this line. When the resource provider is not found, I get the following: http://paste.openstack.org/show/595288/. The only place of the Nova code where a message of the form \"No resource provider with uuid 90de6f38-bc72-4ab3-8a8c-cafc6fe9488f found\" is generated is here: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L458. The other places where an exception including \"No resource provider with uuid\" contain other things in the message string. And as you point out correctly, this message is created without _()","commit_id":"935cf853c93d7438a6f563f7f91ed1a38e16ab5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cbc771a9251f1c256db7a3b9fbeaf069a0aa8ac5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            if \"No resource provider with uuid\" in e.details:"},{"line_number":105,"context_line":"                raise n_exc.PlacementResourceProviderNotFound("},{"line_number":106,"context_line":"                    resource_provider\u003dresource_provider_uuid)"},{"line_number":107,"context_line":"            elif \"No inventory of class\" in e.details:"},{"line_number":108,"context_line":"                raise n_exc.PlacementInventoryNotFound("},{"line_number":109,"context_line":"                    resource_provider\u003dresource_provider_uuid,"},{"line_number":110,"context_line":"                    resource_class\u003dresource_class)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_30cf4b2a","line":107,"updated":"2017-01-17 18:23:32.000000000","message":"nova/exception.py InventoryWithResourceClassNotFound class uses _(), so this might need the same.  I\u0027m assuming that\u0027s what is being returned.  Doesn\u0027t look like the above does that from what I can tell.","commit_id":"935cf853c93d7438a6f563f7f91ed1a38e16ab5c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c0fa12bf419ed8cd448bd8b3a7e128232956130d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            if \"No resource provider with uuid\" in e.details:"},{"line_number":105,"context_line":"                raise n_exc.PlacementResourceProviderNotFound("},{"line_number":106,"context_line":"                    resource_provider\u003dresource_provider_uuid)"},{"line_number":107,"context_line":"            elif \"No inventory of class\" in e.details:"},{"line_number":108,"context_line":"                raise n_exc.PlacementInventoryNotFound("},{"line_number":109,"context_line":"                    resource_provider\u003dresource_provider_uuid,"},{"line_number":110,"context_line":"                    resource_class\u003dresource_class)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_bd1f8859","line":107,"in_reply_to":"7a3c09a3_30cf4b2a","updated":"2017-01-17 22:42:31.000000000","message":"Running a similar experiment for this case, I get the following message: \"No inventory of class IPV4_ADDRESS for 90de6f38-bc72-4ab3-8a8c-cafc6fe9488f\". The only place where this message can be generated is https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/inventory.py#L320. The other places where something similar is generated, include strings with more stuff than \"No inventory of class\". So you are right again, we need to use _() in this case","commit_id":"935cf853c93d7438a6f563f7f91ed1a38e16ab5c"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"045558edbf2419f5b2ac2d5a2080bc44bcc4fe0e","unresolved":false,"context_lines":[{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"        # Since port is bound and there is a mapping to segment, it succeeds."},{"line_number":1335,"context_line":"        self.assertEqual(webob.exc.HTTPConflict.code, response.status_int)"},{"line_number":1336,"context_line":"        self.assertEqual(n_lib_exc.IpAddressGenerationFailure.__name__,"},{"line_number":1337,"context_line":"                         res[\u0027NeutronError\u0027][\u0027type\u0027])"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def test_port_update_fails_if_host_on_wrong_segment(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_c0ea91da","line":1336,"updated":"2017-01-06 21:36:26.000000000","message":"Doesn\u0027t seem to be directly-related to this change","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b6779857f07c2aa69581e6dc0b40d5734910556c","unresolved":false,"context_lines":[{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"        # Since port is bound and there is a mapping to segment, it succeeds."},{"line_number":1335,"context_line":"        self.assertEqual(webob.exc.HTTPConflict.code, response.status_int)"},{"line_number":1336,"context_line":"        self.assertEqual(n_lib_exc.IpAddressGenerationFailure.__name__,"},{"line_number":1337,"context_line":"                         res[\u0027NeutronError\u0027][\u0027type\u0027])"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def test_port_update_fails_if_host_on_wrong_segment(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_3ba0a7a5","line":1336,"in_reply_to":"ba5201f7_c0ea91da","updated":"2017-01-10 01:27:40.000000000","message":"Done","commit_id":"c739bc232bea1aa9810a1bde1adabf0ebf3a8cd2"}]}
