)]}'
{"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib import exceptions"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_be8e082c","line":16,"updated":"2017-05-18 05:38:22.000000000","message":"netaddr is third-party module","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron_lib import exceptions"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron._i18n import _, _LE, _LW"},{"line_number":23,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_9eb104e5","line":22,"range":{"start_line":22,"start_character":27,"end_line":22,"end_character":37},"updated":"2017-05-18 05:38:22.000000000","message":"no longer needed","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e054ee0afd888e53bdcee0b59dfcd18a30a5f81c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            \u0027drop\u0027]"},{"line_number":251,"context_line":"        return self._execute_tc_cmd(cmd)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _replace_htb_qdisc(self):"},{"line_number":254,"context_line":"        cmd \u003d ["},{"line_number":255,"context_line":"            \u0027qdisc\u0027, \u0027replace\u0027, \u0027dev\u0027, self.name,"},{"line_number":256,"context_line":"            \u0027root\u0027, \u0027handle\u0027, \u00271:\u0027, \u0027htb\u0027, \u0027default\u0027, str(DEFAULT_FLOWID)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_a9e6c8e7","line":253,"updated":"2017-04-14 21:22:41.000000000","message":"to make this feature easier to review, can you move the tc_lib changes into a parent patch?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":323,"context_line":"class PortInfo(object):"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def __init__(self, port_id, net_type, seg_id, mac_addresses, min_rate,"},{"line_number":326,"context_line":"                 flowid):"},{"line_number":327,"context_line":"        self.port_id \u003d port_id"},{"line_number":328,"context_line":"        self.net_type \u003d net_type"},{"line_number":329,"context_line":"        self.seg_id \u003d seg_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_b9d74224","line":326,"updated":"2017-05-18 05:38:22.000000000","message":"It is better to have docstring for each field.\nFor example, what are valid values for net_type.","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e054ee0afd888e53bdcee0b59dfcd18a30a5f81c","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def __init__(self, device):"},{"line_number":338,"context_line":"        # kernel_hz is not used."},{"line_number":339,"context_line":"        self.tc_cmd \u003d TcCommand(device, 250)"},{"line_number":340,"context_line":"        self.max_rate \u003d self._get_link_speed(device)"},{"line_number":341,"context_line":"        self.ports \u003d {}"},{"line_number":342,"context_line":"        self._init_flowid()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_89eb0caf","line":339,"updated":"2017-04-14 21:22:41.000000000","message":"Can you adjust TcCommand to accept None for kernel_hz and then only error for a command that requires it?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e054ee0afd888e53bdcee0b59dfcd18a30a5f81c","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        for port_info in self.ports.values():"},{"line_number":370,"context_line":"            port_info.flowid \u003d self._get_next_flowid()"},{"line_number":371,"context_line":"        if self.need_renumbering:"},{"line_number":372,"context_line":"            LOG.error(_LE(\"Too many ports for device %s.\"), self.tc_cmd.name)"},{"line_number":373,"context_line":"            # should be panic."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def _clear_tc_qdisc(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_69d0c0f8","line":372,"updated":"2017-04-14 21:22:41.000000000","message":"can\u0027t you throw exception here to make the device go into an error state, or does the agent just continuously loop?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e054ee0afd888e53bdcee0b59dfcd18a30a5f81c","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        for mac in port.mac_addresses:"},{"line_number":393,"context_line":"            mac \u003d int(netaddr.EUI(mac))"},{"line_number":394,"context_line":"            mac1 \u003d mac \u003e\u003e 32"},{"line_number":395,"context_line":"            mac2 \u003d 0xffffffff \u0026 mac"},{"line_number":396,"context_line":"            filters.append([\u0027u32\u0027,"},{"line_number":397,"context_line":"                \u0027match\u0027, \u0027u32\u0027, \u00270x%x\u0027 % seg_id, \u00270xffffff00\u0027, \u0027at\u0027, \u002732\u0027,"},{"line_number":398,"context_line":"                \u0027match\u0027, \u0027u16\u0027, \u00270x%x\u0027 % mac1, \u00270xffff\u0027, \u0027at\u0027, \u002742\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_49cd045c","line":395,"updated":"2017-04-14 21:22:41.000000000","message":"can you add a comment explaining what this is doing?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        for mac in port.mac_addresses:"},{"line_number":393,"context_line":"            mac \u003d int(netaddr.EUI(mac))"},{"line_number":394,"context_line":"            mac1 \u003d mac \u003e\u003e 32"},{"line_number":395,"context_line":"            mac2 \u003d 0xffffffff \u0026 mac"},{"line_number":396,"context_line":"            filters.append([\u0027u32\u0027,"},{"line_number":397,"context_line":"                \u0027match\u0027, \u0027u32\u0027, \u00270x%x\u0027 % seg_id, \u00270xffffff00\u0027, \u0027at\u0027, \u002732\u0027,"},{"line_number":398,"context_line":"                \u0027match\u0027, \u0027u16\u0027, \u00270x%x\u0027 % mac1, \u00270xffff\u0027, \u0027at\u0027, \u002742\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_792c0a47","line":395,"in_reply_to":"7ffa3b31_49cd045c","updated":"2017-05-18 05:38:22.000000000","message":"+1\n\nIn addition, we can use mac.value.\n\n  mac \u003d netaddr.EUI(mac)\n  mac1 \u003d mac.value \u003e\u003e 32\n  ....\n\nI think mac_upper16 and mac_lower32 is easier to understand rather mac1 and mac2.","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        return filters"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def _port_filters(self, port):"},{"line_number":404,"context_line":"        if port.net_type \u003d\u003d \u0027vxlan\u0027:"},{"line_number":405,"context_line":"            return self._vxlan_port_filters(port)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _add_tc_class_for_port(self, port):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_59a2669c","line":404,"range":{"start_line":404,"start_character":28,"end_line":404,"end_character":36},"updated":"2017-05-18 05:38:22.000000000","message":"Use the constant corresponding to vxlan. In the caller side, you use the constant, so it is better both match.","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e054ee0afd888e53bdcee0b59dfcd18a30a5f81c","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _add_tc_class_for_port(self, port):"},{"line_number":408,"context_line":"        if self.need_renumbering:"},{"line_number":409,"context_line":"            self._restruct_tc_qdisc()"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":"        if not self.init_done:"},{"line_number":412,"context_line":"            self._init_tc_qdisc()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_29dab816","line":409,"updated":"2017-04-14 21:22:41.000000000","message":"ouch, recursive call. Took me a while to follow this code path. It seems like the logic could be simplified quite a bit if you make _get_next_flowid immiediately renumber instead of setting a flag and making other stuff check it. Is that possible?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        self.devices \u003d {}"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def add_device(self, device, phys_net):"},{"line_number":450,"context_line":"        #NOTE: phys_net \u003d\u003d None means it is tunnel device."},{"line_number":451,"context_line":"        if phys_net in self.devices:"},{"line_number":452,"context_line":"            return"},{"line_number":453,"context_line":"        self.devices[phys_net] \u003d TcHtbDevice(device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_f99a5a6c","line":450,"range":{"start_line":450,"start_character":15,"end_line":450,"end_character":58},"updated":"2017-05-18 05:38:22.000000000","message":"How about define a constant for tunnel device?","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"}],"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2665c97bb54988f2cd37e0f15fb5b1834ad0605b","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # support vxlan network_type only currently."},{"line_number":169,"context_line":"        if port[\u0027network_type\u0027] !\u003d common_constants.TYPE_VXLAN:"},{"line_number":170,"context_line":"            LOG.debug(\"not support type for minimum_bandwidth. port: %s\", port)"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        mac_addresses \u003d {port[\u0027mac_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_597dc61a","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":34},"updated":"2017-05-18 05:38:22.000000000","message":"not support -\u003e unsupported","commit_id":"816064d4e22f49fabcb615b879de338ee3f26464"}]}
