)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"67bc6d5715304403ffed4ea32edf484744247396","unresolved":false,"context_lines":[{"line_number":10,"context_line":"settings in other sections (like keystone_authtoken), and the"},{"line_number":11,"context_line":"ability to use client certs and setting the timeout. This changes"},{"line_number":12,"context_line":"the designate.ca_cert setting to designate.cafile, but the former"},{"line_number":13,"context_line":"is added as a deprecated option, so existing config files will work."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f2173b02af5c3929a96ef8c773d587e9b673d62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_a580144b","line":13,"updated":"2017-01-09 12:05:21.000000000","message":"DocImpact and release note? Is there a bug attached to this?","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"2eabf7daab8b6f63d0f6e37b2485346886421e3e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"settings in other sections (like keystone_authtoken), and the"},{"line_number":11,"context_line":"ability to use client certs and setting the timeout. This changes"},{"line_number":12,"context_line":"the designate.ca_cert setting to designate.cafile, but the former"},{"line_number":13,"context_line":"is added as a deprecated option, so existing config files will work."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f2173b02af5c3929a96ef8c773d587e9b673d62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_a950e05f","line":13,"in_reply_to":"ba5201f7_a580144b","updated":"2017-01-09 17:53:34.000000000","message":"No bug report, since it is just an improvement (use a standard lib for session loading, not custom code). There were tons of changes like this, with use-ksa topic. I can add a DocImpact, of course.","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd0d8090ff2eee5884071630d1522458a60869d0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"settings in other sections (like keystone_authtoken), and the"},{"line_number":11,"context_line":"ability to use client certs and setting the timeout. This changes"},{"line_number":12,"context_line":"the designate.ca_cert setting to designate.cafile, but the former"},{"line_number":13,"context_line":"is added as a deprecated option, so existing config files will work."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f2173b02af5c3929a96ef8c773d587e9b673d62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_2c81574e","line":13,"in_reply_to":"ba5201f7_a950e05f","updated":"2017-01-09 20:58:44.000000000","message":"No need, so long there\u0027s at least one that will generate the bug report and hence allow us to take care of the documentation change required.","commit_id":"78f8031766eafb775261a37fa95737a703fae136"}],"neutron/conf/services/extdns_designate_driver.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f18e3f74197305102917a5cc2465f54536c0a649","unresolved":false,"context_lines":[{"line_number":59,"context_line":"def register_designate_opts(CONF\u003dcfg.CONF):"},{"line_number":60,"context_line":"    CONF.register_opts(designate_opts, \u0027designate\u0027)"},{"line_number":61,"context_line":"    loading.conf.register_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.session.register_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_782b03ec","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":41},"updated":"2017-01-02 23:42:24.000000000","message":"Why not use loading.register_session_conf_options\n\nhttps://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/__init__.py#L31\n\nAnd, if you agree and don\u0027t mind, we can also fix L61 with loading.register_auth_conf_options (even though it is not strictly part of this change): \n\nhttps://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/__init__.py#L26\n\nI think this is more compliant with the way we should import / invoke modules","commit_id":"49d72867661715003ddda7ce23e25b4150e31bea"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"f6607230368eb982cd9e51d31eb91aa05d407cdb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"def register_designate_opts(CONF\u003dcfg.CONF):"},{"line_number":60,"context_line":"    CONF.register_opts(designate_opts, \u0027designate\u0027)"},{"line_number":61,"context_line":"    loading.conf.register_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.session.register_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b18f3acb","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":41},"in_reply_to":"ba5201f7_1183a605","updated":"2017-01-03 12:20:27.000000000","message":"(btw my motivation is to get rid of /v2 keystone urls everywhere)","commit_id":"49d72867661715003ddda7ce23e25b4150e31bea"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"cc6627753a7139128be9feb7e29244b8cba81b55","unresolved":false,"context_lines":[{"line_number":59,"context_line":"def register_designate_opts(CONF\u003dcfg.CONF):"},{"line_number":60,"context_line":"    CONF.register_opts(designate_opts, \u0027designate\u0027)"},{"line_number":61,"context_line":"    loading.conf.register_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.session.register_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_1183a605","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":41},"in_reply_to":"ba5201f7_782b03ec","updated":"2017-01-03 12:01:23.000000000","message":"Ah, I did not know it is the preferred way. Of course if I change this one, I should change the other one, too.","commit_id":"49d72867661715003ddda7ce23e25b4150e31bea"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"67bc6d5715304403ffed4ea32edf484744247396","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    loading.register_auth_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.register_session_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_05a9e0df","line":64,"updated":"2017-01-09 12:05:21.000000000","message":"what about \u0027insecure\u0027, should that one be deprecated before removal?","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"2eabf7daab8b6f63d0f6e37b2485346886421e3e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    loading.register_auth_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.register_session_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_490bf47d","line":64,"in_reply_to":"ba5201f7_05a9e0df","updated":"2017-01-09 17:53:34.000000000","message":"insecure will preserved by register_session_conf_options. Only ca_cert changes to cafile.","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd0d8090ff2eee5884071630d1522458a60869d0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    loading.register_auth_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.register_session_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_cc6e0b96","line":64,"in_reply_to":"ba5201f7_490bf47d","updated":"2017-01-09 20:58:44.000000000","message":"are you saying that insecure is registered by register_session_conf_options?","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"97bed2f6452a6a094d3ebb3872201d468113d92c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    loading.register_auth_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.register_session_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_ccca8b6e","line":64,"in_reply_to":"ba5201f7_cc6e0b96","updated":"2017-01-09 21:00:57.000000000","message":"That\u0027s not how I understand [1], but I have been particularly slow lately :)\n\n[1] http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/auth/base.py#n321","commit_id":"78f8031766eafb775261a37fa95737a703fae136"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"2cd6b019e205ecc513ff1933fe40cac4f2766fbd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    loading.register_auth_conf_options(CONF, \u0027designate\u0027)"},{"line_number":62,"context_line":"    loading.register_session_conf_options(conf\u003dCONF,"},{"line_number":63,"context_line":"        group\u003d\u0027designate\u0027,"},{"line_number":64,"context_line":"        deprecated_opts\u003d{\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_cert\u0027)]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_67036610","line":64,"in_reply_to":"ba5201f7_ccca8b6e","updated":"2017-01-10 09:06:11.000000000","message":"This is from the \"new\" keystoneauth1 lib:\n\nhttp://git.openstack.org/cgit/openstack/keystoneauth/tree/keystoneauth1/loading/session.py#n133\n\nIt registers 5 options: cafile,certfile,keyfile,insecure,timeout. So we\u0027ll have even more config options (timeout and client cert authentication).","commit_id":"78f8031766eafb775261a37fa95737a703fae136"}]}