)]}'
{"neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4bd9732ac8f1ac8f9b9b4e5b32dcb2c5644e91d9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        vf_to_pci_slot_mapping \u003d {}"},{"line_number":142,"context_line":"        assigned_devices_info \u003d []"},{"line_number":143,"context_line":"        ls \u003d self.pci_dev_wrapper.link_show()"},{"line_number":144,"context_line":"        for pci_slot, vf_index in self.pci_slot_map.items():"},{"line_number":145,"context_line":"            if not PciOsWrapper.is_assigned_vf(self.dev_name, vf_index, ls):"},{"line_number":146,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_ee6e1c95","line":143,"updated":"2017-01-04 08:42:16.000000000","message":"Just a fancy suggestion with probably little value (beyond the user needing to know that he has to carry the link show string around): \n\nIt\u0027d be super cool to have PciOsWrapper have a function that returned a context, so we could do:\n\n    with self.pci_dev_wrapper.links() as links:\n        for pci_slot, vf_index in self.pci_slot_map.items():\n            if links.have_vf_asigned(self.dev_name, vf_index):\n                continue\n            ..\n            ..\n            vf_to_mac_mapping \u003d links.get_assigned_macs(vf_to_pic_slot_mappping.keys())","commit_id":"f36d960a82a38018361388e525187530f2bc10ba"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9b5c4bd6b2ce3fec3803074f470087f8e299daa","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        vf_to_pci_slot_mapping \u003d {}"},{"line_number":142,"context_line":"        assigned_devices_info \u003d []"},{"line_number":143,"context_line":"        ls \u003d self.pci_dev_wrapper.link_show()"},{"line_number":144,"context_line":"        for pci_slot, vf_index in self.pci_slot_map.items():"},{"line_number":145,"context_line":"            if not PciOsWrapper.is_assigned_vf(self.dev_name, vf_index, ls):"},{"line_number":146,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_9a0a2620","line":143,"in_reply_to":"ba5201f7_3f520cde","updated":"2017-01-04 10:17:28.000000000","message":"Ack, so let\u0027s wait for the tests, and see, thank you for tackling it :)","commit_id":"f36d960a82a38018361388e525187530f2bc10ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2b788578adac626946b95a6bd3c07ac31d973394","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        vf_to_pci_slot_mapping \u003d {}"},{"line_number":142,"context_line":"        assigned_devices_info \u003d []"},{"line_number":143,"context_line":"        ls \u003d self.pci_dev_wrapper.link_show()"},{"line_number":144,"context_line":"        for pci_slot, vf_index in self.pci_slot_map.items():"},{"line_number":145,"context_line":"            if not PciOsWrapper.is_assigned_vf(self.dev_name, vf_index, ls):"},{"line_number":146,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_3f520cde","line":143,"in_reply_to":"ba5201f7_ee6e1c95","updated":"2017-01-04 09:51:43.000000000","message":"Yeah, this might be due for a little refactoring after this patch merges. I need to get this back-ported though so I wanted it to be as uninvasive as possible.","commit_id":"f36d960a82a38018361388e525187530f2bc10ba"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"91465fcb756fb34e380cd76710fda746f39afb85","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        vf_to_pci_slot_mapping \u003d {}"},{"line_number":142,"context_line":"        assigned_devices_info \u003d []"},{"line_number":143,"context_line":"        ls \u003d self.pci_dev_wrapper.link_show(self.dev_name)"},{"line_number":144,"context_line":"        for pci_slot, vf_index in self.pci_slot_map.items():"},{"line_number":145,"context_line":"            if not PciOsWrapper.is_assigned_vf(self.dev_name, vf_index, ls):"},{"line_number":146,"context_line":"                continue"},{"line_number":147,"context_line":"            vf_to_pci_slot_mapping[vf_index] \u003d pci_slot"},{"line_number":148,"context_line":"        if vf_to_pci_slot_mapping:"},{"line_number":149,"context_line":"            vf_to_mac_mapping \u003d self.pci_dev_wrapper.get_assigned_macs("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_212e4aa5","line":146,"range":{"start_line":143,"start_character":0,"end_line":146,"end_character":24},"updated":"2017-01-05 07:03:02.000000000","message":"the macvtap is broken now :) \nThe fix is more complicate.\n\nhere you need ip link show so we can parse the to see if there is macvtap interface.\nand in Line 149 you need the ip link show \u003cPF_interface\u003e\n\nSo I think what you need to do is \nto get the output of \"ip link show\" in line 143\nand pass it to is_assigned_vf\nfor the get_assigned_macs you need to first to know what is the PF you can do it by the vf pci slot and extract only that PF output.","commit_id":"82864d4546aa77fc56c22bc4bac90d56247ea69f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3e63fe4ffc5c836239495978e49b219c0cf36096","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        vf_to_pci_slot_mapping \u003d {}"},{"line_number":142,"context_line":"        assigned_devices_info \u003d []"},{"line_number":143,"context_line":"        ls \u003d self.pci_dev_wrapper.link_show(self.dev_name)"},{"line_number":144,"context_line":"        for pci_slot, vf_index in self.pci_slot_map.items():"},{"line_number":145,"context_line":"            if not PciOsWrapper.is_assigned_vf(self.dev_name, vf_index, ls):"},{"line_number":146,"context_line":"                continue"},{"line_number":147,"context_line":"            vf_to_pci_slot_mapping[vf_index] \u003d pci_slot"},{"line_number":148,"context_line":"        if vf_to_pci_slot_mapping:"},{"line_number":149,"context_line":"            vf_to_mac_mapping \u003d self.pci_dev_wrapper.get_assigned_macs("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_f2a24b4a","line":146,"range":{"start_line":143,"start_character":0,"end_line":146,"end_character":24},"in_reply_to":"ba5201f7_212e4aa5","updated":"2017-01-05 10:12:25.000000000","message":"To make this simple enough for back-port I think I will just leave get_assigned_macs alone for now since it\u0027s only a single call per scan.","commit_id":"82864d4546aa77fc56c22bc4bac90d56247ea69f"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a34529dde0fd4f66f968c4f72db4d6cb8498641a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        @return: dict mapping of vf to mac"},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        vf_to_mac_mapping \u003d {}"},{"line_number":84,"context_line":"        vf_lines \u003d self._get_vf_link_show(vf_list, ip_link_show_output)"},{"line_number":85,"context_line":"        if vf_lines:"},{"line_number":86,"context_line":"            for vf_line in vf_lines:"},{"line_number":87,"context_line":"                vf_details \u003d self._parse_vf_link_show(vf_line)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_26ebd214","line":84,"range":{"start_line":84,"start_character":19,"end_line":84,"end_character":71},"updated":"2017-01-04 18:38:48.000000000","message":"This is what I think is the issue:\n\nthe assumption of the _get_vf_link_show is to parse the input per PF interface not per all interfaces. \n\nnow you are passing the \"ip link show\" output so if  have 2 PF with virtual functions like in our CI it get the wrong mac.\nIt got 00:00:00:00:00 mac for the second PF \nsee error in the log.\n\"Port with MAC address 00:00:00:00:00:00 is added treat_devices_added_updated\"\nso we need to pass only the PF ip link show output.","commit_id":"971dd85e9b9dab500071a78884dc8a84f1f07ef6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f4cca12797947f8db86ca093cc55baf91fac935f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        @return: dict mapping of vf to mac"},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        vf_to_mac_mapping \u003d {}"},{"line_number":84,"context_line":"        vf_lines \u003d self._get_vf_link_show(vf_list, ip_link_show_output)"},{"line_number":85,"context_line":"        if vf_lines:"},{"line_number":86,"context_line":"            for vf_line in vf_lines:"},{"line_number":87,"context_line":"                vf_details \u003d self._parse_vf_link_show(vf_line)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_948664d9","line":84,"range":{"start_line":84,"start_character":19,"end_line":84,"end_character":71},"in_reply_to":"ba5201f7_26ebd214","updated":"2017-01-04 19:44:13.000000000","message":"ah, i didn\u0027t notice the difference in the show commands here.","commit_id":"971dd85e9b9dab500071a78884dc8a84f1f07ef6"}]}
