)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"48cad8ad7f28eb6de7f27fa17485c93727c46eef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"As LinuxBridge L2 agent tests are spawning each agent"},{"line_number":12,"context_line":"in separate namespace it is possible to test security"},{"line_number":13,"context_line":"groups functionality."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I755c2f1cf68acc0df110902f3a587040ed0a4bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_c6cf6654","line":14,"updated":"2017-01-11 14:59:39.000000000","message":"Closes-bug: #1577457","commit_id":"b1c1646b737ef7d96355cac13efbeb2e2a94fbf2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d51c6df09b9f37aacb7c2f72457cf58f805e79ce","unresolved":false,"context_lines":[{"line_number":11,"context_line":"As LinuxBridge L2 agent tests are spawning each agent"},{"line_number":12,"context_line":"in separate namespace it is possible to test security"},{"line_number":13,"context_line":"groups functionality."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I755c2f1cf68acc0df110902f3a587040ed0a4bab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_dc3800f1","line":14,"in_reply_to":"ba5201f7_c6cf6654","updated":"2017-01-11 22:22:44.000000000","message":"Done","commit_id":"b1c1646b737ef7d96355cac13efbeb2e2a94fbf2"}],"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4a3ed5690e43303d52f4e1b0db8026ff6f0fe9ea","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":225,"context_line":"        self._test_tcp_securitygroup(index_to_sg, index_to_host)"},{"line_number":226,"context_line":"        self._test_break_established_connection(index_to_host[2])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class TestLinuxBridgeSecurityGroupsSameNetwork("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_07c79396","line":226,"updated":"2017-01-17 09:53:19.000000000","message":"Does this not work with LB agent cause dropping mechanism is implemented for hybrid driver? It\u0027s worth opening a bug and commenting it here, why don\u0027t we run this test.\n\nAlso given that this is the only change that is required for LB agent, it might be worth considering l2_agent class attribute as a part of scenario configuration.\n\ne.g.\n\n scenarios \u003d [\n     (\u0027ovs-hybrid\u0027, {\n         \u0027firewall_driver\u0027: \u0027iptables_hybrid\u0027,\n         \u0027of_interface\u0027: \u0027native\u0027,\n         \u0027ovsdb_interface\u0027: \u0027native\u0027,\n         \u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),\n     (\u0027ovs-openflow-cli_ovsdb-cli\u0027, {\n         \u0027firewall_driver\u0027: \u0027openvswitch\u0027,\n         \u0027of_interface\u0027: \u0027ovs-ofctl\u0027,\n         \u0027ovsdb_interface\u0027: \u0027vsctl\u0027}),\n     (\u0027lb-iptables\u0027, {\n         \u0027firewall_driver\u0027: \u0027iptables\u0027,\n         \u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE,\n ]\n\n\nthen on test 6. for establishing:\n\n # iptables driver currently contains a bug (link to LP) where established \n # connections are not dropped after security group rule is removed.  \n # Remove this workaround once bug #### is fixed.\n if self.firewall_driver \u003d\u003d \u0027iptables\u0027:\n     return\n \u003cdo test 6 here\u003e","commit_id":"56465606009dbdc9cab84529bf3060b9fe971f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2b2131288145be9a842bd1004b71cbad70b76b14","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":225,"context_line":"        self._test_tcp_securitygroup(index_to_sg, index_to_host)"},{"line_number":226,"context_line":"        self._test_break_established_connection(index_to_host[2])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class TestLinuxBridgeSecurityGroupsSameNetwork("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_227f1a67","line":226,"in_reply_to":"7a3c09a3_07c79396","updated":"2017-01-17 11:20:54.000000000","message":"You\u0027re right. I can do it like You said.\nAbout established connections I will open a bug but I don\u0027t think there is any easy way to fix it.","commit_id":"56465606009dbdc9cab84529bf3060b9fe971f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e0e56245b153924f0fe86c97c1c06a1f3abf444","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":225,"context_line":"        self._test_tcp_securitygroup(index_to_sg, index_to_host)"},{"line_number":226,"context_line":"        self._test_break_established_connection(index_to_host[2])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class TestLinuxBridgeSecurityGroupsSameNetwork("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_a5c930ae","line":226,"in_reply_to":"7a3c09a3_227f1a67","updated":"2017-01-17 21:40:24.000000000","message":"so, bug is reported (but I\u0027m not sure if it is really bug :))\nchanges done.","commit_id":"56465606009dbdc9cab84529bf3060b9fe971f87"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8422943b0040807d75a254768af383606a6bf25e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    network_type \u003d \u0027vxlan\u0027"},{"line_number":78,"context_line":"    scenarios \u003d ["},{"line_number":79,"context_line":"        (\u0027hybrid\u0027, {"},{"line_number":80,"context_line":"            \u0027firewall_driver\u0027: \u0027iptables_hybrid\u0027,"},{"line_number":81,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":82,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_0fca011b","line":79,"range":{"start_line":79,"start_character":10,"end_line":79,"end_character":16},"updated":"2017-01-18 12:36:20.000000000","message":"Nit: we could prefix it with ovs to be consistent with \u0027linuxbridge-iptables\u0027","commit_id":"f9c49696d1282d2a11d041c8944532f36dd76007"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"18f0a710ec1a1ecdb812c6c05c0c32765067a41f","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    network_type \u003d \u0027vxlan\u0027"},{"line_number":78,"context_line":"    scenarios \u003d ["},{"line_number":79,"context_line":"        (\u0027hybrid\u0027, {"},{"line_number":80,"context_line":"            \u0027firewall_driver\u0027: \u0027iptables_hybrid\u0027,"},{"line_number":81,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":82,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_0fbf6161","line":79,"range":{"start_line":79,"start_character":10,"end_line":79,"end_character":16},"in_reply_to":"7a3c09a3_0fca011b","updated":"2017-01-18 12:50:41.000000000","message":"Done","commit_id":"f9c49696d1282d2a11d041c8944532f36dd76007"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8422943b0040807d75a254768af383606a6bf25e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            self.addCleanup(netcat.stop_processes)"},{"line_number":223,"context_line":"            self.assertTrue(netcat.test_connectivity())"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            # 6. check if an established connection stops by deleting"},{"line_number":226,"context_line":"            #    the supporting SG rule."},{"line_number":227,"context_line":"            self.client.delete_security_group_rule(rule2[\u0027id\u0027])"},{"line_number":228,"context_line":"            common_utils.wait_until_true(lambda: netcat.test_no_connectivity(),"},{"line_number":229,"context_line":"                                         sleep\u003d8)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_6f5c657d","line":226,"range":{"start_line":225,"start_character":12,"end_line":226,"end_character":40},"updated":"2017-01-18 12:36:20.000000000","message":"Maybe if you\u0027d need to respin, we can move this comment up under the if statement.","commit_id":"f9c49696d1282d2a11d041c8944532f36dd76007"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"18f0a710ec1a1ecdb812c6c05c0c32765067a41f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            self.addCleanup(netcat.stop_processes)"},{"line_number":223,"context_line":"            self.assertTrue(netcat.test_connectivity())"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            # 6. check if an established connection stops by deleting"},{"line_number":226,"context_line":"            #    the supporting SG rule."},{"line_number":227,"context_line":"            self.client.delete_security_group_rule(rule2[\u0027id\u0027])"},{"line_number":228,"context_line":"            common_utils.wait_until_true(lambda: netcat.test_no_connectivity(),"},{"line_number":229,"context_line":"                                         sleep\u003d8)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_218271c8","line":226,"range":{"start_line":225,"start_character":12,"end_line":226,"end_character":40},"in_reply_to":"7a3c09a3_6f5c657d","updated":"2017-01-18 12:50:41.000000000","message":"Done","commit_id":"f9c49696d1282d2a11d041c8944532f36dd76007"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"29dda009e9204f4ccf5f6201cd62a02f1882119d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":82,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"},{"line_number":83,"context_line":"            \u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":84,"context_line":"        (\u0027openflow-cli_ovsdb-cli\u0027, {"},{"line_number":85,"context_line":"            \u0027firewall_driver\u0027: \u0027openvswitch\u0027,"},{"line_number":86,"context_line":"            \u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":87,"context_line":"            \u0027ovsdb_interface\u0027: \u0027vsctl\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_e1bea963","line":84,"updated":"2017-01-18 12:53:26.000000000","message":"Now the ovs- prefix should come here and","commit_id":"2ac66e039d43d71bbc83ec581b6e5d25be048dbd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c5d11bab3c555c9750eee1f360eeb916d8ec832f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":82,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"},{"line_number":83,"context_line":"            \u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":84,"context_line":"        (\u0027openflow-cli_ovsdb-cli\u0027, {"},{"line_number":85,"context_line":"            \u0027firewall_driver\u0027: \u0027openvswitch\u0027,"},{"line_number":86,"context_line":"            \u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":87,"context_line":"            \u0027ovsdb_interface\u0027: \u0027vsctl\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_e4015706","line":84,"in_reply_to":"7a3c09a3_e1bea963","updated":"2017-01-18 12:56:55.000000000","message":"I didn\u0027t change it because I thought that if there is \"openflow\" in name, then ovs is not necessary also :)\nBut changed now","commit_id":"2ac66e039d43d71bbc83ec581b6e5d25be048dbd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"29dda009e9204f4ccf5f6201cd62a02f1882119d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            \u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":87,"context_line":"            \u0027ovsdb_interface\u0027: \u0027vsctl\u0027,"},{"line_number":88,"context_line":"            \u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":89,"context_line":"        (\u0027openflow-native_ovsdb-native\u0027, {"},{"line_number":90,"context_line":"            \u0027firewall_driver\u0027: \u0027openvswitch\u0027,"},{"line_number":91,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":92,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_21b5117d","line":89,"updated":"2017-01-18 12:53:26.000000000","message":"here :)","commit_id":"2ac66e039d43d71bbc83ec581b6e5d25be048dbd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c5d11bab3c555c9750eee1f360eeb916d8ec832f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            \u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":87,"context_line":"            \u0027ovsdb_interface\u0027: \u0027vsctl\u0027,"},{"line_number":88,"context_line":"            \u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":89,"context_line":"        (\u0027openflow-native_ovsdb-native\u0027, {"},{"line_number":90,"context_line":"            \u0027firewall_driver\u0027: \u0027openvswitch\u0027,"},{"line_number":91,"context_line":"            \u0027of_interface\u0027: \u0027native\u0027,"},{"line_number":92,"context_line":"            \u0027ovsdb_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_84117354","line":89,"in_reply_to":"7a3c09a3_21b5117d","updated":"2017-01-18 12:56:55.000000000","message":"here too :)","commit_id":"2ac66e039d43d71bbc83ec581b6e5d25be048dbd"}]}
