)]}'
{"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac0fd4036cf18310279b059a9c33b27d4fb69611","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self._ensure_extra_attr_model(context, router_db)"},{"line_number":44,"context_line":"            router_db[\u0027extra_attributes\u0027].update({key: to_db(value)})"},{"line_number":45,"context_line":"            return"},{"line_number":46,"context_line":"        raise RuntimeError(\"Tried to set a key \u0027%s\u0027 that doesn\u0027t exist in \""},{"line_number":47,"context_line":"                           \"the extra attributes table.\" % key)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_7a8fbb74","line":46,"updated":"2017-01-08 16:15:44.000000000","message":"please add in a translation here _()","commit_id":"bfcb929d4347af25bd9e6ae8443709fa99776a63"}],"neutron/db/models/l3_attrs.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac0fd4036cf18310279b059a9c33b27d4fb69611","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from neutron.extensions import availability_zone as az"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib.db import model_base"},{"line_number":15,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_faf1eb01","line":12,"updated":"2017-01-08 16:15:44.000000000","message":"this should be in the section below (line 19)","commit_id":"bfcb929d4347af25bd9e6ae8443709fa99776a63"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2196742325f1ad08566c0a6b0df969cb77562c47","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    ha \u003d sa.Column(sa.Boolean,"},{"line_number":59,"context_line":"                   # default is func to reflect config changes"},{"line_number":60,"context_line":"                   default\u003dlambda: get_attr_info()[\u0027ha\u0027][\u0027default\u0027],"},{"line_number":61,"context_line":"                   server_default\u003dsa.sql.false(),"},{"line_number":62,"context_line":"                   nullable\u003dFalse)"},{"line_number":63,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer(), default\u003d0)"},{"line_number":64,"context_line":"    # Availability Zone support"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_bf666327","line":61,"updated":"2017-01-09 11:36:01.000000000","message":"isn\u0027t there a danger that it won\u0027t match with server_default?","commit_id":"e1d815dcc97199d2eabee430a36511f6c0e95665"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ab3a43c6aa25e6281140975f59cd21493a15483d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    ha \u003d sa.Column(sa.Boolean,"},{"line_number":59,"context_line":"                   # default is func to reflect config changes"},{"line_number":60,"context_line":"                   default\u003dlambda: get_attr_info()[\u0027ha\u0027][\u0027default\u0027],"},{"line_number":61,"context_line":"                   server_default\u003dsa.sql.false(),"},{"line_number":62,"context_line":"                   nullable\u003dFalse)"},{"line_number":63,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer(), default\u003d0)"},{"line_number":64,"context_line":"    # Availability Zone support"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_aae70345","line":61,"in_reply_to":"ba5201f7_bf666327","updated":"2017-01-09 11:42:19.000000000","message":"That\u0027s okay. Server_default only applies when creating a table, it sets the SQL backend default value[1].\n\ndefault is what sqlalchemy will populate on inserts when not specified.\n\n1. http://docs.sqlalchemy.org/en/latest/core/defaults.html#server-defaults","commit_id":"e1d815dcc97199d2eabee430a36511f6c0e95665"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2196742325f1ad08566c0a6b0df969cb77562c47","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   default\u003dlambda: get_attr_info()[\u0027ha\u0027][\u0027default\u0027],"},{"line_number":61,"context_line":"                   server_default\u003dsa.sql.false(),"},{"line_number":62,"context_line":"                   nullable\u003dFalse)"},{"line_number":63,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer(), default\u003d0)"},{"line_number":64,"context_line":"    # Availability Zone support"},{"line_number":65,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255), default\u003d\u0027[]\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    router \u003d orm.relationship("},{"line_number":68,"context_line":"        \u0027Router\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_3f7353e9","line":65,"range":{"start_line":63,"start_character":4,"end_line":65,"end_character":69},"updated":"2017-01-09 11:36:01.000000000","message":"these need a DB migration, do they not?","commit_id":"e1d815dcc97199d2eabee430a36511f6c0e95665"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ab3a43c6aa25e6281140975f59cd21493a15483d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   default\u003dlambda: get_attr_info()[\u0027ha\u0027][\u0027default\u0027],"},{"line_number":61,"context_line":"                   server_default\u003dsa.sql.false(),"},{"line_number":62,"context_line":"                   nullable\u003dFalse)"},{"line_number":63,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer(), default\u003d0)"},{"line_number":64,"context_line":"    # Availability Zone support"},{"line_number":65,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255), default\u003d\u0027[]\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    router \u003d orm.relationship("},{"line_number":68,"context_line":"        \u0027Router\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_6ae6fb45","line":65,"range":{"start_line":63,"start_character":4,"end_line":65,"end_character":69},"in_reply_to":"ba5201f7_3f7353e9","updated":"2017-01-09 11:42:19.000000000","message":"no, because they are just sqlalchemy behavior settings. They don\u0027t affect the schema.","commit_id":"e1d815dcc97199d2eabee430a36511f6c0e95665"}]}