)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"be3f18848ff108c59070c2a2ce318d58bf1c6f13","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibf59835a34f2e34212a18e2dc705a84a359b6806"},{"line_number":15,"context_line":"Closes-Bug: #1649124"},{"line_number":16,"context_line":"Related-Bug: #1649124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a461143_cded0990","line":16,"updated":"2017-02-02 20:34:27.000000000","message":"remove the line, it duplicates line 15.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"f7af28ec7ed1a0bcb99fb158b3a131c3aa2b4fd8","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibf59835a34f2e34212a18e2dc705a84a359b6806"},{"line_number":15,"context_line":"Closes-Bug: #1649124"},{"line_number":16,"context_line":"Related-Bug: #1649124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a461143_0b08d6d8","line":16,"in_reply_to":"3a461143_cded0990","updated":"2017-02-02 23:02:35.000000000","message":"Done","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"}],"neutron/agent/ovsdb/impl_vsctl.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c3c3d405fef3600e388ef9622ae9b76888f4a5d0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_b7029f6d","line":184,"updated":"2017-01-20 18:11:02.000000000","message":"As far as I see, we have test coverage for add_manager in neutron/tests/functional/agent/test_ovs_lib.py. How come do tests pass if it\u0027s broken?","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c9edb32a2e3e816ec4fb678ffa47987d3d98b7f6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_3260ca35","line":184,"in_reply_to":"1a430d35_4e2073f8","updated":"2017-02-03 17:31:02.000000000","message":"I think the following tests should cover it:\n\nneutron.tests.functional.agent.test_ovs_lib.OVSLibTestCase.test_add_manager_lifecycle_baseovs(vsctl)\nneutron.tests.functional.agent.test_ovs_lib.OVSLibTestCase. test_add_manager_appends(vsctl)","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"45ec2b6bcb9216343217cffadec237b499223237","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_aed71722","line":184,"in_reply_to":"1a430d35_6b55211c","updated":"2017-02-02 23:30:22.000000000","message":"Thank you sir.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"85b523effb93cde5463253efd71fc4c4d70e20cd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_4e2073f8","line":184,"in_reply_to":"1a430d35_aed71722","updated":"2017-02-02 23:34:21.000000000","message":"Can you do me a favor and try to find if any functional tests are actually running?  I\u0027ve looked at the logs attached to this review and found no traces of functional tests running but I might be looking at the wrong places.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4655153cf31fc71a3e192d3c954845e2a11ed6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_6b55211c","line":184,"in_reply_to":"3a461143_4b7f3e66","updated":"2017-02-02 23:13:45.000000000","message":"If TripleO chooses vsctl interface for you for Newton+, it does something wrong, and we should fix it in TripleO too. Please report a bug against the project so that they are aware they use something that will eventually be deprecated and removed in Neutron (the vsctl interface).\n\nI understand that you may not have time to complete the patch. It will mean that unless someone else steps in and completes it for you, it may take a while for it to land. I added some relevant folks to the reviewers list and hope that if nothing else, someone of them will pick that patch up.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"392f18f9640486034c089ac546ffee8d439eea4c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_ad1b5dc9","line":184,"in_reply_to":"3a461143_6d3a5536","updated":"2017-02-02 20:31:47.000000000","message":"By the way, you may want to switch to \u0027native\u0027 ovsdb interface, that is default in Newton+. AFAIU that should avoid triggering this particular code.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"f7af28ec7ed1a0bcb99fb158b3a131c3aa2b4fd8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_0bec5628","line":184,"in_reply_to":"3a461143_6d3a5536","updated":"2017-02-02 23:02:35.000000000","message":"I\u0027m not a good programmer and this was a quick patch for my tripleo issue that other people will also get at some point.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"f7af28ec7ed1a0bcb99fb158b3a131c3aa2b4fd8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_4b7f3e66","line":184,"in_reply_to":"3a461143_ad1b5dc9","updated":"2017-02-02 23:02:35.000000000","message":"How?  I\u0027m using tripleo to deploy an overcloud.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a193a293f974ed3c19d63878778d71907931bc71","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_6d3a5536","line":184,"in_reply_to":"5a3905b3_77b75686","updated":"2017-02-02 20:30:14.000000000","message":"Yes, there are functional tests in tree that actually create managers for ovs bridges. Do they fail for you in RHEL 7.3? If not, we need to understand where the gap in testing coverage is, and close it with appropriate test cases.\n\nIt\u0027s debatable who is to write those missing tests. It\u0027s common practice in OpenStack that a bug fixer also provides test cases exposing the issue. We tend to follow that practice.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"de5d15b5240fa68b3242db3dca37302bbe0299b4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue, **kwargs):"},{"line_number":182,"context_line":"        return Transaction(self.context, check_error, log_errors, **kwargs)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":185,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":186,"context_line":"        conn_uri \u003d \u0027target\u003d\\\"%s\\\"\u0027 % connection_uri"},{"line_number":187,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_77b75686","line":184,"in_reply_to":"5a3905b3_b7029f6d","updated":"2017-01-20 21:14:02.000000000","message":"Are the tests actual tests trying to actually connect to ovs to create a manager?   It fails here on RHEL 7.3 ... I wrote a quick patch to fix ... if tests need to be written, they should be written / tested by the original code implementer of that chunk of code.  This situation prevents me from installing Newton and Ocata automatically because the neutron-openvswitch-agent dies when starting up because the Manager creation returns -13 or -14 because of the unescapped double quotes.","commit_id":"0c378e29cf2c049e26d6740a17f8a74df591d3e2"}]}