)]}'
{"neutron/tests/tempest/scenario/test_dvr.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"4f0893856eb9ae4e1325e772db8c0c2d584b1965","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        super(NetworkDvrHATest, cls).skip_checks()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u0027fe169f2c-6ed3-4eb0-8afe-2d540c4b49e2\u0027)"},{"line_number":93,"context_line":"    def test_udpate_router_with_dvr_and_ha(self):"},{"line_number":94,"context_line":"        \"\"\"Update DVR and HA values for Router."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Check permutations of DVR and L3-HA values for Router"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_4d1a0370","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":42},"updated":"2017-01-10 09:24:02.000000000","message":"This isn\u0027t needed. Why not just have each of these functions be its own test?","commit_id":"7053de04f1ff0acf9c670cddadbb33ced49b47df"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"4f0893856eb9ae4e1325e772db8c0c2d584b1965","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            router_id\u003drouter[\u0027id\u0027], distributed\u003dTrue, ha\u003dTrue)"},{"line_number":107,"context_line":"        self.admin_manager.network_client.update_router("},{"line_number":108,"context_line":"            router_id\u003drouter[\u0027id\u0027], admin_state_up\u003dTrue)"},{"line_number":109,"context_line":"        self._check_connectivity()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _test_from_legacy(self):"},{"line_number":112,"context_line":"        \"\"\"Update DVR and HA values for Router."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8d9f8bb3","line":109,"range":{"start_line":109,"start_character":13,"end_line":109,"end_character":32},"updated":"2017-01-10 09:24:02.000000000","message":"Also, please do a \u0027show_router\u0027 to make sure that the router really is dvr ha now.","commit_id":"7053de04f1ff0acf9c670cddadbb33ced49b47df"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"4f0893856eb9ae4e1325e772db8c0c2d584b1965","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":117,"context_line":"            distributed\u003dFalse, ha\u003dFalse,"},{"line_number":118,"context_line":"            tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":119,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":120,"context_line":"        self._check_connectivity()"},{"line_number":121,"context_line":"        self._test_dvr_ha(router)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _test_from_ha(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8d786b91","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":34},"updated":"2017-01-10 09:24:02.000000000","message":"These 2 lines are shared amongst these 3 different tests, and can be moved to inside _test_dvr_ha().","commit_id":"7053de04f1ff0acf9c670cddadbb33ced49b47df"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cce0da6215bb94b3b263128042109fb219547650","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":62,"context_line":"            distributed\u003dTrue, tenant_id\u003dself.client.tenant_id, is_admin\u003dTrue)"},{"line_number":63,"context_line":"        self.setup_network_and_server(router\u003drouter)"},{"line_number":64,"context_line":"        self._check_snat_port_connectivity()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a3905b3_c0fd030a","line":64,"updated":"2017-01-24 22:12:11.000000000","message":"strange pep8 error for this line, i\u0027ll fix it","commit_id":"731852da52f118435bb00c268a7e59d87d1cfd50"}]}
