)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd479a9d00f14240aff62226852e96dc1be5f1ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"e.g:"},{"line_number":11,"context_line":"obj \u003d agent.Agent.get_objects("},{"line_number":12,"context_line":"    self.context,"},{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15a76ce20defbcb5b23a13171f93049e84383e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a30ddce_175ee543","line":13,"range":{"start_line":13,"start_character":52,"end_line":13,"end_character":58},"updated":"2017-03-10 00:42:26.000000000","message":"looking at object added in object/utils shouldn\u0027t the arguments be like contains\u003d\u0027xyc\u0027, start\u003d\u0027wrwr\u0027 ?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"e.g:"},{"line_number":11,"context_line":"obj \u003d agent.Agent.get_objects("},{"line_number":12,"context_line":"    self.context,"},{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15a76ce20defbcb5b23a13171f93049e84383e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a1ff146_4fabd374","line":13,"range":{"start_line":13,"start_character":52,"end_line":13,"end_character":58},"in_reply_to":"9a30ddce_175ee543","updated":"2017-03-15 18:35:59.000000000","message":"Well by defaults, it will be contains\u003d\u0027\u0027","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15a76ce20defbcb5b23a13171f93049e84383e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da36d5c6_dd00af04","line":16,"updated":"2017-03-06 15:00:08.000000000","message":"Partially-Implements: ...","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15a76ce20defbcb5b23a13171f93049e84383e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a1ff146_84ee8d20","line":16,"in_reply_to":"da36d5c6_dd00af04","updated":"2017-03-15 18:35:59.000000000","message":"Done","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tonytan4ever \u003ctony.tan@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-02 21:39:15 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support object string field filtering on \"LIKE\" statement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allows objects\u0027 get_objects method take in \"LIKE\" filters."},{"line_number":10,"context_line":"e.g:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_fd240eb1","line":7,"updated":"2017-04-10 14:57:05.000000000","message":"you should update doc/source/devref/objects_usage.rst as part of the patch","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":10,"context_line":"e.g:"},{"line_number":11,"context_line":"obj \u003d agent.Agent.get_objects("},{"line_number":12,"context_line":"    self.context,"},{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_22125563","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":51},"updated":"2017-04-10 14:57:05.000000000","message":"Will probably now be resource_versions\u003dobj_utils.(MatchingStringConstains|StringContains)?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"obj \u003d agent.Agent.get_objects("},{"line_number":12,"context_line":"    self.context,"},{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":14,"context_line":")[0]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":17,"context_line":"Change-Id: I15a76ce20defbcb5b23a13171f93049e84383e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_023e31d9","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":4},"updated":"2017-04-10 14:57:05.000000000","message":"that\u0027s redundant to communicate the idea","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88818aeeff9a76653ec5db1d4d8c954772a193bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allows objects\u0027 get_objects method take in \"LIKE\" filters."},{"line_number":10,"context_line":"e.g:"},{"line_number":11,"context_line":"obj \u003d agent.Agent.get_objects("},{"line_number":12,"context_line":"    self.context,"},{"line_number":13,"context_line":"    resource_versions\u003dobj_utils.StringContains(\u0027obj2\u0027)"},{"line_number":14,"context_line":")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1f013ff3_b084b90d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":3},"updated":"2017-05-16 18:43:39.000000000","message":"objs","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"}],"doc/source/devref/objects_usage.rst":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88818aeeff9a76653ec5db1d4d8c954772a193bf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # for fetching multiple objects:"},{"line_number":71,"context_line":"    dnses \u003d DNSNameServer.get_objects(context)"},{"line_number":72,"context_line":"    # will return list of all dns name servers from DB"},{"line_number":73,"context_line":"    "},{"line_number":74,"context_line":"    # for fetching objects with substrings in a string field:"},{"line_number":75,"context_line":"    from neutron.objects import utils as obj_utils"},{"line_number":76,"context_line":"    dnses \u003d DNSNameServer.get_objects(context, name\u003dobj_utils.StringMatchingContains(\u0027obj2\u0027))"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1f013ff3_5079f52c","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":4},"updated":"2017-05-16 18:43:39.000000000","message":"remove red thingy","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88818aeeff9a76653ec5db1d4d8c954772a193bf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    "},{"line_number":74,"context_line":"    # for fetching objects with substrings in a string field:"},{"line_number":75,"context_line":"    from neutron.objects import utils as obj_utils"},{"line_number":76,"context_line":"    dnses \u003d DNSNameServer.get_objects(context, name\u003dobj_utils.StringMatchingContains(\u0027obj2\u0027))"},{"line_number":77,"context_line":"    # will return list of all dns name servers from DB that has \u0027obj2\u0027 in their names"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # to update fields:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1f013ff3_509e9554","line":76,"range":{"start_line":76,"start_character":86,"end_line":76,"end_character":90},"updated":"2017-05-16 18:43:39.000000000","message":"how about using something more realistic, like \u002710.0.0.\u0027?","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"}],"neutron/db/_model_query.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                    query \u003d query.filter("},{"line_number":193,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":194,"context_line":"                elif isinstance(value, obj_utils.StringMatchingFilterObj):"},{"line_number":195,"context_line":"                    if isinstance(value, obj_utils.StringContains):"},{"line_number":196,"context_line":"                        query \u003d query.filter("},{"line_number":197,"context_line":"                            column.contains(value.contains))"},{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_39c97925","line":195,"range":{"start_line":195,"start_character":23,"end_line":195,"end_character":66},"updated":"2017-07-04 21:13:57.000000000","message":"Shouldn\u0027t this be value.is_contains?","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                    query \u003d query.filter("},{"line_number":193,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":194,"context_line":"                elif isinstance(value, obj_utils.StringMatchingFilterObj):"},{"line_number":195,"context_line":"                    if isinstance(value, obj_utils.StringContains):"},{"line_number":196,"context_line":"                        query \u003d query.filter("},{"line_number":197,"context_line":"                            column.contains(value.contains))"},{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_ea650f1f","line":195,"range":{"start_line":195,"start_character":23,"end_line":195,"end_character":66},"in_reply_to":"3f1d235d_39c97925","updated":"2017-07-06 20:16:06.000000000","message":"can be both actually, but one you said I feel is better. thanks !","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    if isinstance(value, obj_utils.StringContains):"},{"line_number":196,"context_line":"                        query \u003d query.filter("},{"line_number":197,"context_line":"                            column.contains(value.contains))"},{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"},{"line_number":199,"context_line":"                        query \u003d query.filter("},{"line_number":200,"context_line":"                            column.startswith(value.starts))"},{"line_number":201,"context_line":"                    elif isinstance(value, obj_utils.StringEnds):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_f99c210f","line":198,"range":{"start_line":198,"start_character":25,"end_line":198,"end_character":66},"updated":"2017-07-04 21:13:57.000000000","message":"Shouldn\u0027t this be value.is_starts?","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    if isinstance(value, obj_utils.StringContains):"},{"line_number":196,"context_line":"                        query \u003d query.filter("},{"line_number":197,"context_line":"                            column.contains(value.contains))"},{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"},{"line_number":199,"context_line":"                        query \u003d query.filter("},{"line_number":200,"context_line":"                            column.startswith(value.starts))"},{"line_number":201,"context_line":"                    elif isinstance(value, obj_utils.StringEnds):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_8a3c5be1","line":198,"range":{"start_line":198,"start_character":25,"end_line":198,"end_character":66},"in_reply_to":"3f1d235d_f99c210f","updated":"2017-07-06 20:16:06.000000000","message":"Done","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"},{"line_number":199,"context_line":"                        query \u003d query.filter("},{"line_number":200,"context_line":"                            column.startswith(value.starts))"},{"line_number":201,"context_line":"                    elif isinstance(value, obj_utils.StringEnds):"},{"line_number":202,"context_line":"                        query \u003d query.filter("},{"line_number":203,"context_line":"                            column.endswith(value.ends))"},{"line_number":204,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_99876db6","line":201,"range":{"start_line":201,"start_character":25,"end_line":201,"end_character":63},"updated":"2017-07-04 21:13:57.000000000","message":"houldn\u0027t this be value.is_ends?","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                    elif isinstance(value, obj_utils.StringStarts):"},{"line_number":199,"context_line":"                        query \u003d query.filter("},{"line_number":200,"context_line":"                            column.startswith(value.starts))"},{"line_number":201,"context_line":"                    elif isinstance(value, obj_utils.StringEnds):"},{"line_number":202,"context_line":"                        query \u003d query.filter("},{"line_number":203,"context_line":"                            column.endswith(value.ends))"},{"line_number":204,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_aa3957f2","line":201,"range":{"start_line":201,"start_character":25,"end_line":201,"end_character":63},"in_reply_to":"3f1d235d_99876db6","updated":"2017-07-06 20:16:06.000000000","message":"Done","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"}],"neutron/db/common_db_mixin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                            or_(*[column \u003d\u003d v for v in value]))"},{"line_number":155,"context_line":"                    else:"},{"line_number":156,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":157,"context_line":"                elif key \u003d\u003d \"string_matching_filter\":"},{"line_number":158,"context_line":"                    query \u003d query.filter(value)"},{"line_number":159,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"},{"line_number":160,"context_line":"                    # translate a filter on shared into a query against the"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_9ceec389","line":157,"updated":"2017-01-26 21:38:31.000000000","message":"I think that instead of passing sqlalchemy filter definition across the call stack, you should just pass operation definition here as is (using MatchingObj) and construct the needed sqlalchemy filter here.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                            or_(*[column \u003d\u003d v for v in value]))"},{"line_number":155,"context_line":"                    else:"},{"line_number":156,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":157,"context_line":"                elif key \u003d\u003d \"string_matching_filter\":"},{"line_number":158,"context_line":"                    query \u003d query.filter(value)"},{"line_number":159,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"},{"line_number":160,"context_line":"                    # translate a filter on shared into a query against the"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_86b5097f","line":157,"in_reply_to":"3a461143_9ceec389","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2aea42c518af87ea9c1ef34da56b5a4f59b232ad","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                        elif value.is_ends:"},{"line_number":169,"context_line":"                            query \u003d query.filter("},{"line_number":170,"context_line":"                                column.endswith(value.ends))"},{"line_number":171,"context_line":"                        else:"},{"line_number":172,"context_line":"                            raise Exception"},{"line_number":173,"context_line":"                    else:"},{"line_number":174,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":175,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_a8d239fe","line":172,"range":{"start_line":171,"start_character":24,"end_line":172,"end_character":43},"updated":"2017-02-06 21:37:11.000000000","message":"Does this else is needed?  It doesn\u0027t seem to raise an exception in the previous version","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"a3c4c5e89b9628ce1b194e95a9a8fe8a51fa11f2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                        elif value.is_ends:"},{"line_number":169,"context_line":"                            query \u003d query.filter("},{"line_number":170,"context_line":"                                column.endswith(value.ends))"},{"line_number":171,"context_line":"                        else:"},{"line_number":172,"context_line":"                            raise Exception"},{"line_number":173,"context_line":"                    else:"},{"line_number":174,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":175,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_8dc4fe92","line":172,"range":{"start_line":171,"start_character":24,"end_line":172,"end_character":43},"in_reply_to":"1a430d35_a8d239fe","updated":"2017-02-10 15:27:22.000000000","message":"Well I just added here for the sake of clarity. Now I looked at it, it is is probably not needed, as StringMatchObj has taken care of all conditions.\n\nGood catch.","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd479a9d00f14240aff62226852e96dc1be5f1ea","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                        query \u003d query.filter("},{"line_number":160,"context_line":"                            or_(*[column \u003d\u003d v for v in value]))"},{"line_number":161,"context_line":"                    elif isinstance(value, obj_utils.StringMatchingObj):"},{"line_number":162,"context_line":"                        if value.is_contains:"},{"line_number":163,"context_line":"                            query \u003d query.filter("},{"line_number":164,"context_line":"                                column.contains(value.contains))"},{"line_number":165,"context_line":"                        elif value.is_starts:"},{"line_number":166,"context_line":"                            query \u003d query.filter("},{"line_number":167,"context_line":"                                column.startswith(value.starts))"},{"line_number":168,"context_line":"                        elif value.is_ends:"},{"line_number":169,"context_line":"                            query \u003d query.filter("},{"line_number":170,"context_line":"                                column.endswith(value.ends))"},{"line_number":171,"context_line":"                    else:"},{"line_number":172,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":173,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_76e3a2a4","line":170,"range":{"start_line":162,"start_character":24,"end_line":170,"end_character":60},"updated":"2017-03-10 00:42:26.000000000","message":"if someone wants to send (contains, starts_with and end_with) only one filter will work ?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                        query \u003d query.filter("},{"line_number":160,"context_line":"                            or_(*[column \u003d\u003d v for v in value]))"},{"line_number":161,"context_line":"                    elif isinstance(value, obj_utils.StringMatchingObj):"},{"line_number":162,"context_line":"                        if value.is_contains:"},{"line_number":163,"context_line":"                            query \u003d query.filter("},{"line_number":164,"context_line":"                                column.contains(value.contains))"},{"line_number":165,"context_line":"                        elif value.is_starts:"},{"line_number":166,"context_line":"                            query \u003d query.filter("},{"line_number":167,"context_line":"                                column.startswith(value.starts))"},{"line_number":168,"context_line":"                        elif value.is_ends:"},{"line_number":169,"context_line":"                            query \u003d query.filter("},{"line_number":170,"context_line":"                                column.endswith(value.ends))"},{"line_number":171,"context_line":"                    else:"},{"line_number":172,"context_line":"                        query \u003d query.filter(column.in_(value))"},{"line_number":173,"context_line":"                elif key \u003d\u003d \u0027shared\u0027 and hasattr(model, \u0027rbac_entries\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_268eb978","line":170,"range":{"start_line":162,"start_character":24,"end_line":170,"end_character":60},"in_reply_to":"9a30ddce_76e3a2a4","updated":"2017-03-15 18:35:59.000000000","message":"Yes. The user of this class should only pass in one of the contains, starts_with, and ends_witdh parameter\nThis has been addressed in the latest PR by adding validation logic to obj_utils.StringMatchingObj","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        # do multiple equals matches"},{"line_number":127,"context_line":"                        query \u003d query.filter("},{"line_number":128,"context_line":"                            or_(*[column \u003d\u003d v for v in value]))"},{"line_number":129,"context_line":"                    elif isinstance(value, obj_utils.StringMatchingObj):"},{"line_number":130,"context_line":"                        if value.is_contains:"},{"line_number":131,"context_line":"                            query \u003d query.filter("},{"line_number":132,"context_line":"                                column.contains(value.contains))"},{"line_number":133,"context_line":"                        elif value.is_starts:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_dd426a3e","line":130,"range":{"start_line":129,"start_character":20,"end_line":130,"end_character":45},"updated":"2017-04-10 14:57:05.000000000","message":"Could instead just check for the actual StringMatchingContains type.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                        if value.is_contains:"},{"line_number":131,"context_line":"                            query \u003d query.filter("},{"line_number":132,"context_line":"                                column.contains(value.contains))"},{"line_number":133,"context_line":"                        elif value.is_starts:"},{"line_number":134,"context_line":"                            query \u003d query.filter("},{"line_number":135,"context_line":"                                column.startswith(value.starts))"},{"line_number":136,"context_line":"                        elif value.is_ends:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_bd3fa6b2","line":133,"range":{"start_line":133,"start_character":24,"end_line":133,"end_character":45},"updated":"2017-04-10 14:57:05.000000000","message":"ditto","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                        elif value.is_starts:"},{"line_number":134,"context_line":"                            query \u003d query.filter("},{"line_number":135,"context_line":"                                column.startswith(value.starts))"},{"line_number":136,"context_line":"                        elif value.is_ends:"},{"line_number":137,"context_line":"                            query \u003d query.filter("},{"line_number":138,"context_line":"                                column.endswith(value.ends))"},{"line_number":139,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_3d7dd67e","line":136,"range":{"start_line":136,"start_character":24,"end_line":136,"end_character":43},"updated":"2017-04-10 14:57:05.000000000","message":"ditto","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"}],"neutron/objects/agent.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"aa40ac47e57d0fdf1f9257b8af0cefee895db601","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if string_matching_filter is not None:"},{"line_number":125,"context_line":"            filter_kwargs[\u0027string_matching_filter\u0027] \u003d string_matching_filter"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":128,"context_line":"            db_objs \u003d obj_db_api.get_objects("},{"line_number":129,"context_line":"                context, cls.db_model, _pager\u003d_pager,"},{"line_number":130,"context_line":"                **filter_kwargs"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"            return [cls._load_object(context, db_obj) for db_obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_5dd06c1f","line":132,"range":{"start_line":127,"start_character":7,"end_line":132,"end_character":76},"updated":"2017-01-23 16:27:12.000000000","message":"this is repeated code, I guess you can use super here replace this code with just one call","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"bdb9166e4c8365887048661c0d321991cdce9393","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if string_matching_filter is not None:"},{"line_number":125,"context_line":"            filter_kwargs[\u0027string_matching_filter\u0027] \u003d string_matching_filter"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":128,"context_line":"            db_objs \u003d obj_db_api.get_objects("},{"line_number":129,"context_line":"                context, cls.db_model, _pager\u003d_pager,"},{"line_number":130,"context_line":"                **filter_kwargs"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"            return [cls._load_object(context, db_obj) for db_obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_c999b621","line":132,"range":{"start_line":127,"start_character":7,"end_line":132,"end_character":76},"in_reply_to":"5a3905b3_5dd06c1f","updated":"2017-01-25 16:59:15.000000000","message":"It has repeated part, but now I don\u0027t think it can be replaced by super(Agent, cls) yet.  There is filter validation logic in the beginning, and filter_args will be replaced by cls.modify_fields_to_db(filter_args) also, this will incur a lot of higher level code change.","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return not utils.is_agent_down(self.heartbeat_timestamp)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":84,"context_line":"                    **kwargs):"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        Overwriting get_objects to take \"LIKE\" filters"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_7c5117d8","line":83,"updated":"2017-01-26 21:38:31.000000000","message":"there is nothing Agent specific here. I would like to see this code moved into NeutronDbObject to be reused for other objects.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return not utils.is_agent_down(self.heartbeat_timestamp)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":84,"context_line":"                    **kwargs):"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        Overwriting get_objects to take \"LIKE\" filters"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a60e8589","line":83,"in_reply_to":"3a461143_7c5117d8","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            # http://docs.sqlalchemy.org/en/rel_0_9/core/sqlelement.html"},{"line_number":102,"context_line":"            # for a list of sqlalchemy supported string matching filters"},{"line_number":103,"context_line":"            string_matching_obj \u003d string_matching_filter_fields[field]"},{"line_number":104,"context_line":"            if string_matching_obj.is_contains:"},{"line_number":105,"context_line":"                string_matching_filter_list.append("},{"line_number":106,"context_line":"                    getattr(cls.db_model, field).contains("},{"line_number":107,"context_line":"                        string_matching_obj.contains))"},{"line_number":108,"context_line":"            elif string_matching_obj.is_starts:"},{"line_number":109,"context_line":"                string_matching_filter_list.append("},{"line_number":110,"context_line":"                    getattr(cls.db_model, field).startswith("},{"line_number":111,"context_line":"                        string_matching_obj.starts))"},{"line_number":112,"context_line":"            elif string_matching_obj.is_ends:"},{"line_number":113,"context_line":"                string_matching_filter_list.append("},{"line_number":114,"context_line":"                    getattr(cls.db_model, field).endswith("},{"line_number":115,"context_line":"                        string_matching_obj.ends))"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                continue"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_f9b9997a","line":115,"range":{"start_line":104,"start_character":12,"end_line":115,"end_character":50},"updated":"2017-01-26 21:38:31.000000000","message":"what\u0027s the reason to expose each of those instead of .like that should cover all cases?","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                    getattr(cls.db_model, field).endswith("},{"line_number":115,"context_line":"                        string_matching_obj.ends))"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                continue"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        string_matching_filter \u003d None"},{"line_number":120,"context_line":"        if string_matching_filter_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_99bc156e","line":117,"updated":"2017-01-26 21:38:31.000000000","message":"we should probably fail on unknown filter, not silently ignore it","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                    getattr(cls.db_model, field).endswith("},{"line_number":115,"context_line":"                        string_matching_obj.ends))"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                continue"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        string_matching_filter \u003d None"},{"line_number":120,"context_line":"        if string_matching_filter_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a1eaef71","line":117,"in_reply_to":"3a461143_99bc156e","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        string_matching_filter \u003d None"},{"line_number":120,"context_line":"        if string_matching_filter_list:"},{"line_number":121,"context_line":"            string_matching_filter \u003d or_(*string_matching_filter_list)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":124,"context_line":"        if string_matching_filter is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_1c21f34d","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":40},"updated":"2017-01-26 21:38:31.000000000","message":"why is it OR that we use here? I think we should keep it in line with other filters\u0027 behaviour, which is - requiring all filters to match.\n\nIf we need to be able to choose search strategy for some reason, let\u0027s do in a separate patch, and in base class scope too, and for all filters.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        string_matching_filter \u003d None"},{"line_number":120,"context_line":"        if string_matching_filter_list:"},{"line_number":121,"context_line":"            string_matching_filter \u003d or_(*string_matching_filter_list)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":124,"context_line":"        if string_matching_filter is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_c18c5bdc","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":40},"in_reply_to":"3a461143_1c21f34d","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":124,"context_line":"        if string_matching_filter is not None:"},{"line_number":125,"context_line":"            filter_kwargs[\u0027string_matching_filter\u0027] \u003d string_matching_filter"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":128,"context_line":"            db_objs \u003d obj_db_api.get_objects("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_5cae1b86","line":125,"range":{"start_line":125,"start_character":25,"end_line":125,"end_character":51},"updated":"2017-01-26 21:38:31.000000000","message":"I don\u0027t particularly like how you use that special name to pass the filter down the stack. Can\u0027t we enhance db_api.get_objects to accept DBStringMatchingObj and then we would not need to keep the code generating sqlalchemy operations in objects layer?","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":124,"context_line":"        if string_matching_filter is not None:"},{"line_number":125,"context_line":"            filter_kwargs[\u0027string_matching_filter\u0027] \u003d string_matching_filter"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":128,"context_line":"            db_objs \u003d obj_db_api.get_objects("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_0193c3fa","line":125,"range":{"start_line":125,"start_character":25,"end_line":125,"end_character":51},"in_reply_to":"3a461143_5cae1b86","updated":"2017-01-31 18:29:15.000000000","message":"Agreed. Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":51,"context_line":"        result \u003d super(Agent, cls).modify_fields_to_db(fields)"},{"line_number":52,"context_line":"        if (\u0027configurations\u0027 in result and"},{"line_number":53,"context_line":"                not isinstance(result[\u0027configurations\u0027],"},{"line_number":54,"context_line":"                               obj_utils.StringMatchingObj)):"},{"line_number":55,"context_line":"            # dump configuration into string, set \u0027\u0027 if empty \u0027{}\u0027"},{"line_number":56,"context_line":"            result[\u0027configurations\u0027] \u003d ("},{"line_number":57,"context_line":"                cls.filter_to_json_str(result[\u0027configurations\u0027], default\u003d\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_7dba3e0a","line":54,"range":{"start_line":53,"start_character":15,"end_line":54,"end_character":61},"updated":"2017-04-10 14:57:05.000000000","message":"ok, but it seems that you need to do the same for other types that override modify_fields_to_db? Like PortBindingBase?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"}],"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if isinstance(v, obj_utils.StringMatchingObj)"},{"line_number":441,"context_line":"        ])"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        for field in string_matching_filter_fields:"},{"line_number":444,"context_line":"            # remove string matching fields from kwargs"},{"line_number":445,"context_line":"            # as we need to call cls.modify_fields_to_db on each field"},{"line_number":446,"context_line":"            kwargs.pop(field)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_8999807b","line":443,"updated":"2017-03-06 15:00:08.000000000","message":"this logic should be applicable for other methods, like delete_objects and count. Please move it in a separate helper method and reuse from all places.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if isinstance(v, obj_utils.StringMatchingObj)"},{"line_number":441,"context_line":"        ])"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        for field in string_matching_filter_fields:"},{"line_number":444,"context_line":"            # remove string matching fields from kwargs"},{"line_number":445,"context_line":"            # as we need to call cls.modify_fields_to_db on each field"},{"line_number":446,"context_line":"            kwargs.pop(field)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_66eef123","line":443,"in_reply_to":"ba2be162_8999807b","updated":"2017-03-15 18:35:59.000000000","message":"Done.\nSince there is no special treatment for LIKE filters, the logic of this function will stay the same.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            # as we need to call cls.modify_fields_to_db on each field"},{"line_number":446,"context_line":"            kwargs.pop(field)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":449,"context_line":"        for field in string_matching_filter_fields:"},{"line_number":450,"context_line":"            filter_kwargs[field] \u003d string_matching_filter_fields[field]"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_49f6a88f","line":448,"updated":"2017-03-06 15:00:08.000000000","message":"meaning, you don\u0027t apply e.g. field renames to those LIKE filters. Isn\u0027t it a problem for objects that renamed some attributes? Will those renamed fields still work as LIKE filters?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            # as we need to call cls.modify_fields_to_db on each field"},{"line_number":446,"context_line":"            kwargs.pop(field)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        filter_kwargs \u003d cls.modify_fields_to_db(kwargs)"},{"line_number":449,"context_line":"        for field in string_matching_filter_fields:"},{"line_number":450,"context_line":"            filter_kwargs[field] \u003d string_matching_filter_fields[field]"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_86584dfc","line":448,"in_reply_to":"ba2be162_49f6a88f","updated":"2017-03-15 18:35:59.000000000","message":"Done.\nIn retrospect the LIKE filters shouldn\u0027t be treated differently.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if isinstance(value, list):"},{"line_number":493,"context_line":"            return [_dict_to_json(val) for val in value]"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if isinstance(value, list):"},{"line_number":496,"context_line":"            return [_dict_to_json(val) for val in value]"},{"line_number":497,"context_line":"        v \u003d _dict_to_json(value)"},{"line_number":498,"context_line":"        return v"},{"line_number":499,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_b9ebacae","line":496,"range":{"start_line":494,"start_character":0,"end_line":496,"end_character":56},"updated":"2017-03-24 16:55:26.000000000","message":"is it duplicated these instructions from previous lines? or what is the difference?","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if isinstance(value, list):"},{"line_number":493,"context_line":"            return [_dict_to_json(val) for val in value]"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        v \u003d _dict_to_json(value)"},{"line_number":496,"context_line":"        return v"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_5d39baa1","line":494,"updated":"2017-04-10 14:57:05.000000000","message":"spurious change","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"}],"neutron/objects/db/api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _kwargs_to_filters(**kwargs):"},{"line_number":40,"context_line":"    return {k: v if isinstance(v, list) or k \u003d\u003d \"string_matching_filter\""},{"line_number":41,"context_line":"            else [v]"},{"line_number":42,"context_line":"            for k, v in kwargs.items()}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_7c1cb7c1","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":72},"updated":"2017-01-26 21:38:31.000000000","message":"instead of this special casing, and if you would pass MatchingObj here directly, we could just check against the MatchingObj type and do what\u0027s needed.\n\nOf course, it would mean that all the logic to construct sqlalchemy query parameters would go into this module, which makes sense, since object layer is not meant to deal with sqlalchemy, it relies on db/api.py module to implement the needed storage backend features.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _kwargs_to_filters(**kwargs):"},{"line_number":40,"context_line":"    return {k: v if isinstance(v, list) or k \u003d\u003d \"string_matching_filter\""},{"line_number":41,"context_line":"            else [v]"},{"line_number":42,"context_line":"            for k, v in kwargs.items()}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_c161bb06","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":72},"in_reply_to":"3a461143_7c1cb7c1","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"}],"neutron/objects/exceptions.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd479a9d00f14240aff62226852e96dc1be5f1ea","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class NeutronDbObjectInvalidFilter(exceptions.Invalid):"},{"line_number":40,"context_line":"    message \u003d _(\"NeutronDbObject not found by model %(model)s.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NeutronPrimaryKeyMissing(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_7691e2f0","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":62},"updated":"2017-03-10 00:42:26.000000000","message":"``Filter or comparison not supported`` may be something else along the lines. \n\nWe already have DBobject not found I guess","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class NeutronDbObjectInvalidFilter(exceptions.Invalid):"},{"line_number":40,"context_line":"    message \u003d _(\"NeutronDbObject not found by model %(model)s.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NeutronPrimaryKeyMissing(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"da36d5c6_9d0ab724","line":40,"updated":"2017-03-06 15:00:08.000000000","message":"message name not reflecting the intent of the error","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class NeutronDbObjectInvalidFilter(exceptions.Invalid):"},{"line_number":40,"context_line":"    message \u003d _(\"NeutronDbObject not found by model %(model)s.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NeutronPrimaryKeyMissing(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_061b7d1c","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":62},"in_reply_to":"9a30ddce_7691e2f0","updated":"2017-03-15 18:35:59.000000000","message":"Done","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"}],"neutron/objects/utils.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f945c3987439e7c7fe3688f90eb383400666d9e1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"},{"line_number":41,"context_line":"    def is_starts(self):"},{"line_number":42,"context_line":"        return self.contains is not None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def is_ends(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_9d49f462","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":28},"updated":"2017-01-23 16:17:26.000000000","message":"self.starts","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"bdb9166e4c8365887048661c0d321991cdce9393","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"},{"line_number":41,"context_line":"    def is_starts(self):"},{"line_number":42,"context_line":"        return self.contains is not None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def is_ends(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_894b2eb0","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":28},"in_reply_to":"5a3905b3_9d49f462","updated":"2017-01-25 16:59:15.000000000","message":"Done","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f945c3987439e7c7fe3688f90eb383400666d9e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def is_ends(self):"},{"line_number":46,"context_line":"        return self.contains is not None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_bd46b04c","line":46,"range":{"start_line":46,"start_character":15,"end_line":46,"end_character":28},"updated":"2017-01-23 16:17:26.000000000","message":"self.ends","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"bdb9166e4c8365887048661c0d321991cdce9393","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def is_ends(self):"},{"line_number":46,"context_line":"        return self.contains is not None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_e9d032cc","line":46,"range":{"start_line":46,"start_character":15,"end_line":46,"end_character":28},"in_reply_to":"5a3905b3_bd46b04c","updated":"2017-01-25 16:59:15.000000000","message":"Done","commit_id":"ab5e51a698ad43b5bc0dba63726b0d9403e81cbd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DBStringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_7cd757ed","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":8},"updated":"2017-01-26 21:38:31.000000000","message":"While you want to use it for DB backed objects, I think it would make sense to avoid mentioning DB here and make it agnostic to storage backend. Let base object class determine how to implement the requested filter.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DBStringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_0106631f","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":8},"in_reply_to":"3a461143_7cd757ed","updated":"2017-01-31 18:29:15.000000000","message":"Done","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_1cf9f380","line":34,"range":{"start_line":32,"start_character":8,"end_line":34,"end_character":24},"updated":"2017-01-26 21:38:31.000000000","message":"I don\u0027t know why we need all of those and not just \u0027like\u0027","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_5bd3f3d4","line":34,"range":{"start_line":32,"start_character":8,"end_line":34,"end_character":24},"in_reply_to":"3a461143_1cf9f380","updated":"2017-01-31 18:29:15.000000000","message":"This is because \"contains\", \"starts\",  and \"ends\" will translate to different sqlalchemy matching expression (filters) respectively:\n\nLIKE %(match_str)%,  LIKE (match_str)%, and LIKE match_str)%\n\nand see sqlalchemy\u0027s doc:\n\nhttp://docs.sqlalchemy.org/en/latest/core/metadata.html\n\nFor detail","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2aea42c518af87ea9c1ef34da56b5a4f59b232ad","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_28d4891e","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":23},"updated":"2017-02-06 21:37:11.000000000","message":"What about moving this class to common_types module?","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"a3c4c5e89b9628ce1b194e95a9a8fe8a51fa11f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_ed001aad","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":23},"in_reply_to":"1a430d35_28d4891e","updated":"2017-02-10 15:27:22.000000000","message":"Well, this is really not an object field \"Type\" though, it is a \"filter\" type used for object/DB integration.  So I think staying here is fine.","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2aea42c518af87ea9c1ef34da56b5a4f59b232ad","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_a8cf997d","line":34,"range":{"start_line":30,"start_character":23,"end_line":34,"end_character":24},"updated":"2017-02-06 21:37:11.000000000","message":"Shouldn\u0027t be better to only have two args(Value and type)? In that way we can allow add more things in the future","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"a3c4c5e89b9628ce1b194e95a9a8fe8a51fa11f2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_8d95de41","line":34,"range":{"start_line":30,"start_character":23,"end_line":34,"end_character":24},"in_reply_to":"1a430d35_a8cf997d","updated":"2017-02-10 15:27:22.000000000","message":"This is BC for supporting some DB sql statements:\n\"LIKE %S%\"  \u003d\u003d \u003e contains\n\"LIKE %S\"   \u003d\u003d\u003e  ends\n\"LIKE S%\"  \u003d\u003d starts\nThis is aiming to taking care of all these string \"LIKE\" statement cases.","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_491ea80c","line":28,"updated":"2017-03-06 15:00:08.000000000","message":"At this point, you could as well have three separate types for each check. You implement polymorphism with three largely separate attributes, there is no reason to keep them all bundled in a single class.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_668d1131","line":28,"in_reply_to":"ba2be162_491ea80c","updated":"2017-03-15 18:35:59.000000000","message":"Done","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_29ea54db","line":32,"updated":"2017-03-06 15:00:08.000000000","message":"nit: maybe it\u0027s just me but I love classes calling to super() in __init__. That allows for multiple inheritance whenever we will need it.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, contains\u003dNone, starts\u003dNone, ends\u003dNone):"},{"line_number":31,"context_line":"        # Add some validation logic here ?"},{"line_number":32,"context_line":"        self.contains \u003d contains"},{"line_number":33,"context_line":"        self.starts \u003d starts"},{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_46881523","line":32,"in_reply_to":"ba2be162_29ea54db","updated":"2017-03-15 18:35:59.000000000","message":"Done","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"96b27afbb9934d886e5189648a592be888cb2cb0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"},{"line_number":38,"context_line":"        return self.contains is not None"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_696b6c85","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":11},"updated":"2017-03-06 15:00:08.000000000","message":"what is is_ prefix supposed to indicate?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.ends \u003d ends"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @property"},{"line_number":37,"context_line":"    def is_contains(self):"},{"line_number":38,"context_line":"        return self.contains is not None"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_4fde696e","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":11},"in_reply_to":"ba2be162_696b6c85","updated":"2017-03-15 18:35:59.000000000","message":"It\u0027s really a shortcut for indicating which sqlalchemy api it will use when doing the real database query.\nSee neutron/db/common_db_mixin.py for details","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class StringMatchingContains(StringMatchingObj):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, matching_string):"},{"line_number":46,"context_line":"        # Add some validation logic here ?"},{"line_number":47,"context_line":"        self.contains \u003d matching_string"},{"line_number":48,"context_line":"        super(StringMatchingContains, self).__init__()"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_391e7cba","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":42},"updated":"2017-03-24 16:55:26.000000000","message":"is this a TODO?, what kind of validation logic should be there?","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, matching_string):"},{"line_number":46,"context_line":"        # Add some validation logic here ?"},{"line_number":47,"context_line":"        self.contains \u003d matching_string"},{"line_number":48,"context_line":"        super(StringMatchingContains, self).__init__()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class StringMatchingStarts(StringMatchingObj):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_b9bccc69","line":48,"range":{"start_line":47,"start_character":8,"end_line":48,"end_character":54},"updated":"2017-03-24 16:55:26.000000000","message":"Usually the order is different, the first call of the constructor is to call the parent class constructor as long as you don\u0027t need to do something before\n\n    super(StringMatchingContains, self).__init__()\n    self.contains \u003d matching_string","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class StringMatchingStarts(StringMatchingObj):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, matching_string):"},{"line_number":54,"context_line":"        # Add some validation logic here ?"},{"line_number":55,"context_line":"        self.starts \u003d matching_string"},{"line_number":56,"context_line":"        super(StringMatchingStarts, self).__init__()"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_b9872cd8","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":42},"updated":"2017-03-24 16:55:26.000000000","message":"ditto line 46","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class StringMatchingEnds(StringMatchingObj):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, matching_string):"},{"line_number":62,"context_line":"        # Add some validation logic here ?"},{"line_number":63,"context_line":"        self.ends \u003d matching_string"},{"line_number":64,"context_line":"        super(StringMatchingEnds, self).__init__()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_7969a423","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":42},"updated":"2017-03-24 16:55:26.000000000","message":"ditto line 46","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    return result"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_624e1d98","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":23},"updated":"2017-04-10 14:57:05.000000000","message":"StringFilter?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class StringMatchingObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"},{"line_number":32,"context_line":"        return hasattr(self, \"contains\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"},{"line_number":36,"context_line":"        return hasattr(self, \"starts\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def is_ends(self):"},{"line_number":40,"context_line":"        return hasattr(self, \"ends\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class StringMatchingContains(StringMatchingObj):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_42c559f0","line":40,"range":{"start_line":30,"start_character":4,"end_line":40,"end_character":36},"updated":"2017-04-10 14:57:05.000000000","message":"those can be killed now and replaced with isinstance(...) calls for new types.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return hasattr(self, \"ends\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class StringMatchingContains(StringMatchingObj):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, matching_string):"},{"line_number":46,"context_line":"        super(StringMatchingContains, self).__init__()"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_226b75f1","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":28},"updated":"2017-04-10 14:57:05.000000000","message":"maybe just StringContains is still a clear name, and more dense.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.contains \u003d matching_string"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class StringMatchingStarts(StringMatchingObj):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, matching_string):"},{"line_number":53,"context_line":"        super(StringMatchingStarts, self).__init__()"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_c275e9cc","line":50,"range":{"start_line":50,"start_character":6,"end_line":50,"end_character":26},"updated":"2017-04-10 14:57:05.000000000","message":"StringStarts?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.starts \u003d matching_string"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class StringMatchingEnds(StringMatchingObj):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, matching_string):"},{"line_number":60,"context_line":"        super(StringMatchingEnds, self).__init__()"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_a27e65ac","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":25},"updated":"2017-04-10 14:57:05.000000000","message":"StringEnds?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"},{"line_number":32,"context_line":"        return hasattr(self, \"contains\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_f9b5417f","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":22},"updated":"2017-07-04 21:13:57.000000000","message":"Recently, in another review, another reviewer brought this up: https://hynek.me/articles/hasattr/. Should it be considered here?","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"},{"line_number":32,"context_line":"        return hasattr(self, \"contains\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_14d51744","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":22},"in_reply_to":"3f1d235d_f9b5417f","updated":"2017-07-06 20:16:06.000000000","message":"Done","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"},{"line_number":36,"context_line":"        return hasattr(self, \"starts\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def is_ends(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_b9b34998","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":22},"updated":"2017-07-04 21:13:57.000000000","message":"Ditto","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"},{"line_number":36,"context_line":"        return hasattr(self, \"starts\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def is_ends(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_74c32b8a","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":22},"in_reply_to":"3f1d235d_b9b34998","updated":"2017-07-06 20:16:06.000000000","message":"Done","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3edbb550442ba445f49a771840ea9d3b0b05e153","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def is_ends(self):"},{"line_number":40,"context_line":"        return hasattr(self, \"ends\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class StringContains(StringMatchingFilterObj):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_79a93122","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":22},"updated":"2017-07-04 21:13:57.000000000","message":"Ditto","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2bf1fa32dea6d4c4a0dfa7a2a08f812efb7f001a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def is_ends(self):"},{"line_number":40,"context_line":"        return hasattr(self, \"ends\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class StringContains(StringMatchingFilterObj):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_54beeffe","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":22},"in_reply_to":"3f1d235d_79a93122","updated":"2017-07-06 20:16:06.000000000","message":"Done","commit_id":"1509323ea40d1a65b31960f1559d17b1294a07a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04bf6d51c9638ff86b67c2467b70eb560faeddec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class StringMatchingFilterObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"},{"line_number":32,"context_line":"        return True if getattr(self, \"contains\") else False"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_5b6ef4c9","line":32,"range":{"start_line":31,"start_character":26,"end_line":32,"end_character":59},"updated":"2017-07-07 16:02:03.000000000","message":"nit: -\u003e return bool(getattr(self, \u0027contains\u0027))","commit_id":"1dd597cffb6e58607c2fd1a44b5e833e5fbe79fc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c8600e7a08f5d22df5354f0d164e2b6e7774aa9d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class StringMatchingFilterObj(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def is_contains(self):"},{"line_number":32,"context_line":"        return True if getattr(self, \"contains\") else False"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def is_starts(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_fb9dc057","line":32,"range":{"start_line":31,"start_character":26,"end_line":32,"end_character":59},"in_reply_to":"3f1d235d_5b6ef4c9","updated":"2017-07-07 16:14:20.000000000","message":"Done","commit_id":"1dd597cffb6e58607c2fd1a44b5e833e5fbe79fc"}],"neutron/tests/unit/objects/test_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        obj_contains \u003d agent.Agent.get_objects("},{"line_number":86,"context_line":"            self.context,"},{"line_number":87,"context_line":"            resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":88,"context_line":"        )[0]"},{"line_number":89,"context_line":"        self.assertEqual(versions, obj_contains.resource_versions)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_fca2674a","line":87,"updated":"2017-01-26 21:38:31.000000000","message":"so what\u0027s the actual in-tree use case here? Do we really do such filtering based on json anywhere in plugin code?","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        obj_contains \u003d agent.Agent.get_objects("},{"line_number":86,"context_line":"            self.context,"},{"line_number":87,"context_line":"            resource_versions\u003dobj_utils.DBStringMatchingObj(\u0027obj2\u0027)"},{"line_number":88,"context_line":"        )[0]"},{"line_number":89,"context_line":"        self.assertEqual(versions, obj_contains.resource_versions)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_9e3f09b3","line":87,"in_reply_to":"3a461143_fca2674a","updated":"2017-01-31 18:29:15.000000000","message":"Done.\nThis has been moved to base test level","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7a4eb3627f1a83589f1613ac1c533287cd8e2fd1","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        obj_starts \u003d agent.Agent.get_objects("},{"line_number":92,"context_line":"            self.context,"},{"line_number":93,"context_line":"            resource_versions\u003dobj_utils.DBStringMatchingObj(starts\u003d\u0027{\u0027)"},{"line_number":94,"context_line":"        )[0]"},{"line_number":95,"context_line":"        self.assertEqual(versions, obj_starts.resource_versions)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_1f148542","line":93,"range":{"start_line":93,"start_character":30,"end_line":93,"end_character":71},"updated":"2017-01-26 21:38:31.000000000","message":"I think you break a layer of code abstraction here. This is because you assume that storage backend stores the resource_versions field as json blob, which may or may not be the case.\n\nI don\u0027t think that searching for braces is a valid use case. I would suggest that instead of that, (and assuming the use case is even valid/real), we would make base object class to know how to match against filters that are of dict type. If that means that we would need to construct complex matching operation AND/OR do post-fetch filtering, so be it. It\u0027s a reasonable price to keep persistence implementation details isolated from object user.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"d764669d1877db301896fa642180d7604681d76c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        obj_starts \u003d agent.Agent.get_objects("},{"line_number":92,"context_line":"            self.context,"},{"line_number":93,"context_line":"            resource_versions\u003dobj_utils.DBStringMatchingObj(starts\u003d\u0027{\u0027)"},{"line_number":94,"context_line":"        )[0]"},{"line_number":95,"context_line":"        self.assertEqual(versions, obj_starts.resource_versions)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_fe764da2","line":93,"range":{"start_line":93,"start_character":30,"end_line":93,"end_character":71},"in_reply_to":"3a461143_1f148542","updated":"2017-01-31 18:29:15.000000000","message":"Done. This has been moved to base test level.","commit_id":"2772f72e1e36758fac6467e468d67515a0a8094b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        db_fields \u003d obj.modify_fields_to_db(obj)"},{"line_number":76,"context_line":"        self.assertIsNone(db_fields[\u0027resource_versions\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_like_selectors(self):"},{"line_number":79,"context_line":"        obj \u003d self.objs[0]"},{"line_number":80,"context_line":"        versions \u003d {\u0027obj1\u0027: \u0027ver1\u0027, \u0027obj2\u0027: 1.1}"},{"line_number":81,"context_line":"        obj.resource_versions \u003d versions"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_541c6569","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":27},"updated":"2017-03-24 16:55:26.000000000","message":"I would like to also consider those cases where nothing is retrieved.","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6d541c10720eb21f53d63813555b4771e1a61007","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        db_fields \u003d obj.modify_fields_to_db(obj)"},{"line_number":76,"context_line":"        self.assertIsNone(db_fields[\u0027resource_versions\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_like_selectors(self):"},{"line_number":79,"context_line":"        obj \u003d self.objs[0]"},{"line_number":80,"context_line":"        versions \u003d {\u0027obj1\u0027: \u0027ver1\u0027, \u0027obj2\u0027: 1.1}"},{"line_number":81,"context_line":"        obj.resource_versions \u003d versions"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_0a9f91b4","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":27},"in_reply_to":"ffe62b97_541c6569","updated":"2017-03-28 19:47:59.000000000","message":"why does the patch that adds LIKE support touches agent test?","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        obj_contains \u003d agent.Agent.get_objects("},{"line_number":85,"context_line":"            self.context,"},{"line_number":86,"context_line":"            resource_versions\u003dobj_utils.StringMatchingContains(\u0027obj2\u0027)"},{"line_number":87,"context_line":"        )[0]"},{"line_number":88,"context_line":"        self.assertEqual(versions, obj_contains.resource_versions)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        obj_starts \u003d agent.Agent.get_objects("}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_f91ed46e","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":12},"updated":"2017-03-24 16:55:26.000000000","message":"I don\u0027t think that you have to restrict the number of rows retrieved by this query.","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        db_fields \u003d obj.modify_fields_to_db(obj)"},{"line_number":76,"context_line":"        self.assertIsNone(db_fields[\u0027resource_versions\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_like_selectors(self):"},{"line_number":79,"context_line":"        obj \u003d self.objs[0]"},{"line_number":80,"context_line":"        versions \u003d {\u0027obj1\u0027: \u0027ver1\u0027, \u0027obj2\u0027: 1.1}"},{"line_number":81,"context_line":"        obj.resource_versions \u003d versions"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_7d16bef3","line":78,"updated":"2017-04-10 14:57:05.000000000","message":"I would actually prefer if the patch doesn\u0027t mess with agents specifically here. You add a generic support for LIKE filters for objects, so it makes sense to write a generic test in test_base.py for that.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_like_selectors(self):"},{"line_number":79,"context_line":"        obj \u003d self.objs[0]"},{"line_number":80,"context_line":"        versions \u003d {\u0027obj1\u0027: \u0027ver1\u0027, \u0027obj2\u0027: 1.1}"},{"line_number":81,"context_line":"        obj.resource_versions \u003d versions"},{"line_number":82,"context_line":"        obj.create()"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_7d4fde33","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":47},"updated":"2017-04-10 14:57:05.000000000","message":"are both formats even supported? Why do we set them with different types? Is it inherent to what you try to test here?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":23821,"name":"Prince Nana Owusu Boateng","email":"prince.a.owusu.boateng@intel.com","username":"nanaboat"},"change_message_id":"9b25c554af456e99ffc9e2ca1244522afefb521f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        obj_contains \u003d agent.Agent.get_objects("},{"line_number":85,"context_line":"            self.context,"},{"line_number":86,"context_line":"            resource_versions\u003dobj_utils.StringMatchingContains(\u0027obj2\u0027)"},{"line_number":87,"context_line":"        )[0]"},{"line_number":88,"context_line":"        self.assertEqual(versions, obj_contains.resource_versions)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        obj_starts \u003d agent.Agent.get_objects("}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_0d5599c6","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":12},"updated":"2017-04-06 21:34:01.000000000","message":"Is there a reason for restricting the number of rows to output. I think since its a string matching, why not output all rows that match/contain string?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":23821,"name":"Prince Nana Owusu Boateng","email":"prince.a.owusu.boateng@intel.com","username":"nanaboat"},"change_message_id":"9b25c554af456e99ffc9e2ca1244522afefb521f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        obj_starts \u003d agent.Agent.get_objects("},{"line_number":91,"context_line":"            self.context,"},{"line_number":92,"context_line":"            resource_versions\u003dobj_utils.StringMatchingStarts(\u0027{\u0027)"},{"line_number":93,"context_line":"        )[0]"},{"line_number":94,"context_line":"        self.assertEqual(versions, obj_starts.resource_versions)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        obj_ends \u003d agent.Agent.get_objects("}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_cd60d1a8","line":93,"range":{"start_line":93,"start_character":9,"end_line":93,"end_character":12},"updated":"2017-04-06 21:34:01.000000000","message":"ditto","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        obj_non_exist_list \u003d agent.Agent.get_objects("},{"line_number":103,"context_line":"            self.context,"},{"line_number":104,"context_line":"            resource_versions\u003dobj_utils.StringMatchingContains(\u0027@\u0027)"},{"line_number":105,"context_line":"        )"},{"line_number":106,"context_line":"        self.assertEqual([], obj_non_exist_list)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_5d077acb","line":104,"range":{"start_line":104,"start_character":63,"end_line":104,"end_character":66},"updated":"2017-04-10 14:57:05.000000000","message":"it\u0027s not clear where we should see that @. A comment could help.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88818aeeff9a76653ec5db1d4d8c954772a193bf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        obj \u003d agent.Agent.get_object(self.context, id\u003dobj.id)"},{"line_number":50,"context_line":"        self.assertEqual(conf, obj.configurations)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_resource_versions(self):"},{"line_number":53,"context_line":"        obj \u003d self.objs[0]"},{"line_number":54,"context_line":"        versions \u003d {\u0027obj1\u0027: \u0027ver1\u0027, \u0027obj2\u0027: 1.1}"},{"line_number":55,"context_line":"        obj.resource_versions \u003d versions"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_703f5125","side":"PARENT","line":52,"updated":"2017-05-16 18:43:39.000000000","message":"why is it that you remove the test case?","commit_id":"e8e89d8a878b766c0f70bebba08e7bac62112bed"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2aea42c518af87ea9c1ef34da56b5a4f59b232ad","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                break"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if filter_string_field is None:"},{"line_number":816,"context_line":"            # No string field exist in this object, skip this test"},{"line_number":817,"context_line":"            return"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        filter_dict \u003d {"},{"line_number":820,"context_line":"            filter_string_field: obj_utils.StringMatchingObj(\"random_thing\")}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_e8e8c112","line":817,"range":{"start_line":816,"start_character":12,"end_line":817,"end_character":18},"updated":"2017-02-06 21:37:11.000000000","message":"This should use skipTest method\n\n    self.skipTest(\u0027There is no string field in this object\u0027)","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"a3c4c5e89b9628ce1b194e95a9a8fe8a51fa11f2","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                break"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if filter_string_field is None:"},{"line_number":816,"context_line":"            # No string field exist in this object, skip this test"},{"line_number":817,"context_line":"            return"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        filter_dict \u003d {"},{"line_number":820,"context_line":"            filter_string_field: obj_utils.StringMatchingObj(\"random_thing\")}"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_ad92a255","line":817,"range":{"start_line":816,"start_character":12,"end_line":817,"end_character":18},"in_reply_to":"1a430d35_e8e8c112","updated":"2017-02-10 15:27:22.000000000","message":"Done","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2aea42c518af87ea9c1ef34da56b5a4f59b232ad","unresolved":false,"context_lines":[{"line_number":816,"context_line":"            # No string field exist in this object, skip this test"},{"line_number":817,"context_line":"            return"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        filter_dict \u003d {"},{"line_number":820,"context_line":"            filter_string_field: obj_utils.StringMatchingObj(\"random_thing\")}"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        with mock.patch.object("},{"line_number":823,"context_line":"                obj_db_api, \u0027get_objects\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_6883f104","line":820,"range":{"start_line":819,"start_character":8,"end_line":820,"end_character":77},"updated":"2017-02-06 21:37:11.000000000","message":"This UT only uses \"contains\" filter, can you include other UT that ensures \"starts\" and \"ends\" works?","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"a3c4c5e89b9628ce1b194e95a9a8fe8a51fa11f2","unresolved":false,"context_lines":[{"line_number":816,"context_line":"            # No string field exist in this object, skip this test"},{"line_number":817,"context_line":"            return"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        filter_dict \u003d {"},{"line_number":820,"context_line":"            filter_string_field: obj_utils.StringMatchingObj(\"random_thing\")}"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        with mock.patch.object("},{"line_number":823,"context_line":"                obj_db_api, \u0027get_objects\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_cdc43642","line":820,"range":{"start_line":819,"start_character":8,"end_line":820,"end_character":77},"in_reply_to":"1a430d35_6883f104","updated":"2017-02-10 15:27:22.000000000","message":"Done","commit_id":"098c146e4a8a033d0d52bb469eaf0f1e200eb2a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd479a9d00f14240aff62226852e96dc1be5f1ea","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        for field in self.obj_fields:"},{"line_number":811,"context_line":"            if isinstance(field, obj_fields.StringField):"},{"line_number":812,"context_line":"                filter_string_field \u003d field"},{"line_number":813,"context_line":"                break"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if filter_string_field is None:"},{"line_number":816,"context_line":"            self.skipTest(\u0027There is no string field in this object\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_96a81679","line":813,"range":{"start_line":813,"start_character":16,"end_line":813,"end_character":21},"updated":"2017-03-10 00:42:26.000000000","message":"what if someone tries to pass like on multiple args ?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        for field in self.obj_fields:"},{"line_number":811,"context_line":"            if isinstance(field, obj_fields.StringField):"},{"line_number":812,"context_line":"                filter_string_field \u003d field"},{"line_number":813,"context_line":"                break"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if filter_string_field is None:"},{"line_number":816,"context_line":"            self.skipTest(\u0027There is no string field in this object\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_e4a3c19c","line":813,"range":{"start_line":813,"start_character":16,"end_line":813,"end_character":21},"in_reply_to":"9a30ddce_96a81679","updated":"2017-03-15 18:35:59.000000000","message":"The test meant to use the first string field of the object. It will work for multiple args.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd479a9d00f14240aff62226852e96dc1be5f1ea","unresolved":false,"context_lines":[{"line_number":833,"context_line":"        with mock.patch.object("},{"line_number":834,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":835,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":836,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":837,"context_line":"                                         **filter_dict_starts)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        filter_dict_ends \u003d {"},{"line_number":840,"context_line":"            filter_string_field: obj_utils.StringMatchingObj("},{"line_number":841,"context_line":"                ends\u003d\"random_thing\")"},{"line_number":842,"context_line":"        }"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        with mock.patch.object("},{"line_number":845,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":846,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":847,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":848,"context_line":"                                         **filter_dict_ends)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def test_delete_objects(self):"},{"line_number":851,"context_line":"        \u0027\u0027\u0027Test that delete_objects calls to underlying db_api.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_76fac244","line":848,"range":{"start_line":836,"start_character":11,"end_line":848,"end_character":60},"updated":"2017-03-10 00:42:26.000000000","message":"these tests are just calling get_objects with LIKE case shouldn\u0027t code be making some assertions as well to conform if they actually work or not ?","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b91a69cc84b8cad0ecf24fd1076259dd2cbdbb9d","unresolved":false,"context_lines":[{"line_number":833,"context_line":"        with mock.patch.object("},{"line_number":834,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":835,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":836,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":837,"context_line":"                                         **filter_dict_starts)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        filter_dict_ends \u003d {"},{"line_number":840,"context_line":"            filter_string_field: obj_utils.StringMatchingObj("},{"line_number":841,"context_line":"                ends\u003d\"random_thing\")"},{"line_number":842,"context_line":"        }"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        with mock.patch.object("},{"line_number":845,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":846,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":847,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":848,"context_line":"                                         **filter_dict_ends)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def test_delete_objects(self):"},{"line_number":851,"context_line":"        \u0027\u0027\u0027Test that delete_objects calls to underlying db_api.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a1ff146_a412a960","line":848,"range":{"start_line":836,"start_character":11,"end_line":848,"end_character":60},"in_reply_to":"9a30ddce_76fac244","updated":"2017-03-15 18:35:59.000000000","message":"Well it seems like all other tests in the same class is only calling self._test_class.get_objects without any assertions so I am really just following the convention here.\nWith that said I will add some tests in specific test case to make this test more tangible.","commit_id":"cc4dcd75ac4df385d0ea0fd088d9e7e43799a594"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ad830770f133f8c31b6fbeb7230127e33bce7313","unresolved":false,"context_lines":[{"line_number":816,"context_line":"            filter_string_field: obj_utils.StringMatchingContains("},{"line_number":817,"context_line":"                \"random_thing\")}"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"        with mock.patch.object("},{"line_number":820,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":821,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":822,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":823,"context_line":"                                         **filter_dict_contains)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"        filter_dict_starts \u003d {"},{"line_number":826,"context_line":"            filter_string_field: obj_utils.StringMatchingStarts("},{"line_number":827,"context_line":"                \"random_thing\")"},{"line_number":828,"context_line":"        }"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        with mock.patch.object("},{"line_number":831,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":832,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":833,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":834,"context_line":"                                         **filter_dict_starts)"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"        filter_dict_ends \u003d {"},{"line_number":837,"context_line":"            filter_string_field: obj_utils.StringMatchingEnds("},{"line_number":838,"context_line":"                \"random_thing\")"},{"line_number":839,"context_line":"        }"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        with mock.patch.object("},{"line_number":842,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":843,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":844,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":845,"context_line":"                                         **filter_dict_ends)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def test_delete_objects(self):"},{"line_number":848,"context_line":"        \u0027\u0027\u0027Test that delete_objects calls to underlying db_api.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_94978d91","line":845,"range":{"start_line":819,"start_character":8,"end_line":845,"end_character":60},"updated":"2017-03-24 16:55:26.000000000","message":"AFAIK, this test should validate that a NeutronDbObjectInvalidFilter exception is raised in certain cases.","commit_id":"ddd2b65fd6d9107a46c80ebdccb5a4970e5f236d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                              self._test_class.get_objects, self.context,"},{"line_number":796,"context_line":"                              fake_field\u003d\u0027xxx\u0027)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    def test_get_objects_without_validate_filters(self):"},{"line_number":799,"context_line":"        with mock.patch.object("},{"line_number":800,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":801,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":802,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":803,"context_line":"                                         **self.valid_field_filter)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"    def test_get_objects_with_string_matching_filters(self):"},{"line_number":806,"context_line":"        filter_string_field \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_9dc74265","line":803,"range":{"start_line":798,"start_character":4,"end_line":803,"end_character":67},"updated":"2017-04-10 14:57:05.000000000","message":"why have you touched this test?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    def test_get_objects_with_string_matching_filters(self):"},{"line_number":806,"context_line":"        filter_string_field \u003d None"},{"line_number":807,"context_line":"        # find the first string field to use as string matching filter"},{"line_number":808,"context_line":"        for field in self.obj_fields:"},{"line_number":809,"context_line":"            if isinstance(field, obj_fields.StringField):"},{"line_number":810,"context_line":"                filter_string_field \u003d field"},{"line_number":811,"context_line":"                break"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if filter_string_field is None:"},{"line_number":814,"context_line":"            self.skipTest(\u0027There is no string field in this object\u0027)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        filter_dict_contains \u003d {"},{"line_number":817,"context_line":"            filter_string_field: obj_utils.StringMatchingContains("}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_dd7f0a13","line":814,"range":{"start_line":808,"start_character":8,"end_line":814,"end_character":68},"updated":"2017-04-10 14:57:05.000000000","message":"(No action required) could also be:\n\nfor ...:\n    if ...:\n        filter_string_field \u003d field\n        break\nelse:\n    self.skipTest(...)","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        with mock.patch.object("},{"line_number":821,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":822,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":823,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":824,"context_line":"                                         **filter_dict_contains)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        filter_dict_starts \u003d {"},{"line_number":827,"context_line":"            filter_string_field: obj_utils.StringMatchingStarts("}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_dda4aaa8","line":824,"range":{"start_line":823,"start_character":12,"end_line":824,"end_character":64},"updated":"2017-04-10 14:57:05.000000000","message":"don\u0027t you want to validate result?","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":823,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":824,"context_line":"                                         **filter_dict_contains)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        filter_dict_starts \u003d {"},{"line_number":827,"context_line":"            filter_string_field: obj_utils.StringMatchingStarts("},{"line_number":828,"context_line":"                \"random_thing\")"},{"line_number":829,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_1db0d2dc","line":826,"updated":"2017-04-10 14:57:05.000000000","message":"I actually would suggest you split the test case into three pieces, one per type.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":846,"context_line":"                                         **filter_dict_ends)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        invalid_string_mactch_filter \u003d {"},{"line_number":849,"context_line":"            filter_string_field: obj_utils.StringMatchingContains("},{"line_number":850,"context_line":"                \"random_thing\")"},{"line_number":851,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_9dc3c238","line":848,"range":{"start_line":848,"start_character":23,"end_line":848,"end_character":29},"updated":"2017-04-10 14:57:05.000000000","message":"match","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"de40e9c5ae226f6948ce7342e66c317ab6d003ec","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            self._test_class.get_objects(self.context,"},{"line_number":846,"context_line":"                                         **filter_dict_ends)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        invalid_string_mactch_filter \u003d {"},{"line_number":849,"context_line":"            filter_string_field: obj_utils.StringMatchingContains("},{"line_number":850,"context_line":"                \"random_thing\")"},{"line_number":851,"context_line":"        }"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        with mock.patch.object("},{"line_number":854,"context_line":"                obj_db_api, \u0027get_objects\u0027,"},{"line_number":855,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":856,"context_line":"            self.assertRaises(n_exc.InvalidInput,"},{"line_number":857,"context_line":"                              self._test_class.get_objects, self.context,"},{"line_number":858,"context_line":"                              **invalid_string_mactch_filter)"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    def test_delete_objects(self):"},{"line_number":861,"context_line":"        \u0027\u0027\u0027Test that delete_objects calls to underlying db_api.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_bd3d662c","line":858,"range":{"start_line":848,"start_character":9,"end_line":858,"end_character":61},"updated":"2017-04-10 14:57:05.000000000","message":"I probably miss something but how is it different from Lines 816-824, and why does this one fail?\n\nActually, it seems the test is not executed, it always skips.","commit_id":"26e95aff9bac4052b8effc94cce0efa9143fe422"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bcc599d85f09762bd6fd07e57d4880b16d031386","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    def _prep_string_field(self):"},{"line_number":810,"context_line":"        self.filter_string_field \u003d None"},{"line_number":811,"context_line":"        # find the first string field to use as string matching filter"},{"line_number":812,"context_line":"        for field in self.obj_fields:"},{"line_number":813,"context_line":"            if isinstance(field, obj_fields.StringField):"},{"line_number":814,"context_line":"                self.filter_string_field \u003d field"},{"line_number":815,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_034a4c54","line":812,"range":{"start_line":812,"start_character":8,"end_line":812,"end_character":37},"updated":"2017-06-20 21:34:36.000000000","message":"self.obj_fields is a list of dictionary and each element is a dictionary? it will skip tests for all","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f68d2d18557ef678db8119f197f294cd32a3a855","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":830,"context_line":"            res \u003d self._test_class.get_objects(self.context,"},{"line_number":831,"context_line":"                                               **filter_dict_contains)"},{"line_number":832,"context_line":"            self.assertEqual(res, [])"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    def test_get_objects_with_string_matching_filters_starts(self):"},{"line_number":835,"context_line":"        self._prep_string_field()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_f0c7e111","line":832,"updated":"2017-05-16 18:44:36.000000000","message":"Also seems like pep8 job fails because of incorrect order of arguments here.","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88818aeeff9a76653ec5db1d4d8c954772a193bf","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                side_effect\u003dself.fake_get_objects):"},{"line_number":860,"context_line":"            res \u003d self._test_class.get_objects(self.context,"},{"line_number":861,"context_line":"                                               **filter_dict_ends)"},{"line_number":862,"context_line":"            self.assertEqual(res, [])"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    def test_delete_objects(self):"},{"line_number":865,"context_line":"        \u0027\u0027\u0027Test that delete_objects calls to underlying db_api.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_90865ddb","line":862,"updated":"2017-05-16 18:43:39.000000000","message":"we also need tests that would validate that if there are matching resources, they will be returned.","commit_id":"02494944176d402bdab48bb756b278d2cccd50bb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5138ba11d27f807320c972451d919b4b72ef9ac2","unresolved":false,"context_lines":[{"line_number":840,"context_line":"    def _prep_string_field(self):"},{"line_number":841,"context_line":"        self.filter_string_field \u003d None"},{"line_number":842,"context_line":"        # find the first string field to use as string matching filter"},{"line_number":843,"context_line":"        for field in self.obj_fields[0]:"},{"line_number":844,"context_line":"            if isinstance(field, str):"},{"line_number":845,"context_line":"                self.filter_string_field \u003d field"},{"line_number":846,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_58e041cd","line":843,"range":{"start_line":843,"start_character":21,"end_line":843,"end_character":39},"updated":"2017-06-28 23:28:13.000000000","message":"changed this as self.obj_fields was list of dictionaries","commit_id":"da59a2461376fb04470b4caa8664b58d87d6d37e"}]}
