)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0f8ce2c6ff40f90b5c24c84c3566fe4b7fe4ae64","unresolved":false,"context_lines":[{"line_number":10,"context_line":"can inherit policy attached to network. This patch adds"},{"line_number":11,"context_line":"field \"network_qos_policy_id\" to port fields to show users"},{"line_number":12,"context_line":"what QoS policy attached to network is affecting current port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Reedip \u003creedip14@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: Ibd3a614a33f057e14f35f5eecad9fd80b0ba2c2c"},{"line_number":16,"context_line":"Closes-Bug: #1649517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f201791_f18c16d8","line":13,"updated":"2017-06-27 07:29:32.000000000","message":"I think that DocImpact is necessary here as You are changing values returned from API","commit_id":"f38dcdf65cfa3406798f2dc2fad0538115e14cc9"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"67538198431f8be25e58d5bd3c141b92f4eea6ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"field \"network_qos_policy_id\" to port fields to show users"},{"line_number":12,"context_line":"what QoS policy attached to network is affecting current port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Ports created on a network also inherit the network\u0027s QoS policies,"},{"line_number":16,"context_line":"which will now be displayed with the port\u0027s QoS policies."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"7f287b81_55aba573","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2017-08-30 14:59:45.000000000","message":"If we think there are neutron/doc/** impacts, why not just include them with this patch?\n\n\nThe APIImpact should generate an auto-bug which we can then use to update the neutron-lib api-ref.","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a6819d63366339f8d8a02d2dbbd0ca9f6711cb5d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"field \"network_qos_policy_id\" to port fields to show users"},{"line_number":12,"context_line":"what QoS policy attached to network is affecting current port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Ports created on a network also inherit the network\u0027s QoS policies,"},{"line_number":16,"context_line":"which will now be displayed with the port\u0027s QoS policies."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"7f287b81_688115c3","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"7f287b81_55aba573","updated":"2017-08-31 04:42:30.000000000","message":"Isnt the paragraph from Line#15 including the docimpact changes?","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7cf2d0506c97c3a0423e2a68c9107e6e0f82c1c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"field \"network_qos_policy_id\" to port fields to show users"},{"line_number":12,"context_line":"what QoS policy attached to network is affecting current port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Ports created on a network also inherit the network\u0027s QoS policies,"},{"line_number":16,"context_line":"which will now be displayed with the port\u0027s QoS policies."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"7f287b81_b71aaa6c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"7f287b81_688115c3","updated":"2017-08-31 17:34:40.000000000","message":"Not sure we are on the same page here.\nWhen we use DocImpact and APIImpact a neutron bug is auto-created to track the doc work that needs to be done.\n\nIMO the APIImpact is warranted here; we need to update the api-ref in neutron-lib once this merges to reflect the API extension change.\nHowever DocImpact indicates (generally) that something needs to be updated in neutron/docs/**, for example contributor internals.\n\n\nMy point is; for the latter why not just include the neutron/doc/** changes herein and remove the DocImpact tag (leaving the APIImpact tag).\n\n\nIn either case it\u0027s fine, I was just curious why folks didn\u0027t just include the doc changes right in their patch rather than autogen a doc defect with  DocImpact and cache the work for later.","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"216acdd6dcbef027f4ba0f1c066c1b0cf2f900cc","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Reedip \u003creedip14@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Ibd3a614a33f057e14f35f5eecad9fd80b0ba2c2c"},{"line_number":18,"context_line":"Closes-Bug: #1649517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"3f4b6375_43f0cbfe","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"updated":"2017-10-24 14:27:54.000000000","message":"Anyway, it seems that the rfe proposal is not approved by drivers team.","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9362364a4a415bbccd357b7a077b2ef3acabe266","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Reedip \u003creedip14@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Ibd3a614a33f057e14f35f5eecad9fd80b0ba2c2c"},{"line_number":18,"context_line":"Closes-Bug: #1649517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"3f4b6375_b8ea05d5","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"in_reply_to":"3f4b6375_43f0cbfe","updated":"2017-10-24 17:37:47.000000000","message":"So, should I remove it or ???","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"62242b9af46a57ddb0f23725a354618146e5c687","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Reedip \u003creedip14@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Ibd3a614a33f057e14f35f5eecad9fd80b0ba2c2c"},{"line_number":18,"context_line":"Closes-Bug: #1649517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"3f4b6375_55be2fb4","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"in_reply_to":"3f4b6375_b8ea05d5","updated":"2017-10-25 01:28:53.000000000","message":"You should access drivers team so that the team triage this feature in drivers team meeting.","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"}],"doc/source/admin/config-qos.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"702bd90377172c57e2a1e688e18b7d5556085590","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Ports created on a network can also inherit the network\u0027s QoS policies, if the "},{"line_number":301,"context_line":"extension ``qos_network_policy_id`` is enabled in the network nodes, under the"},{"line_number":302,"context_line":"``[ml2]`` section."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":305,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5f2577a7_95f4365d","line":302,"updated":"2017-09-10 08:08:43.000000000","message":"@David: yes, Your understanding is correct :)","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e160e36a3befbcdbd12850b1499ff5588fb71c7","unresolved":false,"context_lines":[{"line_number":297,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":298,"context_line":"policy application."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Ports created on a network can also inherit the network\u0027s QoS policies, if the "},{"line_number":301,"context_line":"extension ``qos_network_policy_id`` is enabled in the network nodes, under the"},{"line_number":302,"context_line":"``[ml2]`` section."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":305,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7f287b81_5e48d3ca","line":302,"range":{"start_line":300,"start_character":0,"end_line":302,"end_character":18},"updated":"2017-09-06 10:09:40.000000000","message":"I don\u0027t think this section is worded correctly.\nIt implies that without this patch ports don\u0027t inherit the qos_policy from the network, which the paragraph before contradicts.\n\nFrom my understanding this patch adds a new field to neutron ports that show the qos_policy_id that is attached to the network the ports are attached to.","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":298,"context_line":"policy application."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Ports created on a network can also inherit the network\u0027s QoS policies, if the "},{"line_number":301,"context_line":"extension ``qos_network_policy_id`` is enabled in the network nodes, under the"},{"line_number":302,"context_line":"``[ml2]`` section."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":305,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5f2577a7_44e3bd06","line":302,"range":{"start_line":300,"start_character":0,"end_line":302,"end_character":18},"in_reply_to":"7f287b81_5e48d3ca","updated":"2017-09-10 15:42:55.000000000","message":"Done","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"236b907d869f6df2a2e3ffd051b4335fc8ca1989","unresolved":false,"context_lines":[{"line_number":297,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":298,"context_line":"policy application."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Ports created on a network also inherit the network\u0027s QoS policies, and the networks\u0027"},{"line_number":301,"context_line":"QoS policies are visible if the extension ``qos-network-policy-id`` is enabled in the"},{"line_number":302,"context_line":"network nodes, under the ``[ml2]`` section."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":305,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":34,"id":"5f2577a7_3c4c269d","line":302,"range":{"start_line":300,"start_character":0,"end_line":302,"end_character":43},"updated":"2017-09-12 12:32:30.000000000","message":"This paragraph repeats some things said in the previous paragraph, I\u0027d recommend changing it to this:\n\"By also enabling the extension \u0027\u0027qos-network-policy-id\u0027\u0027 the QoS policy active on the network will also be visible from the compute port.\"","commit_id":"f61b2c6edb7f03bf40a8b038c7d9da0a18ab7a85"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"216acdd6dcbef027f4ba0f1c066c1b0cf2f900cc","unresolved":false,"context_lines":[{"line_number":304,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":305,"context_line":"policy application."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"By also enabling the extension ``qos-network-policy-id`` under the ``[ml2]`` section,"},{"line_number":308,"context_line":"the QoS policy active on the network will also be visible from the compute port."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":311,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":37,"id":"3f4b6375_2d44a073","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":80},"updated":"2017-10-24 14:27:54.000000000","message":"How do we enable the extension in ml2 config section? Do you mean extension_drivers?","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9362364a4a415bbccd357b7a077b2ef3acabe266","unresolved":false,"context_lines":[{"line_number":304,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":305,"context_line":"policy application."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"By also enabling the extension ``qos-network-policy-id`` under the ``[ml2]`` section,"},{"line_number":308,"context_line":"the QoS policy active on the network will also be visible from the compute port."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"In order to attach a QoS policy to a network, update an existing"},{"line_number":311,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":37,"id":"3f4b6375_38b855e3","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":80},"in_reply_to":"3f4b6375_2d44a073","updated":"2017-10-24 17:37:47.000000000","message":"Hmm , maybe it can be modified a bit","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"91e3d1dbcaa73b5c177d7ad8478a752b1c8f3417","unresolved":false,"context_lines":[{"line_number":304,"context_line":"owned ports like DHCP and internal router ports are excluded from network"},{"line_number":305,"context_line":"policy application."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"By enabling the extension ``qos-network-policy-id`` under the ``[ml2]`` section as an"},{"line_number":308,"context_line":"extension driver, the QoS policy active on the network will also be visible from the "},{"line_number":309,"context_line":"compute port."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"In order to attach a QoS policy to a network, update an existing"}],"source_content_type":"text/x-rst","patch_set":38,"id":"3f4b6375_1502f76f","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":17},"updated":"2017-10-25 01:33:23.000000000","message":"Is this independent extension driver? If so, we must set \"qos-network-policy-id\" like the following? \n\n [ml2]\n extension_drivers \u003d port_security, qos, qos-network-policy-id","commit_id":"6ef0349274c248108120b360994ed972b742ca33"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"91e3d1dbcaa73b5c177d7ad8478a752b1c8f3417","unresolved":false,"context_lines":[{"line_number":305,"context_line":"policy application."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"By enabling the extension ``qos-network-policy-id`` under the ``[ml2]`` section as an"},{"line_number":308,"context_line":"extension driver, the QoS policy active on the network will also be visible from the "},{"line_number":309,"context_line":"compute port."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"In order to attach a QoS policy to a network, update an existing"}],"source_content_type":"text/x-rst","patch_set":38,"id":"3f4b6375_b54563b6","line":308,"range":{"start_line":308,"start_character":84,"end_line":308,"end_character":85},"updated":"2017-10-25 01:33:23.000000000","message":"Remove extra space.","commit_id":"6ef0349274c248108120b360994ed972b742ca33"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b81e5550b42e1faf8edbf80b0b071d2c0d940a8a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"policy application."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"By enabling the extension ``qos-network-policy-id`` under the ``[ml2]`` section as an"},{"line_number":308,"context_line":"extension driver, the QoS policy active on the network will also be visible from the "},{"line_number":309,"context_line":"compute port."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"In order to attach a QoS policy to a network, update an existing"}],"source_content_type":"text/x-rst","patch_set":38,"id":"3f4b6375_f6298836","line":308,"range":{"start_line":308,"start_character":84,"end_line":308,"end_character":85},"in_reply_to":"3f4b6375_b54563b6","updated":"2017-10-25 19:39:43.000000000","message":"Hirofumi is right. IMHO this info is not necessary here. This extension will be loaded always with qos service plugin. \nWe should add proper info to api-ref document in neutron-lib repo.","commit_id":"6ef0349274c248108120b360994ed972b742ca33"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5435210d2695e1c8e2b6fa7f67ca88e806b61af","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        except tenacity.RetryError:"},{"line_number":339,"context_line":"            # if ovs fails to find datapath_id then something is likely to be"},{"line_number":340,"context_line":"            # broken here"},{"line_number":341,"context_line":"            LOG.exception(_(\"Timed out retrieving datapath_id on bridge %s.\"),"},{"line_number":342,"context_line":"                          self.br_name)"},{"line_number":343,"context_line":"            raise RuntimeError(\u0027No datapath_id on bridge %s\u0027 % self.br_name)"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_7d918f52","line":341,"updated":"2017-06-12 08:08:19.000000000","message":"Why this change? I think it\u0027s unrelated","commit_id":"463eb5fa40b050b23158ee97dfcf39fd48c4791b"}],"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5435210d2695e1c8e2b6fa7f67ca88e806b61af","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    if (self.namespace and not"},{"line_number":483,"context_line":"                            ip_lib.IPWrapper().netns.exists(self.namespace)):"},{"line_number":484,"context_line":"                        ctx.reraise \u003d False"},{"line_number":485,"context_line":"                        LOG.error(_(\"Namespace %s was deleted during IPTables \""},{"line_number":486,"context_line":"                                  \"operations.\"), self.namespace)"},{"line_number":487,"context_line":"                        return []"},{"line_number":488,"context_line":"            all_lines \u003d save_output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_fd8ebf2c","line":485,"range":{"start_line":485,"start_character":33,"end_line":485,"end_character":36},"updated":"2017-06-12 08:08:19.000000000","message":"ditto","commit_id":"463eb5fa40b050b23158ee97dfcf39fd48c4791b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    if (self.namespace and not"},{"line_number":483,"context_line":"                            ip_lib.IPWrapper().netns.exists(self.namespace)):"},{"line_number":484,"context_line":"                        ctx.reraise \u003d False"},{"line_number":485,"context_line":"                        LOG.error(_(\"Namespace %s was deleted during IPTables \""},{"line_number":486,"context_line":"                                  \"operations.\"), self.namespace)"},{"line_number":487,"context_line":"                        return []"},{"line_number":488,"context_line":"            all_lines \u003d save_output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_03f6cd90","line":485,"updated":"2017-06-20 21:21:45.000000000","message":"AFAIK log messages shouldn\u0027t be translated anymore","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"}],"neutron/core_extensions/qos.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e2a8596a8791cf328ba25ed19a359194b471b70f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":106,"context_line":"            return {"},{"line_number":107,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":108,"context_line":"                qos_consts.NET_QOS_POLICY_ID: self._get_network_policy_id("},{"line_number":109,"context_line":"                    resource.network_id)"},{"line_number":110,"context_line":"            }"},{"line_number":111,"context_line":"        return {qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_e67e8dad","line":108,"updated":"2017-01-13 10:56:11.000000000","message":"I\u0027m now thinking that this could be confusing to users.\n\nThey\u0027ll see both policies, but the one that has precedence is the port policy... hmmm\nthoughts?","commit_id":"99423cb2101d7e7a431499dc6ea0c9270450c5bb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e8d783ff3057f48f095038e164ec4229c381d046","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":106,"context_line":"            return {"},{"line_number":107,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":108,"context_line":"                qos_consts.NET_QOS_POLICY_ID: self._get_network_policy_id("},{"line_number":109,"context_line":"                    resource.network_id)"},{"line_number":110,"context_line":"            }"},{"line_number":111,"context_line":"        return {qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_43113e5c","line":108,"in_reply_to":"5a3905b3_80c4db40","updated":"2017-02-25 10:53:11.000000000","message":"I\u0027m not sure but IMHO less confusing option would be to display: \n* no qos policy assigned - display only qos_policy with None value (like now)\n* qos policy assigned only to network - display network_qos_policy with policy id and qos_policy with None value\n* qos policy assigned to network and to port - display both, qos_policy (like now) and network_qos_policy\n* qos policy assigned only to port - display only qos_policy (like is now)\n\nWhat You think about it?","commit_id":"99423cb2101d7e7a431499dc6ea0c9270450c5bb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0fbe4d78b789cd16024e624207785f41b4379f40","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":106,"context_line":"            return {"},{"line_number":107,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":108,"context_line":"                qos_consts.NET_QOS_POLICY_ID: self._get_network_policy_id("},{"line_number":109,"context_line":"                    resource.network_id)"},{"line_number":110,"context_line":"            }"},{"line_number":111,"context_line":"        return {qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_80c4db40","line":108,"in_reply_to":"7a3c09a3_e67e8dad","updated":"2017-01-19 08:57:03.000000000","message":"IMHO, there are three scenarios:\n\n- To show only port qos policy (current status)\n- To show both, port and net qos policy (this patch)\n- To show only one:\n  - port_qos\n  - If not port_qos, then net_qos (and specifying this is the net_qos policy)\n  - If not both, show nothing\n\nI think this proposal (both at the same time) is better. User should (must) know the precedence. Having both at the same time in the \"show\" parameter could be useful.","commit_id":"99423cb2101d7e7a431499dc6ea0c9270450c5bb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"37d4a1074fa20d31f7b03056fe519a9cc297ee8b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":106,"context_line":"            return {"},{"line_number":107,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":108,"context_line":"                qos_consts.NET_QOS_POLICY_ID: self._get_network_policy_id("},{"line_number":109,"context_line":"                    resource.network_id)"},{"line_number":110,"context_line":"            }"},{"line_number":111,"context_line":"        return {qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_7e71e643","line":108,"in_reply_to":"da36d5c6_43113e5c","updated":"2017-04-11 19:03:33.000000000","message":"I consider this to be a bit different.\nLet both Network qos_policy_id and port qos_policy_id exist .\nAnd we update:\n- Neither if no policy is defined\n- Network qos_policy_id if network has a policy associated with it\n- Port qos_policy_id if port has policy associated with it\n- both if both have policies which are not impacting each other.","commit_id":"99423cb2101d7e7a431499dc6ea0c9270450c5bb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb69c4ddb467601fa11944cd002774f74d32bd24","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def _get_network_policy_id(network_id):"},{"line_number":39,"context_line":"        network_policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":40,"context_line":"            context.get_admin_context(), network_id)"},{"line_number":41,"context_line":"        return network_policy[\u0027id\u0027] if network_policy else None"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_policy_obj(self, context, policy_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_b6b89210","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":39},"updated":"2017-04-12 14:56:38.000000000","message":"Go to comment in L99","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb69c4ddb467601fa11944cd002774f74d32bd24","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       {resource_type: actual_resource,"},{"line_number":97,"context_line":"                        \"%s_changes\" % resource_type: requested_resource})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def extract_fields(self, resource_type, resource):"},{"line_number":100,"context_line":"        if not self.plugin_loaded:"},{"line_number":101,"context_line":"            return {}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_595859f8","line":99,"updated":"2017-04-12 14:56:38.000000000","message":"Functions calling \"extract_fields\" are extend_network_dict and extend_port_dict. Both have \"session\" as a parameter. You should modify \"extract_fields\" to receive this DB session to avoid in L40 to get the context.\n\nBut please, try to ping Ann Taraday to confirm this. I don\u0027t know if session is enough here. Maybe you need to pass the context.","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71f828fccb1e10de4b6ebef5da49a1bf38553add","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       {resource_type: actual_resource,"},{"line_number":97,"context_line":"                        \"%s_changes\" % resource_type: requested_resource})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def extract_fields(self, resource_type, resource):"},{"line_number":100,"context_line":"        if not self.plugin_loaded:"},{"line_number":101,"context_line":"            return {}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_684e9297","line":99,"in_reply_to":"bff0334d_595859f8","updated":"2017-05-25 14:54:30.000000000","message":"I reviewed the code. You can\u0027t modify extract_fields definition, it\u0027s in CoreResourceExtension.\n\nKeep it this way.","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"073b9a436228423831381588e79aeb0d98ce69ec","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       {resource_type: actual_resource,"},{"line_number":97,"context_line":"                        \"%s_changes\" % resource_type: requested_resource})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def extract_fields(self, resource_type, resource):"},{"line_number":100,"context_line":"        if not self.plugin_loaded:"},{"line_number":101,"context_line":"            return {}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_dd4309af","line":99,"in_reply_to":"ff0f0b1f_684e9297","updated":"2017-05-26 06:30:44.000000000","message":"I guess everything is sorted out already :) \nGetting context is fine, as anyway we should get session from context.","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb69c4ddb467601fa11944cd002774f74d32bd24","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":105,"context_line":"        qos_network_id \u003d self._get_network_policy_id("},{"line_number":106,"context_line":"                    resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":107,"context_line":"        return {"},{"line_number":108,"context_line":"            qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":109,"context_line":"            qos_consts.NET_QOS_POLICY_ID: qos_network_id,"},{"line_number":110,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_90d7d54b","line":110,"range":{"start_line":107,"start_character":7,"end_line":110,"end_character":13},"updated":"2017-04-12 14:56:38.000000000","message":"This function could be called from extend_network_dict and extend_port_dict. Both functions require diferent results. NETWORK object doesn\u0027t have NET_QOS_POLICY_ID member, only PORT with this change.","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"35246b8e1ccd438139c090c0aadd61a938ea8ae1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       {resource_type: actual_resource,"},{"line_number":97,"context_line":"                        \"%s_changes\" % resource_type: requested_resource})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def extract_fields(self, resource_type, resource):"},{"line_number":100,"context_line":"        if not self.plugin_loaded:"},{"line_number":101,"context_line":"            return {}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e8e862e2","line":99,"updated":"2017-05-25 14:44:45.000000000","message":"From Rodolfo\u0027s comments in PS#2:\nFunctions calling \"extract_fields\" are extend_network_dict and extend_port_dict. Both have \"session\" as a parameter. You should modify \"extract_fields\" to receive this DB session to avoid in L40 to get the context.\nBut please, try to ping Ann Taraday to confirm this. I don\u0027t know if session is enough here. Maybe you need to pass the context.","commit_id":"780593e0343a95490364019a418ba7ad42a33298"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14b292d6521b820879412871b1bb36520419ee94","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        qos_network_id \u003d self._get_network_policy_id("},{"line_number":106,"context_line":"                    resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":107,"context_line":"        if resource_type \u003d base.PORT:"},{"line_number":108,"context_line":"            return {"},{"line_number":109,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":110,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id,"},{"line_number":111,"context_line":"                }"},{"line_number":112,"context_line":"        elif resource_type \u003d base.NETWORK:"},{"line_number":113,"context_line":"            return {"},{"line_number":114,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_b0ec1ebb","line":111,"range":{"start_line":108,"start_character":12,"end_line":111,"end_character":17},"updated":"2017-05-25 09:00:47.000000000","message":"Along with this change, you need to modify \"port\" object, to add \"network_qos_policy_id\" as a new synthetic field.","commit_id":"780593e0343a95490364019a418ba7ad42a33298"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0b45c358c04b2b819dcc12020d8d226a44544db4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        qos_network_id \u003d self._get_network_policy_id("},{"line_number":106,"context_line":"                    resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":107,"context_line":"        if resource_type \u003d base.PORT:"},{"line_number":108,"context_line":"            return {"},{"line_number":109,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":110,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id,"},{"line_number":111,"context_line":"                }"},{"line_number":112,"context_line":"        elif resource_type \u003d base.NETWORK:"},{"line_number":113,"context_line":"            return {"},{"line_number":114,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_4333b762","line":111,"range":{"start_line":108,"start_character":12,"end_line":111,"end_character":17},"in_reply_to":"ff0f0b1f_b0ec1ebb","updated":"2017-05-25 10:51:33.000000000","message":"Actually you are right, there is no need to modify the port object. The port dict will be extended with this new info and then sent to the OpenStack client.","commit_id":"780593e0343a95490364019a418ba7ad42a33298"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        binding \u003d resource[\u0027qos_policy_binding\u0027]"},{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        qos_network_id \u003d self._get_network_policy_id("},{"line_number":118,"context_line":"            resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":119,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":120,"context_line":"            return {"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_23278915","line":117,"updated":"2017-06-20 21:21:45.000000000","message":"IMO You should look for qos_network_id only if resource_type is PORT.\nOtherwise it\u0027s unnecessary call to db","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e211c929837fdf570bb7bf13f0ba1b4daa22155","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id, }"},{"line_number":123,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"},{"line_number":124,"context_line":"            return {"},{"line_number":125,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id, }"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_c8cd1f32","line":122,"range":{"start_line":122,"start_character":60,"end_line":122,"end_character":61},"updated":"2017-06-24 08:29:53.000000000","message":"nit: is this comma needed here?","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4d2aa6f2f66ccfdcb6791085620cd38ff19f960d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id, }"},{"line_number":123,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"},{"line_number":124,"context_line":"            return {"},{"line_number":125,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id, }"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_3debaadc","line":122,"range":{"start_line":122,"start_character":60,"end_line":122,"end_character":61},"in_reply_to":"5f201791_c8cd1f32","updated":"2017-06-26 03:12:31.000000000","message":"JFI : Comma may be useful in source code change management tools in a python dict/list, otherwise it is useless. :)","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e211c929837fdf570bb7bf13f0ba1b4daa22155","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id, }"},{"line_number":123,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"},{"line_number":124,"context_line":"            return {"},{"line_number":125,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id, }"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_a8ce632a","line":125,"range":{"start_line":125,"start_character":55,"end_line":125,"end_character":56},"updated":"2017-06-24 08:29:53.000000000","message":"nit: is this comma needed here?","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a0076bae89eb79697c8817e3eadb7e7e88178b43","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_b6e8f8e1","line":119,"range":{"start_line":119,"start_character":36,"end_line":119,"end_character":67},"updated":"2017-06-26 07:12:23.000000000","message":"L117 had check the resource_type.","commit_id":"b404944ace5743dfce297d33ded0d804cc6f9c44"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7003a63f359d0f04c4f0ed0e3761c06362f13f28","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_0753f440","line":119,"range":{"start_line":119,"start_character":36,"end_line":119,"end_character":67},"in_reply_to":"5f201791_b6e8f8e1","updated":"2017-06-26 09:09:50.000000000","message":"Done","commit_id":"b404944ace5743dfce297d33ded0d804cc6f9c44"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a0076bae89eb79697c8817e3eadb7e7e88178b43","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                resource.network_id) if resource_type \u003d\u003d base.PORT else None"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"},{"line_number":123,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_f696703e","line":120,"updated":"2017-06-26 07:12:23.000000000","message":"I think it is not good to coupling this block in qos extension.","commit_id":"b404944ace5743dfce297d33ded0d804cc6f9c44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37964916f2f1d62207bf0bf567104143e170dbe0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return self._plugin_loaded"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def _get_network_policy_id(network_id):"},{"line_number":38,"context_line":"        network_policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":39,"context_line":"            context.get_admin_context(), network_id)"},{"line_number":40,"context_line":"        return network_policy[\u0027id\u0027] if network_policy else None"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_b96ea92c","line":37,"updated":"2017-07-04 20:59:27.000000000","message":"You should check py27 tests results and mock this method in some tests because now those tests are failing without this mock probably","commit_id":"03a3e8f90e8ffeb9a8c82e48622150c64beae238"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17268b174f8a140a7213c6425d93d1b302f3493b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                binding[\u0027network_id\u0027])"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_80082dd9","line":119,"updated":"2017-08-01 17:51:22.000000000","message":"You should handle case that binding is None, see L116 and qos_policy_id\nNow some unit tests are failing because of that","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13054697b8b5b8c16b7f3b09f2b044bb39a2f165","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                binding[\u0027network_id\u0027])"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf3e73b7_056940bd","line":119,"in_reply_to":"df3967d1_227ccab3","updated":"2017-08-05 05:34:58.000000000","message":"Doesnt it depend on the API ?\nIf the extended API uses the network-id, it should be reflected here in the extract_fields, right?","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"65a4904755b353755e80b76878068a46445b0f3b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            qos_network_id \u003d self._get_network_policy_id("},{"line_number":119,"context_line":"                binding[\u0027network_id\u0027])"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: qos_network_id}"}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_227ccab3","line":119,"in_reply_to":"df3967d1_80082dd9","updated":"2017-08-02 13:13:49.000000000","message":"Reedip, be careful with this.\n\nIf the resource_type is PORT, the \"qos_policy_binding\" you have is \"QosPortPolicyBinding\". In this object (you have a dict of this object), there is no \"network_id\", only \"qos_policy_id\" AND \"port_id\".\n\nRelated to comment in https://review.openstack.org/#/c/419642/18/neutron/tests/unit/core_extensions/test_qos.py","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ae1bd9d0d16f2ef91704e9eec8b5b0fa64ea42e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        binding \u003d resource[\u0027qos_policy_binding\u0027]"},{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            net_id \u003d binding.get(\u0027network_id\u0027, None)"},{"line_number":119,"context_line":"            if net_id:"},{"line_number":120,"context_line":"                qos_network_id \u003d self._get_network_policy_id(net_id)"},{"line_number":121,"context_line":"                return {"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_45986869","line":118,"updated":"2017-08-05 07:01:51.000000000","message":"nit: None is default value and it\u0027s not necessary to pass it here","commit_id":"dc1524cb2a8595db699ff0d8b3021efef372db43"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"90a85423c024931d72066d7a1d7bca9226385535","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        binding \u003d resource[\u0027qos_policy_binding\u0027]"},{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            net_id \u003d binding.get(\u0027network_id\u0027, None)"},{"line_number":119,"context_line":"            if net_id:"},{"line_number":120,"context_line":"                qos_network_id \u003d self._get_network_policy_id(net_id)"},{"line_number":121,"context_line":"                return {"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_e53abc32","line":118,"in_reply_to":"bf3e73b7_45986869","updated":"2017-08-05 07:08:11.000000000","message":"BTW. it\u0027s still not good. I just tried Your patch on devstack and I have AttributeError here because \"\u0027NoneType\u0027 object has no attribute \u0027get\u0027\". So You have to check if binding isn\u0027t None and only then try to get network_id from it.","commit_id":"dc1524cb2a8595db699ff0d8b3021efef372db43"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e718d212dd7ec4b6d56102c63aa3badc9cfe685b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        binding \u003d resource[\u0027qos_policy_binding\u0027]"},{"line_number":116,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":117,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":118,"context_line":"            net_id \u003d binding.get(\u0027network_id\u0027, None)"},{"line_number":119,"context_line":"            if net_id:"},{"line_number":120,"context_line":"                qos_network_id \u003d self._get_network_policy_id(net_id)"},{"line_number":121,"context_line":"                return {"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_c591f8f3","line":118,"in_reply_to":"bf3e73b7_e53abc32","updated":"2017-09-22 03:05:52.000000000","message":"Ok , got it ...","commit_id":"dc1524cb2a8595db699ff0d8b3021efef372db43"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"238d68474ab6feab4e56e28e12a8ebcd2cadd0b4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                resource[\u0027network_id\u0027])"},{"line_number":120,"context_line":"            return {"},{"line_number":121,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":122,"context_line":"                qos_consts.NET_QOS_POLICY_ID: network_qos_policy_id}"},{"line_number":123,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"},{"line_number":124,"context_line":"            return {"},{"line_number":125,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":22,"id":"bf3e73b7_fc46ce21","line":122,"updated":"2017-08-06 11:59:06.000000000","message":"so we have a change in the data returned now?\n\nhonestly i am not sure what this feature give use. seems like an overkill","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        binding \u003d resource[\u0027qos_policy_binding\u0027]"},{"line_number":118,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":119,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":120,"context_line":"            network_qos_policy_id \u003d self._get_network_policy_id("},{"line_number":121,"context_line":"                resource[\u0027network_id\u0027])"},{"line_number":122,"context_line":"            return {"},{"line_number":123,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":124,"context_line":"                qos_consts.NET_QOS_POLICY_ID: network_qos_policy_id}"},{"line_number":125,"context_line":"        elif resource_type \u003d\u003d base.NETWORK:"},{"line_number":126,"context_line":"            return {"},{"line_number":127,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id}"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_563a65e7","line":127,"range":{"start_line":119,"start_character":0,"end_line":127,"end_character":56},"updated":"2017-09-08 22:06:25.000000000","message":"Consider the following alternative. Maybe it is simpler:\n\n    fields \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id}\n    if resource_type \u003d\u003d base.PORT:\n        fields[qos_consts.NET_QOS_POLICY_ID] \u003d self._get_network_policy_id(\n            resource[\u0027network_id\u0027])\n    return fields","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e68bb4091b83f8951562b18c9493135ac668c265","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.db import api as db_api"},{"line_number":24,"context_line":"from neutron.objects.qos import policy as policy_object"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#ToDo(Reedip):On migrating to neutron-lib,change the import locations in code"},{"line_number":27,"context_line":"NET_QOS_POLICY_ID \u003d \u0027network_qos_policy_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"ff82abbf_189b99c9","line":26,"updated":"2017-11-21 09:13:50.000000000","message":"nit: s/ToDo/TODO\nmissing space after \":\"\nmissing space after \",\"","commit_id":"04a18a76401ae0bd7d0092a954a885b5acdc36c8"}],"neutron/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb69c4ddb467601fa11944cd002774f74d32bd24","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                    \u0027is_visible\u0027: True,"},{"line_number":126,"context_line":"                                    \u0027default\u0027: None,"},{"line_number":127,"context_line":"                                    \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}},"},{"line_number":128,"context_line":"              qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":129,"context_line":"                                    \u0027allow_post\u0027: False,"},{"line_number":130,"context_line":"                                    \u0027allow_put\u0027: False,"},{"line_number":131,"context_line":"                                    \u0027is_visible\u0027: True,"},{"line_number":132,"context_line":"                                    \u0027default\u0027: None}},"},{"line_number":133,"context_line":"    \u0027networks\u0027: {qos_consts.QOS_POLICY_ID: {"},{"line_number":134,"context_line":"                                    \u0027allow_post\u0027: True,"},{"line_number":135,"context_line":"                                    \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_f505f314","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":54},"updated":"2017-04-12 14:56:38.000000000","message":"The same comment made in [1] and [2]: if you are modifying the API, you need to put this in other file.\n\nPlease, check this point with Ihar.\n\n[1] https://review.openstack.org/#/c/449831/7/neutron/extensions/qos.py\n[2] https://review.openstack.org/#/c/428304/44//COMMIT_MSG","commit_id":"717124a083d605fc25a09b44a2fe2dd74844f115"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14b292d6521b820879412871b1bb36520419ee94","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                    \u0027is_visible\u0027: True,"},{"line_number":129,"context_line":"                                    \u0027default\u0027: None,"},{"line_number":130,"context_line":"                                    \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}},"},{"line_number":131,"context_line":"              qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":132,"context_line":"                                    \u0027allow_post\u0027: False,"},{"line_number":133,"context_line":"                                    \u0027allow_put\u0027: False,"},{"line_number":134,"context_line":"                                    \u0027is_visible\u0027: True,"},{"line_number":135,"context_line":"                                    \u0027default\u0027: None}},"},{"line_number":136,"context_line":"    \u0027networks\u0027: {qos_consts.QOS_POLICY_ID: {"},{"line_number":137,"context_line":"                                    \u0027allow_post\u0027: True,"},{"line_number":138,"context_line":"                                    \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_70944637","line":135,"range":{"start_line":131,"start_character":0,"end_line":135,"end_character":54},"updated":"2017-05-25 09:00:47.000000000","message":"This section is superseded by https://review.openstack.org/#/c/419642/4/neutron/extensions/qos_network_policy_id.py\n\nYou need to remove it.","commit_id":"780593e0343a95490364019a418ba7ad42a33298"}],"neutron/extensions/qos_network_policy_id.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14b292d6521b820879412871b1bb36520419ee94","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""},{"line_number":30,"context_line":"               \"which are affecting the current port\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# The list of required extensions."},{"line_number":33,"context_line":"REQUIRED_EXTENSIONS \u003d [qos.ALIAS]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_703326ac","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":25},"updated":"2017-05-25 09:00:47.000000000","message":"nit: s/are/is","commit_id":"780593e0343a95490364019a418ba7ad42a33298"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# The name of the extension."},{"line_number":23,"context_line":"NAME \u003d \"Network ID for QoS Policy\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-policy-network-id\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_635b4187","line":23,"updated":"2017-06-20 21:21:45.000000000","message":"It\u0027s more something like \"Network QoS Policy ID\"","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"NAME \u003d \"Network ID for QoS Policy\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-policy-network-id\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_e37511fc","line":26,"updated":"2017-06-20 21:21:45.000000000","message":"maybe \"qos-network-policy-id\"?","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class Qos_bw_limit_direction(api_extensions.ExtensionDescriptor):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_23554951","line":50,"updated":"2017-06-20 21:21:45.000000000","message":"This class name is probably wrong :)\nI\u0027m not sure but shouldn\u0027t class name be the same as file in which it is?","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2fea6773cb66830e90e2fd68c73812a4d5c1704d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# The name of the extension."},{"line_number":23,"context_line":"NAME \u003d \"Network QoS Policy ID\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_cf21befd","line":23,"updated":"2017-08-01 20:59:50.000000000","message":"In my opinion, this name doesn\u0027t describe what the extension does. Consider something like:\n\nPort QoS Policy ID inherited from Network\n\nGranted, it is long, but not as long as other extensions that I can see in my dev environment, for example: \n\nNeutron L3 Configurable external gateway mode","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13054697b8b5b8c16b7f3b09f2b044bb39a2f165","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# The name of the extension."},{"line_number":23,"context_line":"NAME \u003d \"Network QoS Policy ID\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""}],"source_content_type":"text/x-python","patch_set":18,"id":"bf3e73b7_854c1077","line":23,"in_reply_to":"df3967d1_cf21befd","updated":"2017-08-05 05:34:58.000000000","message":"Done","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2fea6773cb66830e90e2fd68c73812a4d5c1704d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"NAME \u003d \"Network QoS Policy ID\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_8ff05669","line":26,"updated":"2017-08-01 20:59:50.000000000","message":"If you follow my comment to L23, then this might be \n\nport-qos-policy-id-from-network\n\nwhich is not much longer than:\n\nstandard-attr-description\n\nor\n\nnetwork_availability_zone","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13054697b8b5b8c16b7f3b09f2b044bb39a2f165","unresolved":false,"context_lines":[{"line_number":23,"context_line":"NAME \u003d \"Network QoS Policy ID\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""}],"source_content_type":"text/x-python","patch_set":18,"id":"bf3e73b7_65512c0f","line":26,"in_reply_to":"df3967d1_8ff05669","updated":"2017-08-05 05:34:58.000000000","message":"Done","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2fea6773cb66830e90e2fd68c73812a4d5c1704d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""},{"line_number":30,"context_line":"               \"which is affecting the current port\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# The list of required extensions."},{"line_number":33,"context_line":"REQUIRED_EXTENSIONS \u003d [qos.ALIAS]"}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_aff8ba48","line":30,"range":{"start_line":29,"start_character":16,"end_line":30,"end_character":51},"updated":"2017-08-01 20:59:50.000000000","message":"I would rephrase this as:\n\nEnables users to see the QoS policy ID inherited by a port from its network","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13054697b8b5b8c16b7f3b09f2b044bb39a2f165","unresolved":false,"context_lines":[{"line_number":26,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The description of the extension."},{"line_number":29,"context_line":"DESCRIPTION \u003d (\"Show users the QoS policy inherited from network \""},{"line_number":30,"context_line":"               \"which is affecting the current port\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# The list of required extensions."},{"line_number":33,"context_line":"REQUIRED_EXTENSIONS \u003d [qos.ALIAS]"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf3e73b7_45562809","line":30,"range":{"start_line":29,"start_character":16,"end_line":30,"end_character":51},"in_reply_to":"df3967d1_aff8ba48","updated":"2017-08-05 05:34:58.000000000","message":"Done","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# The name of the extension."},{"line_number":23,"context_line":"NAME \u003d \"Port QoS Policy ID derived from Network\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-inherit-from-network\""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_abc14056","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":34},"updated":"2017-08-16 19:23:44.000000000","message":"I would use inherited. It matches the description below","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3259f7de739c81a52b6021ca24856c14bdd64b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# The name of the extension."},{"line_number":23,"context_line":"NAME \u003d \"Port QoS Policy ID derived from Network\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The alias of the extension."},{"line_number":26,"context_line":"ALIAS \u003d \"qos-inherit-from-network\""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_f4aba0d2","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":34},"in_reply_to":"9f436f4f_abc14056","updated":"2017-08-17 03:24:38.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"67538198431f8be25e58d5bd3c141b92f4eea6ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"7f287b81_152bdd82","updated":"2017-08-30 14:59:45.000000000","message":"This extension API definition will end up in neutron-lib right? I\u0027m guessing that\u0027s why it uses ALIAS and other globals like what we do in lib.","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a6819d63366339f8d8a02d2dbbd0ca9f6711cb5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"7f287b81_08f7318d","in_reply_to":"7f287b81_152bdd82","updated":"2017-08-31 04:42:30.000000000","message":"Yes, it should, IIUC","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"67538198431f8be25e58d5bd3c141b92f4eea6ef","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The resource attribute map for the extension."},{"line_number":39,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":40,"context_line":"    \"ports\": {"},{"line_number":41,"context_line":"        qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":42,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":43,"context_line":"            \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_15799d92","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":10},"updated":"2017-08-30 14:59:45.000000000","message":"What about just using::\n\n  neutron_lib.api.definitions.port.COLLECTION_NAME","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a6819d63366339f8d8a02d2dbbd0ca9f6711cb5d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The resource attribute map for the extension."},{"line_number":39,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":40,"context_line":"    \"ports\": {"},{"line_number":41,"context_line":"        qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":42,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":43,"context_line":"            \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_488419d3","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":10},"in_reply_to":"7f287b81_15799d92","updated":"2017-08-31 04:42:30.000000000","message":"Done","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"0eb5ee3876a2c738170d8336b54f6692781ee21f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# The resource attribute map for the extension."},{"line_number":40,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":41,"context_line":"    definitions.port.COLLECTION_NAME: {"},{"line_number":42,"context_line":"        qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":43,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":44,"context_line":"            \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_d45ad44e","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":20},"updated":"2017-08-31 17:30:22.000000000","message":"Isn\u0027t it considered bad form to import an use a package rather than just importing the module (e.g. from neutron_lib.api.defintions import port)","commit_id":"1084755b3195e225bdb6aaf9f6acdb77f52f63b0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"216acdd6dcbef027f4ba0f1c066c1b0cf2f900cc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The name of the extension."},{"line_number":24,"context_line":"NAME \u003d \"Port QoS Policy ID inherited from Network\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# The alias of the extension."},{"line_number":27,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# The description of the extension."},{"line_number":30,"context_line":"DESCRIPTION \u003d (\"Enables users to see QoS policy ID inherited by a port \""},{"line_number":31,"context_line":"               \"from its network.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# The list of required extensions."},{"line_number":34,"context_line":"REQUIRED_EXTENSIONS \u003d [qos.ALIAS]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The list of optional extensions."},{"line_number":37,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# The resource attribute map for the extension."},{"line_number":40,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":41,"context_line":"    port.COLLECTION_NAME: {"},{"line_number":42,"context_line":"        qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":43,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":44,"context_line":"            \u0027allow_put\u0027: False,"},{"line_number":45,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":46,"context_line":"            \u0027default\u0027: None}"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Qos_network_policy_id(api_extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":37,"id":"3f4b6375_502f6f8d","line":48,"range":{"start_line":23,"start_character":0,"end_line":48,"end_character":1},"updated":"2017-10-24 14:27:54.000000000","message":"This is neutron-lib\u0027s api-ref format. Did you propose it in neutron-lib? If you want to merge this patch before neutron-lib\u0027s release, you should add a TODO\u0027s comment with api-def\u0027s patch link.","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9362364a4a415bbccd357b7a077b2ef3acabe266","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The name of the extension."},{"line_number":24,"context_line":"NAME \u003d \"Port QoS Policy ID inherited from Network\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# The alias of the extension."},{"line_number":27,"context_line":"ALIAS \u003d \"qos-network-policy-id\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# The description of the extension."},{"line_number":30,"context_line":"DESCRIPTION \u003d (\"Enables users to see QoS policy ID inherited by a port \""},{"line_number":31,"context_line":"               \"from its network.\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# The list of required extensions."},{"line_number":34,"context_line":"REQUIRED_EXTENSIONS \u003d [qos.ALIAS]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The list of optional extensions."},{"line_number":37,"context_line":"OPTIONAL_EXTENSIONS \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# The resource attribute map for the extension."},{"line_number":40,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":41,"context_line":"    port.COLLECTION_NAME: {"},{"line_number":42,"context_line":"        qos_consts.NET_QOS_POLICY_ID: {"},{"line_number":43,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":44,"context_line":"            \u0027allow_put\u0027: False,"},{"line_number":45,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":46,"context_line":"            \u0027default\u0027: None}"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Qos_network_policy_id(api_extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":37,"id":"3f4b6375_187fd915","line":48,"range":{"start_line":23,"start_character":0,"end_line":48,"end_character":1},"in_reply_to":"3f4b6375_502f6f8d","updated":"2017-10-24 17:37:47.000000000","message":"No, not yet. Once this patch is merged, I will move it to Neutron-Lib.\nI will add a ToDo though","commit_id":"478b534c9e29ab6c0bbdc039bac90c8d7b81f070"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"49cf8f7768a892b20474f1f876f7e6134eb936c0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":"# ToDo(Reedip): Move the above portion to Neutron-Lib"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class Qos_network_policy_id(api_extensions.ExtensionDescriptor):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f4b6375_d5cd7f85","line":50,"updated":"2017-10-25 01:25:25.000000000","message":"pep8 says \"E302 expected 2 blank lines, found 1\"","commit_id":"6ef0349274c248108120b360994ed972b742ca33"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e68bb4091b83f8951562b18c9493135ac668c265","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027default\u0027: None}"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":"# ToDo(Reedip): Move the above portion to Neutron-Lib"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class Qos_network_policy_id(api_extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff82abbf_38a0ddf4","line":51,"updated":"2017-11-21 09:13:50.000000000","message":"nit: s/ToDo/TODO","commit_id":"04a18a76401ae0bd7d0092a954a885b5acdc36c8"}],"neutron/plugins/ml2/db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5435210d2695e1c8e2b6fa7f67ca88e806b61af","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            result[partial_id] \u003d matching[0]"},{"line_number":311,"context_line":"            continue"},{"line_number":312,"context_line":"        if len(matching) \u003c 1:"},{"line_number":313,"context_line":"            LOG.info(_(\"No ports have port_id starting with %s\"), partial_id)"},{"line_number":314,"context_line":"        elif len(matching) \u003e 1:"},{"line_number":315,"context_line":"            LOG.error(_LE(\"Multiple ports have port_id starting with %s\"),"},{"line_number":316,"context_line":"                      partial_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_7d9f4f50","line":313,"range":{"start_line":313,"start_character":21,"end_line":313,"end_character":23},"updated":"2017-06-12 08:08:19.000000000","message":"ditto","commit_id":"463eb5fa40b050b23158ee97dfcf39fd48c4791b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            result[partial_id] \u003d matching[0]"},{"line_number":311,"context_line":"            continue"},{"line_number":312,"context_line":"        if len(matching) \u003c 1:"},{"line_number":313,"context_line":"            LOG.info(_(\"No ports have port_id starting with %s\"), partial_id)"},{"line_number":314,"context_line":"        elif len(matching) \u003e 1:"},{"line_number":315,"context_line":"            LOG.error(_LE(\"Multiple ports have port_id starting with %s\"),"},{"line_number":316,"context_line":"                      partial_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_03524d68","line":313,"updated":"2017-06-20 21:21:45.000000000","message":"AFAIK log messages shouldn\u0027t be translated anymore","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e211c929837fdf570bb7bf13f0ba1b4daa22155","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        if len(matching) \u003c 1:"},{"line_number":313,"context_line":"            LOG.info(\"No ports have port_id starting with %s\", partial_id)"},{"line_number":314,"context_line":"        elif len(matching) \u003e 1:"},{"line_number":315,"context_line":"            LOG.error(\"Multiple ports have port_id starting with %s\", partial_id)"},{"line_number":316,"context_line":"    return result"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_287493fd","line":315,"updated":"2017-06-24 08:29:53.000000000","message":"this is IMHO not related to Your patch","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7be18e8fcf373c9cb406292912c91d12ab1d3334","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            LOG.info(\"No ports have port_id starting with %s\", partial_id)"},{"line_number":314,"context_line":"        elif len(matching) \u003e 1:"},{"line_number":315,"context_line":"            LOG.error(_LE("},{"line_number":316,"context_line":"                \"Multiple ports have port_id starting with %s\"), partial_id)"},{"line_number":317,"context_line":"    return result"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f201791_62fbb646","line":316,"updated":"2017-06-26 09:41:08.000000000","message":"why this change?","commit_id":"2033297037dac54b64774c4f55d4c444aa60efb6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a143e8b0c3300a1c710b71d6fc5a78c85699ce91","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            LOG.info(\"No ports have port_id starting with %s\", partial_id)"},{"line_number":314,"context_line":"        elif len(matching) \u003e 1:"},{"line_number":315,"context_line":"            LOG.error(_LE("},{"line_number":316,"context_line":"                \"Multiple ports have port_id starting with %s\"), partial_id)"},{"line_number":317,"context_line":"    return result"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f201791_fa5d1315","line":316,"in_reply_to":"5f201791_62fbb646","updated":"2017-06-27 05:44:36.000000000","message":"Thought I might get pep8 error.. :)","commit_id":"2033297037dac54b64774c4f55d4c444aa60efb6"}],"neutron/plugins/ml2/extensions/data_plane_status.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5435210d2695e1c8e2b6fa7f67ca88e806b61af","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    _supported_extension_alias \u003d \u0027data-plane-status\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def initialize(self):"},{"line_number":30,"context_line":"        LOG.info(_(\"DataPlaneStatusExtensionDriver initialization complete\"))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @property"},{"line_number":33,"context_line":"    def extension_alias(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_3da9d77a","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":19},"updated":"2017-06-12 08:08:19.000000000","message":"ditto","commit_id":"463eb5fa40b050b23158ee97dfcf39fd48c4791b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"24463eee26be24a8952a1c5341c2b920e03845f9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    _supported_extension_alias \u003d \u0027data-plane-status\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def initialize(self):"},{"line_number":30,"context_line":"        LOG.info(_(\"DataPlaneStatusExtensionDriver initialization complete\"))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @property"},{"line_number":33,"context_line":"    def extension_alias(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_c34b35ae","line":30,"updated":"2017-06-20 21:21:45.000000000","message":"AFAIK log messages shouldn\u0027t be translated anymore","commit_id":"6ecea4208026eb598184c8835e2818a9ad250a70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e211c929837fdf570bb7bf13f0ba1b4daa22155","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron_lib.api.definitions import data_plane_status as dps_lib"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.db import data_plane_status_db as dps_db"},{"line_number":20,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_88d3a7d5","line":18,"updated":"2017-06-24 08:29:53.000000000","message":"is it related somehow?","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d7031108e656eda9565fb9018fe2fe8d6a5ac53d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron_lib.api.definitions import data_plane_status as dps_lib"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.db import data_plane_status_db as dps_db"},{"line_number":20,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_3dc4ca5e","line":18,"in_reply_to":"5f201791_88d3a7d5","updated":"2017-06-26 09:09:30.000000000","message":"not anymorw","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"}],"neutron/services/qos/qos_consts.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"67538198431f8be25e58d5bd3c141b92f4eea6ef","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DSCP_MARK \u003d \"dscp_mark\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"QOS_POLICY_ID \u003d \u0027qos_policy_id\u0027"},{"line_number":32,"context_line":"NET_QOS_POLICY_ID \u003d \u0027network_qos_policy_id\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"QOS_PLUGIN \u003d \u0027qos_plugin\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_75c3418a","line":32,"updated":"2017-08-30 14:59:45.000000000","message":"Unfortunately this will conflict with I6ed379b178a2b79fd14385a1d1e87d87eb04bfb9 since these qos constants are now in lib. While I\u0027d like to ask you to put this in lib and consume it here, that would mean you\u0027d have to wait for a neutron-lib release with the new constant.\n\n\nI guess I\u0027ll take the hit here and once this merges move it into lib and rework I6ed379b178a2b79fd14385a1d1e87d87eb04bfb9","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a6819d63366339f8d8a02d2dbbd0ca9f6711cb5d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DSCP_MARK \u003d \"dscp_mark\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"QOS_POLICY_ID \u003d \u0027qos_policy_id\u0027"},{"line_number":32,"context_line":"NET_QOS_POLICY_ID \u003d \u0027network_qos_policy_id\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"QOS_PLUGIN \u003d \u0027qos_plugin\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_e81f45b4","line":32,"in_reply_to":"7f287b81_75c3418a","updated":"2017-08-31 04:42:30.000000000","message":"Ok, so once this patch merges the API Definition and the QoS Constant would be moved to neutron-lib.","commit_id":"b82a87646e676dd1fb00b143908a7e33ac1339ad"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"89807f419bcc14c167f33392cdba951194271d99","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027qos-network-policy-id\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_2504447b","line":46,"updated":"2017-08-05 07:04:19.000000000","message":"You changed alias in api extension but You forgot to change it here. It won\u0027t work like that.","commit_id":"dc1524cb2a8595db699ff0d8b3021efef372db43"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"238d68474ab6feab4e56e28e12a8ebcd2cadd0b4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027port-qos-policyid-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bf3e73b7_7c3bfe9b","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":66},"updated":"2017-08-06 11:59:06.000000000","message":"this should at least follow the format above.\nmaybe qos-inherit-from-network","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cd37d8e96b895c83c23a622dc9b9affb0f28506e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027port-qos-policyid-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bf3e73b7_f16cb09d","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":66},"in_reply_to":"bf3e73b7_7c3bfe9b","updated":"2017-08-07 03:37:32.000000000","message":"The port is inheriting the policy from the network, so maybe we can change if to qos-port-policy-from-network, if we intend to keep it in the qos-** format","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd0eea573bafb7eea430484d10fa92c38a0e4552","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027port-qos-policyid-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_c14c0ea0","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":66},"in_reply_to":"bf3e73b7_f16cb09d","updated":"2017-08-10 03:31:30.000000000","message":"Done","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"702bd90377172c57e2a1e688e18b7d5556085590","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027qos-inherit-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_b5ef3286","line":46,"updated":"2017-09-10 08:08:43.000000000","message":"Maybe \"qos-network-policy-id\" (without word \"inherit\" as it\u0027s in fact not adds any inheritance. What You think?","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e160e36a3befbcdbd12850b1499ff5588fb71c7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027qos-inherit-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"7f287b81_be48d786","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":60},"updated":"2017-09-06 10:09:40.000000000","message":"This name implies that the ports don\u0027t already inherit the policy from the network.\nA better name may be \"qos-inherit-network-id\".","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   \u0027qos-bw-limit-direction\u0027,"},{"line_number":44,"context_line":"                                   \u0027qos-default\u0027,"},{"line_number":45,"context_line":"                                   \u0027qos-rule-type-details\u0027,"},{"line_number":46,"context_line":"                                   \u0027qos-inherit-from-network\u0027]"},{"line_number":47,"context_line":"    __native_pagination_support \u003d True"},{"line_number":48,"context_line":"    __native_sorting_support \u003d True"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_e4a069a8","line":46,"in_reply_to":"5f2577a7_b5ef3286","updated":"2017-09-10 15:42:55.000000000","message":"I think that can work","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"}],"neutron/tests/contrib/hooks/api_all_extensions":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e160e36a3befbcdbd12850b1499ff5588fb71c7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",project-id\""},{"line_number":30,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",provider\""},{"line_number":31,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",qos\""},{"line_number":32,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",qos-inherit-from-network\""},{"line_number":33,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",quotas\""},{"line_number":34,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",quota_details\""},{"line_number":35,"context_line":"NETWORK_API_EXTENSIONS+\u003d\",rbac-policies\""}],"source_content_type":"application/octet-stream","patch_set":33,"id":"7f287b81_de3a83e5","line":32,"range":{"start_line":32,"start_character":26,"end_line":32,"end_character":50},"updated":"2017-09-06 10:09:40.000000000","message":"ditto on previous file.","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"fb0c59963d2802489d163652ad555a3925de17b0","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        updated_port \u003d self.admin_client.show_port(port_id)"},{"line_number":277,"context_line":"        self.assertIsNone(updated_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":280,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":281,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":282,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_f64a3653","line":279,"range":{"start_line":279,"start_character":4,"end_line":279,"end_character":69},"updated":"2017-08-10 02:00:23.000000000","message":"It\u0027s better to add a requires_ext here for the new extension.","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"21023ee45f57b07065e5d2754d0daa2a4b3337b3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.assertIsNone(updated_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":280,"context_line":"    @test.requires_ext(extension\u003d\"qos-inherit-from-network\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":282,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_50a3459f","line":280,"range":{"start_line":280,"start_character":4,"end_line":280,"end_character":79},"updated":"2017-08-10 05:08:25.000000000","message":"Please also add in L298. And add the extension in test hooks:\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/contrib/hooks/api_all_extensions","commit_id":"fb9155f54bf6199829b5c9ce2c0aee6978924939"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c08b2d42dba5870d7d35cc4b2ca5abc6f9e3d29d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.assertIsNone(updated_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":280,"context_line":"    @test.requires_ext(extension\u003d\"qos-inherit-from-network\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":282,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_93353749","line":280,"range":{"start_line":280,"start_character":4,"end_line":280,"end_character":79},"in_reply_to":"9f436f4f_50a3459f","updated":"2017-08-10 06:16:20.000000000","message":"Done","commit_id":"fb9155f54bf6199829b5c9ce2c0aee6978924939"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_2b6af018","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":68},"updated":"2017-08-16 19:23:44.000000000","message":"what is the value added of disassociating the policy from the networks in this test case?","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d6f02e230cfff7f7a6d8ff20206c03319687e77","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_98fd99b3","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":68},"in_reply_to":"9f436f4f_12e06afa","updated":"2017-08-17 14:12:29.000000000","message":"disassociating is done only to be able to remove QoS policy in teardown method. It should be done before assertions otherwise if test will fail and assertion will not be good then this policy will still be in use by network and it will not be cleaned in teardown method.","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6071699c92a4b382cf02d88ec7739cc641963d3a","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_12e06afa","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":68},"in_reply_to":"9f436f4f_146ce4cb","updated":"2017-08-17 13:13:50.000000000","message":"\u003e what is the value added of disassociating the policy from the networks in this test case?\n\nTo see in both states (with and without qos policy) the QoS assignation.\n\nIMO, the test should be:\n\n\n    policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,\n                                    description\u003d\u0027test policy\u0027,\n                                    shared\u003dTrue)\n    network \u003d self.create_network(\u0027test network\u0027,\n                                  qos_policy_id\u003dpolicy[\u0027id\u0027])\n    port \u003d self.create_port(network)\n    retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])\n\n    # Test port QoS and netQoS are policy[\u0027id\u0027]\n    self.assertEqual(policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])\n    self.assertEqual(policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])\n\n    # \u0027_disassociate_network\u0027 also tests network QoS \u003d\u003d None\n    self._disassociate_network(self.admin_client, network[\u0027id\u0027])\n\n    # Test port doesn\u0027t have any QoS policy associated.\n    retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])  \u003c-- YOU NEED TO RETRIEVE THE DATA AGAIN.\n    self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])\n    self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3d4dc805ac838c2d185aadfd80547acac5e468be","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_146ce4cb","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":68},"in_reply_to":"9f436f4f_2b6af018","updated":"2017-08-17 03:24:04.000000000","message":"Guess it just resets the network policy to None, so that the teardown is easier, isnt it?\n@Slaweq : Let me know your opinion as well","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3838580a635bf86db916f8ad1548faa34a8770b","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_7877950a","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":68},"in_reply_to":"9f436f4f_98fd99b3","updated":"2017-08-17 14:21:57.000000000","message":"Anyway, altough this could be not needed here (between L285 and L291 you can have an exception), this kind of needed actions are managed with \"self.addCleanup\", to be always sure this action is always executed.","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_4b8bf4c1","line":294,"range":{"start_line":294,"start_character":49,"end_line":294,"end_character":72},"updated":"2017-08-16 19:23:44.000000000","message":"Why not use the constant defined here: https://review.openstack.org/#/c/419642/25/neutron/services/qos/qos_consts.py@31","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3259f7de739c81a52b6021ca24856c14bdd64b9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_d4b65c3e","line":294,"range":{"start_line":294,"start_character":49,"end_line":294,"end_character":72},"in_reply_to":"9f436f4f_4b8bf4c1","updated":"2017-08-17 03:24:38.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d6f02e230cfff7f7a6d8ff20206c03319687e77","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_b8ee1deb","line":294,"range":{"start_line":294,"start_character":49,"end_line":294,"end_character":72},"in_reply_to":"9f436f4f_72ba16e2","updated":"2017-08-17 14:12:29.000000000","message":"No, it\u0027s just assertion of what was done in line 289.","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3838580a635bf86db916f8ad1548faa34a8770b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_7829d5f0","line":294,"range":{"start_line":294,"start_character":49,"end_line":294,"end_character":72},"in_reply_to":"9f436f4f_b8ee1deb","updated":"2017-08-17 14:21:57.000000000","message":"Ok, so you are not testing both states, when the network has a qos and not, only when the QoS is attached.\n\nFor sure, the disassociation is needed, but I though you wanted to test both states, with and without.","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6071699c92a4b382cf02d88ec7739cc641963d3a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_72ba16e2","line":294,"range":{"start_line":294,"start_character":49,"end_line":294,"end_character":72},"in_reply_to":"9f436f4f_d4b65c3e","updated":"2017-08-17 13:13:50.000000000","message":"This is not possible. retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027] must be None\n\nThe problem is the variable \"retrieved_port\" has old values.\n\nYou need to retrieve the port again.","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"},{"line_number":298,"context_line":"    @test.requires_ext(extension\u003d\"qos-inherit-from-network\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_0b916cf1","line":295,"range":{"start_line":295,"start_character":49,"end_line":295,"end_character":64},"updated":"2017-08-16 19:23:44.000000000","message":"Why not use the constants defined here: https://review.openstack.org/#/c/419642/25/neutron/services/qos/qos_consts.py@31?","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3259f7de739c81a52b6021ca24856c14bdd64b9","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        self.assertEqual("},{"line_number":294,"context_line":"            policy[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":295,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"},{"line_number":298,"context_line":"    @test.requires_ext(extension\u003d\"qos-inherit-from-network\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_b4b19846","line":295,"range":{"start_line":295,"start_character":49,"end_line":295,"end_character":64},"in_reply_to":"9f436f4f_0b916cf1","updated":"2017-08-17 03:24:38.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_8bcf9c27","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":43},"updated":"2017-08-16 19:23:44.000000000","message":"Same here, what is the point of this? How does it contribute to the test case?","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3d4dc805ac838c2d185aadfd80547acac5e468be","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_74a0d0f4","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":43},"in_reply_to":"9f436f4f_8bcf9c27","updated":"2017-08-17 03:24:04.000000000","message":"Similar to Line#272, and the explanation given in Line#291","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_eb8bc8bc","line":316,"range":{"start_line":316,"start_character":51,"end_line":316,"end_character":74},"updated":"2017-08-16 19:23:44.000000000","message":"Why not use the constants defined here: https://review.openstack.org/#/c/419642/25/neutron/services/qos/qos_consts.py@31?","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7d6f02e230cfff7f7a6d8ff20206c03319687e77","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_38b46df2","line":316,"range":{"start_line":316,"start_character":51,"end_line":316,"end_character":74},"in_reply_to":"9f436f4f_12ae2a98","updated":"2017-08-17 14:12:29.000000000","message":"again, those tests are done like:\n\n    get_tested_values()\n    clean_network()\n    make_assertions()","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6071699c92a4b382cf02d88ec7739cc641963d3a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_12ae2a98","line":316,"range":{"start_line":316,"start_character":51,"end_line":316,"end_character":74},"in_reply_to":"9f436f4f_94869465","updated":"2017-08-17 13:13:50.000000000","message":"This is incorrect. You need to retrieve the port data after L313","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3259f7de739c81a52b6021ca24856c14bdd64b9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self._disassociate_port(port[\u0027id\u0027])"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_94869465","line":316,"range":{"start_line":316,"start_character":51,"end_line":316,"end_character":74},"in_reply_to":"9f436f4f_eb8bc8bc","updated":"2017-08-17 03:24:38.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":321,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_abc380ec","line":318,"range":{"start_line":318,"start_character":52,"end_line":318,"end_character":66},"updated":"2017-08-16 19:23:44.000000000","message":"Why not use the constants defined here: https://review.openstack.org/#/c/419642/25/neutron/services/qos/qos_consts.py@31?","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6071699c92a4b382cf02d88ec7739cc641963d3a","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":321,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_f2928658","line":318,"range":{"start_line":318,"start_character":52,"end_line":318,"end_character":66},"in_reply_to":"9f436f4f_7489f072","updated":"2017-08-17 13:13:50.000000000","message":"ditto","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3259f7de739c81a52b6021ca24856c14bdd64b9","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":321,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_7489f072","line":318,"range":{"start_line":318,"start_character":52,"end_line":318,"end_character":66},"in_reply_to":"9f436f4f_abc380ec","updated":"2017-08-17 03:24:38.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cff1503ebec3512cc95eaa2294f9c05e814a8642","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual("},{"line_number":316,"context_line":"            policy_1[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027network_qos_policy_id\u0027])"},{"line_number":317,"context_line":"        self.assertEqual("},{"line_number":318,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][\u0027qos_policy_id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":321,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9f436f4f_f2a2504b","line":318,"range":{"start_line":318,"start_character":52,"end_line":318,"end_character":66},"in_reply_to":"9f436f4f_f2928658","updated":"2017-08-19 04:57:23.000000000","message":"Same as Slawek answered earlier :)","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        self.assertEqual("},{"line_number":287,"context_line":"            policy[\u0027id\u0027], retrieved_port["},{"line_number":288,"context_line":"                \u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])"},{"line_number":289,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_395eaae6","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":54},"updated":"2017-09-08 22:06:25.000000000","message":"Wouldn\u0027t this be clearer / nicer:\n\n    self.assertEqual(policy[\u0027id\u0027],\n                     retrieved_port[\u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        self.assertEqual("},{"line_number":287,"context_line":"            policy[\u0027id\u0027], retrieved_port["},{"line_number":288,"context_line":"                \u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])"},{"line_number":289,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_04749534","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":54},"in_reply_to":"5f2577a7_395eaae6","updated":"2017-09-10 15:42:55.000000000","message":"It would be nicer, yes , but wont make a big differebce....","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        retrieved_port \u003d self.admin_client.show_port(port[\u0027id\u0027])"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        self.assertEqual("},{"line_number":307,"context_line":"            policy_1[\u0027id\u0027], retrieved_port["},{"line_number":308,"context_line":"                \u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])"},{"line_number":309,"context_line":"        self.assertEqual("},{"line_number":310,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_d901e6b1","line":308,"range":{"start_line":306,"start_character":0,"end_line":308,"end_character":54},"updated":"2017-09-08 22:06:25.000000000","message":"Wouldn\u0027t this be clearer / nicer:\n\n    self.assertEqual(policy_1[\u0027id\u0027],\n                     retrieved_port[\u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.assertEqual("},{"line_number":307,"context_line":"            policy_1[\u0027id\u0027], retrieved_port["},{"line_number":308,"context_line":"                \u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])"},{"line_number":309,"context_line":"        self.assertEqual("},{"line_number":310,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":313,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_99d23e34","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":77},"updated":"2017-09-08 22:06:25.000000000","message":"I would do:\n\n    self.assertEqual(policy_2[\u0027id\u0027],\n                     retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.assertEqual("},{"line_number":307,"context_line":"            policy_1[\u0027id\u0027], retrieved_port["},{"line_number":308,"context_line":"                \u0027port\u0027][qos_consts.NET_QOS_POLICY_ID])"},{"line_number":309,"context_line":"        self.assertEqual("},{"line_number":310,"context_line":"            policy_2[\u0027id\u0027], retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @decorators.idempotent_id(\u002798fcd95e-84cf-4746-860e-44692e674f2e\u0027)"},{"line_number":313,"context_line":"    def test_policy_association_with_port_shared_policy(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_a498216a","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":77},"in_reply_to":"5f2577a7_99d23e34","updated":"2017-09-10 15:42:55.000000000","message":"This works, I am leaving this, but fixed the other 2","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"6a1d43960619537b3ccec918a3cec8e4ca4a6f92","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":275,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":276,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":277,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":278,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f515b1d_c03ddfdd","line":275,"range":{"start_line":275,"start_character":5,"end_line":275,"end_character":9},"updated":"2017-09-27 09:11:01.000000000","message":"This is hasn\u0027t been imported.","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"89a79551d7e167e2e3507b0b8048f6a825c872c7","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":275,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":276,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":277,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":278,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"5f4e5783_88bc0e6a","line":275,"range":{"start_line":275,"start_character":5,"end_line":275,"end_character":9},"in_reply_to":"5f4e5783_4ce63347","updated":"2017-10-11 02:38:21.000000000","message":"oh, thanks ... , the issue has been resolved now","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bd7824158eefd281654b882ade08e4876bb6f08b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":275,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":276,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":277,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":278,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"5f4e5783_4ce63347","line":275,"range":{"start_line":275,"start_character":5,"end_line":275,"end_character":9},"in_reply_to":"7f515b1d_39de2511","updated":"2017-10-10 20:08:06.000000000","message":"When I rebased this patch it looks that \"test\" module is not imported anymore from tempest. Patch I79a9c3033fb38780808e02f34966280aa9591bc8 switch to use tempest.common.utils.requires_ext instead of tempest.test.requires_ext and this was only place where \"test.requires_ext\" was still used.","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17b15990b47af4ebfa3048a27f76edade82b4a8e","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":275,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":276,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":277,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":278,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f515b1d_39de2511","line":275,"range":{"start_line":275,"start_character":5,"end_line":275,"end_character":9},"in_reply_to":"7f515b1d_b9957542","updated":"2017-10-09 09:30:21.000000000","message":"Pep8 is throwing an error saying it isn\u0027t, but it looks like it is being imported:\nhttp://logs.openstack.org/42/419642/35/check/gate-neutron-pep8-ubuntu-xenial/3435725/console.html#_2017-09-27_07_00_44_567050","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a3a7823eced187006ca33975d2ca5094c7943a72","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00277f6d0efd-1dd7-47f5-af8d-399b12b62590\u0027)"},{"line_number":275,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":276,"context_line":"    def test_policy_inherited_from_network_association_with_port(self):"},{"line_number":277,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":278,"context_line":"                                        description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f515b1d_b9957542","line":275,"range":{"start_line":275,"start_character":5,"end_line":275,"end_character":9},"in_reply_to":"7f515b1d_c03ddfdd","updated":"2017-10-09 09:24:56.000000000","message":"Not sure what you mean ..\nI think it is imported (.??.)","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"6a1d43960619537b3ccec918a3cec8e4ca4a6f92","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        self.assertIsNone(retrieved_port[\u0027port\u0027][qos_consts.QOS_POLICY_ID])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"},{"line_number":291,"context_line":"    @test.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":292,"context_line":"    def test_policies_association_with_port(self):"},{"line_number":293,"context_line":"        policy_1 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":294,"context_line":"                                          description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f515b1d_4029ef98","line":291,"range":{"start_line":291,"start_character":5,"end_line":291,"end_character":9},"updated":"2017-09-27 09:11:01.000000000","message":"ditto","commit_id":"c4c90f8c2bf3ca8238743ffb44c1328983276457"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7571e10bafa133edeeb571752937920c26e28a9a","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"},{"line_number":280,"context_line":"    @utils.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policies_association_with_port(self):"},{"line_number":282,"context_line":"        policy_1 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                          description\u003d\u0027test policy\u0027,"},{"line_number":284,"context_line":"                                          shared\u003dTrue)"},{"line_number":285,"context_line":"        policy_2 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"5f4e5783_53df7039","line":282,"range":{"start_line":282,"start_character":48,"end_line":282,"end_character":59},"updated":"2017-10-16 04:09:38.000000000","message":"nit: test-policy-1","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176291268a8df2adde725a77b796d9673fa6ec2b","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    @decorators.idempotent_id(\u0027d93f7523-652e-43f5-9413-020833eb1c68\u0027)"},{"line_number":280,"context_line":"    @utils.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policies_association_with_port(self):"},{"line_number":282,"context_line":"        policy_1 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                          description\u003d\u0027test policy\u0027,"},{"line_number":284,"context_line":"                                          shared\u003dTrue)"},{"line_number":285,"context_line":"        policy_2 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"5f4e5783_8c3487df","line":282,"range":{"start_line":282,"start_character":48,"end_line":282,"end_character":59},"in_reply_to":"5f4e5783_53df7039","updated":"2017-10-17 04:10:28.000000000","message":"I think its ok :)","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7571e10bafa133edeeb571752937920c26e28a9a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    @utils.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policies_association_with_port(self):"},{"line_number":282,"context_line":"        policy_1 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                          description\u003d\u0027test policy\u0027,"},{"line_number":284,"context_line":"                                          shared\u003dTrue)"},{"line_number":285,"context_line":"        policy_2 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":286,"context_line":"                                          description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"5f4e5783_33e874e0","line":283,"range":{"start_line":283,"start_character":55,"end_line":283,"end_character":66},"updated":"2017-10-16 04:09:38.000000000","message":"nit: test policy 1","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176291268a8df2adde725a77b796d9673fa6ec2b","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    @utils.requires_ext(extension\u003d\"qos-network-policy-id\", service\u003d\"network\")"},{"line_number":281,"context_line":"    def test_policies_association_with_port(self):"},{"line_number":282,"context_line":"        policy_1 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":283,"context_line":"                                          description\u003d\u0027test policy\u0027,"},{"line_number":284,"context_line":"                                          shared\u003dTrue)"},{"line_number":285,"context_line":"        policy_2 \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":286,"context_line":"                                          description\u003d\u0027test policy\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"5f4e5783_6c2f0b88","line":283,"range":{"start_line":283,"start_character":55,"end_line":283,"end_character":66},"in_reply_to":"5f4e5783_33e874e0","updated":"2017-10-17 04:10:28.000000000","message":"I think its ok :)","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e39981b431147479fb79a2b5a49130b35c3f98fd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":16,"context_line":"import neutron.core_extensions.qos as qos_api_consts"},{"line_number":17,"context_line":"from tempest.common import utils"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_ce3170ef","line":16,"updated":"2017-11-03 11:40:32.000000000","message":"it should be moved just above L25\nBTW. if makes pep8 test fails. Why You need to import it here?","commit_id":"3ca20d924c1260c9a1899711f794b5128e9b2da4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13f7321852f8a283ddc84be296d6d957232db27c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":16,"context_line":"import neutron.core_extensions.qos as qos_api_consts"},{"line_number":17,"context_line":"from tempest.common import utils"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_90f13c98","line":16,"in_reply_to":"3f4b6375_ce3170ef","updated":"2017-12-11 08:30:10.000000000","message":"I was trying to import the constant now that qos_const file has been removed.","commit_id":"3ca20d924c1260c9a1899711f794b5128e9b2da4"}],"neutron/tests/unit/core_extensions/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37964916f2f1d62207bf0bf567104143e170dbe0","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def _test_extract_fields_for_port(self, qos_policy_id):"},{"line_number":313,"context_line":"        with self._mock_plugin_loaded(True), mock.patch.object("},{"line_number":314,"context_line":"                 qos_core.QosCoreResourceExtension, \"_get_network_policy_id\","},{"line_number":315,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027) :"},{"line_number":316,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":317,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id))"},{"line_number":318,"context_line":"            self.assertEqual({qos_consts.QOS_POLICY_ID: qos_policy_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_39085990","line":315,"range":{"start_line":315,"start_character":44,"end_line":315,"end_character":45},"updated":"2017-07-04 20:59:27.000000000","message":"pep8 is crying because of this :)","commit_id":"03a3e8f90e8ffeb9a8c82e48622150c64beae238"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37964916f2f1d62207bf0bf567104143e170dbe0","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":317,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id))"},{"line_number":318,"context_line":"            self.assertEqual({qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":319,"context_line":"                              \u0027network_qos_policy_id\u0027: \u0027fake_net_id\u0027}, fields)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_extract_fields_no_port_policy(self):"},{"line_number":322,"context_line":"        self._test_extract_fields_for_port(None)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_79d8111d","line":319,"updated":"2017-07-04 20:59:27.000000000","message":"You should use constant instead of \"network_qos_policy_id\" string here","commit_id":"03a3e8f90e8ffeb9a8c82e48622150c64beae238"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"65a4904755b353755e80b76878068a46445b0f3b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_test_dbdata(qos_policy_id):"},{"line_number":29,"context_line":"    return {\u0027id\u0027: None, \u0027qos_policy_binding\u0027: {\u0027policy_id\u0027: qos_policy_id,"},{"line_number":30,"context_line":"                                               \u0027network_id\u0027: \u0027fake_net_id\u0027}}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class QosCoreResourceExtensionTestCase(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_a2eafaa8","line":30,"range":{"start_line":30,"start_character":47,"end_line":30,"end_character":75},"updated":"2017-08-02 13:13:49.000000000","message":"This is not correct, but maybe you should create another patch to submit the solution.\n\n\"_get_test_dbdata\" is being called from \"_test_extract_fields_for_network\" and \"_test_extract_fields_for_port\", but in both cases the result is different.\n\nFor \"_test_extract_fields_for_port\" the result should be:\n\n\u0027qos_policy_binding\u0027:\n  {\u0027policy_id\u0027: qos_policy_id,\n   \u0027port_id\u0027: \u0027fake_port_id\u0027}","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17268b174f8a140a7213c6425d93d1b302f3493b","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def _test_extract_fields_for_port(self, qos_policy_id):"},{"line_number":313,"context_line":"        with self._mock_plugin_loaded(True), mock.patch.object("},{"line_number":314,"context_line":"                 qos_core.QosCoreResourceExtension, \"_get_network_policy_id\","},{"line_number":315,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027) :"},{"line_number":316,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":317,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id))"},{"line_number":318,"context_line":"            self.assertEqual({"}],"source_content_type":"text/x-python","patch_set":18,"id":"df3967d1_acab2d1b","line":315,"range":{"start_line":315,"start_character":44,"end_line":315,"end_character":45},"updated":"2017-08-01 17:51:22.000000000","message":"this makes pep8 tests unhappy","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"fb0c59963d2802489d163652ad555a3925de17b0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_data \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: None,"},{"line_number":31,"context_line":"        \u0027qos_policy_binding\u0027: {\u0027policy_id\u0027: qos_policy_id,"},{"line_number":32,"context_line":"                               \u0027port_id\u0027: \u0027fake_port_id\u0027}}"},{"line_number":33,"context_line":"    if port:"},{"line_number":34,"context_line":"        db_data[\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027"},{"line_number":35,"context_line":"    return db_data"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_f60236b4","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":57},"updated":"2017-08-10 02:00:23.000000000","message":"I think this change will mislead us, if resource type is network, qos_policy_binding does not have port_id filed.","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd0eea573bafb7eea430484d10fa92c38a0e4552","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_data \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: None,"},{"line_number":31,"context_line":"        \u0027qos_policy_binding\u0027: {\u0027policy_id\u0027: qos_policy_id,"},{"line_number":32,"context_line":"                               \u0027port_id\u0027: \u0027fake_port_id\u0027}}"},{"line_number":33,"context_line":"    if port:"},{"line_number":34,"context_line":"        db_data[\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027"},{"line_number":35,"context_line":"    return db_data"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_41db7eec","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":57},"in_reply_to":"9f436f4f_f60236b4","updated":"2017-08-10 03:31:30.000000000","message":"Got it :\nhttps://github.com/openstack/neutron/blob/8718d5c2b6dd98e987185df7d6a5953ea8f1d34a/neutron/db/qos/models.py#L38","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"fb0c59963d2802489d163652ad555a3925de17b0","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                 qos_core.QosCoreResourceExtension, \"_get_network_policy_id\","},{"line_number":320,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027):"},{"line_number":321,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":322,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id, port\u003dTrue))"},{"line_number":323,"context_line":"            self.assertEqual({"},{"line_number":324,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":325,"context_line":"                qos_consts.NET_QOS_POLICY_ID: \u0027fake_net_id\u0027}, fields)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_56a8e2d9","line":322,"range":{"start_line":322,"start_character":64,"end_line":322,"end_character":68},"updated":"2017-08-10 02:00:23.000000000","message":"nit: how about is_port?","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd0eea573bafb7eea430484d10fa92c38a0e4552","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                 qos_core.QosCoreResourceExtension, \"_get_network_policy_id\","},{"line_number":320,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027):"},{"line_number":321,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":322,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id, port\u003dTrue))"},{"line_number":323,"context_line":"            self.assertEqual({"},{"line_number":324,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":325,"context_line":"                qos_consts.NET_QOS_POLICY_ID: \u0027fake_net_id\u0027}, fields)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f436f4f_e1df12d4","line":322,"range":{"start_line":322,"start_character":64,"end_line":322,"end_character":68},"in_reply_to":"9f436f4f_56a8e2d9","updated":"2017-08-10 03:31:30.000000000","message":"seems good enough","commit_id":"8db0953ea278174518b020fcbc1965863b7725b5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"21023ee45f57b07065e5d2754d0daa2a4b3337b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_data \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: None,"},{"line_number":31,"context_line":"        \u0027qos_policy_binding\u0027: {\u0027policy_id\u0027: qos_policy_id}}"},{"line_number":32,"context_line":"    if is_port:"},{"line_number":33,"context_line":"        db_data[\u0027qos_policy_binding\u0027][\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027"},{"line_number":34,"context_line":"    else:"},{"line_number":35,"context_line":"        db_data[\u0027qos_policy_binding\u0027][\u0027port_id\u0027]  \u003d \u0027fake_port_id\u0027"},{"line_number":36,"context_line":"    return db_data"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_30cb2173","line":35,"range":{"start_line":32,"start_character":4,"end_line":35,"end_character":66},"updated":"2017-08-10 05:08:25.000000000","message":"How about like this:\nif is_port:\n    db_data[\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027\n    db_data[\u0027qos_policy_binding\u0027][\u0027port_id\u0027]  \u003d \u0027fake_port_id\u0027\nelse:\n    db_data[\u0027qos_policy_binding\u0027][\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027","commit_id":"fb9155f54bf6199829b5c9ce2c0aee6978924939"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c08b2d42dba5870d7d35cc4b2ca5abc6f9e3d29d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_data \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: None,"},{"line_number":31,"context_line":"        \u0027qos_policy_binding\u0027: {\u0027policy_id\u0027: qos_policy_id}}"},{"line_number":32,"context_line":"    if is_port:"},{"line_number":33,"context_line":"        db_data[\u0027qos_policy_binding\u0027][\u0027network_id\u0027] \u003d \u0027fake_net_id\u0027"},{"line_number":34,"context_line":"    else:"},{"line_number":35,"context_line":"        db_data[\u0027qos_policy_binding\u0027][\u0027port_id\u0027]  \u003d \u0027fake_port_id\u0027"},{"line_number":36,"context_line":"    return db_data"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_333a0b34","line":35,"range":{"start_line":32,"start_character":4,"end_line":35,"end_character":66},"in_reply_to":"9f436f4f_30cb2173","updated":"2017-08-10 06:16:20.000000000","message":"Done","commit_id":"fb9155f54bf6199829b5c9ce2c0aee6978924939"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027):"},{"line_number":324,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":325,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id, is_port\u003dTrue))"},{"line_number":326,"context_line":"            self.assertEqual({"},{"line_number":327,"context_line":"                qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":328,"context_line":"                qos_consts.NET_QOS_POLICY_ID: \u0027fake_net_id\u0027}, fields)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def test_extract_fields_no_port_policy(self):"},{"line_number":331,"context_line":"        self._test_extract_fields_for_port(None)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_798e722f","line":328,"range":{"start_line":326,"start_character":0,"end_line":328,"end_character":69},"updated":"2017-09-08 22:06:25.000000000","message":"Consider:\n\n    expected_fields \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id,\n                       qos_consts.NET_QOS_POLICY_ID: \u0027fake_net_id\u0027}\n    self.assertEqual(expected_fieds, fields)\n\nIMO, it looks cleaner","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"72ee3bf056ac47fa75eac8267776067f42542565","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    def _test_extract_fields_for_port(self, qos_policy_id):"},{"line_number":321,"context_line":"        with self._mock_plugin_loaded(True), mock.patch.object("},{"line_number":322,"context_line":"                 qos_core.QosCoreResourceExtension, \"_get_network_policy_id\","},{"line_number":323,"context_line":"                 return_value\u003d\u0027fake_net_id\u0027):"},{"line_number":324,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":325,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id, is_port\u003dTrue))"},{"line_number":326,"context_line":"            expected_fields \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id,"}],"source_content_type":"text/x-python","patch_set":42,"id":"1f485f77_03afbce3","line":323,"range":{"start_line":323,"start_character":31,"end_line":323,"end_character":42},"updated":"2017-11-14 03:53:06.000000000","message":"This must be \u0027net_qos_policy_id\u0027.","commit_id":"dc104f0fd2c3f66e6751d8e39fe4181d4a453b91"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"72ee3bf056ac47fa75eac8267776067f42542565","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            fields \u003d self.core_extension.extract_fields("},{"line_number":325,"context_line":"                base_core.PORT, _get_test_dbdata(qos_policy_id, is_port\u003dTrue))"},{"line_number":326,"context_line":"            expected_fields \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id,"},{"line_number":327,"context_line":"                               qos_core.NET_QOS_POLICY_ID: \u0027fake_net_id\u0027}"},{"line_number":328,"context_line":"            self.assertEqual(expected_fields, fields)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def test_extract_fields_no_port_policy(self):"}],"source_content_type":"text/x-python","patch_set":42,"id":"1f485f77_c3b8842b","line":327,"range":{"start_line":327,"start_character":60,"end_line":327,"end_character":71},"updated":"2017-11-14 03:53:06.000000000","message":"ditto","commit_id":"dc104f0fd2c3f66e6751d8e39fe4181d4a453b91"}],"releasenotes/notes/qos-policy-network-d9c68512e9793651.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e211c929837fdf570bb7bf13f0ba1b4daa22155","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the network\u0027s QoS policies."},{"line_number":5,"context_line":"    The new API parameter shows the users which Network QoS policies affect"},{"line_number":6,"context_line":"    the port."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_28e253a1","line":5,"range":{"start_line":5,"start_character":48,"end_line":5,"end_character":68},"updated":"2017-06-24 08:29:53.000000000","message":"\"Network QoS policy\" IMHO because there can\u0027t be more than 1 policy assigned to network","commit_id":"53f2d06f10025a88deb558c24342e8eb42eae690"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2fea6773cb66830e90e2fd68c73812a4d5c1704d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the network\u0027s QoS policies."},{"line_number":5,"context_line":"    The new API parameter shows the users which Network QoS policy affect"},{"line_number":6,"context_line":"    the port."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df3967d1_4f0f0ee1","line":4,"range":{"start_line":4,"start_character":66,"end_line":4,"end_character":74},"updated":"2017-08-01 20:59:50.000000000","message":"A port inherits one policy from the network, correct?","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"65a4904755b353755e80b76878068a46445b0f3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the network\u0027s QoS policies."},{"line_number":5,"context_line":"    The new API parameter shows the users which Network QoS policy affect"},{"line_number":6,"context_line":"    the port."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df3967d1_c7eab073","line":4,"range":{"start_line":4,"start_character":66,"end_line":4,"end_character":74},"in_reply_to":"df3967d1_4f0f0ee1","updated":"2017-08-02 13:13:49.000000000","message":"Yes, only one (or none) QoS policy per network is possible.\n\n--\u003e \"...network\u0027s QoS policy\"","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2fea6773cb66830e90e2fd68c73812a4d5c1704d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the network\u0027s QoS policies."},{"line_number":5,"context_line":"    The new API parameter shows the users which Network QoS policy affect"},{"line_number":6,"context_line":"    the port."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df3967d1_efac8236","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":13},"updated":"2017-08-01 20:59:50.000000000","message":"I would rephrase this as:\n\nThere is a new API that enables users to see the QoS policy ID inherited by a port from its network","commit_id":"50f668638d6be7a90e49fc1d7a2299d799ca17f0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e0c245c6129b737aa2b88421cf72635c29b5502","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter enables users to see the QoS policy ID inherited by"},{"line_number":6,"context_line":"    a port from its network."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f436f4f_8b7c3c72","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"updated":"2017-08-16 19:23:44.000000000","message":"Look at how this is rendered in the release notes: http://docs-draft.openstack.org/42/419642/25/check/gate-neutron-releasenotes/96c9a60//releasenotes/build/html/unreleased.html\n\nThe reader will not have a clue what new attribute you are talking about. Somewhere in this paragraph, you have to mention that the new port attribute is network_qos_policy_id.\n\nI recommend including it as ``network_qos_policy_id`` so it stands out","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3d4dc805ac838c2d185aadfd80547acac5e468be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter enables users to see the QoS policy ID inherited by"},{"line_number":6,"context_line":"    a port from its network."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f436f4f_9478d48f","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"in_reply_to":"9f436f4f_8b7c3c72","updated":"2017-08-17 03:24:04.000000000","message":"Done","commit_id":"83332c9e29ceafba1db4281ba11091d2cc40be7b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e160e36a3befbcdbd12850b1499ff5588fb71c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"7f287b81_a169d6be","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":47},"updated":"2017-09-06 10:09:40.000000000","message":"s/also inherit/ have always inherited","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e160e36a3befbcdbd12850b1499ff5588fb71c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"7f287b81_6163eedd","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":65},"updated":"2017-09-06 10:09:40.000000000","message":"s/on/of","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"5f2577a7_049b7572","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":47},"in_reply_to":"5f2577a7_d653f5e1","updated":"2017-09-10 15:42:55.000000000","message":"Done","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"5f2577a7_d653f5e1","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":47},"in_reply_to":"7f287b81_a169d6be","updated":"2017-09-08 22:06:25.000000000","message":"I would go just for \u0027inherit\u0027","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"13ba552f8bb89488ad8528677a80e3e987eb9907","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"5f2577a7_962d6d48","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":61},"updated":"2017-09-08 22:06:25.000000000","message":"Because of the way you inserted commas here, this reads as though previously you have already indicated that there is a new API parameter.\n\nThis would be better be clearer:\n\nThe new API parameter ``network_qos_policy_id`` enables....\n\nAlternatively, if you want to keep the commas, you can do write the following:\n\nA new parameter, ``network_qos_policy_id``, enables...","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e99e76d3463cfb988e3659b86695366708451e9d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network also inherit the QoS policy on the network."},{"line_number":5,"context_line":"    The new API parameter, ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"5f2577a7_249e7163","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":61},"in_reply_to":"5f2577a7_962d6d48","updated":"2017-09-10 15:42:55.000000000","message":"Done","commit_id":"bbface1f3605c904ef48f09304e50c2e9adfe22c"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7571e10bafa133edeeb571752937920c26e28a9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network inherit the QoS policy of the network."},{"line_number":5,"context_line":"    The new API parameter ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":36,"id":"5f4e5783_d315a0e6","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":8},"updated":"2017-10-16 04:09:38.000000000","message":"nit: how about add \"compute\" here?","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176291268a8df2adde725a77b796d9673fa6ec2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ports created on a network inherit the QoS policy of the network."},{"line_number":5,"context_line":"    The new API parameter ``network_qos_policy_id``, enables users to see the"},{"line_number":6,"context_line":"    QoS policy ID inherited by a port from its network."}],"source_content_type":"text/x-yaml","patch_set":36,"id":"5f4e5783_0c565707","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":8},"in_reply_to":"5f4e5783_d315a0e6","updated":"2017-10-17 04:10:28.000000000","message":"Not necessarily the compute port , I guess.","commit_id":"b24e88ee0877e867939b57be63f0eba59c0045cb"}],"tags":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0f8ce2c6ff40f90b5c24c84c3566fe4b7fe4ae64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"!_TAG_FILE_FORMAT\t2\t/extended format; --format\u003d1 will not append ;\" to lines/"},{"line_number":2,"context_line":"!_TAG_FILE_SORTED\t1\t/0\u003dunsorted, 1\u003dsorted, 2\u003dfoldcase/"},{"line_number":3,"context_line":"!_TAG_PROGRAM_AUTHOR\tDarren Hiebert\t/dhiebert@users.sourceforge.net/"},{"line_number":4,"context_line":"!_TAG_PROGRAM_NAME\tExuberant Ctags\t//"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"5f201791_3175eecb","line":1,"updated":"2017-06-27 07:29:32.000000000","message":"are You sure that this file is not added by mistake? :)","commit_id":"f38dcdf65cfa3406798f2dc2fad0538115e14cc9"}]}
