)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"eda85d2fe50d22ac5361757b2921f80924e3a375","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-17 15:01:59 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing L3 agent hosting router for DVR setup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests for L3 agent hosting routers were failing in DVR setup"},{"line_number":10,"context_line":"because the code was trying to add router to l3 agent when it was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a3c09a3_b4adc4ea","line":7,"updated":"2017-01-18 12:21:20.000000000","message":"Prefix with \u0027tempest\u0027 so it\u0027s clear from the title that this patch fixes tests and not production code.","commit_id":"f6d8943b26f44ef917b580ce9cc62ddb5eeb68f5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c87b2aa995283287ff736288e338659f97eb204e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"because the code was trying to add router to l3 agent when it was"},{"line_number":11,"context_line":"already there."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1662462"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0087ad6f6df662579d557ab790de64e04ff22943"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_426202b0","line":13,"updated":"2017-04-04 18:43:36.000000000","message":"you should use 1590049 instead which is not a duplicate.","commit_id":"b031141787cdf93c2bdc458623f1079c978a1b93"}],"neutron/tests/tempest/api/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6f990605e151882d03130648f92e9faf044f55d6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                cls.client.add_router_interface_with_port_id("},{"line_number":80,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":81,"context_line":"                cls.agent \u003d cls.admin_client.list_l3_agents_hosting_router("},{"line_number":82,"context_line":"                    cls.router[\u0027id\u0027])[\u0027agents\u0027][0]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"},{"line_number":85,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_bb595737","line":82,"updated":"2017-01-23 17:08:57.000000000","message":"It looks like in case of having DVR router, it makes L52 unnecessary which is going to save an API call per resource setup (sounds like a good benefit).\n\nI suggest you to move L52-L64 under this if branch and return on L83\n\nI\u0027m looking in the meantime whether those L52-L64 are even needed as per TODO.","commit_id":"871a2b3d828bccf94bd934542e78e4f937863684"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"39a7d7289ce319a2c3c25d0190c953c567144855","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                cls.client.add_router_interface_with_port_id("},{"line_number":80,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":81,"context_line":"                cls.agent \u003d cls.admin_client.list_l3_agents_hosting_router("},{"line_number":82,"context_line":"                    cls.router[\u0027id\u0027])[\u0027agents\u0027][0]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"},{"line_number":85,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_8c2b4733","line":82,"in_reply_to":"5a3905b3_bb595737","updated":"2017-01-25 12:56:52.000000000","message":"Done","commit_id":"871a2b3d828bccf94bd934542e78e4f937863684"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"3f36998b20da351cdbb50b21b4905bbecbce6fc6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if (test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027) and"},{"line_number":86,"context_line":"            cls.admin_client.show_router("},{"line_number":87,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)):"},{"line_number":88,"context_line":"            cls._create_dvr_setup()"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            cls._create_l3_setup()"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_ab1095a9","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":35},"updated":"2017-04-04 14:23:15.000000000","message":"As we don\u0027t support Liberty anymore I think we can safely remove this and skip creating the net/subnet/port and attaching an interface to the router. That would work for DVR and non-DVR setups.","commit_id":"b031141787cdf93c2bdc458623f1079c978a1b93"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"11ee2d22bf97c4181cb5932d3945dd299dfe9d32","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if (test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027) and"},{"line_number":86,"context_line":"            cls.admin_client.show_router("},{"line_number":87,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)):"},{"line_number":88,"context_line":"            cls._create_dvr_setup()"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            cls._create_l3_setup()"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_26995c78","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":35},"in_reply_to":"dfeb2761_ab1095a9","updated":"2017-04-04 14:41:02.000000000","message":"+1, and that would also bring this in-line with the other proposed change:\n\nhttps://review.openstack.org/#/c/322118/23/tempest/api/network/admin/test_l3_agent_scheduler.py","commit_id":"b031141787cdf93c2bdc458623f1079c978a1b93"}]}