)]}'
{"neutron/tests/tempest/api/test_network_ip_availability_negative.py":[{"author":{"_account_id":23122,"name":"Amy Fong","email":"amy.fong@windriver.com","username":"afong"},"change_message_id":"b93931013009c58af75a395b51c8dbc153d5e5a8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @test.idempotent_id(\u00273b8693eb-6c57-4ea1-ab84-3730c9ee9c84\u0027)"},{"line_number":26,"context_line":"    def test_network_availability_nonexistent_network_id(self):"},{"line_number":27,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":28,"context_line":"                          self.admin_client.show_network_ip_availabilitie,"},{"line_number":29,"context_line":"                          uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_c146374e","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":73},"updated":"2017-01-17 18:57:32.000000000","message":"typo? (shouldn\u0027t this be show_network_ip_availability?)","commit_id":"d29c198d02d2da99571eb87be422c49bb4ea0a8b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"433e6f72528e6aea871201639aaeaa1379aa8706","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @test.idempotent_id(\u00273b8693eb-6c57-4ea1-ab84-3730c9ee9c84\u0027)"},{"line_number":26,"context_line":"    def test_network_availability_nonexistent_network_id(self):"},{"line_number":27,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":28,"context_line":"                          self.admin_client.show_network_ip_availabilitie,"},{"line_number":29,"context_line":"                          uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_11fc036f","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":73},"in_reply_to":"7a3c09a3_b31fb759","updated":"2017-01-18 01:08:16.000000000","message":"Miguel: Nice. I forgot the map. I\u0027ll fix on next patch.","commit_id":"d29c198d02d2da99571eb87be422c49bb4ea0a8b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b720ff3f7d0e9e876959e4026fddcbd0dc46b6d4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @test.idempotent_id(\u00273b8693eb-6c57-4ea1-ab84-3730c9ee9c84\u0027)"},{"line_number":26,"context_line":"    def test_network_availability_nonexistent_network_id(self):"},{"line_number":27,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":28,"context_line":"                          self.admin_client.show_network_ip_availabilitie,"},{"line_number":29,"context_line":"                          uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b31fb759","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":73},"in_reply_to":"7a3c09a3_c146374e","updated":"2017-01-17 23:41:28.000000000","message":"It\u0027s actually not a typo. Given the way the Neutron ReST client in Tempest works in this case (please see https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/services/network/json/network_client.py#L125 and https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/services/network/json/network_client.py#L79), this line generates the correct url: /v2.0/network-ip-availabilities/{network_id}.\n\nWouldn\u0027t it be better, though, to add the following line to the dictionary here: https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/services/network/json/network_client.py#L84:\n\n\u0027network_ip_availabilities\u0027: \u0027network_ip_availabilities\u0027\n\nSomething similar is done for security groups and security group rules. This way the readers of this test won\u0027t get confused","commit_id":"d29c198d02d2da99571eb87be422c49bb4ea0a8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7ef984d649860a62616d0b9f8b135e181e9fcba5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @test.idempotent_id(\u00273b8693eb-6c57-4ea1-ab84-3730c9ee9c84\u0027)"},{"line_number":26,"context_line":"    def test_network_availability_nonexistent_network_id(self):"},{"line_number":27,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":28,"context_line":"                          self.admin_client.show_network_ip_availabilities,"},{"line_number":29,"context_line":"                          uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_75a44107","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":74},"updated":"2017-01-18 09:59:49.000000000","message":"Why not show_network_ip_availability?\nIt might be a stupid question though.","commit_id":"76ca4db454d6382490a7f5a5a29f295c0f70b6ac"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7ef984d649860a62616d0b9f8b135e181e9fcba5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027quotas\u0027: \u0027quotas\u0027,"},{"line_number":88,"context_line":"            \u0027qos_policy\u0027: \u0027policies\u0027,"},{"line_number":89,"context_line":"            \u0027rbac_policy\u0027: \u0027rbac_policies\u0027,"},{"line_number":90,"context_line":"            \u0027network_ip_availabilities\u0027: \u0027network_ip_availabilities\u0027,"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        return resource_plural_map.get(resource_name, resource_name + \u0027s\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_ff2e52a3","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":38},"updated":"2017-01-18 09:59:49.000000000","message":"Why is the key a plural case? A map from plural to plural sound odd. The same thing applies to L.85-87.","commit_id":"76ca4db454d6382490a7f5a5a29f295c0f70b6ac"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"73eb248a3fbfb7e43aa006b6f460ea1f7429c30b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027quotas\u0027: \u0027quotas\u0027,"},{"line_number":88,"context_line":"            \u0027qos_policy\u0027: \u0027policies\u0027,"},{"line_number":89,"context_line":"            \u0027rbac_policy\u0027: \u0027rbac_policies\u0027,"},{"line_number":90,"context_line":"            \u0027network_ip_availabilities\u0027: \u0027network_ip_availabilities\u0027,"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        return resource_plural_map.get(resource_name, resource_name + \u0027s\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_22209449","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":38},"in_reply_to":"7a3c09a3_29395642","updated":"2017-01-19 05:28:54.000000000","message":"You\u0027re right. I\u0027ll fix on next patch.","commit_id":"76ca4db454d6382490a7f5a5a29f295c0f70b6ac"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0f493fe81ae4f9fc34588777173f01f376d1c787","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027quotas\u0027: \u0027quotas\u0027,"},{"line_number":88,"context_line":"            \u0027qos_policy\u0027: \u0027policies\u0027,"},{"line_number":89,"context_line":"            \u0027rbac_policy\u0027: \u0027rbac_policies\u0027,"},{"line_number":90,"context_line":"            \u0027network_ip_availabilities\u0027: \u0027network_ip_availabilities\u0027,"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        return resource_plural_map.get(resource_name, resource_name + \u0027s\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_29395642","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":38},"in_reply_to":"7a3c09a3_ff2e52a3","updated":"2017-01-18 21:23:44.000000000","message":"Yeah, you make a good point. Let\u0027s follow the Neutron client: https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L2027","commit_id":"76ca4db454d6382490a7f5a5a29f295c0f70b6ac"}]}