)]}'
{"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aa9b9c973f07b47a35d2fe1a193b9e04361a854e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            create_port_body \u003d {"},{"line_number":171,"context_line":"                \u0027binding:vnic_type\u0027: CONF.network.port_vnic_type,"},{"line_number":172,"context_line":"                \u0027name\u0027: \"_\".join([\u0027port\u0027, CONF.network.port_vnic_type]),"},{"line_number":173,"context_line":"                \u0027security_groups\u0027: [cls.secgroup[\u0027security_group\u0027][\u0027id\u0027]]}"},{"line_number":174,"context_line":"            nic_settings \u003d cls.create_network_with_port(**create_port_body)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        elif not nic_settings:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_047a31bd","line":173,"updated":"2017-01-30 07:41:28.000000000","message":"do all port types support security groups? not sure how the sriov ones do this and the API may throw an exception. do we want to check or limit this?","commit_id":"4f7f3cfecc1e63cb7947e7c0935ad73fdc2912b9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"d5f398a0c858a74ab5f26701418d7eb4115f5145","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            create_port_body \u003d {"},{"line_number":171,"context_line":"                \u0027binding:vnic_type\u0027: CONF.network.port_vnic_type,"},{"line_number":172,"context_line":"                \u0027name\u0027: \"_\".join([\u0027port\u0027, CONF.network.port_vnic_type]),"},{"line_number":173,"context_line":"                \u0027security_groups\u0027: [cls.secgroup[\u0027security_group\u0027][\u0027id\u0027]]}"},{"line_number":174,"context_line":"            nic_settings \u003d cls.create_network_with_port(**create_port_body)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        elif not nic_settings:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_e1cabb19","line":173,"in_reply_to":"1a430d35_9678652d","updated":"2017-02-06 11:44:49.000000000","message":"Today it doesn\u0027t, but it doesn\u0027t influence the test, even when the security group is configured the tests pass, the same behavior with this test.\nI think it\u0027s better to leave it this way as in the future I hope such a behavior will and for sure should be supported","commit_id":"4f7f3cfecc1e63cb7947e7c0935ad73fdc2912b9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"47a3d137d819c84ced8d0e28a000e8c83f0a4b29","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            create_port_body \u003d {"},{"line_number":171,"context_line":"                \u0027binding:vnic_type\u0027: CONF.network.port_vnic_type,"},{"line_number":172,"context_line":"                \u0027name\u0027: \"_\".join([\u0027port\u0027, CONF.network.port_vnic_type]),"},{"line_number":173,"context_line":"                \u0027security_groups\u0027: [cls.secgroup[\u0027security_group\u0027][\u0027id\u0027]]}"},{"line_number":174,"context_line":"            nic_settings \u003d cls.create_network_with_port(**create_port_body)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        elif not nic_settings:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_9678652d","line":173,"in_reply_to":"1a430d35_e3e01acf","updated":"2017-02-06 07:53:54.000000000","message":"how does the SRIOV support the security groups?","commit_id":"4f7f3cfecc1e63cb7947e7c0935ad73fdc2912b9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"9fdaed1fe14ac1e49872267b36b41086d4bee5da","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            create_port_body \u003d {"},{"line_number":171,"context_line":"                \u0027binding:vnic_type\u0027: CONF.network.port_vnic_type,"},{"line_number":172,"context_line":"                \u0027name\u0027: \"_\".join([\u0027port\u0027, CONF.network.port_vnic_type]),"},{"line_number":173,"context_line":"                \u0027security_groups\u0027: [cls.secgroup[\u0027security_group\u0027][\u0027id\u0027]]}"},{"line_number":174,"context_line":"            nic_settings \u003d cls.create_network_with_port(**create_port_body)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        elif not nic_settings:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_e3e01acf","line":173,"in_reply_to":"3a461143_047a31bd","updated":"2017-02-05 09:46:30.000000000","message":"Such tests run in tempest and there as well the security group is configured in the port level for SRIOV, so it supposed to work here as well.","commit_id":"4f7f3cfecc1e63cb7947e7c0935ad73fdc2912b9"}],"neutron/tests/tempest/scenario/test_qos.py":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"8fa97b999f6192172ce6d66cb819c2180018b408","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        NC_PORT \u003d 1234"},{"line_number":154,"context_line":"        # For SRIOV test, create network with direct port"},{"line_number":155,"context_line":"        if CONF.neutron_plugin_options.sriov_support:"},{"line_number":156,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: \u0027direct\u0027,"},{"line_number":157,"context_line":"                                \u0027name\u0027: \u0027port-sriov\u0027}"},{"line_number":158,"context_line":"            port \u003d self.create_network_with_port(**create_port_body)"},{"line_number":159,"context_line":"            self.setup_network_and_server(network\u003dport)"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            self.setup_network_and_server()"},{"line_number":162,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":163,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_5541ce38","line":160,"range":{"start_line":154,"start_character":0,"end_line":160,"end_character":13},"updated":"2017-01-19 11:22:40.000000000","message":"It seems a little problematic for me to add the check of SR-IOV configuration for just one test. I think all the tests should basically run with SR-IOV unless there is a specific problem. I thought about adding a global config for the vnic_type but then we\u0027ll just configure SR-IOV or non-SRIOV for all the tests.","commit_id":"93b792dfd8d2fc84b50ab58ea0e1b69adb5cad45"}]}
