)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f7631ffa5a1d1490c341ebab65531183a9d69876","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix OVSBridge.delete_flows when called with no args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With this change, when called with no kwargs, delete_flows will result,"},{"line_number":10,"context_line":"instead of calling \"ovs-ofctl \u003caction\u003e \u003cbridge\u003e -\" (which does nothing with no"},{"line_number":11,"context_line":"flow spec given on stdin), in calling \"ovs-ofctl \u003caction\u003e \u003cbridge\u003e\" which"},{"line_number":12,"context_line":"will delete all flows."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_8a1f9ab6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2017-01-24 21:38:06.000000000","message":"Probably you need to have the open bracket start here instead of starting at which does\u0027.\n\nThe sentense does not make sense.","commit_id":"7294c9631f5ef6f294a2230042d74eacf793a9aa"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"33c38d403655e3b99a7bd9be2e44953f24824fd3","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        self.do_action_flows(\u0027mod\u0027, [kwargs])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def delete_flows(self, **kwargs):"},{"line_number":311,"context_line":"        if len(kwargs) \u003d\u003d 0:"},{"line_number":312,"context_line":"            self.remove_all_flows()"},{"line_number":313,"context_line":"        else:"},{"line_number":314,"context_line":"            self.do_action_flows(\u0027del\u0027, [kwargs])"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":317,"context_line":"        return self.dump_flows_for(table\u003dtable)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_9f9d2cbe","line":314,"range":{"start_line":311,"start_character":8,"end_line":314,"end_character":49},"updated":"2017-01-24 16:37:00.000000000","message":"It\u0027s better to be the following.\n\n if kwargs:\n     self.do_action_flows(\u0027del\u0027, [kwargs])\n else:\n     self.remove_all_flows()","commit_id":"4bfcc053dfd0002c6871a339d4136b683666818f"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7ed6930147e24cae738ba54b658c86764947e18e","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        self.do_action_flows(\u0027mod\u0027, [kwargs])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def delete_flows(self, **kwargs):"},{"line_number":311,"context_line":"        if len(kwargs) \u003d\u003d 0:"},{"line_number":312,"context_line":"            self.remove_all_flows()"},{"line_number":313,"context_line":"        else:"},{"line_number":314,"context_line":"            self.do_action_flows(\u0027del\u0027, [kwargs])"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def dump_flows_for_table(self, table):"},{"line_number":317,"context_line":"        return self.dump_flows_for(table\u003dtable)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_cab442d6","line":314,"range":{"start_line":311,"start_character":8,"end_line":314,"end_character":49},"in_reply_to":"5a3905b3_9f9d2cbe","updated":"2017-01-24 21:33:34.000000000","message":"Done","commit_id":"4bfcc053dfd0002c6871a339d4136b683666818f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d73ab1d0db88714f9aac878c8a8a2d067508396f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if kwargs_list !\u003d [{}]:"},{"line_number":298,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":299,"context_line":"                for kw in kwargs_list:"},{"line_number":300,"context_line":"                    if \u0027cookie\u0027 not in kw:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_5a922d4d","line":297,"range":{"start_line":297,"start_character":26,"end_line":297,"end_character":30},"updated":"2017-01-31 02:48:57.000000000","message":"i think you need to do empty-check for every elements of the kwargs_list, if action is del.\nmaybe you can replace empty elements with something like table\u003d255.","commit_id":"4cc95539aedfebabaa3283307cedae6b6212265b"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7abf07506ea27238f6b2d35c63f4b870c2580337","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if kwargs_list !\u003d [{}]:"},{"line_number":298,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":299,"context_line":"                for kw in kwargs_list:"},{"line_number":300,"context_line":"                    if \u0027cookie\u0027 not in kw:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_c959f936","line":297,"range":{"start_line":297,"start_character":26,"end_line":297,"end_character":30},"in_reply_to":"3a461143_5a922d4d","updated":"2017-01-31 07:59:57.000000000","message":"Indeed there could be more than one {} element, in which case we would end up calling ovs-ofctl ... - with an empty stdin.\n\nAnother thing is that, if there are multiple elements and one of them is {}, which will then matches everything, it means we can ignore all the other elements.\n\nSo I think the test for the case where del is called without an stdin input, should be: \n\n if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):","commit_id":"4cc95539aedfebabaa3283307cedae6b6212265b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9d3f9bb57fc51f25a73e79858db8b4d68511a6ee","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_3a2c6f98","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"updated":"2017-01-31 13:24:26.000000000","message":"i\u0027m not sure what\u0027s the intention of this \"not kwargs_list\" condition.  can you explain?","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"31d0224f2ac229291f549ddb8638bb6a98674c41","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_75b2d807","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"1a430d35_25bbcfe6","updated":"2017-02-07 08:29:53.000000000","message":"(Apparently my explanation was lost in the ether)\n\nYes, after removing it and seeing the test fails, I opened my eyes and realized that the reason I added this check is that kwargs_list is [] when delete_flows() is called (with no kwargs). This is also a case where we need to call ovs-ofctl without \u0027-\u0027 and process_input.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2d6d4a41ea8fe48ec5b4789cdee669e77df059c1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_900cb23c","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"1a430d35_75b2d807","updated":"2017-02-07 08:45:04.000000000","message":"in that case kwargs_list is [{}], isn\u0027t it?","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c99ea66412736151343513b70cef4dce560c5f1f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_f5d43ebe","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"1a430d35_7dcaff6f","updated":"2017-02-06 09:06:28.000000000","message":"@yamamoto: the last PS removes this check that indeed is not  necessary.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9d522c8dbe714a2e555947ffad2014540625b7bd","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_dd6700b5","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"1a430d35_900cb23c","updated":"2017-02-08 09:08:27.000000000","message":"Yes, you\u0027re right. Can find why, but I got confused somewhere along the road.\n\nFixed in last PS...\n\nThanks for your patience.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5d8931180b2acebaa0361a8a009ef9a2bf5af6cd","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_25bbcfe6","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"1a430d35_f5d43ebe","updated":"2017-02-06 23:59:42.000000000","message":"and you put it back in PS12 for some reason?","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d6c2bca52af25dc0d403978e09d8dcd16abcd23","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_7dcaff6f","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"3a461143_11005565","updated":"2017-02-05 23:35:40.000000000","message":"i tend to think unnecessary \"safeguard\" a bad thing as it would hide bugs. but it might be just me.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c477778702e3f37bf2c5b436d62c81cc01dc3cb7","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_5a985b6a","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"3a461143_3a2c6f98","updated":"2017-01-31 13:34:28.000000000","message":"Well if kwargs_list is None, then {} won\u0027t be in it, but we still want to call ovs-ofctl without stdin.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"25a25e8e53ad9884fc0d290483d5f2a2075be29e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_d8919e48","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"3a461143_5a985b6a","updated":"2017-01-31 22:40:19.000000000","message":"in which case can it be None? i couldn\u0027t find any.","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a80f4f2cef057a5704af47aab968932bd116dd5b","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and (not kwargs_list or {} in kwargs_list):"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list is empty/None"},{"line_number":299,"context_line":"            # or if there is at least one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_11005565","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":47},"in_reply_to":"3a461143_d8919e48","updated":"2017-02-01 09:05:09.000000000","message":"Possibly there isn\u0027t any case where it is None, but isn\u0027t a safeguard a good idea ?","commit_id":"69ea8282515a7a0f249fcd57a9945cdf14dc4fbf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"81488ea0bfa719052ab61c46ff29efdc90040ac7","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_7ddd2cdf","line":300,"range":{"start_line":300,"start_character":12,"end_line":300,"end_character":51},"updated":"2017-02-08 09:18:27.000000000","message":"Be careful: you are not including the cookie. By default (L304-305), if there is no cookie in the arguments, it\u0027s added using the default one.","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"167ed47b644a396744303ce770fb631591c8aa7f","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_9d2498c5","line":300,"range":{"start_line":300,"start_character":12,"end_line":300,"end_character":51},"in_reply_to":"1a430d35_7ddd2cdf","updated":"2017-02-08 09:21:23.000000000","message":"The cookie was not added for the \u0027del\u0027 action (see line 302), and this change preserves this behavior.","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1d5e344c69f4e7bbcef7edec5e9efd418958331b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_73cd5830","line":300,"range":{"start_line":300,"start_character":12,"end_line":300,"end_character":51},"in_reply_to":"1a430d35_9d2498c5","updated":"2017-02-08 11:19:47.000000000","message":"You are right!","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"0febcff7cf9549cd5091e96db074d02927644f25","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"},{"line_number":304,"context_line":"                    if \u0027cookie\u0027 not in kw:"},{"line_number":305,"context_line":"                        kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":306,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action)"},{"line_number":307,"context_line":"                         for kw in kwargs_list]"},{"line_number":308,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [\u0027-\u0027], \u0027\\n\u0027.join(flow_strs))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":311,"context_line":"        self.do_action_flows(\u0027add\u0027, [kwargs])"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_814d019c","line":308,"range":{"start_line":297,"start_character":0,"end_line":308,"end_character":76},"updated":"2017-02-08 15:28:26.000000000","message":"nit: maybe restructuring a bit will help readability? Smth like\n\nargs \u003d [\u0027-\u0027]\nproc_input \u003d None\n\nif action \u003d\u003d \u0027del\u0027:\n    if {} in kwargs_list:\n        args \u003d []\nelse:\n    for kw in kwargs_list:\n        if \u0027cookie\u0027 not in kw:\n            kw[\u0027cookie\u0027] \u003d self._default_cookie\n    proc_input \u003d \u0027\\n\u0027.join([_build_flow_expr_str(kw, action) for kw in kwargs_list])\n\nself.run_ofctl(\u0027%s-flows\u0027 % action, args, proc_input)","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4ef5c08253f9983e274317029827de3ec936e41e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"},{"line_number":304,"context_line":"                    if \u0027cookie\u0027 not in kw:"},{"line_number":305,"context_line":"                        kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":306,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action)"},{"line_number":307,"context_line":"                         for kw in kwargs_list]"},{"line_number":308,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [\u0027-\u0027], \u0027\\n\u0027.join(flow_strs))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":311,"context_line":"        self.do_action_flows(\u0027add\u0027, [kwargs])"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_ab3d77c5","line":308,"range":{"start_line":297,"start_character":0,"end_line":308,"end_character":76},"in_reply_to":"1a430d35_814d019c","updated":"2017-02-08 16:03:15.000000000","message":"Your suggestion does not work as is: the case where action is \u0027del\u0027 and something different from {} is in kwargs_list will not produce the expected result (proc_input won\u0027t be built).\n\nPrecisely because we can not just factor out on action\u003d\u003d\u0027del\u0027, I don\u0027t see how I can restructure relevantly here.\n\nAnd well, what is more or less readable sometimes depends on the reader...","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"fc92def2a211a340fed76f75e20d1ef0666aa2d9","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                               self.br_name, \u0027datapath_id\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def do_action_flows(self, action, kwargs_list):"},{"line_number":297,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":298,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"},{"line_number":299,"context_line":"            # one item that matches everything"},{"line_number":300,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [])"},{"line_number":301,"context_line":"        else:"},{"line_number":302,"context_line":"            if action !\u003d \u0027del\u0027:"},{"line_number":303,"context_line":"                for kw in kwargs_list:"},{"line_number":304,"context_line":"                    if \u0027cookie\u0027 not in kw:"},{"line_number":305,"context_line":"                        kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":306,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action)"},{"line_number":307,"context_line":"                         for kw in kwargs_list]"},{"line_number":308,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, [\u0027-\u0027], \u0027\\n\u0027.join(flow_strs))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":311,"context_line":"        self.do_action_flows(\u0027add\u0027, [kwargs])"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa31d9ce_ab8bed66","line":308,"range":{"start_line":297,"start_character":0,"end_line":308,"end_character":76},"in_reply_to":"1a430d35_ab3d77c5","updated":"2017-02-14 14:50:23.000000000","message":"You are right here, my bad","commit_id":"4d0409afdc433e633f94367470bf5b55d17424b4"}]}
