)]}'
{"neutron/extensions/l3.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e8e58ab020fa6a2a9cb3a2894f2fc347acbdabf2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.conf import quota"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# L3 Exceptions"},{"line_number":31,"context_line":"class RouterNotFound(nexception.NotFound):"},{"line_number":32,"context_line":"    message \u003d _(\"Router %(router_id)s could not be found\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_0dda85e8","side":"PARENT","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":15},"updated":"2017-07-12 10:52:19.000000000","message":"how do you plan to migrate exceptions?\n\nexception raising code (eg. neutron) and catching code (eg.  subprojects) need to use the same class.\ni guess it would be smoother to migrate if we have aliases (eg. RouterNotFound \u003d neutron_lib.exceptions.l3.RouterNotFound, probably with debtcollector) here.\n\nhow do you think?","commit_id":"f27425ef5e8b24b465b4ca03402ce4508a38608b"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8b47b64987dc0afcc661d5867dba4a5a83cc834c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.conf import quota"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# L3 Exceptions"},{"line_number":31,"context_line":"class RouterNotFound(nexception.NotFound):"},{"line_number":32,"context_line":"    message \u003d _(\"Router %(router_id)s could not be found\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_25348c92","side":"PARENT","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":15},"in_reply_to":"1f1a1f67_0dda85e8","updated":"2017-10-25 17:53:43.000000000","message":"Generally we haven\u0027t had too many problems with this type of issue. Likely due to lower consumption, not checking types, small migration window, etc..\nHowever I agree it\u0027s a problem here since we have so many consumers of these. I\u0027ve proposed to shim the exceptions in Ifd79eb1a92853e49bd4ef028e7a7bd89811c6957 for this, then we can start moving the consumers over.","commit_id":"f27425ef5e8b24b465b4ca03402ce4508a38608b"}],"neutron/tests/unit/extensions/test_extraroute.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17aaa41ab2cafedf7390f750343dfa82e217e862","unresolved":false,"context_lines":[{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def setUp(self, plugin\u003dNone, ext_mgr\u003dNone):"},{"line_number":501,"context_line":"        self._backup \u003d copy.deepcopy(l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":502,"context_line":"        self.addCleanup(self._restore)"},{"line_number":503,"context_line":"        if not plugin:"},{"line_number":504,"context_line":"            plugin \u003d (\u0027neutron.tests.unit.extensions.test_extraroute.\u0027"},{"line_number":505,"context_line":"                      \u0027TestExtraRouteIntPlugin\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_700b5429","side":"PARENT","line":502,"updated":"2017-11-17 21:44:51.000000000","message":"why those cleanup is not necessary anymore? Is it related to this patch?\nSame question is applicable for other similar changes in different files in this patch.","commit_id":"cfc0a1ae5bc1920e1fca196798536695631e693e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6c9a6dc0d2e93442793dfca619d289fe5f9fbe46","unresolved":false,"context_lines":[{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def setUp(self, plugin\u003dNone, ext_mgr\u003dNone):"},{"line_number":501,"context_line":"        self._backup \u003d copy.deepcopy(l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":502,"context_line":"        self.addCleanup(self._restore)"},{"line_number":503,"context_line":"        if not plugin:"},{"line_number":504,"context_line":"            plugin \u003d (\u0027neutron.tests.unit.extensions.test_extraroute.\u0027"},{"line_number":505,"context_line":"                      \u0027TestExtraRouteIntPlugin\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_49a620c4","side":"PARENT","line":502,"in_reply_to":"1f485f77_700b5429","updated":"2017-11-21 21:06:27.000000000","message":"Now that the l3 api def is in neutron, it\u0027s already backed-up and handled via neutron-lib\u0027s APIDefinitionFixture that setup in the super setUp() call chain.","commit_id":"cfc0a1ae5bc1920e1fca196798536695631e693e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9925c043fc94a2e21b613678ebe03c33bdbd2824","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class ExtraRouteTestExtensionManager(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_resources(self):"},{"line_number":39,"context_line":"        l3.L3().update_attributes_map(xroute_apidef.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":40,"context_line":"        return l3.L3.get_resources()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_actions(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_719a3f62","side":"PARENT","line":39,"updated":"2017-12-12 00:01:08.000000000","message":"question: Who populates attribute(s) specific to extra route extension? Is it determined based on supported_extension_aliases below (L.52)?\n\nPerhaps this is just because I am not familiar with the API definition migration. Some information would be appreciated.","commit_id":"259eedaaba209215ff2235c539d79a209e1d044d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8cc5bf5defe5c8534cff13f1bde2ad8b8e0efabc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class ExtraRouteTestExtensionManager(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_resources(self):"},{"line_number":39,"context_line":"        l3.L3().update_attributes_map(xroute_apidef.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":40,"context_line":"        return l3.L3.get_resources()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_actions(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_a8d8491d","side":"PARENT","line":39,"in_reply_to":"df87a7cf_719a3f62","updated":"2017-12-12 13:37:09.000000000","message":"IIUC they are processed automatically via neutron.api.extensions.ExtensionManager. The manager will _load_all_extensions() from path, and when processing them the extending is done in extend_resources().","commit_id":"259eedaaba209215ff2235c539d79a209e1d044d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1694e8d7b7311a8baabd63c4467a255c9e07d7e7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class ExtraRouteTestExtensionManager(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_resources(self):"},{"line_number":39,"context_line":"        l3.L3().update_attributes_map(xroute_apidef.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":40,"context_line":"        return l3.L3.get_resources()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_actions(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_51e58909","side":"PARENT","line":39,"in_reply_to":"df87a7cf_a8d8491d","updated":"2017-12-13 15:58:27.000000000","message":"ExtensionManager updates the attribute map automatically, but previously this needed to be done here. Perhaps the process of the test plugin was improved at some point. Thanks.","commit_id":"259eedaaba209215ff2235c539d79a209e1d044d"}]}
