)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c29180721de25753587af62a17cbbd33e83f79b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LIU Yulong \u003cliuyulong@le.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 15:09:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3][QoS] Flating IP rate limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add rate_limit to floating IP, then the user could set/update"},{"line_number":10,"context_line":"the bandwidth of a floating IP more convenient."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_2f9325a5","line":7,"updated":"2017-01-25 13:14:47.000000000","message":"Floating...","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e01ddfd2ded50e69227bb8070326e984bc19863f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"value to 0."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Related-Bug: #1596611"},{"line_number":24,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_3a6eb601","line":22,"updated":"2017-01-26 19:53:33.000000000","message":"you must provide a draft text here explaining what to put/update in docs","commit_id":"24ffd81e213ac65b6149dd221120e5bcdab3b631"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e4a8f73ec8378e1580b21a2f8bda2965383fb320","unresolved":false,"context_lines":[{"line_number":19,"context_line":"value to 0."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Related-Bug: #1596611"},{"line_number":24,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_651d4a66","line":22,"in_reply_to":"3a461143_3a6eb601","updated":"2017-02-03 02:10:34.000000000","message":"Done","commit_id":"24ffd81e213ac65b6149dd221120e5bcdab3b631"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-10 14:33:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - [L3][QoS] Neutron server side Floating IP QoS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add qos_policy_id to floating IP, then the user could set/update"},{"line_number":10,"context_line":"the binding QoS policy of a floating IP."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f4e5783_fa3fc3d3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2017-10-11 08:39:19.000000000","message":"Please, remove the WIP tag","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003crodolfo.alonso.hernandez@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-10 14:33:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - [L3][QoS] Neutron server side Floating IP QoS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add qos_policy_id to floating IP, then the user could set/update"},{"line_number":10,"context_line":"the binding QoS policy of a floating IP."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f4e5783_963b0337","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"5f4e5783_fa3fc3d3","updated":"2017-10-11 13:47:46.000000000","message":"I think the WIP may stay for a while. This patch now does not involved deeply with QoS plugin [1] [2] (btw, tired that but tests can not pass). This is still in a traditional L3 extension implementation, aka, it\u0027s only extending the L3 plugin now. What do you think about this?\n\n[1] https://review.openstack.org/#/c/424466/13/neutron/services/l3_router/l3_router_plugin.py@78\n[2] https://review.openstack.org/#/c/424466/13/neutron/extensions/qos_fip.py@59","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: implemented neutron server side floating IP QoS."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #1596611"},{"line_number":18,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f4e5783_9a2e8fa3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"updated":"2017-10-11 08:39:19.000000000","message":"This is more a \"Partial-Bug\". You are implementing code for this specific bug","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: implemented neutron server side floating IP QoS."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #1596611"},{"line_number":18,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f4e5783_764887cb","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"in_reply_to":"5f4e5783_9a2e8fa3","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"08eb1b1fb12a93f734ba7e821dddddde5f0b07a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"APIImpact: a new parameter qos_policy_id was added to floating IP"},{"line_number":13,"context_line":"related API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: implemented neutron server side floating IP QoS."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1596611"},{"line_number":18,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3f4b6375_8020a79c","line":15,"updated":"2017-10-26 22:46:23.000000000","message":"Didn\u0027t we decide that there is no need for the DocImpact going forward.","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68dffa5a31669547e1e96aa66db49615f31a3827","unresolved":false,"context_lines":[{"line_number":12,"context_line":"APIImpact: a new parameter qos_policy_id was added to floating IP"},{"line_number":13,"context_line":"related API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: implemented neutron server side floating IP QoS."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1596611"},{"line_number":18,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3f4b6375_dd6fa825","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":59},"updated":"2017-10-26 22:19:01.000000000","message":"Since docs migrated to Neutron, we don\u0027t use the DocImpact flag anymore. Either add the docs to this patch or create a dependent patch with it","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f3c992bc4c94f7b77fe5d69399dd35762f7f51a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"APIImpact: a new parameter qos_policy_id was added to floating IP"},{"line_number":13,"context_line":"related API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact: implemented neutron server side floating IP QoS."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1596611"},{"line_number":18,"context_line":"Change-Id: I4efe9e49d268dffeb3df4de4ea1780152218633b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3f4b6375_2ca0cc8f","line":15,"in_reply_to":"3f4b6375_8020a79c","updated":"2017-10-27 02:40:54.000000000","message":"Done, will remove this flag in next patch set. We have a release note here:\nhttps://review.openstack.org/#/c/424466/17/releasenotes/notes/fip-qos-52926bce81c3f8bb.yaml","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"}],"etc/neutron/rootwrap.d/l3.filters":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":30,"context_line":"find: RegExpFilter, find, root, find, /sys/class/net, -maxdepth, 1, -type, l, -printf, %.*"},{"line_number":31,"context_line":"ip_exec: IpNetnsExecFilter, ip, root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# l3_tc_lib"},{"line_number":34,"context_line":"tc: CommandFilter, tc, root"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# For ip monitor"},{"line_number":37,"context_line":"kill_ip_monitor: KillFilter, root, ip, -9"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ff0f0b1f_ca7cf384","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":27},"updated":"2017-05-22 11:26:31.000000000","message":"This is part of https://review.openstack.org/#/c/453458/","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"find: RegExpFilter, find, root, find, /sys/class/net, -maxdepth, 1, -type, l, -printf, %.*"},{"line_number":31,"context_line":"ip_exec: IpNetnsExecFilter, ip, root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# l3_tc_lib"},{"line_number":34,"context_line":"tc: CommandFilter, tc, root"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# For ip monitor"},{"line_number":37,"context_line":"kill_ip_monitor: KillFilter, root, ip, -9"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ff0f0b1f_53d5251b","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":27},"in_reply_to":"ff0f0b1f_ca7cf384","updated":"2017-05-23 03:00:31.000000000","message":"Yes, you are right, all those code was split from this patch.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # TC rule added to all agents that HA router was scheduled to,"},{"line_number":283,"context_line":"        # then need to remove TC rule in all l3 agent node."},{"line_number":284,"context_line":"        fip_ip \u003d ip_cidr[:ip_cidr.index(\u0027/\u0027)]"},{"line_number":285,"context_line":"        self._remove_fip_rate_limit(device, fip_ip)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if device.addr.list(to\u003dip_cidr):"},{"line_number":288,"context_line":"            super(HaRouter, self).remove_floating_ip(device, ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f5bf1a5e","line":285,"updated":"2017-01-25 03:11:55.000000000","message":"Can\u0027t this just call self.remove_fip_rate_limit(device, ip_cidr) ?","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # TC rule added to all agents that HA router was scheduled to,"},{"line_number":283,"context_line":"        # then need to remove TC rule in all l3 agent node."},{"line_number":284,"context_line":"        fip_ip \u003d ip_cidr[:ip_cidr.index(\u0027/\u0027)]"},{"line_number":285,"context_line":"        self._remove_fip_rate_limit(device, fip_ip)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if device.addr.list(to\u003dip_cidr):"},{"line_number":288,"context_line":"            super(HaRouter, self).remove_floating_ip(device, ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_e6abe0d4","line":285,"in_reply_to":"5a3905b3_f5bf1a5e","updated":"2017-01-25 13:12:06.000000000","message":"The reason is that the dvr_edg_ha_router can not.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def _remove_fip_rate_limit(self, device, fip_ip):"},{"line_number":304,"context_line":"        tc_wrapper \u003d self._get_tc_wrapper(device)"},{"line_number":305,"context_line":"        for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":306,"context_line":"            if device.exists():"},{"line_number":307,"context_line":"                tc_wrapper.clear_ip_rate_limit(direction, fip_ip)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            self._remove_ip_ratelimit_cache(fip_ip, direction)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_503e3c2a","line":306,"updated":"2017-01-25 03:11:55.000000000","message":"Necessary?","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def _remove_fip_rate_limit(self, device, fip_ip):"},{"line_number":304,"context_line":"        tc_wrapper \u003d self._get_tc_wrapper(device)"},{"line_number":305,"context_line":"        for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":306,"context_line":"            if device.exists():"},{"line_number":307,"context_line":"                tc_wrapper.clear_ip_rate_limit(direction, fip_ip)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            self._remove_ip_ratelimit_cache(fip_ip, direction)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_ebfe4937","line":306,"in_reply_to":"5a3905b3_503e3c2a","updated":"2017-01-25 13:12:06.000000000","message":"We have run this code for almost 8 month with mitaka relase. Seems here has a race condition between device plug/unplug and tc commands.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def process_ip_rate_limit(self, ip, rate, direction, device):"},{"line_number":329,"context_line":"        ratelimits \u003d direction + \"_ratelimits\""},{"line_number":330,"context_line":"        old_rate_limits \u003d getattr(self, ratelimits, {})"},{"line_number":331,"context_line":"        old_rate \u003d old_rate_limits.get(ip)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        if (old_rate and old_rate \u003d\u003d rate) or (not old_rate and rate \u003d\u003d 0):"},{"line_number":334,"context_line":"            # 1. Floating IP rate limit does not change."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_709fb850","line":331,"updated":"2017-01-25 03:11:55.000000000","message":"This code has a lot of checks, I think it can be tweaked a little. or I\u0027m completely breaking things :)\n\nold_rate \u003d old_rate_limits.get(ip, 0)\n\nif old_rate \u003d\u003d rate:\n    return\n\ntc_wrapper \u003d ...\n\ntc_wrapper.clear_ip_rate_limit(...)\n\nif rate \u003d\u003d 0:\n    \"pop\"\n    return\n\ntc_wrapper.set_ip_rate_limit(...)\nold_rate_limits[ip] \u003d rate","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def process_ip_rate_limit(self, ip, rate, direction, device):"},{"line_number":329,"context_line":"        ratelimits \u003d direction + \"_ratelimits\""},{"line_number":330,"context_line":"        old_rate_limits \u003d getattr(self, ratelimits, {})"},{"line_number":331,"context_line":"        old_rate \u003d old_rate_limits.get(ip)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        if (old_rate and old_rate \u003d\u003d rate) or (not old_rate and rate \u003d\u003d 0):"},{"line_number":334,"context_line":"            # 1. Floating IP rate limit does not change."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_ec712be2","line":331,"in_reply_to":"5a3905b3_709fb850","updated":"2017-01-25 13:12:06.000000000","message":"Looks good, let me test it. : )","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                      self.router[\u0027id\u0027])"},{"line_number":367,"context_line":"            return fip_statuses"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        device \u003d self._get_rate_limit_ip_device(interface_name)"},{"line_number":370,"context_line":"        existing_cidrs \u003d self.get_router_cidrs(device)"},{"line_number":371,"context_line":"        new_cidrs \u003d set()"},{"line_number":372,"context_line":"        gw_cidrs \u003d self._get_gw_ips_cidr()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_904d04c7","line":369,"updated":"2017-01-25 03:11:55.000000000","message":"This change doesn\u0027t seem necessary","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                      self.router[\u0027id\u0027])"},{"line_number":367,"context_line":"            return fip_statuses"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        device \u003d self._get_rate_limit_ip_device(interface_name)"},{"line_number":370,"context_line":"        existing_cidrs \u003d self.get_router_cidrs(device)"},{"line_number":371,"context_line":"        new_cidrs \u003d set()"},{"line_number":372,"context_line":"        gw_cidrs \u003d self._get_gw_ips_cidr()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8c17c753","line":369,"in_reply_to":"5a3905b3_904d04c7","updated":"2017-01-25 13:12:06.000000000","message":"The difference is between dvr-router rfp-device and none-dvr qg-device.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                fip_statuses[fip[\u0027id\u0027]] \u003d FLOATINGIP_STATUS_NOCHANGE"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            # process floating IP rate limit"},{"line_number":400,"context_line":"            rate \u003d fip[\u0027rate_limit\u0027]"},{"line_number":401,"context_line":"            for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":402,"context_line":"                if device.exists():"},{"line_number":403,"context_line":"                    self.process_ip_rate_limit("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f063a83f","line":400,"updated":"2017-01-25 03:11:55.000000000","message":"This block just seems like it should be in it\u0027s own function like L303 above.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                fip_statuses[fip[\u0027id\u0027]] \u003d FLOATINGIP_STATUS_NOCHANGE"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            # process floating IP rate limit"},{"line_number":400,"context_line":"            rate \u003d fip[\u0027rate_limit\u0027]"},{"line_number":401,"context_line":"            for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":402,"context_line":"                if device.exists():"},{"line_number":403,"context_line":"                    self.process_ip_rate_limit("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_46b594ce","line":400,"in_reply_to":"5a3905b3_f063a83f","updated":"2017-01-25 13:12:06.000000000","message":"set_ip_rate_limit is also used by dvr edge router for snat rate limit.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            # process floating IP rate limit"},{"line_number":400,"context_line":"            rate \u003d fip[\u0027rate_limit\u0027]"},{"line_number":401,"context_line":"            for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":402,"context_line":"                if device.exists():"},{"line_number":403,"context_line":"                    self.process_ip_rate_limit("},{"line_number":404,"context_line":"                        fip_ip, rate, direction, device)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d0022c72","line":402,"updated":"2017-01-25 03:11:55.000000000","message":"Is this necessary?  I think add_floating_ip() would have already blown-up if it didn\u0027t exist.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            # process floating IP rate limit"},{"line_number":400,"context_line":"            rate \u003d fip[\u0027rate_limit\u0027]"},{"line_number":401,"context_line":"            for direction in tc_lib.RATE_LIMIT_DIRECTIONS:"},{"line_number":402,"context_line":"                if device.exists():"},{"line_number":403,"context_line":"                    self.process_ip_rate_limit("},{"line_number":404,"context_line":"                        fip_ip, rate, direction, device)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_c6a2649a","line":402,"in_reply_to":"5a3905b3_d0022c72","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        return floating_ips"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def _delete_stale_tc_rules(self, ex_gw_port_id):"},{"line_number":920,"context_line":"        interface_name \u003d self.get_external_device_name(ex_gw_port_id)"},{"line_number":921,"context_line":"        device \u003d self._get_rate_limit_ip_device(interface_name)"},{"line_number":922,"context_line":"        if not device or not device.exists():"},{"line_number":923,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_5001dc38","line":920,"updated":"2017-01-25 03:11:55.000000000","message":"maybe \u0027if not interface_name:\" here, then you don\u0027t need the device check below","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        return floating_ips"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def _delete_stale_tc_rules(self, ex_gw_port_id):"},{"line_number":920,"context_line":"        interface_name \u003d self.get_external_device_name(ex_gw_port_id)"},{"line_number":921,"context_line":"        device \u003d self._get_rate_limit_ip_device(interface_name)"},{"line_number":922,"context_line":"        if not device or not device.exists():"},{"line_number":923,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_66d45047","line":920,"in_reply_to":"5a3905b3_5001dc38","updated":"2017-01-25 13:12:06.000000000","message":"The device name is different between dvr-snat sg-device and none-dvr qg-device.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                        new_filters.add(filter_id)"},{"line_number":934,"context_line":"                except tc_lib.FilterIDForIPNotFound:"},{"line_number":935,"context_line":"                    pass"},{"line_number":936,"context_line":"            existed_filter_ids \u003d tc_wrapper.get_existed_filter_ids(direction)"},{"line_number":937,"context_line":"            if existed_filter_ids:"},{"line_number":938,"context_line":"                removed_filters \u003d set(existed_filter_ids) - new_filters"},{"line_number":939,"context_line":"                tc_wrapper.delete_filter_ids(direction, removed_filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f098081e","line":936,"range":{"start_line":936,"start_character":12,"end_line":936,"end_character":19},"updated":"2017-01-25 03:11:55.000000000","message":"existing...","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                        new_filters.add(filter_id)"},{"line_number":934,"context_line":"                except tc_lib.FilterIDForIPNotFound:"},{"line_number":935,"context_line":"                    pass"},{"line_number":936,"context_line":"            existed_filter_ids \u003d tc_wrapper.get_existed_filter_ids(direction)"},{"line_number":937,"context_line":"            if existed_filter_ids:"},{"line_number":938,"context_line":"                removed_filters \u003d set(existed_filter_ids) - new_filters"},{"line_number":939,"context_line":"                tc_wrapper.delete_filter_ids(direction, removed_filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_a6ce38b2","line":936,"range":{"start_line":936,"start_character":12,"end_line":936,"end_character":19},"in_reply_to":"5a3905b3_f098081e","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":956,"context_line":"                ex_gw_port)"},{"line_number":957,"context_line":"            fip_statuses \u003d self.configure_fip_addresses(interface_name)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            self._delete_stale_tc_rules(ex_gw_port[\u0027id\u0027])"},{"line_number":960,"context_line":"        except (n_exc.FloatingIpSetupException,"},{"line_number":961,"context_line":"                n_exc.IpTablesApplyException):"},{"line_number":962,"context_line":"                # All floating IPs must be put in error state"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_b0a68051","line":959,"updated":"2017-01-25 03:11:55.000000000","message":"The interface_name was retrieved on L955, why not just pass that instead?","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":956,"context_line":"                ex_gw_port)"},{"line_number":957,"context_line":"            fip_statuses \u003d self.configure_fip_addresses(interface_name)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            self._delete_stale_tc_rules(ex_gw_port[\u0027id\u0027])"},{"line_number":960,"context_line":"        except (n_exc.FloatingIpSetupException,"},{"line_number":961,"context_line":"                n_exc.IpTablesApplyException):"},{"line_number":962,"context_line":"                # All floating IPs must be put in error state"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4f34f1dd","line":959,"in_reply_to":"5a3905b3_b0a68051","updated":"2017-01-25 13:12:06.000000000","message":"The device name is different between dvr-snat sg-device and none-dvr qg-device.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":26262,"name":"1912294464","email":"1912294464@qq.com","username":"1912294464"},"change_message_id":"f752354df63f2866895d2bcef7467e4222aa25b9","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            self._remove_ip_ratelimit_cache(fip_ip, direction)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":331,"context_line":"        device.delete_addr_and_conntrack_state(ip_cidr)"},{"line_number":332,"context_line":"        self.remove_fip_rate_limit(device, ip_cidr)"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_2d873812","line":330,"range":{"start_line":330,"start_character":4,"end_line":330,"end_character":49},"updated":"2017-12-07 11:00:49.000000000","message":"The method is rewritten by DvrLocalRouter class in \"dvr_local_router.py\".So when the router deployment model is dvr,\u0027remove_fip_rate_limit\u0027 will not be call","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/agent/linux/l3_tc_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class FloatingIPTcCommandBase(ip_lib.IPDevice):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _execute_tc_cmd(self, cmd, **kwargs):"},{"line_number":46,"context_line":"        cmd \u003d [\u0027tc\u0027] + cmd"},{"line_number":47,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":48,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue, **kwargs)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_640d3937","line":46,"updated":"2017-01-25 03:11:55.000000000","message":"It \"tc\" in pyroute2?  Would be good to use that now instead of migrating to it later.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class FloatingIPTcCommandBase(ip_lib.IPDevice):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _execute_tc_cmd(self, cmd, **kwargs):"},{"line_number":46,"context_line":"        cmd \u003d [\u0027tc\u0027] + cmd"},{"line_number":47,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":48,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue, **kwargs)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_6b6259af","line":46,"in_reply_to":"5a3905b3_640d3937","updated":"2017-01-25 13:12:06.000000000","message":"I\u0027m not familiar with pyroute2, can it fit the Line 143, or any tc sub commands here?","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_0a454b43","line":1,"updated":"2017-05-22 11:26:31.000000000","message":"This is part of https://review.openstack.org/#/c/453458/","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_f3df9937","line":1,"in_reply_to":"ff0f0b1f_0a454b43","updated":"2017-05-23 03:00:31.000000000","message":"Yes, you are right, all those code was split from this patch.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/common/exceptions.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class FloatingIPQosBindingNotFound(e.NotFound):"},{"line_number":54,"context_line":"    message \u003d _(\"QoS binding for floating IP %(fip_id)s \""},{"line_number":55,"context_line":"                \"and policy %(policy_id)s \""},{"line_number":56,"context_line":"                \"could not be found.\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class FloatingIPQosBindingError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_3d0af5d1","line":56,"range":{"start_line":54,"start_character":16,"end_line":56,"end_character":37},"updated":"2017-10-11 08:39:19.000000000","message":"You have 79 chars per line. You can extend a bit more these strings and use only two lines, instead of three.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class FloatingIPQosBindingNotFound(e.NotFound):"},{"line_number":54,"context_line":"    message \u003d _(\"QoS binding for floating IP %(fip_id)s \""},{"line_number":55,"context_line":"                \"and policy %(policy_id)s \""},{"line_number":56,"context_line":"                \"could not be found.\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class FloatingIPQosBindingError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_239acf13","line":56,"range":{"start_line":54,"start_character":16,"end_line":56,"end_character":37},"in_reply_to":"5f4e5783_3d0af5d1","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class FloatingIPQosBindingError(e.NeutronException):"},{"line_number":60,"context_line":"    message \u003d _(\"QoS binding for floating IP %(fip_id)s \""},{"line_number":61,"context_line":"                \"and policy %(policy_id)s \""},{"line_number":62,"context_line":"                \"could not be created: %(db_error)s.\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class NetworkQosBindingError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_ddf881c5","line":62,"range":{"start_line":60,"start_character":16,"end_line":62,"end_character":53},"updated":"2017-10-11 08:39:19.000000000","message":"ditto","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class FloatingIPQosBindingError(e.NeutronException):"},{"line_number":60,"context_line":"    message \u003d _(\"QoS binding for floating IP %(fip_id)s \""},{"line_number":61,"context_line":"                \"and policy %(policy_id)s \""},{"line_number":62,"context_line":"                \"could not be created: %(db_error)s.\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class NetworkQosBindingError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_039fd303","line":62,"range":{"start_line":60,"start_character":16,"end_line":62,"end_character":53},"in_reply_to":"5f4e5783_ddf881c5","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"}],"neutron/db/fip_rate_limit_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether enable floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_e48cc981","line":26,"updated":"2017-01-25 03:11:55.000000000","message":"Do we really want to have a new config option for this?  Then you\u0027d have to restart the server for any changes to take effect.  I don\u0027t know how the other QoS rates are configured.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether enable floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_cbc98d5c","line":26,"in_reply_to":"5a3905b3_e48cc981","updated":"2017-01-25 13:12:06.000000000","message":"The fip-rate-limit or gatway-rate-limit extension will be enabled by default after it get merged. This will give the cloud administrator a choice to simply disable it. Or if there is a better way to disable an extension, then I\u0027m running the wrong way.","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether enable floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_e4e3e931","line":28,"updated":"2017-01-25 03:11:55.000000000","message":"s/to enable a","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether enable floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_0b6c759b","line":28,"in_reply_to":"5a3905b3_e4e3e931","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate, \""},{"line_number":32,"context_line":"                      \"the unit is Mbps. If it is set to 0 then the \""},{"line_number":33,"context_line":"                      \"floating IP rate limit will not be enabled event \""},{"line_number":34,"context_line":"                      \"set enable_fip_rate_limit to true.\")),"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":"cfg.CONF.register_opts(fip_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_c4bd0d04","line":33,"range":{"start_line":33,"start_character":66,"end_line":33,"end_character":71},"updated":"2017-01-25 03:11:55.000000000","message":"s/even\n\nThis paragraph needs an update, but I\u0027ll save that after I know the answer to my question on L26","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate, \""},{"line_number":32,"context_line":"                      \"the unit is Mbps. If it is set to 0 then the \""},{"line_number":33,"context_line":"                      \"floating IP rate limit will not be enabled event \""},{"line_number":34,"context_line":"                      \"set enable_fip_rate_limit to true.\")),"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":"cfg.CONF.register_opts(fip_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_cb534d6b","line":33,"range":{"start_line":33,"start_character":66,"end_line":33,"end_character":71},"in_reply_to":"5a3905b3_c4bd0d04","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"246cfa3df615edc92090bc3625b343a622b7c576","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _process_extra_fip_rate_limit_update("},{"line_number":66,"context_line":"            self, context, floatingip_db, fip, floatingip_data):"},{"line_number":67,"context_line":"        if not cfg.CONF.enable_fip_rate_limit:"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":"        if \u0027rate_limit\u0027 in fip:"},{"line_number":70,"context_line":"            rate_limit_db \u003d context.session.query("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_2451710f","line":67,"updated":"2017-01-25 03:11:55.000000000","message":"could just add \"or \u0027rate_limit\u0027 not in fip:\" here and return","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _process_extra_fip_rate_limit_update("},{"line_number":66,"context_line":"            self, context, floatingip_db, fip, floatingip_data):"},{"line_number":67,"context_line":"        if not cfg.CONF.enable_fip_rate_limit:"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":"        if \u0027rate_limit\u0027 in fip:"},{"line_number":70,"context_line":"            rate_limit_db \u003d context.session.query("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_6f48cd5c","line":67,"in_reply_to":"5a3905b3_2451710f","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether to enable a floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_6adcc7e3","line":26,"range":{"start_line":26,"start_character":17,"end_line":26,"end_character":38},"updated":"2017-05-22 11:26:31.000000000","message":"This is a new extension. You should enable it by adding in the config a service plugin. E.g.: trunk ports [1], QoS [2]\n\n[1] https://docs.openstack.org/draft/networking-guide/config-trunking.html\n[2] https://docs.openstack.org/mitaka/networking-guide/config-qos.html","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"fip_opts \u003d ["},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether to enable a floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_33a8718b","line":26,"range":{"start_line":26,"start_character":17,"end_line":26,"end_character":38},"in_reply_to":"ff0f0b1f_6adcc7e3","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether to enable a floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate limit, \""},{"line_number":32,"context_line":"                      \"the unit is Mbps. If it is set to 0 then the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_aa809fc0","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":43},"updated":"2017-05-22 11:26:31.000000000","message":"What does it means? If you set this default rate all FIPs will have this new QoS applied by default?","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027enable_fip_rate_limit\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Whether to enable a floating IP rate limit.\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027fip_rate_limit_default_rate\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d_(\"The default value of the floating IP rate limit, \""},{"line_number":32,"context_line":"                      \"the unit is Mbps. If it is set to 0 then the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_13a9ed8e","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":43},"in_reply_to":"ff0f0b1f_aa809fc0","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":36,"context_line":"cfg.CONF.register_opts(fip_opts)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class FloatingIPRatelimitDbMixin(object):"},{"line_number":40,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s extra attributes.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_aadadf47","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":32},"updated":"2017-05-22 11:26:31.000000000","message":"I think this class (and models.l3.FloatingIPRatelimit) shouldn\u0027t exist.\n\nIf you want to link a QoS policy register to a FIP, you should make an object QoSFIPPolicyBinding. This object (with it\u0027s own DB definition, see [1] and [2]) will link a FIP with a QoS policy.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L51\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L42","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"cfg.CONF.register_opts(fip_opts)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class FloatingIPRatelimitDbMixin(object):"},{"line_number":40,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s extra attributes.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_939cdd6a","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":32},"in_reply_to":"ff0f0b1f_aadadf47","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class FloatingIPRatelimitDbMixin(object):"},{"line_number":40,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s extra attributes.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":43,"context_line":"        l3.FLOATINGIPS, [\u0027_extend_extra_fip_dict\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _extend_extra_fip_dict(self, fip_res, fip_db):"},{"line_number":46,"context_line":"        fip_res[\u0027rate_limit\u0027] \u003d cfg.CONF.fip_rate_limit_default_rate"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_0abaeb08","line":43,"range":{"start_line":42,"start_character":4,"end_line":43,"end_character":51},"updated":"2017-05-22 11:26:31.000000000","message":"You should use the decorator @resource_extend.extends([l3.FLOATINGIPS]) in the function.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class FloatingIPRatelimitDbMixin(object):"},{"line_number":40,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s extra attributes.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":43,"context_line":"        l3.FLOATINGIPS, [\u0027_extend_extra_fip_dict\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _extend_extra_fip_dict(self, fip_res, fip_db):"},{"line_number":46,"context_line":"        fip_res[\u0027rate_limit\u0027] \u003d cfg.CONF.fip_rate_limit_default_rate"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_73994977","line":43,"range":{"start_line":42,"start_character":4,"end_line":43,"end_character":51},"in_reply_to":"ff0f0b1f_0abaeb08","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/db/l3_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 VMware, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_8a483b87","line":1,"updated":"2017-05-22 11:26:31.000000000","message":"All QoS stuff must be done in the service qos plugin, not here.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 VMware, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_b37c811f","line":1,"in_reply_to":"ff0f0b1f_8a483b87","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@registry.has_registry_receivers"},{"line_number":76,"context_line":"class L3_NAT_dbonly_mixin(l3.RouterPluginBase,"},{"line_number":77,"context_line":"                          base_services.WorkerBase,"},{"line_number":78,"context_line":"                          st_attr.StandardAttrDescriptionMixin):"},{"line_number":79,"context_line":"    \"\"\"Mixin class to add L3/NAT router methods to db_base_plugin_v2.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_0046ae24","line":76,"updated":"2017-10-11 08:39:19.000000000","message":"Shouldn\u0027t inherit this class from FloatingQoSDbMixin?\n\nYou are calling _process_extra_fip_qos_create and _process_extra_fip_qos_update form this class.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@registry.has_registry_receivers"},{"line_number":76,"context_line":"class L3_NAT_dbonly_mixin(l3.RouterPluginBase,"},{"line_number":77,"context_line":"                          base_services.WorkerBase,"},{"line_number":78,"context_line":"                          st_attr.StandardAttrDescriptionMixin):"},{"line_number":79,"context_line":"    \"\"\"Mixin class to add L3/NAT router methods to db_base_plugin_v2.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_a3859faf","line":76,"in_reply_to":"5f4e5783_0046ae24","updated":"2017-10-11 13:47:46.000000000","message":"L3 plugin will finally inherit all classes.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@registry.has_registry_receivers"},{"line_number":76,"context_line":"class L3_NAT_dbonly_mixin(l3.RouterPluginBase,"},{"line_number":77,"context_line":"                          base_services.WorkerBase,"},{"line_number":78,"context_line":"                          st_attr.StandardAttrDescriptionMixin):"},{"line_number":79,"context_line":"    \"\"\"Mixin class to add L3/NAT router methods to db_base_plugin_v2.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_37bc24ba","line":76,"in_reply_to":"5f4e5783_160eea31","updated":"2017-10-12 15:50:08.000000000","message":"This implantation is similar to DNS extension.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@registry.has_registry_receivers"},{"line_number":76,"context_line":"class L3_NAT_dbonly_mixin(l3.RouterPluginBase,"},{"line_number":77,"context_line":"                          base_services.WorkerBase,"},{"line_number":78,"context_line":"                          st_attr.StandardAttrDescriptionMixin):"},{"line_number":79,"context_line":"    \"\"\"Mixin class to add L3/NAT router methods to db_base_plugin_v2.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_160eea31","line":76,"in_reply_to":"5f4e5783_a3859faf","updated":"2017-10-11 17:01:38.000000000","message":"Sorry, but if you are going to use those functions here, make L3_NAT_dbonly_mixin inherit from FloatingQoSDbMixin.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"            if self._is_fip_qos_supported:"},{"line_number":1324,"context_line":"                self._process_extra_fip_qos_create(context,"},{"line_number":1325,"context_line":"                                                   fip_id,"},{"line_number":1326,"context_line":"                                                   fip)"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1329,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id}})"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_f18db631","line":1326,"updated":"2017-10-30 09:43:27.000000000","message":"nit: can\u0027t all of that arguments be in one line?","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"            if self._is_fip_qos_supported:"},{"line_number":1324,"context_line":"                self._process_extra_fip_qos_create(context,"},{"line_number":1325,"context_line":"                                                   fip_id,"},{"line_number":1326,"context_line":"                                                   fip)"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1329,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id}})"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_9cd9f9f5","line":1326,"in_reply_to":"3f4b6375_f18db631","updated":"2017-10-30 11:09:57.000000000","message":"...","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"}],"neutron/db/l3_fip_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return fip_res"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":38,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":39,"context_line":"            context,"},{"line_number":40,"context_line":"            fip_id\u003dfip_id,"},{"line_number":41,"context_line":"            policy_id\u003dpolicy_id).create()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_7d97b549","line":38,"updated":"2017-07-28 14:44:48.000000000","message":"You have modified (in the correct way, IMHO) the QoS policy object, adding \"attach_floatingip\" and \"detach_floatingip\".\n\nYou should call QoSPolicy object functions.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return fip_res"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":38,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":39,"context_line":"            context,"},{"line_number":40,"context_line":"            fip_id\u003dfip_id,"},{"line_number":41,"context_line":"            policy_id\u003dpolicy_id).create()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_48f78a5a","line":38,"in_reply_to":"ff346bd7_7d97b549","updated":"2017-07-28 16:36:43.000000000","message":"Will try that way.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _process_extra_fip_qos_update("},{"line_number":53,"context_line":"            self, context, floatingip_db, fip):"},{"line_number":54,"context_line":"        qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":55,"context_line":"        if not qos_policy_id:"},{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if floatingip_db.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_7da575a1","line":55,"updated":"2017-07-28 14:44:48.000000000","message":"You need to check:\n- If there was a previous qos policy and a new one is added\n   --\u003e delete old bind\n   --\u003e create new bind\n\n- If there wasn\u0027t a previous qos policy:\n   --\u003e create new bind\n\n- If the policy is removed:\n   --\u003e delete bind","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _process_extra_fip_qos_update("},{"line_number":53,"context_line":"            self, context, floatingip_db, fip):"},{"line_number":54,"context_line":"        qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":55,"context_line":"        if not qos_policy_id:"},{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if floatingip_db.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e8e51edd","line":55,"in_reply_to":"ff346bd7_7da575a1","updated":"2017-07-28 16:36:43.000000000","message":"Actually I want the policy_id of a floating IP can be updated.\n\nSo, if using QoSPolicy object, it will be two actions of detach and attach, right?","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":29,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":30,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":31,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_60f0c268","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"updated":"2017-10-11 08:39:19.000000000","message":"You are not using this function.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":29,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":30,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":31,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_178488d3","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"in_reply_to":"5f4e5783_56a8e2d9","updated":"2017-10-12 15:50:08.000000000","message":"No, it\u0027s not. These are the resource extend mechanism:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1044\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/_resource_extend.py","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":29,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":30,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":31,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_b6695fbf","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"in_reply_to":"5f4e5783_60f0c268","updated":"2017-10-11 13:47:46.000000000","message":"This will be called by l3 plugin to extend the l3 resource dict.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":29,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":30,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":31,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_56a8e2d9","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"in_reply_to":"5f4e5783_b6695fbf","updated":"2017-10-11 17:01:38.000000000","message":"In this patch? If this function is not going to be used in this patch, move it to the follow up one.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":34,"context_line":"        return fip_res"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":37,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":38,"context_line":"            context,"},{"line_number":39,"context_line":"            fip_id\u003dfip_id,"},{"line_number":40,"context_line":"            policy_id\u003dpolicy_id).create()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _delete_fip_qos_db(self, context, fip_id):"},{"line_number":43,"context_line":"        binding.QosPolicyFloatingIPBinding.delete_objects("},{"line_number":44,"context_line":"            context, fip_id\u003dfip_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _process_extra_fip_qos_create("},{"line_number":47,"context_line":"            self, context, fip_id, fip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_4094a637","line":44,"range":{"start_line":36,"start_character":3,"end_line":44,"end_character":35},"updated":"2017-10-11 08:39:19.000000000","message":"You already implemented QoS object methods to attach and detach","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":34,"context_line":"        return fip_res"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":37,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":38,"context_line":"            context,"},{"line_number":39,"context_line":"            fip_id\u003dfip_id,"},{"line_number":40,"context_line":"            policy_id\u003dpolicy_id).create()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _delete_fip_qos_db(self, context, fip_id):"},{"line_number":43,"context_line":"        binding.QosPolicyFloatingIPBinding.delete_objects("},{"line_number":44,"context_line":"            context, fip_id\u003dfip_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _process_extra_fip_qos_create("},{"line_number":47,"context_line":"            self, context, fip_id, fip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_778e1cd1","line":44,"range":{"start_line":36,"start_character":3,"end_line":44,"end_character":35},"in_reply_to":"5f4e5783_366a06b3","updated":"2017-10-12 15:50:08.000000000","message":"It\u0027s something about `resource not found` error.  I will paste a complete log later.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":34,"context_line":"        return fip_res"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":37,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":38,"context_line":"            context,"},{"line_number":39,"context_line":"            fip_id\u003dfip_id,"},{"line_number":40,"context_line":"            policy_id\u003dpolicy_id).create()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _delete_fip_qos_db(self, context, fip_id):"},{"line_number":43,"context_line":"        binding.QosPolicyFloatingIPBinding.delete_objects("},{"line_number":44,"context_line":"            context, fip_id\u003dfip_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _process_extra_fip_qos_create("},{"line_number":47,"context_line":"            self, context, fip_id, fip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_f6e6b7e8","line":44,"range":{"start_line":36,"start_character":3,"end_line":44,"end_character":35},"in_reply_to":"5f4e5783_4094a637","updated":"2017-10-11 13:47:46.000000000","message":"I\u0027ve tried that, but the extension unit tests [1] can not pass with it. The qos and l3 plugin confused me.\n\n\n[1] https://review.openstack.org/#/c/424466/15/neutron/tests/unit/extensions/test_qos_fip.py","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":34,"context_line":"        return fip_res"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_fip_qos_db(self, context, fip_id, policy_id):"},{"line_number":37,"context_line":"        binding.QosPolicyFloatingIPBinding("},{"line_number":38,"context_line":"            context,"},{"line_number":39,"context_line":"            fip_id\u003dfip_id,"},{"line_number":40,"context_line":"            policy_id\u003dpolicy_id).create()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _delete_fip_qos_db(self, context, fip_id):"},{"line_number":43,"context_line":"        binding.QosPolicyFloatingIPBinding.delete_objects("},{"line_number":44,"context_line":"            context, fip_id\u003dfip_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _process_extra_fip_qos_create("},{"line_number":47,"context_line":"            self, context, fip_id, fip):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_366a06b3","line":44,"range":{"start_line":36,"start_character":3,"end_line":44,"end_character":35},"in_reply_to":"5f4e5783_f6e6b7e8","updated":"2017-10-11 17:01:38.000000000","message":"I don\u0027t understand this: find the QoSpolicy object with this policy_id and then use the methods inside it.\n\nWhat errors are you having?","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":62,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":63,"context_line":"        if old_qos_policy_id and not new_qos_policy_id:"},{"line_number":64,"context_line":"            # Removing"},{"line_number":65,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_200f6ae2","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":22},"updated":"2017-10-11 08:39:19.000000000","message":"not needed, you are calling \"_delete_fip_qos_db\". It is understood","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":62,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":63,"context_line":"        if old_qos_policy_id and not new_qos_policy_id:"},{"line_number":64,"context_line":"            # Removing"},{"line_number":65,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_638fa7cc","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":22},"in_reply_to":"5f4e5783_200f6ae2","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":63,"context_line":"        if old_qos_policy_id and not new_qos_policy_id:"},{"line_number":64,"context_line":"            # Removing"},{"line_number":65,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_e073927f","line":66,"range":{"start_line":65,"start_character":12,"end_line":66,"end_character":56},"updated":"2017-10-11 08:39:19.000000000","message":"In the same line, it fits","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":63,"context_line":"        if old_qos_policy_id and not new_qos_policy_id:"},{"line_number":64,"context_line":"            # Removing"},{"line_number":65,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_16a033f4","line":66,"range":{"start_line":65,"start_character":12,"end_line":66,"end_character":56},"in_reply_to":"5f4e5783_e073927f","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_20d1aace","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":24},"updated":"2017-10-11 08:39:19.000000000","message":"DB object doesn\u0027t have \"qos_policy_binding\" field.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_b6e6ff15","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":24},"in_reply_to":"5f4e5783_20d1aace","updated":"2017-10-11 13:47:46.000000000","message":"Here we extend it:\nhttps://review.openstack.org/#/c/424466/15/neutron/db/qos/models.py@75","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_f6f0eecb","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":24},"in_reply_to":"5f4e5783_b6e6ff15","updated":"2017-10-11 17:01:38.000000000","message":"Right!","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_c0f536cd","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":22},"updated":"2017-10-11 08:39:19.000000000","message":"ditto","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_d6a97bdf","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":22},"in_reply_to":"5f4e5783_c0f536cd","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"},{"line_number":74,"context_line":"            self._create_fip_qos_db(context,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_568eab78","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":77},"updated":"2017-10-11 13:47:46.000000000","message":"This is the point why I did not add the policy_id to primary_keys [1].\n\n[1] https://review.openstack.org/#/c/424466/15/neutron/objects/qos/binding.py","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"},{"line_number":74,"context_line":"            self._create_fip_qos_db(context,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_b68f1622","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":77},"in_reply_to":"5f4e5783_568eab78","updated":"2017-10-11 17:01:38.000000000","message":"That\u0027s the point: if you need to make a new FIP-QOS bind, delete the old one and create a new one.\n\nTake a look at port-qos and network-qos binding. If you have a new qos policy for a network/port, the old port-qos or net-qos binding is deleted and a new one is created.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"},{"line_number":74,"context_line":"            self._create_fip_qos_db(context,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_37666453","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":77},"in_reply_to":"5f4e5783_b68f1622","updated":"2017-10-12 15:50:08.000000000","message":"OK, make it consistent with qos-network/port, : )","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"},{"line_number":74,"context_line":"            self._create_fip_qos_db(context,"},{"line_number":75,"context_line":"                                    floatingip_db[\u0027id\u0027],"},{"line_number":76,"context_line":"                                    new_qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_a0e47aad","line":76,"range":{"start_line":69,"start_character":9,"end_line":76,"end_character":54},"updated":"2017-10-11 08:39:19.000000000","message":"I don\u0027t undestand this logic\n\nPlease take a look at qos core extension.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    floatingip_db[\u0027id\u0027])"},{"line_number":67,"context_line":"            return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":70,"context_line":"            # Updating"},{"line_number":71,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            # Creating during update API"},{"line_number":74,"context_line":"            self._create_fip_qos_db(context,"},{"line_number":75,"context_line":"                                    floatingip_db[\u0027id\u0027],"},{"line_number":76,"context_line":"                                    new_qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_211190ad","line":76,"range":{"start_line":69,"start_character":9,"end_line":76,"end_character":54},"in_reply_to":"5f4e5783_a0e47aad","updated":"2017-10-12 15:50:08.000000000","message":"The floating IP without policy_id can add it by a updating API.\nAnyway, let\u0027s make it consistent with qos-network/port, : )","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68dffa5a31669547e1e96aa66db49615f31a3827","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FloatingQoSDbMixin(object):"},{"line_number":27,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s QoS extra attributes.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_0034b7dc","line":26,"updated":"2017-10-26 22:19:01.000000000","message":"I think you need to add a line above this one with:\n\n@resource_extend.has_resource_extenders\n\nOtherwise, _extend_extra_fip_dict (L31) won\u0027t work. See here: https://github.com/openstack/neutron/blob/master/neutron/db/_resource_extend.py#L81","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f3c992bc4c94f7b77fe5d69399dd35762f7f51a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FloatingQoSDbMixin(object):"},{"line_number":27,"context_line":"    \"\"\"Mixin class to enable floating IP\u0027s QoS extra attributes.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_cc913849","line":26,"in_reply_to":"3f4b6375_0034b7dc","updated":"2017-10-27 02:40:54.000000000","message":"Done","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_917c4221","line":1,"updated":"2017-10-30 09:43:27.000000000","message":"Maybe You should put this file in \"neutron/db/qos\" directory as it is related to QoS?","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_fc658d46","line":1,"in_reply_to":"3f4b6375_917c4221","updated":"2017-10-30 11:09:57.000000000","message":"I think this is more closer to L3, because floating IP is a L3 resource.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_62d9f620","line":1,"in_reply_to":"3f4b6375_fc658d46","updated":"2017-10-30 15:35:50.000000000","message":"IMHO it\u0027s not. It\u0027s same \"QoS\" stuff like for ports or networks but associated with different resource now (FIP)","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_7179c62d","line":68,"updated":"2017-10-30 09:43:27.000000000","message":"nit: You can move this line above L64 and use \"new_qos_policy_id in \"if\" condition in L64.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_5c2021f8","line":68,"in_reply_to":"3f4b6375_7179c62d","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"64e447d3133bbf3c50a74977a07a8eed63c916b7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_d7818ac5","line":68,"in_reply_to":"3f4b6375_7179c62d","updated":"2017-10-30 11:25:19.000000000","message":"Sorry can\u0027t do this change. Clear the qos_policy_id will send a {\"qos_policy_id\": None}.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_020a4289","line":68,"in_reply_to":"3f4b6375_d7818ac5","updated":"2017-10-30 15:35:50.000000000","message":"ok","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1c2647f1c176bc622ac70d055f70755e78fc21f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":"        self._create_fip_qos_db(context, fip_id, qos_policy_id)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _process_extra_fip_qos_update("},{"line_number":63,"context_line":"            self, context, floatingip_db, fip, old_floatingip):"},{"line_number":64,"context_line":"        if \u0027qos_policy_id\u0027 not in fip:"},{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"},{"line_number":72,"context_line":"            return"},{"line_number":73,"context_line":"        if old_qos_policy_id:"},{"line_number":74,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":75,"context_line":"                                    floatingip_db[\u0027id\u0027],"},{"line_number":76,"context_line":"                                    old_qos_policy_id)"},{"line_number":77,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":78,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":79,"context_line":"        if not new_qos_policy_id:"},{"line_number":80,"context_line":"            return"},{"line_number":81,"context_line":"        qos_policy_binding \u003d self._create_fip_qos_db("},{"line_number":82,"context_line":"            context,"},{"line_number":83,"context_line":"            floatingip_db[\u0027id\u0027],"},{"line_number":84,"context_line":"            new_qos_policy_id)"},{"line_number":85,"context_line":"        if not floatingip_db.qos_policy_binding:"},{"line_number":86,"context_line":"            floatingip_db.qos_policy_binding \u003d qos_policy_binding"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_ac348efc","line":86,"range":{"start_line":62,"start_character":0,"end_line":86,"end_character":65},"updated":"2017-10-30 03:41:09.000000000","message":"If user request an API which want to cancel the rate limit from a paticular Qos policy, it must be \u0027qos_policy_id\u0027: None in the request body. Right? I think this function logic not cover this. It still leave a result in db .","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":"        self._create_fip_qos_db(context, fip_id, qos_policy_id)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _process_extra_fip_qos_update("},{"line_number":63,"context_line":"            self, context, floatingip_db, fip, old_floatingip):"},{"line_number":64,"context_line":"        if \u0027qos_policy_id\u0027 not in fip:"},{"line_number":65,"context_line":"            # No qos_policy_id in API input, do nothing"},{"line_number":66,"context_line":"            return"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        new_qos_policy_id \u003d fip.get(\u0027qos_policy_id\u0027)"},{"line_number":69,"context_line":"        old_qos_policy_id \u003d old_floatingip.get(\u0027qos_policy_id\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if old_qos_policy_id \u003d\u003d new_qos_policy_id:"},{"line_number":72,"context_line":"            return"},{"line_number":73,"context_line":"        if old_qos_policy_id:"},{"line_number":74,"context_line":"            self._delete_fip_qos_db(context,"},{"line_number":75,"context_line":"                                    floatingip_db[\u0027id\u0027],"},{"line_number":76,"context_line":"                                    old_qos_policy_id)"},{"line_number":77,"context_line":"        if floatingip_db.qos_policy_binding:"},{"line_number":78,"context_line":"            floatingip_db.qos_policy_binding[\u0027policy_id\u0027] \u003d new_qos_policy_id"},{"line_number":79,"context_line":"        if not new_qos_policy_id:"},{"line_number":80,"context_line":"            return"},{"line_number":81,"context_line":"        qos_policy_binding \u003d self._create_fip_qos_db("},{"line_number":82,"context_line":"            context,"},{"line_number":83,"context_line":"            floatingip_db[\u0027id\u0027],"},{"line_number":84,"context_line":"            new_qos_policy_id)"},{"line_number":85,"context_line":"        if not floatingip_db.qos_policy_binding:"},{"line_number":86,"context_line":"            floatingip_db.qos_policy_binding \u003d qos_policy_binding"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_7c23dd06","line":86,"range":{"start_line":62,"start_character":0,"end_line":86,"end_character":65},"in_reply_to":"3f4b6375_ac348efc","updated":"2017-10-30 11:09:57.000000000","message":"please see test case:\nhttps://review.openstack.org/#/c/424466/18/neutron/tests/unit/extensions/test_qos_fip.py@125","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"01bbb98ab5b1a5bdf761c15e0184c64b564f8912","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":32,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":33,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":34,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":35,"context_line":"        else:"},{"line_number":36,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":37,"context_line":"        return fip_res"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f485f77_066fc592","line":34,"updated":"2017-11-14 08:42:22.000000000","message":"Sorry but what \"...\" means?","commit_id":"a10ccdae6a90b8c664efb7dc6188ce7a173bc544"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a1345e2e794a931709b1a8d80ef0af59a9635f71","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":32,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":33,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":34,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":35,"context_line":"        else:"},{"line_number":36,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":37,"context_line":"        return fip_res"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f485f77_4e6055a6","line":34,"updated":"2017-11-13 08:55:48.000000000","message":"please use neutron_lib.services.qos.constants.QOS_POLICY_ID constant instead of hardcoded string here and in all other places where You are using it","commit_id":"a10ccdae6a90b8c664efb7dc6188ce7a173bc544"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"80ed326676da9e131bbc3891fb69a67151fe8822","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @resource_extend.extends([l3.FLOATINGIPS])"},{"line_number":32,"context_line":"    def _extend_extra_fip_dict(fip_res, fip_db):"},{"line_number":33,"context_line":"        if fip_db.get(\u0027qos_policy_binding\u0027):"},{"line_number":34,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d fip_db.qos_policy_binding.policy_id"},{"line_number":35,"context_line":"        else:"},{"line_number":36,"context_line":"            fip_res[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":37,"context_line":"        return fip_res"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f485f77_0228f131","line":34,"in_reply_to":"1f485f77_4e6055a6","updated":"2017-11-13 09:27:42.000000000","message":"...","commit_id":"a10ccdae6a90b8c664efb7dc6188ce7a173bc544"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5ecacffa66de860a2b5c35d75f5ae884f22697b0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            context,"},{"line_number":85,"context_line":"            floatingip_db[\u0027id\u0027],"},{"line_number":86,"context_line":"            new_qos_policy_id)"},{"line_number":87,"context_line":"        if not floatingip_db.qos_policy_binding:"},{"line_number":88,"context_line":"            floatingip_db.qos_policy_binding \u003d qos_policy_binding"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_0701ed6b","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":48},"updated":"2017-11-14 23:09:12.000000000","message":"Do we need this if? Shouldn\u0027t we execute L88 regardless?","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"495c1b15127f4b1c8ef546e0662a5072a9743ccc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            context,"},{"line_number":85,"context_line":"            floatingip_db[\u0027id\u0027],"},{"line_number":86,"context_line":"            new_qos_policy_id)"},{"line_number":87,"context_line":"        if not floatingip_db.qos_policy_binding:"},{"line_number":88,"context_line":"            floatingip_db.qos_policy_binding \u003d qos_policy_binding"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_e1d11ccf","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":48},"in_reply_to":"1f485f77_0701ed6b","updated":"2017-11-15 00:48:27.000000000","message":"Seems true, I\u0027ll test it locally.","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7b27bf99c60c2aa7f94139d72bbc0d44816df0fa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            context,"},{"line_number":85,"context_line":"            floatingip_db[\u0027id\u0027],"},{"line_number":86,"context_line":"            new_qos_policy_id)"},{"line_number":87,"context_line":"        if not floatingip_db.qos_policy_binding:"},{"line_number":88,"context_line":"            floatingip_db.qos_policy_binding \u003d qos_policy_binding"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_35b40a35","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":48},"in_reply_to":"1f485f77_e1d11ccf","updated":"2017-11-15 02:38:30.000000000","message":"OK we can\u0027t remove that line, I remember this, because of the following errors:\n\nhttp://paste.openstack.org/show/626312/\nhttp://paste.openstack.org/show/626313/\n\nIf floatingipd_db already has a qos_policy_binding object,\nIMO, [1] will let it fill with its new policy_id.\n\nhttps://review.openstack.org/#/c/424466/24/neutron/db/qos/models.py@75","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/594422d373ee_fip_rate_limit.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"afdcb8f73a67c2856b0929fc387cff9a638b690c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                              nullable\u003dFalse),"},{"line_number":36,"context_line":"                    sa.Column(u\u0027rate_limit\u0027,"},{"line_number":37,"context_line":"                              sa.Integer(), autoincrement\u003dFalse,"},{"line_number":38,"context_line":"                              nullable\u003dFalse, default\u003d0),"},{"line_number":39,"context_line":"                    sa.ForeignKeyConstraint([\u0027fip_id\u0027], [\u0027floatingips.id\u0027],"},{"line_number":40,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"                    sa.PrimaryKeyConstraint(\u0027fip_id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_16a5c745","line":38,"range":{"start_line":38,"start_character":46,"end_line":38,"end_character":55},"updated":"2017-01-24 07:21:30.000000000","message":"default is useless in migrations, use server_default instead\nFor reference: http://docs.openstack.org/developer/neutron/devref/db_layer.html#difference-between-default-and-server-default-parameters-for-columns","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1db5af7da90d40ef2178e0cc756424df4234c87d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                              nullable\u003dFalse),"},{"line_number":36,"context_line":"                    sa.Column(u\u0027rate_limit\u0027,"},{"line_number":37,"context_line":"                              sa.Integer(), autoincrement\u003dFalse,"},{"line_number":38,"context_line":"                              nullable\u003dFalse, default\u003d0),"},{"line_number":39,"context_line":"                    sa.ForeignKeyConstraint([\u0027fip_id\u0027], [\u0027floatingips.id\u0027],"},{"line_number":40,"context_line":"                                            ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"                    sa.PrimaryKeyConstraint(\u0027fip_id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_eb500961","line":38,"range":{"start_line":38,"start_character":46,"end_line":38,"end_character":55},"in_reply_to":"5a3905b3_16a5c745","updated":"2017-01-25 13:12:06.000000000","message":"Done","commit_id":"2851359cbe21b4f41ab618218e6657ae60cc9bc8"}],"neutron/db/migration/alembic_migrations/versions/pike/expand/594422d373ee_fip_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_1cfc2fb3","line":1,"updated":"2017-07-28 14:44:48.000000000","message":"This feature should be planned for Queens now. You should change to the new release directory.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_68f24e9c","line":1,"in_reply_to":"ff346bd7_1cfc2fb3","updated":"2017-07-28 16:36:43.000000000","message":"Done, still marked WIP.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 594422d373ee"},{"line_number":19,"context_line":"Revises: 349b6fd605a6"},{"line_number":20,"context_line":"Create Date: 2016-04-26 17:16:10.323756"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_ac9e8d60","line":20,"updated":"2017-08-01 17:37:48.000000000","message":"nit: probably date is wrong here :)","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f151d36f3473b19f1eead7365c0354930951b09","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 594422d373ee"},{"line_number":19,"context_line":"Revises: 349b6fd605a6"},{"line_number":20,"context_line":"Create Date: 2016-04-26 17:16:10.323756"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_591b5780","line":20,"in_reply_to":"df3967d1_ac9e8d60","updated":"2017-08-02 02:29:25.000000000","message":"Done","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68dffa5a31669547e1e96aa66db49615f31a3827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3f4b6375_a00ba38b","line":40,"updated":"2017-10-26 22:19:01.000000000","message":"Don\u0027t you need to add a primary key constraint, like here: https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/mitaka/expand/659bf3d90664_add_attributes_to_support_external_dns_integration.py#L67","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f3c992bc4c94f7b77fe5d69399dd35762f7f51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3f4b6375_0c9d1065","line":40,"in_reply_to":"3f4b6375_a00ba38b","updated":"2017-10-27 02:40:54.000000000","message":"It\u0027s similar to network_qos_binding[1] and port_qos_binding [2]. And models PKs are defined here [3] and [4].\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L42\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L51\n[3] https://review.openstack.org/#/c/424466/17/neutron/db/qos/models.py@65\n[4] https://review.openstack.org/#/c/424466/17/neutron/db/qos/models.py@71","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_118e1227","line":1,"updated":"2017-10-30 09:43:27.000000000","message":"This file should be now moved to Queens directory","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_022fe2f6","line":1,"in_reply_to":"3f4b6375_02d7e225","updated":"2017-10-30 15:35:50.000000000","message":"You can create this directory if You need","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bd657ccffe07d0939f55d35e7a68ce392159e5c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_37f9fe4c","line":1,"in_reply_to":"3f4b6375_118e1227","updated":"2017-10-30 11:33:29.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cd68afd1c7d55ea2719ff9bf009c943461e5eb31","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_02d7e225","line":1,"in_reply_to":"3f4b6375_37f9fe4c","updated":"2017-10-30 11:58:24.000000000","message":"No queens migration versions folder, will do rebase later.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027qos_fip_policy_bindings\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027policy_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_f192564b","line":34,"updated":"2017-10-30 09:43:27.000000000","message":"You should use db_const.UUID_FIELD_SIZE constant instead of \"36\"","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027qos_fip_policy_bindings\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027policy_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_5c2dc1a6","line":34,"in_reply_to":"3f4b6375_f192564b","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sa.Column(\u0027policy_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":38,"context_line":"                  sa.ForeignKey(\u0027floatingips.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":39,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_d1975a3a","line":37,"updated":"2017-10-30 09:43:27.000000000","message":"You should use db_const.UUID_FIELD_SIZE constant instead of \"36\"","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sa.Column(\u0027policy_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                  sa.ForeignKey(\u0027qos_policies.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":38,"context_line":"                  sa.ForeignKey(\u0027floatingips.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":39,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_1c198987","line":37,"in_reply_to":"3f4b6375_d1975a3a","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":38,"context_line":"                  sa.ForeignKey(\u0027floatingips.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":39,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_b19cde5d","line":39,"updated":"2017-10-30 09:43:27.000000000","message":"Shouldn\u0027t You define it as primary key here? It is defined as primary key in db model definition","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":38,"context_line":"                  sa.ForeignKey(\u0027floatingips.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":39,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_239add6d","line":39,"in_reply_to":"3f4b6375_7c207db1","updated":"2017-10-30 15:35:50.000000000","message":"ok","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":38,"context_line":"                  sa.ForeignKey(\u0027floatingips.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":39,"context_line":"                  nullable\u003dFalse, unique\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_7c207db1","line":39,"in_reply_to":"3f4b6375_b19cde5d","updated":"2017-10-30 11:09:57.000000000","message":"You can see the comments in patch set 14/15 which i left to Rodolfo.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"}],"neutron/db/migration/alembic_migrations/versions/pike/expand/594422d373ee_fip_rate_limit.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027fip_rate_limits\u0027,"},{"line_number":34,"context_line":"                    sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                              primary_key\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(u\u0027rate_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_4a0c6340","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":36},"updated":"2017-05-22 11:26:31.000000000","message":"As I said, this should be something like QoSFIPPolicyBinding, to link a FIP with a QoS policy.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027fip_rate_limits\u0027,"},{"line_number":34,"context_line":"                    sa.Column(\u0027fip_id\u0027, sa.String(length\u003d36),"},{"line_number":35,"context_line":"                              primary_key\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(u\u0027rate_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_d3a495a8","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":36},"in_reply_to":"ff0f0b1f_4a0c6340","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/db/models/l3.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    api_collections \u003d [l3.FLOATINGIPS]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class FloatingIPRatelimit(model_base.BASEV2):"},{"line_number":109,"context_line":"    \"\"\"Represent floating IP rate limit.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    __tablename__ \u003d \u0027fip_rate_limits\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_f80554c3","line":108,"range":{"start_line":108,"start_character":6,"end_line":108,"end_character":25},"updated":"2017-05-22 11:26:31.000000000","message":"I don\u0027t understand this new class. This should be a QoS rule in a QoS policy. You are breaking the QoS policy API.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    api_collections \u003d [l3.FLOATINGIPS]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class FloatingIPRatelimit(model_base.BASEV2):"},{"line_number":109,"context_line":"    \"\"\"Represent floating IP rate limit.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    __tablename__ \u003d \u0027fip_rate_limits\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_b3a12197","line":108,"range":{"start_line":108,"start_character":6,"end_line":108,"end_character":25},"in_reply_to":"ff0f0b1f_f80554c3","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/db/qos/models.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QoSFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(36),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_1d1b09ca","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":9},"updated":"2017-07-28 14:44:48.000000000","message":"lower case, like QosNetworkPolicyBinding and QosPortPolicyBinding","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QoSFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(36),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e833de60","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":9},"in_reply_to":"ff346bd7_1d1b09ca","updated":"2017-07-28 16:36:43.000000000","message":"Done","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QosFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(36),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_91a1e298","line":61,"updated":"2017-10-30 09:43:27.000000000","message":"You should use db_const.UUID_FIELD_SIZE constant instead of \"36\"","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QosFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(36),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_f7024609","line":61,"in_reply_to":"3f4b6375_91a1e298","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_719e6655","line":65,"updated":"2017-10-30 09:43:27.000000000","message":"Are You sure it should be primary key? One policy can be attached to more than one FIP, right?","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_b70cce3b","line":65,"in_reply_to":"3f4b6375_719e6655","updated":"2017-10-30 11:09:57.000000000","message":"It\u0027s a joint primary key by fip_id and policy_id. right?\n\nAnd it\u0027s similar to network_qos_binding[1] and port_qos_binding [2]. \n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L42\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L51","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_837cf120","line":65,"in_reply_to":"3f4b6375_b70cce3b","updated":"2017-10-30 15:35:50.000000000","message":"ok","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                       nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_51ab6a74","line":66,"updated":"2017-10-30 09:43:27.000000000","message":"You should use db_const.UUID_FIELD_SIZE constant instead of \"36\"","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                       nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_571b5a72","line":66,"in_reply_to":"3f4b6375_51ab6a74","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5ecacffa66de860a2b5c35d75f5ae884f22697b0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QosFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(db_const.PROJECT_ID_FIELD_SIZE),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_07a0cd42","line":61,"range":{"start_line":61,"start_character":45,"end_line":61,"end_character":66},"updated":"2017-11-14 23:09:12.000000000","message":"Shouldn\u0027t this be UUID_FIELD_SIZE?","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"495c1b15127f4b1c8ef546e0662a5072a9743ccc","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class QosFIPPolicyBinding(model_base.BASEV2):"},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027qos_fip_policy_bindings\u0027"},{"line_number":61,"context_line":"    policy_id \u003d sa.Column(sa.String(db_const.PROJECT_ID_FIELD_SIZE),"},{"line_number":62,"context_line":"                          sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_21073485","line":61,"range":{"start_line":61,"start_character":45,"end_line":61,"end_character":66},"in_reply_to":"1f485f77_07a0cd42","updated":"2017-11-15 00:48:27.000000000","message":"Ops... done","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5ecacffa66de860a2b5c35d75f5ae884f22697b0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(db_const.PROJECT_ID_FIELD_SIZE),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                       nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_87815d92","line":66,"range":{"start_line":66,"start_character":42,"end_line":66,"end_character":63},"updated":"2017-11-14 23:09:12.000000000","message":"Shouldn\u0027t this be PROJECT_ID_FIELD_SIZE?","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"495c1b15127f4b1c8ef546e0662a5072a9743ccc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":64,"context_line":"                          nullable\u003dFalse,"},{"line_number":65,"context_line":"                          primary_key\u003dTrue)"},{"line_number":66,"context_line":"    fip_id \u003d sa.Column(sa.String(db_const.PROJECT_ID_FIELD_SIZE),"},{"line_number":67,"context_line":"                       sa.ForeignKey(\u0027floatingips.id\u0027,"},{"line_number":68,"context_line":"                                     ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                       nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_e100fc69","line":66,"range":{"start_line":66,"start_character":42,"end_line":66,"end_character":63},"in_reply_to":"1f485f77_87815d92","updated":"2017-11-15 00:48:27.000000000","message":"Done","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"}],"neutron/extensions/fip_rate_limit.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_4a7c631e","line":1,"updated":"2017-05-22 11:26:31.000000000","message":"Please, take a look at [1] to see how to create a new extension.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/qos_bw_limit_direction.py","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Letv Cloud Computing"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_73a709a9","line":1,"in_reply_to":"ff0f0b1f_4a7c631e","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":23,"context_line":"    l3.FLOATINGIPS: {"},{"line_number":24,"context_line":"        \u0027rate_limit\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":25,"context_line":"                       \u0027default\u0027: 1, \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":26,"context_line":"                       \u0027validate\u0027: {\u0027type:range\u0027: [0, 10000]},"},{"line_number":27,"context_line":"                       \u0027is_visible\u0027: True}"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_8a595b36","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":19},"updated":"2017-05-22 11:26:31.000000000","message":"You are breaking the QoS API. This should be a qos_policy_id.\nBecause you want only rate limiting, in the service driver (E.g. [1], [2] and [3]), specify which rules and parameters are valid for this driver.\n[1] https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/linuxbridge/driver.py\n[2] https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py\n[3] https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/sriov/driver.py","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":23,"context_line":"    l3.FLOATINGIPS: {"},{"line_number":24,"context_line":"        \u0027rate_limit\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":25,"context_line":"                       \u0027default\u0027: 1, \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":26,"context_line":"                       \u0027validate\u0027: {\u0027type:range\u0027: [0, 10000]},"},{"line_number":27,"context_line":"                       \u0027is_visible\u0027: True}"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_13b0cddc","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":19},"in_reply_to":"ff0f0b1f_8a595b36","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return \"2016-05-20T00:00:00-00:00\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_required_extensions(self):"},{"line_number":56,"context_line":"        return [\"router\"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_extended_resources(self, version):"},{"line_number":59,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_aa965f3d","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":24},"updated":"2017-05-22 11:26:31.000000000","message":"This new extension also requires \"qos\"","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return \"2016-05-20T00:00:00-00:00\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_required_extensions(self):"},{"line_number":56,"context_line":"        return [\"router\"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_extended_resources(self, version):"},{"line_number":59,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_330d11a1","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":24},"in_reply_to":"ff0f0b1f_aa965f3d","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/extensions/qos_fip.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class FloatingIPRatelimitNotFound(nexception.NotFound):"},{"line_number":36,"context_line":"    message \u003d _(\"Floating IP %(floatingip_id)s rate limit could not be found\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_acac4d8c","line":35,"updated":"2017-08-01 17:37:48.000000000","message":"shouldn\u0027t it be in neutron.common.execptions ?","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return \"2017-07-20T00:00:00-00:00\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_required_extensions(self):"},{"line_number":59,"context_line":"        return [\"router\"]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_extended_resources(self, version):"},{"line_number":62,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_573970d4","line":59,"updated":"2017-07-28 14:44:48.000000000","message":"And QoS","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return \"2017-07-20T00:00:00-00:00\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_required_extensions(self):"},{"line_number":59,"context_line":"        return [\"router\"]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_extended_resources(self, version):"},{"line_number":62,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_6847eebd","line":59,"in_reply_to":"ff346bd7_573970d4","updated":"2017-07-28 16:36:43.000000000","message":"Done","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.api import extensions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.extensions import l3"},{"line_number":17,"context_line":"# from neutron.extensions import qos"},{"line_number":18,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"FIP_QOS_ALIAS \u003d \"qos-fip\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_7d32adf3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":36},"updated":"2017-10-11 08:39:19.000000000","message":"Please, remove this","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.api import extensions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.extensions import l3"},{"line_number":17,"context_line":"# from neutron.extensions import qos"},{"line_number":18,"context_line":"from neutron.services.qos import qos_consts"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"FIP_QOS_ALIAS \u003d \"qos-fip\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_a3aebf2b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":36},"in_reply_to":"5f4e5783_7d32adf3","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return \"2017-07-20T00:00:00-00:00\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_required_extensions(self):"},{"line_number":52,"context_line":"        return [\"router\"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_extended_resources(self, version):"},{"line_number":55,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_11897225","line":52,"updated":"2017-10-30 09:43:27.000000000","message":"I think that \"qos\" is also required for this extension","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return \"2017-07-20T00:00:00-00:00\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_required_extensions(self):"},{"line_number":52,"context_line":"        return [\"router\"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_extended_resources(self, version):"},{"line_number":55,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_a39c8d5d","line":52,"in_reply_to":"3f4b6375_11897225","updated":"2017-10-30 15:35:50.000000000","message":"so \"qos\" extension isn\u0027t required to make this one working?","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"605ebe5381852e9ac1aa1cde0a2d6a373e2b71ab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return \"2017-07-20T00:00:00-00:00\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_required_extensions(self):"},{"line_number":52,"context_line":"        return [\"router\"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_extended_resources(self, version):"},{"line_number":55,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_cb5f9070","line":52,"in_reply_to":"3f4b6375_a39c8d5d","updated":"2017-10-31 03:00:13.000000000","message":"Sorry I missed this, done.","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3971dd1dca18f6ef8078867440581a74c93535f8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.api import extensions"},{"line_number":15,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.extensions import l3"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"FIP_QOS_ALIAS \u003d \"qos-fip\""},{"line_number":20,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_e7ab6986","line":17,"updated":"2017-11-23 11:33:33.000000000","message":"I think that You can already use definition from neutron_lib instead of this one","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0cc04aa6480d47c31799bc86d4166aac4df9176c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib.api import extensions"},{"line_number":15,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.extensions import l3"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"FIP_QOS_ALIAS \u003d \"qos-fip\""},{"line_number":20,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_a4231c05","line":17,"in_reply_to":"ff82abbf_e7ab6986","updated":"2017-11-23 13:17:22.000000000","message":"Done","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b40a66967fdc2dc5b208dfcf12922ff92f679ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"# under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":15,"context_line":"from neutron_lib.api import extensions"},{"line_number":16,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_8a56215c","line":14,"updated":"2017-11-23 14:24:27.000000000","message":"nit: if You will respin it, please change this to \"import l3 as l3_apidef\" because it\u0027s quite common convention of naming such imports if You will check in other Neutron\u0027s files.","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"13a26b144e92c797f1d5b699ac049ab2caeb7ebc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"# under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":15,"context_line":"from neutron_lib.api import extensions"},{"line_number":16,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_ffacfb9f","line":14,"in_reply_to":"ff82abbf_0dcd0065","updated":"2017-11-28 14:38:39.000000000","message":"All examples, including yours, have `neutron_lib/api/definitions/xxx` in neutron lib. So they can import `xxx as xxx_apiref` in neutron. But qos_fip does not. So here `from neutron_lib.api.definitions import l3` is stay consistent with the neutron_lib code, again see example [1] and [2].\n\nAnd if write it as `from neutron_lib.api.definitions import l3 as l3_apiref`. It makes code confused. And one day, this extension may be moved to neutron_lib. They needs to refactor this line to meet the consistence with [1] and [2] etc.","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3419160512937ddabf90526f39af1754aa726901","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"# under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":15,"context_line":"from neutron_lib.api import extensions"},{"line_number":16,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_0dcd0065","line":14,"in_reply_to":"ff82abbf_23401ba5","updated":"2017-11-28 08:01:32.000000000","message":"I didn\u0027t say about imports in neutron-lib. Please check how similar things are imported in neutron, e.g.: https://github.com/openstack/neutron/blob/b5e3f171f17730cbab75f56e0f33f44a14604c1f/neutron/extensions/dns.py","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"38319a85987511cbf33fc44a153dc5307eea0f48","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"# under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":15,"context_line":"from neutron_lib.api import extensions"},{"line_number":16,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_23401ba5","line":14,"in_reply_to":"ff82abbf_8a56215c","updated":"2017-11-28 02:05:13.000000000","message":"No, it\u0027s not the same. neutron-lib does not have such `apidef`, we should stay consistent with the original code, for instance:\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/l3_ext_gw_mode.py#L17\n[2] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/l3_ext_ha_mode.py#L16","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"}],"neutron/objects/qos/binding.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ff346bd7_3dc48d3f","line":68,"updated":"2017-07-28 14:44:48.000000000","message":"This object doesn\u0027t accept updates. You need to add:\n  fields_no_update \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ff346bd7_8825720b","line":68,"in_reply_to":"ff346bd7_3dc48d3f","updated":"2017-07-28 16:36:43.000000000","message":"Actually I want a floating IP can update its policy_id. It can save DB delete and insert actions.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f4e5783_bdab85d4","line":68,"updated":"2017-10-11 08:39:19.000000000","message":"Every QosFIPPolicyBinding register is meant to be read-only: you can create or delete them, but not modify.\n\nYou should add:\n\n  fields_no_update \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a6912d25eb6771ad01e05f8d58144a604684f58b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f4e5783_f7032c72","line":68,"in_reply_to":"5f4e5783_96a41abb","updated":"2017-10-12 15:50:08.000000000","message":"OK, make it consistent with qos-network/port, : )","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1338dc0bdbdf6fbc47d57be5bf5e682e2afc5cb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f4e5783_96a41abb","line":68,"in_reply_to":"5f4e5783_996694ed","updated":"2017-10-11 17:01:38.000000000","message":"That\u0027s the point: if you need to make a new FIP-QOS bind, delete the old one and create a new one.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f4e5783_996694ed","line":68,"in_reply_to":"5f4e5783_bdab85d4","updated":"2017-10-11 13:47:46.000000000","message":"Line [1] directly updates the policy_id, is that correct? or I miss something?\n[1] https://review.openstack.org/#/c/424466/15/neutron/db/l3_fip_qos.py@71","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027fip_id\u0027: common_types.UUIDField()"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    primary_keys \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_5176ca40","line":67,"updated":"2017-10-30 09:43:27.000000000","message":"are You sure that both should be primary keys?","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027fip_id\u0027: common_types.UUIDField()"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    primary_keys \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_973f92b4","line":67,"in_reply_to":"3f4b6375_5176ca40","updated":"2017-10-30 11:09:57.000000000","message":"Please see Rodolfo\u0027s comments in patch set 15.\n\nAnd it\u0027s similar to network_qos_binding[1] and port_qos_binding [2]. \n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L42\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/liberty/expand/48153cb5f051_qos_db_changes.py#L51","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027fip_id\u0027: common_types.UUIDField()"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    primary_keys \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_a2024e3d","line":67,"in_reply_to":"3f4b6375_973f92b4","updated":"2017-10-30 15:35:50.000000000","message":"ok","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5ecacffa66de860a2b5c35d75f5ae884f22697b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1f485f77_a2aa07cf","line":68,"updated":"2017-11-14 23:09:12.000000000","message":"Shouldn\u0027t we have a line here as follows?:\n\n    fields_no_update \u003d [\u0027policy_id\u0027, \u0027fip_id\u0027]\n\nLook at L52 and L36","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"495c1b15127f4b1c8ef546e0662a5072a9743ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1f485f77_61776c04","line":68,"in_reply_to":"1f485f77_a2aa07cf","updated":"2017-11-15 00:48:27.000000000","message":"Done","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e58db9384592b4e92fcf40aa5aef2aef1f9b67","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    port_binding_model \u003d qos_db_model.QosPortPolicyBinding"},{"line_number":55,"context_line":"    network_binding_model \u003d qos_db_model.QosNetworkPolicyBinding"},{"line_number":56,"context_line":"    fip_binding_model \u003d qos_db_model.QoSFIPPolicyBinding"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    fields \u003d {"},{"line_number":59,"context_line":"        \u0027id\u0027: common_types.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_bd33dd61","line":56,"range":{"start_line":56,"start_character":39,"end_line":56,"end_character":40},"updated":"2017-07-28 14:44:48.000000000","message":"lower case, like QosPortPolicyBinding and QosNetworkPolicyBinding","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a8867f567e6512fe72cbd47ed8175d43faca6a4e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    port_binding_model \u003d qos_db_model.QosPortPolicyBinding"},{"line_number":55,"context_line":"    network_binding_model \u003d qos_db_model.QosNetworkPolicyBinding"},{"line_number":56,"context_line":"    fip_binding_model \u003d qos_db_model.QoSFIPPolicyBinding"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    fields \u003d {"},{"line_number":59,"context_line":"        \u0027id\u0027: common_types.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_a86f1629","line":56,"range":{"start_line":56,"start_character":39,"end_line":56,"end_character":40},"in_reply_to":"ff346bd7_bd33dd61","updated":"2017-07-28 16:36:43.000000000","message":"Done","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa5a17fca2df13d56d5247f4d8392bbd3223b17b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                                                 db_error\u003de)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def attach_floatingip(self, fip_id):"},{"line_number":231,"context_line":"        fip_binding \u003d {\u0027policy_id\u0027: self.id,"},{"line_number":232,"context_line":"                       \u0027fip_id\u0027: fip_id}"},{"line_number":233,"context_line":"        fip_binding_obj \u003d binding.QosPolicyFloatingIPBinding("},{"line_number":234,"context_line":"            self.obj_context, **fip_binding)"},{"line_number":235,"context_line":"        try:"},{"line_number":236,"context_line":"            fip_binding_obj.create()"},{"line_number":237,"context_line":"        except db_exc.DBReferenceError as e:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_fd5e9de4","line":234,"range":{"start_line":231,"start_character":8,"end_line":234,"end_character":44},"updated":"2017-10-11 08:39:19.000000000","message":"Very small nit: instead of creating this dict, you can call directly the object:\n\nfip_binding_obj \u003d binding.QosPolicyFloatingIPBinding(\n    self.obj_context, policy_id\u003dself.id, fip_id\u003dfip_id)\n\nI don\u0027t see any reason to create this intermediary object.","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"594d8e082677fee9a36e8eec750dd52483b5e0f6","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                                                 db_error\u003de)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def attach_floatingip(self, fip_id):"},{"line_number":231,"context_line":"        fip_binding \u003d {\u0027policy_id\u0027: self.id,"},{"line_number":232,"context_line":"                       \u0027fip_id\u0027: fip_id}"},{"line_number":233,"context_line":"        fip_binding_obj \u003d binding.QosPolicyFloatingIPBinding("},{"line_number":234,"context_line":"            self.obj_context, **fip_binding)"},{"line_number":235,"context_line":"        try:"},{"line_number":236,"context_line":"            fip_binding_obj.create()"},{"line_number":237,"context_line":"        except db_exc.DBReferenceError as e:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f4e5783_23688ff3","line":234,"range":{"start_line":231,"start_character":8,"end_line":234,"end_character":44},"in_reply_to":"5f4e5783_fd5e9de4","updated":"2017-10-11 13:47:46.000000000","message":"Done","commit_id":"10328055ed099a87143d2866ffa36296339b363c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Version 1.3: Added standard attributes (created_at, revision, etc)"},{"line_number":45,"context_line":"    # Version 1.4: Changed tenant_id to project_id"},{"line_number":46,"context_line":"    # Version 1.5: Direction for bandwidth limit rule added"},{"line_number":47,"context_line":"    # Version 1.6: Added \"is_default\" field"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.6\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # required by RbacNeutronMetaclass"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_d182ba00","line":47,"updated":"2017-10-30 09:43:27.000000000","message":"You should bump version of object","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Version 1.3: Added standard attributes (created_at, revision, etc)"},{"line_number":45,"context_line":"    # Version 1.4: Changed tenant_id to project_id"},{"line_number":46,"context_line":"    # Version 1.5: Direction for bandwidth limit rule added"},{"line_number":47,"context_line":"    # Version 1.6: Added \"is_default\" field"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.6\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # required by RbacNeutronMetaclass"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_7cff5d34","line":47,"in_reply_to":"3f4b6375_d182ba00","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"57d02a495460991390d41f4cf03605c3f4fb6569","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    binding_models \u003d {\u0027port\u0027: binding.QosPolicyPortBinding,"},{"line_number":74,"context_line":"                      \u0027network\u0027: binding.QosPolicyNetworkBinding,"},{"line_number":75,"context_line":"                      \u0027floatingip\u0027: binding.QosPolicyFloatingIPBinding}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":78,"context_line":"        if attrname \u003d\u003d \u0027rules\u0027:"}],"source_content_type":"text/x-python","patch_set":30,"id":"ff82abbf_c6d7d64a","line":75,"range":{"start_line":75,"start_character":23,"end_line":75,"end_character":33},"updated":"2017-11-29 08:38:34.000000000","message":"this line caused the problem. It should be `fip`.","commit_id":"12e9a33afdbc7c98f5018375ae684cb3d0765fd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"57d02a495460991390d41f4cf03605c3f4fb6569","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                    raise exceptions.QosPolicyInUse("},{"line_number":202,"context_line":"                        policy_id\u003dself.id,"},{"line_number":203,"context_line":"                        object_type\u003dobject_type,"},{"line_number":204,"context_line":"                        object_id\u003dbinding_obj[0][\u0027%s_id\u0027 % object_type])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            super(QosPolicy, self).delete()"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ff82abbf_06b93e13","line":204,"range":{"start_line":204,"start_character":24,"end_line":204,"end_character":72},"updated":"2017-11-29 08:38:34.000000000","message":"This is the base line where caused the exception.","commit_id":"12e9a33afdbc7c98f5018375ae684cb3d0765fd6"}],"neutron/opts.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":121,"context_line":"             neutron.db.l3_dvr_db.router_distributed_opts,"},{"line_number":122,"context_line":"             neutron.db.l3_agentschedulers_db.L3_AGENTS_SCHEDULER_OPTS,"},{"line_number":123,"context_line":"             neutron.db.l3_hamode_db.L3_HA_OPTS,"},{"line_number":124,"context_line":"             neutron.db.fip_rate_limit_db.fip_opts)"},{"line_number":125,"context_line":"         ),"},{"line_number":126,"context_line":"        (\u0027database\u0027,"},{"line_number":127,"context_line":"         neutron.db.migration.cli.get_engine_config())"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_0a8d4bd2","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":50},"updated":"2017-05-22 11:26:31.000000000","message":"According to comments in https://review.openstack.org/#/c/424466/9/neutron/db/fip_rate_limit_db.py, this shouldn\u0027t be set","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"             neutron.db.l3_dvr_db.router_distributed_opts,"},{"line_number":122,"context_line":"             neutron.db.l3_agentschedulers_db.L3_AGENTS_SCHEDULER_OPTS,"},{"line_number":123,"context_line":"             neutron.db.l3_hamode_db.L3_HA_OPTS,"},{"line_number":124,"context_line":"             neutron.db.fip_rate_limit_db.fip_opts)"},{"line_number":125,"context_line":"         ),"},{"line_number":126,"context_line":"        (\u0027database\u0027,"},{"line_number":127,"context_line":"         neutron.db.migration.cli.get_engine_config())"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_f3b439d3","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":50},"in_reply_to":"ff0f0b1f_0a8d4bd2","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"}],"neutron/services/l3_router/l3_router_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb98d1f15e1ed649196a93df156fbf7df628ac00","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":61,"context_line":"                                   \"extraroute\", \"l3_agent_scheduler\","},{"line_number":62,"context_line":"                                   \"l3-ha\", \"router_availability_zone\","},{"line_number":63,"context_line":"                                   \"l3-flavors\", \"fip-rate-limit\"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    __native_pagination_support \u003d True"},{"line_number":66,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_6d3d01c3","line":63,"range":{"start_line":63,"start_character":49,"end_line":63,"end_character":65},"updated":"2017-05-22 11:26:31.000000000","message":"If you are adding this extension to the supported ones, the change in https://review.openstack.org/#/c/424466/9/neutron/db/fip_rate_limit_db.py@26 is not needed.","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"66c0cfd751ddd838508be09df2db97f9cdead31b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":61,"context_line":"                                   \"extraroute\", \"l3_agent_scheduler\","},{"line_number":62,"context_line":"                                   \"l3-ha\", \"router_availability_zone\","},{"line_number":63,"context_line":"                                   \"l3-flavors\", \"fip-rate-limit\"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    __native_pagination_support \u003d True"},{"line_number":66,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_d3d25500","line":63,"range":{"start_line":63,"start_character":49,"end_line":63,"end_character":65},"in_reply_to":"ff0f0b1f_6d3d01c3","updated":"2017-05-23 03:00:31.000000000","message":"This is stale code, it was something described by the very old SPEC:\nhttps://review.openstack.org/#/c/374506/7/specs/pike/layer-3-rate-limit.rst","commit_id":"a535fae74ee3cdf962c13856c9b632392e07be3f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    _supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":76,"context_line":"                                    \"extraroute\", \"l3_agent_scheduler\","},{"line_number":77,"context_line":"                                    \"l3-ha\", \"router_availability_zone\","},{"line_number":78,"context_line":"                                    \"l3-flavors\", \"qos-fip\"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    __native_pagination_support \u003d True"},{"line_number":81,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_8c43c9af","line":78,"updated":"2017-08-01 17:37:48.000000000","message":"I would rather move it to extensions supported by QoS service plugin as it extends Floating IP with qos_policy_id in same way how it\u0027s done e.g. for ports or networks.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f151d36f3473b19f1eead7365c0354930951b09","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    _supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":76,"context_line":"                                    \"extraroute\", \"l3_agent_scheduler\","},{"line_number":77,"context_line":"                                    \"l3-ha\", \"router_availability_zone\","},{"line_number":78,"context_line":"                                    \"l3-flavors\", \"qos-fip\"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    __native_pagination_support \u003d True"},{"line_number":81,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_d92507c4","line":78,"in_reply_to":"df3967d1_8c43c9af","updated":"2017-08-02 02:29:25.000000000","message":"Will try that way.","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68dffa5a31669547e1e96aa66db49615f31a3827","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    _supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":75,"context_line":"                                    \"extraroute\", \"l3_agent_scheduler\","},{"line_number":76,"context_line":"                                    \"l3-ha\", \"router_availability_zone\","},{"line_number":77,"context_line":"                                    \"l3-flavors\", \"qos-fip\"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    __native_pagination_support \u003d True"},{"line_number":80,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_60b92b77","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":58},"updated":"2017-10-26 22:19:01.000000000","message":"Should this be an optional / configurable extension?","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c28af7dc2919a529d3f33bd62a53b59ead1ad4d5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    _supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":75,"context_line":"                                    \"extraroute\", \"l3_agent_scheduler\","},{"line_number":76,"context_line":"                                    \"l3-ha\", \"router_availability_zone\","},{"line_number":77,"context_line":"                                    \"l3-flavors\", \"qos-fip\"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    __native_pagination_support \u003d True"},{"line_number":80,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_ec007404","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":58},"in_reply_to":"3f4b6375_2c6a0c19","updated":"2017-10-27 02:52:35.000000000","message":"Sorry my mistake, l3 extensions should not be set to l2 configuration. And seems extensions for l3 are not configurable. Correct me if I miss something.","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f3c992bc4c94f7b77fe5d69399dd35762f7f51a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    _supported_extension_aliases \u003d [\"dvr\", \"router\", \"ext-gw-mode\","},{"line_number":75,"context_line":"                                    \"extraroute\", \"l3_agent_scheduler\","},{"line_number":76,"context_line":"                                    \"l3-ha\", \"router_availability_zone\","},{"line_number":77,"context_line":"                                    \"l3-flavors\", \"qos-fip\"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    __native_pagination_support \u003d True"},{"line_number":80,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_2c6a0c19","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":58},"in_reply_to":"3f4b6375_60b92b77","updated":"2017-10-27 02:40:54.000000000","message":"Yes, this should be configured by ml2 extension_drivers.","commit_id":"8acb2d49a228c7b91c88a99961adc526dcceb143"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5ecacffa66de860a2b5c35d75f5ae884f22697b0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_629acf6e","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":41},"updated":"2017-11-14 23:09:12.000000000","message":"Nice!","commit_id":"b8fe08e81bd3192e63a0115a2d7501b7870833f5"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1d51d867e78a1e1b3d30d4888ccd82cdebace046","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_8fc5133f","line":109,"range":{"start_line":107,"start_character":12,"end_line":109,"end_character":41},"updated":"2017-11-21 16:00:31.000000000","message":"This doesn\u0027t work fine because neutron server loads l3 plugin before loading qos plugin. As a resut, qos-fip never be enable.","commit_id":"2af233d26014216620fd24a4c37d67f947e558fc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9aed64099d6f8e86a3542022d8234cb7fe0d56cc","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_b28f1ecb","line":109,"range":{"start_line":107,"start_character":12,"end_line":109,"end_character":41},"in_reply_to":"ff82abbf_12b60afc","updated":"2017-11-21 16:36:55.000000000","message":"No. My comment didn\u0027t explain it enough. I mean the loading order is created by devstack. The devstack adds router into service_plugins and then it adds other service plugins(i.e. qos). So it shouldn\u0027t depend on service_plugins order.","commit_id":"2af233d26014216620fd24a4c37d67f947e558fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d0bebf8037875ae8185fbaea43fadbf5a0e60d1d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_12b60afc","line":109,"range":{"start_line":107,"start_character":12,"end_line":109,"end_character":41},"in_reply_to":"ff82abbf_8fc5133f","updated":"2017-11-21 16:24:41.000000000","message":"Yes, I think here needs some doc work.\nin neutron.conf, the service_plugins should have a order, the `qos` is former than `router`:\nservice_plugins \u003d qos,router","commit_id":"2af233d26014216620fd24a4c37d67f947e558fc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6cab75e346b11fda2a1b66d87a397621e2f67f60","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_d53bacce","line":109,"range":{"start_line":107,"start_character":12,"end_line":109,"end_character":41},"in_reply_to":"ff82abbf_b28f1ecb","updated":"2017-11-21 16:43:46.000000000","message":"Well, it\u0027s a test point of view above but generally application shouldn\u0027t change the behavior depending on configuration\u0027s order.","commit_id":"2af233d26014216620fd24a4c37d67f947e558fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2824ce629cf863500f8fc443da32eed60a3c5f2e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":105,"context_line":"            aliases \u003d self._supported_extension_aliases[:]"},{"line_number":106,"context_line":"            disable_dvr_extension_by_config(aliases)"},{"line_number":107,"context_line":"            plugins \u003d directory.get_plugins().keys()"},{"line_number":108,"context_line":"            if \u0027qos\u0027 not in [key.lower() for key in plugins]:"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_a25fc13f","line":109,"range":{"start_line":107,"start_character":12,"end_line":109,"end_character":41},"in_reply_to":"ff82abbf_d53bacce","updated":"2017-11-22 00:05:39.000000000","message":"Fine, we can directly use the cfg.CONF.service_plugins to verify the configured plugins. Maybe someday neutron_lib can supply such functionality.","commit_id":"2af233d26014216620fd24a4c37d67f947e558fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3971dd1dca18f6ef8078867440581a74c93535f8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":107,"context_line":"            if all(p not in cfg.CONF.service_plugins"},{"line_number":108,"context_line":"                   for p in [\u0027qos\u0027, qos_class]):"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_a7956142","line":109,"updated":"2017-11-23 11:33:33.000000000","message":"IMO it could be moved to helper function in same way like it is done already for \"disable_dvr_extension_by_config\" - it would be then more readable","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0cc04aa6480d47c31799bc86d4166aac4df9176c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":107,"context_line":"            if all(p not in cfg.CONF.service_plugins"},{"line_number":108,"context_line":"                   for p in [\u0027qos\u0027, qos_class]):"},{"line_number":109,"context_line":"                aliases.remove(\u0027qos-fip\u0027)"},{"line_number":110,"context_line":"            self._aliases \u003d aliases"},{"line_number":111,"context_line":"        return self._aliases"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_842858e2","line":109,"in_reply_to":"ff82abbf_a7956142","updated":"2017-11-23 13:17:22.000000000","message":"Done","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c65bb35b28e4d3f22435c8948596b0cdfd65dfce","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_a2242cb0","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":59},"updated":"2017-11-27 20:40:48.000000000","message":"Is there a way to get this from the neutron.service_plugins namespace?","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"57771e22ef2ca39f07bc6a603b8fd338cfdec8c8","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_b64d4e9b","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":59},"in_reply_to":"ff82abbf_a2242cb0","updated":"2017-11-28 00:11:27.000000000","message":"seems negative","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c65bb35b28e4d3f22435c8948596b0cdfd65dfce","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"@resource_extend.has_resource_extenders"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_7fe7a1ad","line":58,"updated":"2017-11-27 20:40:48.000000000","message":"Please look at L51. Should we take the same precaution here before attempting the from aliases? The if in L51 must be there for a reason...","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"21c28c093c07e1a9344a40baa5db4f2631e8de71","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"@resource_extend.has_resource_extenders"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_e871aa45","line":58,"in_reply_to":"ff82abbf_565e4244","updated":"2017-11-28 08:51:10.000000000","message":"I agree with Miguel here.\nWhat if Your function will be used by other implementation of L3RouterPlugin? then it can fail if \u0027qos-fip\u0027 will not be in supported_extensions list, right?","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"57771e22ef2ca39f07bc6a603b8fd338cfdec8c8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"@resource_extend.has_resource_extenders"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_565e4244","line":58,"in_reply_to":"ff82abbf_7fe7a1ad","updated":"2017-11-28 00:11:27.000000000","message":"IMO，that line is redundant. Line 80-83 put it hard coded.","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"13a26b144e92c797f1d5b699ac049ab2caeb7ebc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def disable_qos_fip_extension_by_plugins(aliases):"},{"line_number":56,"context_line":"    qos_class \u003d \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027"},{"line_number":57,"context_line":"    if all(p not in cfg.CONF.service_plugins for p in [\u0027qos\u0027, qos_class]):"},{"line_number":58,"context_line":"        aliases.remove(\u0027qos-fip\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"@resource_extend.has_resource_extenders"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff82abbf_ffd2bbd0","line":58,"in_reply_to":"ff82abbf_e871aa45","updated":"2017-11-28 14:38:39.000000000","message":"OK, make sense. We should make code robust.","commit_id":"d061677cc3dd1d740f9c826b01d5f81d1917c456"}],"neutron/tests/unit/extensions/test_qos_fip.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.tests.unit.extensions import test_l3"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FloatingIPQoSTestExtensionManager(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_resources(self):"},{"line_number":29,"context_line":"        l3.RESOURCE_ATTRIBUTE_MAP[\u0027floatingips\u0027].update("}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_6c1425a1","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":19},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase please","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return []"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class TestFloatingIPQoSIntPlugin("},{"line_number":41,"context_line":"        test_l3.TestL3NatIntPlugin,"},{"line_number":42,"context_line":"        l3_fip_qos.FloatingQoSDbMixin):"},{"line_number":43,"context_line":"    supported_extension_aliases \u003d [\"external-net\", \"router\","}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_0c1119ad","line":40,"range":{"start_line":40,"start_character":22,"end_line":40,"end_character":23},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                   qos_fip.FIP_QOS_ALIAS]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class TestFloatingIPQoSL3NatServicePlugin("},{"line_number":48,"context_line":"        test_l3.TestL3NatServicePlugin,"},{"line_number":49,"context_line":"        l3_fip_qos.FloatingQoSDbMixin):"},{"line_number":50,"context_line":"    supported_extension_aliases \u003d [\"router\", qos_fip.FIP_QOS_ALIAS]"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_8c1ce9c1","line":47,"range":{"start_line":47,"start_character":22,"end_line":47,"end_character":23},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    supported_extension_aliases \u003d [\"router\", qos_fip.FIP_QOS_ALIAS]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class FloatingIPQoSDBTestCaseBase(object):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_create_fip_with_qos_policy_id(self):"},{"line_number":56,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_2c83bdce","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":19},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                             policy_obj2.id)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class FloatingIPQoSDBIntTestCase(test_l3.L3BaseForIntTests,"},{"line_number":98,"context_line":"                                 test_l3.L3NatTestCaseMixin,"},{"line_number":99,"context_line":"                                 FloatingIPQoSDBTestCaseBase):"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_ecda55e7","line":97,"range":{"start_line":97,"start_character":18,"end_line":97,"end_character":19},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c3ed6496bdd34e67dbbb1519ac11b17366c6298","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def setUp(self, plugin\u003dNone):"},{"line_number":102,"context_line":"        if not plugin:"},{"line_number":103,"context_line":"            plugin \u003d (\u0027neutron.tests.unit.extensions.test_qos_fip.\u0027"},{"line_number":104,"context_line":"                      \u0027TestFloatingIPQoSIntPlugin\u0027)"},{"line_number":105,"context_line":"        # for these tests we need to enable overlapping ips"},{"line_number":106,"context_line":"        cfg.CONF.set_default(\u0027allow_overlapping_ips\u0027, True)"},{"line_number":107,"context_line":"        cfg.CONF.set_default(\u0027max_routes\u0027, 3)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_ace44dad","line":104,"range":{"start_line":104,"start_character":39,"end_line":104,"end_character":40},"updated":"2017-08-01 17:37:48.000000000","message":"lowercase","commit_id":"44545e20b96a8c93d6f6cb8d3891350e90d0183d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":73,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":74,"context_line":"        policy_obj1 \u003d policy.QosPolicy(ctx,"},{"line_number":75,"context_line":"                                       id\u003duuidutils.generate_uuid(),"},{"line_number":76,"context_line":"                                       project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol2\u0027,"},{"line_number":77,"context_line":"                                       rules\u003d[])"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_31734e50","line":74,"updated":"2017-10-30 09:43:27.000000000","message":"nit: IMHO \"policy_1\" (without \"obj\") would be better name in those tests","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c65b5d6659e6013fb3efc983ccc83a2b23787608","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":73,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":74,"context_line":"        policy_obj1 \u003d policy.QosPolicy(ctx,"},{"line_number":75,"context_line":"                                       id\u003duuidutils.generate_uuid(),"},{"line_number":76,"context_line":"                                       project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol2\u0027,"},{"line_number":77,"context_line":"                                       rules\u003d[])"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_174ba287","line":74,"in_reply_to":"3f4b6375_31734e50","updated":"2017-10-30 11:40:56.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":73,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":74,"context_line":"        policy_obj_1 \u003d policy.QosPolicy(ctx,"},{"line_number":75,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":76,"context_line":"                                        project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol2\u0027,"},{"line_number":77,"context_line":"                                        rules\u003d[])"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_c3b0a9e0","line":74,"updated":"2017-10-30 15:35:50.000000000","message":"do You really need this \"obj\" in name of each object here?","commit_id":"9aa1b73b2cebc560f0e6003146438d003646d11d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a227231b60d5c88e3546f7a85a281da052eda883","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":73,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":74,"context_line":"        policy_obj_1 \u003d policy.QosPolicy(ctx,"},{"line_number":75,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":76,"context_line":"                                        project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol2\u0027,"},{"line_number":77,"context_line":"                                        rules\u003d[])"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_6690d196","line":74,"in_reply_to":"3f4b6375_c3b0a9e0","updated":"2017-10-31 03:26:08.000000000","message":"There are many cases in the tests/unit/objects using such style name. Let\u0027s keep it consistent.","commit_id":"9aa1b73b2cebc560f0e6003146438d003646d11d"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ada69cd7e019dafc4252c0732a0a0e1162d9e79c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":59,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":60,"context_line":"                                      rules\u003d[])"},{"line_number":61,"context_line":"        policy_obj.create()"},{"line_number":62,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as s:"},{"line_number":63,"context_line":"            network_id \u003d s[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":64,"context_line":"            self._set_net_external(network_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f4b6375_d8268fcb","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":27},"updated":"2017-11-07 17:06:51.000000000","message":"You shouldn\u0027t be creating database entries in unit tests. This should be done in functional or fullstack tests","commit_id":"026ec8f8c825a00383ce471c9236fe16d631bf62"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"245f1676e66146766be35432a23cd95b47becd6f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":59,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol1\u0027,"},{"line_number":60,"context_line":"                                      rules\u003d[])"},{"line_number":61,"context_line":"        policy_obj.create()"},{"line_number":62,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as s:"},{"line_number":63,"context_line":"            network_id \u003d s[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":64,"context_line":"            self._set_net_external(network_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f485f77_78e9bb7e","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":27},"in_reply_to":"3f4b6375_d8268fcb","updated":"2017-11-10 03:00:49.000000000","message":"Could you please explain why we shouldn\u0027t ? Neutron unit tests use a sqlite DB to test all this. Add it will remove the temp DB file. There are tons of obj.create() in neutron unit tests. So I think this is just fine. :)","commit_id":"026ec8f8c825a00383ce471c9236fe16d631bf62"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ada69cd7e019dafc4252c0732a0a0e1162d9e79c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":76,"context_line":"                                        project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol2\u0027,"},{"line_number":77,"context_line":"                                        rules\u003d[])"},{"line_number":78,"context_line":"        policy_obj_1.create()"},{"line_number":79,"context_line":"        policy_obj_2 \u003d policy.QosPolicy(ctx,"},{"line_number":80,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":81,"context_line":"                                        project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol3\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f4b6375_b81bd37e","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":29},"updated":"2017-11-07 17:06:51.000000000","message":"ditto","commit_id":"026ec8f8c825a00383ce471c9236fe16d631bf62"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ada69cd7e019dafc4252c0732a0a0e1162d9e79c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                      id\u003duuidutils.generate_uuid(),"},{"line_number":107,"context_line":"                                      project_id\u003d\u0027tenant\u0027, name\u003d\u0027pol4\u0027,"},{"line_number":108,"context_line":"                                      rules\u003d[])"},{"line_number":109,"context_line":"        policy_obj.create()"},{"line_number":110,"context_line":"        with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as s:"},{"line_number":111,"context_line":"            network_id \u003d s[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":112,"context_line":"            self._set_net_external(network_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f4b6375_981ed76d","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":27},"updated":"2017-11-07 17:06:51.000000000","message":"ditto","commit_id":"026ec8f8c825a00383ce471c9236fe16d631bf62"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8873c925425bab084fd2e8a83907cdd7400417cf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                self.fmt,"},{"line_number":68,"context_line":"                network_id,"},{"line_number":69,"context_line":"                qos_policy_id\u003dpolicy_obj.id)"},{"line_number":70,"context_line":"            self.assertEqual(fip[\u0027floatingip\u0027][qos_consts.QOS_POLICY_ID],"},{"line_number":71,"context_line":"                             policy_obj.id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":74,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f485f77_5ff8a147","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":43},"updated":"2017-11-16 03:18:04.000000000","message":"Nit: the recommended format for this is:\n\nself.assertEqual(expected, actual)\n\nYou have the opposite. The same for the rest of all assertEqual below. Consider fixing them if you roll another patch","commit_id":"59d909f761aaba6774a8e6674f8f4f2d8a27493a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cee0c8537021d006ddac9c4a6bb4eee0923d1553","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                self.fmt,"},{"line_number":68,"context_line":"                network_id,"},{"line_number":69,"context_line":"                qos_policy_id\u003dpolicy_obj.id)"},{"line_number":70,"context_line":"            self.assertEqual(fip[\u0027floatingip\u0027][qos_consts.QOS_POLICY_ID],"},{"line_number":71,"context_line":"                             policy_obj.id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_floatingip_update_qos_policy_id(self):"},{"line_number":74,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f485f77_27a39b02","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":43},"in_reply_to":"1f485f77_5ff8a147","updated":"2017-11-16 07:16:29.000000000","message":"Done","commit_id":"59d909f761aaba6774a8e6674f8f4f2d8a27493a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3971dd1dca18f6ef8078867440581a74c93535f8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db import l3_fip_qos"},{"line_number":21,"context_line":"from neutron.extensions import l3"},{"line_number":22,"context_line":"from neutron.extensions import qos_fip"},{"line_number":23,"context_line":"from neutron.objects.qos import policy"},{"line_number":24,"context_line":"from neutron.tests.unit.extensions import test_l3"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_47a575b4","line":21,"updated":"2017-11-23 11:33:33.000000000","message":"maybe apidef from neutron_lib could be used here alread?","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0cc04aa6480d47c31799bc86d4166aac4df9176c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db import l3_fip_qos"},{"line_number":21,"context_line":"from neutron.extensions import l3"},{"line_number":22,"context_line":"from neutron.extensions import qos_fip"},{"line_number":23,"context_line":"from neutron.objects.qos import policy"},{"line_number":24,"context_line":"from neutron.tests.unit.extensions import test_l3"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff82abbf_c40e608c","line":21,"in_reply_to":"ff82abbf_47a575b4","updated":"2017-11-23 13:17:22.000000000","message":"We can\u0027t,  see line 32","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a31bc77aa2798b9b8267d4e5f2d930e9348b74f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027QosMinimumBandwidthRule\u0027: \u00271.3-314c3419f4799067cc31cc319080adff\u0027,"},{"line_number":75,"context_line":"    \u0027QosRuleType\u0027: \u00271.3-7286188edeb3a0386f9cf7979b9700fc\u0027,"},{"line_number":76,"context_line":"    \u0027QosRuleTypeDriver\u0027: \u00271.0-7d8cb9f0ef661ac03700eae97118e3db\u0027,"},{"line_number":77,"context_line":"    \u0027QosPolicy\u0027: \u00271.6-4adb0cde3102c10d8970ec9487fd7fe7\u0027,"},{"line_number":78,"context_line":"    \u0027QosPolicyDefault\u0027: \u00271.0-59e5060eedb1f06dd0935a244d27d11c\u0027,"},{"line_number":79,"context_line":"    \u0027QosPolicyFloatingIPBinding\u0027: \u00271.0-5625df4205a18778cd6aa40f99be024e\u0027,"},{"line_number":80,"context_line":"    \u0027QosPolicyNetworkBinding\u0027: \u00271.0-df53a1e0f675aab8d27a1ccfed38dc42\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_b1873e10","line":77,"updated":"2017-10-30 09:43:27.000000000","message":"probably QosPolicy hash should be updated also","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a844cf7e0578b2a6b9bf4ad703372bc2b150eb96","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027QosMinimumBandwidthRule\u0027: \u00271.3-314c3419f4799067cc31cc319080adff\u0027,"},{"line_number":75,"context_line":"    \u0027QosRuleType\u0027: \u00271.3-7286188edeb3a0386f9cf7979b9700fc\u0027,"},{"line_number":76,"context_line":"    \u0027QosRuleTypeDriver\u0027: \u00271.0-7d8cb9f0ef661ac03700eae97118e3db\u0027,"},{"line_number":77,"context_line":"    \u0027QosPolicy\u0027: \u00271.6-4adb0cde3102c10d8970ec9487fd7fe7\u0027,"},{"line_number":78,"context_line":"    \u0027QosPolicyDefault\u0027: \u00271.0-59e5060eedb1f06dd0935a244d27d11c\u0027,"},{"line_number":79,"context_line":"    \u0027QosPolicyFloatingIPBinding\u0027: \u00271.0-5625df4205a18778cd6aa40f99be024e\u0027,"},{"line_number":80,"context_line":"    \u0027QosPolicyNetworkBinding\u0027: \u00271.0-df53a1e0f675aab8d27a1ccfed38dc42\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_5c582155","line":77,"in_reply_to":"3f4b6375_b1873e10","updated":"2017-10-30 11:09:57.000000000","message":"Done","commit_id":"8b037c05b69b8b758a362d029d20c3a5297b9cda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"473448247de947807cf059b08bfaaddf1318e10f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027QosMinimumBandwidthRule\u0027: \u00271.3-314c3419f4799067cc31cc319080adff\u0027,"},{"line_number":75,"context_line":"    \u0027QosRuleType\u0027: \u00271.3-7286188edeb3a0386f9cf7979b9700fc\u0027,"},{"line_number":76,"context_line":"    \u0027QosRuleTypeDriver\u0027: \u00271.0-7d8cb9f0ef661ac03700eae97118e3db\u0027,"},{"line_number":77,"context_line":"    \u0027QosPolicy\u0027: \u00271.7-4adb0cde3102c10d8970ec9487fd7fe7\u0027,"},{"line_number":78,"context_line":"    \u0027QosPolicyDefault\u0027: \u00271.0-59e5060eedb1f06dd0935a244d27d11c\u0027,"},{"line_number":79,"context_line":"    \u0027QosPolicyFloatingIPBinding\u0027: \u00271.0-5625df4205a18778cd6aa40f99be024e\u0027,"},{"line_number":80,"context_line":"    \u0027QosPolicyNetworkBinding\u0027: \u00271.0-df53a1e0f675aab8d27a1ccfed38dc42\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_23c1bd2f","line":77,"updated":"2017-10-30 15:35:50.000000000","message":"hash wasn\u0027t changed?","commit_id":"9aa1b73b2cebc560f0e6003146438d003646d11d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a227231b60d5c88e3546f7a85a281da052eda883","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027QosMinimumBandwidthRule\u0027: \u00271.3-314c3419f4799067cc31cc319080adff\u0027,"},{"line_number":75,"context_line":"    \u0027QosRuleType\u0027: \u00271.3-7286188edeb3a0386f9cf7979b9700fc\u0027,"},{"line_number":76,"context_line":"    \u0027QosRuleTypeDriver\u0027: \u00271.0-7d8cb9f0ef661ac03700eae97118e3db\u0027,"},{"line_number":77,"context_line":"    \u0027QosPolicy\u0027: \u00271.7-4adb0cde3102c10d8970ec9487fd7fe7\u0027,"},{"line_number":78,"context_line":"    \u0027QosPolicyDefault\u0027: \u00271.0-59e5060eedb1f06dd0935a244d27d11c\u0027,"},{"line_number":79,"context_line":"    \u0027QosPolicyFloatingIPBinding\u0027: \u00271.0-5625df4205a18778cd6aa40f99be024e\u0027,"},{"line_number":80,"context_line":"    \u0027QosPolicyNetworkBinding\u0027: \u00271.0-df53a1e0f675aab8d27a1ccfed38dc42\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_66e57138","line":77,"in_reply_to":"3f4b6375_23c1bd2f","updated":"2017-10-31 03:26:08.000000000","message":"Test pass, so yes, it\u0027s not changed.","commit_id":"9aa1b73b2cebc560f0e6003146438d003646d11d"}],"releasenotes/notes/fip-qos-52926bce81c3f8bb.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3971dd1dca18f6ef8078867440581a74c93535f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implementation of floating IP QoS. A new parameter qos_policy_id"},{"line_number":4,"context_line":"    was added to floating IP related API."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ff82abbf_07af6d94","line":3,"updated":"2017-11-23 11:33:33.000000000","message":"qos_policy_id should be IMHO written with \"``\" so it would be ``qos_policy_id``","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0cc04aa6480d47c31799bc86d4166aac4df9176c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implementation of floating IP QoS. A new parameter qos_policy_id"},{"line_number":4,"context_line":"    was added to floating IP related API."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ff82abbf_e41124ae","line":3,"in_reply_to":"ff82abbf_07af6d94","updated":"2017-11-23 13:17:22.000000000","message":"Done","commit_id":"d67cfe84254b4333bf9725281e91b32cff04b187"}]}
